openproject

Commit Graph

Author	SHA1	Message	Date
Alex Coles	a8e92e251f	Rename Changeset changes assoc. to file_changes Avoid naming collision with `ActiveRecord::AttributeMethods::Dirty#changes`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Oliver Günther	3ccde73519	Allow automatic creation of manageable repositories through a setting This commit allows manageable repositories to be automatically created by default whenever a new project is created and the repository module is activated. Relevant work package: https://community.openproject.org/work_packages/21277	9 years ago
Jens Ulferts	751f1f2801	rewrite legacy spec as feature spec Another option would have been to write it as unit tests for the controller. However, that would have required to restructure the controller as unit testing would otherwiese require to much mocking. Additionally, the feature specs are required anyway.	9 years ago
Jens Ulferts	e03e1e99df	prevent spec flicker by cleaning up after Setting.notified_events	9 years ago
Alexander Bach	a8e1aadec7	replace changed_data by details working towards making the alias obsolete...	9 years ago
Jan Sandbrink	f08eb09627	fix specs	9 years ago
Oliver Günther	bfa0c4d69d	Extend repository with UTF-16 encoded file, extend specs accordingly	9 years ago
Jan Sandbrink	ca03e6543a	fix specs	9 years ago
Oliver Günther	2b0ac5f86e	Use heuristic check to determine binary files based on null bytes The git adapter currently has a bug that denies to annotate regular text files when the author name has an umlaut. This commit changes the binary file detection by simply counting null bytes. This may not detect all binary files correctly, but that isn't a requirement. The original check was arguably used to avoid rendering large binary files in the browser. Relevant bug report: https://community.openproject.org/work_packages/20883	9 years ago
Jens Ulferts	d082237fc2	adapt spec to changed interface	9 years ago
Jens Ulferts	67d8e7f240	remove DefaultData::Loader from source All of it is now handled by db:seed which needs to run anyway	9 years ago
Alexander Bach	6424ce2b13	Remove legacy module	9 years ago
Alexander Bach	5fea667954	Return recipients as users instead of mail addresses	9 years ago
Oliver Günther	325ddf6fb3	Fix skipped legacy spec due to removed subversion test directory	9 years ago
Alexander Bach	22e6a37f9e	Migrate legacy spec	9 years ago
Alexander Bach	c771325d0b	Improve class naming	9 years ago
Oliver Günther	319bd21daf	Moved managed repository lifetime entirely to the model.	9 years ago
Oliver Günther	1e8c873544	Remove filesystem adapter This commit removes the entire FileSystem repository and adapter. It rids all specs (core and legacy) of remaining uses of this adpater and replaces it with a temporary subversion repository, where necessary. We also need to remove remaining filesystem instances from the database, otherwise users will receive errors when accessing said repositories on the Frontend. This does not destroy any data on filesystem, but database information on the repositories (remarks) are lost.	9 years ago
Oliver Günther	abc597a6d2	First draft implementation of radio-based frontend.	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - Configuration: Currently replaces the existing options in `configuration.yml`. - Implementation specifics: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Oliver Günther	7ebac37c14	Repository Management - Refactoring and Preparation Related work package: [#20415](https://community.openproject.org/work_packages/20415). This is a combined refactoring and extraction effort of local SCM functionality for SVM, Git adapters in preparation for the explicit lifetime management of repositories in #20416 and implementation of (local) repository storage quota in #18393. This PR is still heavily WIP and for the time being, depends on the legacy specs for testing. To run the tests, execute the following steps: ~~~ rake test:scm:setup:all rake spec:legacy ~~~ I'm open for ideas on how we integrate scm adapters tests into current specs. --- - [x] Exchange `IO::Open` for `Open3` to avoid countless manual exitcode checks - [x] Extract local functionality in its own Module - [] Extend `LocalClient` module with links to create/delete services for #20415 - [x] Break down unbearable local parse routines (Hound will be over the place until fixed - but down from 260 to < 20) - [x] `entries` - [x] `revisions` - [] local repository factory - [] Specs - [] Fix / Modernize - [] More adapter-related specs	9 years ago
Alexander Bach	ee14628c09	Move send_notification to event origin	9 years ago
Alexander Bach	a5f4eb1e8b	First event-based draft Unifies Journal- and WorkPackageObserver Removes them as observers Makes new JournalListener more classy	9 years ago
Markus Kahl	bd0df07090	fixed specs	9 years ago
Alex Coles	ee12f7ea82	Add explicit join references in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	81de05e5fe	Remove deprecated Relation#all in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	3355458fc8	Remove Array expectation in legacy Type spec Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	b2790b8db1	Migrate deprecated .update_all with conditions Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	424889897a	Migrate AR finder/query methods in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in `74228b59`. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	61d77c721b	Fix TextFormatting#format_text specs w/requests * Make intent slightly clearer with a shared context. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jens Ulferts	ea0b10b444	remove outdated spec Should have been removed together with the link	10 years ago
Florian Kraft	ccb2a6032e	repair legacy specs fix the application helper legacy spec fix text formatting spec to reflect anchors only mode w/o request Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Oliver Günther	5ada719136	Consolidate Module menu in header navigation This effectively changes the following menus: Top Menu - Removed Administration item - Added Item 'Work Packages' -> /work_packages - Added Item 'News' -> /news - Added Item 'Time Sheet' -> /time_entries (if user has a project with view time log permission) My Menu - Added Administration item as first position With work packages, time entries, news now residing in the top menu, these buttons are superfluous in the projects overview and are also removed. Relevant work package: https://community.openproject.org/work_packages/20512	10 years ago
Alex Coles	c7ef9bd060	Replace PlainTextInterceptor with BaseMailer This replaces the solution in `78e8fc38`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	077e42ba06	Make VersionsController#update use PATCH Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	bdf38a55af	fix all the legacy specs	10 years ago
Alex Coles	2640852fe3	Fix MembersController#autocomplete_for_member routing * make routing less convoluted (as in `18835799`). Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ae97716087	Make MyController#account use PATCH Now routes form helper-generated request correctly. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ab0864062e	Make WikiController#rename use PATCH Now routes form helper-generated request correctly. http://weblog.rubyonrails.org/2012/2/26/edge-rails-patch-is-the-new-primary-http-method-for-updates/ Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	516c9a5f3e	move mock method out of production code	10 years ago
Jan Sandbrink	bc3437c3b0	replace create_uploaded_file in specs mock_uploaded_file creates a Rack::Test::UploadedFile, which should behave equally to a real uploaded file, but is also treated correctly by Rack::Test	10 years ago
Alex Coles	78e8fc38e3	Replace UserMailer plain text hack w/ Interceptor The previous hack was broken, most likely as a result of internal `ActionMailer::Base` changes. This solution is still not ideal as the resulting email is unnecessarily multipart: albeit `multipart/mixed` with one plain text part, rather than `multipart/alternative`. There does not appear to be a built-in Ruby Mail API to convert multipart back to plain text. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	a2b0365a6f	Prune wiki examples in legacy routing spec Destroy routes should only need to support the DELETE verb. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	5d2577285f	Correct destroy method in legacy Group spec `#clear` (or `#delete_all`) will not invoke association callbacks (e.g `after_remove`) – it is unclear if this by design. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	abf4a011f0	Fix copying of versions on Project copy Adds a more robust solution for copying closed versions and associating with copied work packages (see original patch `10ec20a8`). Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	dffaf63c38	Fix assets path in ProjectsController legacy spec Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e4047301bb	Fix template name in ReportsController legacy spec Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	88f1898d86	Update legacy WelcomeController spec for HTML5 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago

1 2

78 Commits (a8e92e251f012f96f78308f534a5d289d17164a3)