openproject

Commit Graph

Author	SHA1	Message	Date
Benjamin Bädorf	68949daa03	Feature/35521 ium capabilities (#9158 ) * Started experimenting with capabilities * Started adding akita store * Use current user store to filter projects * Work on integrating capabilities * Added capability checks * Fix project select * Working on ium specs * Change ng select option list format * Fix proejct search label * Fix some specs * Fix issue with principal select * Add spec for missing placeholder user capabilities * Add new capability specs, fix existing ones * Fix import * Update shrinkwrap * Add JSDoc deprecations Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Benjamin Bädorf	64143001fc	Set moment locale globally (#9040 ) * Set moment locale globally This sets the moment locale to the application locale globally, ensuring that moment uses the right translation strings wherever applicable. However, since we only work with languages (en), and not real locales (en-US), the first day of year calculation has to default to some option. This commit defaults to ISO 8601 for every language and locale. * Add setting to mark dayOfYear * Fix NaN check * Add spec for switching settings * Output uniq github specs Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	3e723a07af	[36764] Fix margins of table when sums and/or inline create showing In https://github.com/opf/openproject/pull/8771, a double styling was added when the inline create row is showing. Back then, sums row was always taking up space even if not visible so the double margin was correct. This however is no longer the case. We need to apply different margins when either sums or inline create, or both are showing. https://community.openproject.org/wp/36764	4 years ago
Wieland Lindenthal	21af36f56a	Add step for quick add menu to onboarding tour	4 years ago
Wieland Lindenthal	c29df6223e	Change icon for inviting a user from within drop down from plus to user-plus [ci skip]	4 years ago
Oliver Günther	b0e4b0e9b2	Set explicit timeout in the dev proxy Otherwise longer debug sessions will get terminated	4 years ago
ulferts	72abb45249	Fix/project status flaws (#9138 ) * fix documentation on project statusExplanation * correctly denote the type of the project status * don`t reloy on faulty backend type	4 years ago
Philipp Tessenow	a46de71009	[#36204 ] Add new GitHub plugin tab enabling users to copy git actions (#9027 ) * Let GitHub integration show changes in a separate tab * added new github integration icons to icon font * add tab content: working tab-header and copy-menu * modernise github_integrations ruby code * refactored some code to be more modern ruby (if wrote most of it 7 years ago and couldn't look at some parts without squinting too much) * make some intended-to-be-private module methods actually private * fixed all rubocop errors in the /modules/github_integration * re-organized tests a little * gave our rubocop.yml some RSpec-related defaults -- happy to discuss these, but I think we can live with these as a good starting point 👆 all without actually (intentionally) changing the behaviour * removed dead angular template code * codeclimate found more things than rubocop :) * removed create-pr-button since we decided against implementing that feature * added missing translations * properly cache the github related part of the wp api * lower case pull requests in translations * fix specs	4 years ago
Oliver Günther	693d01f8c7	Bump Sentry and implement log handling in core (#9133 ) * Bump Sentry and implement log handling in core * Manually insert the sentry middlewares * Also add user locale as tags * Add performance tracing * Update sentry host to sentry2 * Update frontend sentry-reporter to the new sdk * Silence delayed_job's own logger since activejob logs already Delayed::Job will otherwise always log all arguments, which we disable by design * Remove default sentry host	4 years ago
Benjamin Bädorf	2667cd1581	Refactor/app header (#9110 ) * [35527] Add quick add button menu in top menu * Add quick menu item to top menu * Refactor top_menu.sass to follow BEM * Only render project-based path if persisted * Render project types when in project context * Add headline and determine if any types are visible * Hide quick add menu for unauthorized users * Fix login menu dropdown by adding class * Add schematic for correctly generating components * Add augment service for triggering invite user modal * Fix allowed_to? check in menu * Add spec * Highlight types and show all * Fix help menu overridden * Extend spec * Add parent_id to project in dropdown and expand advanced settings * Reload the page if the modal returned any data * Fix invalid url allowed check if there is no URL to check * Basic BEM changes * Remove old classes * Update more classes * Update togling logic * Fixed menu opening and some styles * Added op-menu * Fix some help menu styles * Add op-menu to help menug * Add avatar border * Fix auth_provider_spec * Fix zen mode * Fix static link help menu * Fixed top menu specs * Fix self registration specs * Fix logout spec * Fix bim revit navigation spec * Fixed menu permissions spec * Fix homescreen onboarding tour spec * Fix top menu item spec * Remove unused file * Fix a lot of mobile styles * Fix more mobile styles * Fixed build * Move quick add menu to right hand side * Improve quick-add-button styles, fix main-menu-toggle close icon * Remove add new project spec * Fix spec * Update project dropdown styles * Fix click handler for chrome mobile, update some styles Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	18320fcae6	Fix styling of LSG [ci skip]	4 years ago
Oliver Günther	00cb496c94	[34513] Remove min=0 for integer filter https://community.openproject.org/wp/34513	4 years ago
Benjamin Bädorf	79832c27ea	Invite user modal fixes (#9107 ) * Improve invite button styling * Put buttons on the right hand side inside modals, highlight next buttons, show newlines for invitation message * Fix form-field invalid styles, fix some i18n typos * Fix modal close button position * Updat emobile and scroll styling * Show email instead of name when inviting a new user * Remove close on escape * Force autofocus of message input * Fix typing * Update texts * Fix translation string, update op-link inline styles, add autosizing to textarea * Injecting CreateAutocompleterComponent to trigger onUserInvited * Dirty fix for the data coming out of the modal * Adapt Constructor of TimeEntryWorkPackageAutocompleterComponent Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Philipp Tessenow	b10e81b46e	Updated y18n (#9144 ) `npm audit` yielded the following security hint: ``` ❯ npm audit y18n <3.2.2\|\|=4.0.0\|\|>=5.0.0 <5.0.5 Severity: high Prototype Pollution - https://npmjs.com/advisories/1654 fix available via `npm audit fix` node_modules/y18n 1 high severity vulnerability ``` Updating the js dependency from 4.0.0 to 4.0.1 resolved that issue.	4 years ago
Philipp Tessenow	f426d3ece3	Allow plugins to add additional work package tabs (#8999 ) * Allow plugins to add additional work package tabs * side fix: moved registration of new work package tabs into the hook service while still being type-checked * Restore shrinkwrap Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	e811d8b6f7	Don't clear the datepicker input resulting in an endless loop Clearing the datepicker when it is not set will result in an endless loop since flatpickr already unsets it properly. Instead just emit the empty value	4 years ago
Oliver Günther	9e23fe14b8	Codeclimate: Revert rubocop channel back to 1-9-1 (#9131 ) * Revert rubocop channel back to 1-9-1 Newer versions are not supported yet: https://codeclimate.com/github/opf/openproject/builds/19192 * Rename scsslint to scss-lint * Fix tsconfig path for eslint in codeclimate	4 years ago
Aleix Suau	4fa6cc9f71	Shorten file paths to avoid Windows errors	4 years ago
Aleix Suau	f568f0f369	Revert "shorten-files-path-to-avoid-windows-error" This reverts commit `5646b30571`.	4 years ago
Aleix Suau	5646b30571	shorten-files-path-to-avoid-windows-error	4 years ago
Aleix Suau	6b0c2c0d91	shorten-files-path-to-avoid-windows-error (#9132 )	4 years ago
ulferts	3d0420a2a9	fix implicit any declaration	4 years ago
Oliver Günther	6944affca8	[35527] Add quick-menu to top menu (#9058 ) * [35527] Add quick add button menu in top menu * Add quick menu item to top menu * Refactor top_menu.sass to follow BEM * Only render project-based path if persisted * Render project types when in project context * Add headline and determine if any types are visible * Hide quick add menu for unauthorized users * Fix login menu dropdown by adding class * Add schematic for correctly generating components * Add augment service for triggering invite user modal * Fix allowed_to? check in menu * Add spec * Highlight types and show all * Fix help menu overridden * Extend spec * Add parent_id to project in dropdown and expand advanced settings * Reload the page if the modal returned any data * Fix invalid url allowed check if there is no URL to check * Restrict top_menu sass * Remove unused imports * Reduce required permissions to show quick add * Spec review feedback * Rename project fieldset ID	4 years ago
Oliver Günther	57034bc7d6	[35744] Use case-insenstive string comparison for action boards (#9112 ) https://community.openproject.com/work_packages/35744	4 years ago
Oliver Günther	26159af5d8	[36291] Fix selector for checkbox check-all function https://community.openproject.org/work_packages/36291	4 years ago
ulferts	e04b8ab4f1	failsave for displayed days	4 years ago
Benjamin Bädorf	77aca255c4	Fix multiselect list custom field (#9108 ) In the custom field type, both array and non-array value types were being handled the same, causing array types to be unwrapped once too often.	4 years ago
Oliver Günther	dfe575ca9c	[36269] Add "other" to pluralization rules for one (#9102 ) * [36269] Add "other" to pluralization rules for one For languages that do not have "one" as a pluralization rule (japanese, for example), the pluralization rule defined by I18n.js does not return a valid string for count: 1. Since we probably do not want to define custom pluralization rules for all languages, we can fall back to the "other" key if "one" is not defined. https://community.openproject.com/wp/36269 * Explicitly wait before clicking on viewpoint The click happens before the side tree is rendered by xeokit, and not being updated afterwards	4 years ago
Aleix Suau	9575a5761f	Weekdays displayed in local order and saved with weekday offset 1	4 years ago
Aleix Suau	694483db83	Weekdays displayed in local order and saved with weekday offset 1	4 years ago
Oliver Günther	334eea3f78	[36278] Hide sums row when not used (#9104 ) The sums row has an empty height, but the border is still applied in Firefox, but not in Chrome. Instead, truly hide it until used https://community.openproject.org/wp/36278	4 years ago
Aleix Suau	e9c59029f5	Fixed by refreshing wps from states	4 years ago
Oliver Günther	3fb0504c98	[36425] Fix and localize contact us for demo link (#9100 ) https://community.openproject.com/wp/36425	4 years ago
Benjamin Bädorf	beb4e6ba50	Refactor/user avatar to principal (#9069 ) * Fix some ium stylings * Extend create service to also test with empty names * Add PrincipalLike type to pass around non-created placeholder refs * Add icon-context * Move principal rendering to its own module * Fix emit create new placeholder to principals * Revert op-principal for now * Add memberships form API to properly post * Fix types for returned principals * Move untilDestroyed in role * Filter input if not string in role-search * Pass correct inputs to success component * Return principal after saving membership * Fix small stuff around the ium * Fix the way HalResources are selected and passed * Move principal module to be exported by common * Disable quotemark in tslint until eslint is enabled * Fix image path in success * Adapt modal to run all steps in one within the modal helper component * Several fixes to modals * Fix ium success component styles, * Registration modal y-overflow * Add SMTP parameters to .env.example * Add disabled option to op-option-list, disabled placeholder users for non-ee instances * Add correct ee link to placeholder user option * Fix build * Removed unused sass files * Fix principal search not found indicator, added placeholder add image * Fix enterprise edition url, use dirty instead of touched check * Use backend class names for frontend principal types * Fix duplicate import and principal type usage * Also disable banners if with_ee is present in test * Extend specs for placeholders * Fix disabled attribute * Extend spec WIP * Improved inline-validation styles, fixed more PrincipalType usages * Add group happy path test, fix more PrincipalType usage * Fix a translation * Revert line deletion * Rewrite same spec examples into shared examples * Fix name of shared example * Dont run assets:clean to remove angular assets * Output whether assets are there at all * Update user-avatar usages to principal * Fix some op-principal usages * Fix principal typing * Remove ls of non-existent directory * Rename more user-avatar instances * Avatars now render correctly * Fix an op-principal instance, default to avatar class for avatars * Always add principal id to default principal tag * Small fixes to op-principal * Fix multiline user display * Dirty fix for capybara click events * Update avatar sizing * Fixed some specs * Fix unit specs * Added op-link styles * Fix add placeholder image link * Remove byebug debugger statements Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	b609964818	Fix double usage of loading-indicator in export modal	4 years ago
Aleix Suau	372ffa9428	Allow InjectFlags on @InjectField (Optional, SkipSelf...)	4 years ago
Aleix Suau	7dc34a9f7b	Removed wrong chages coming from dev	4 years ago
Aleix Suau	e8fb2349a4	Handling url params update when wp type changes	4 years ago
Oliver Günther	6fde8cc32a	Add patch to I18n to replace empty strings with nil (#9068 ) * Add patch to I18n to replace empty strings with nil * Add common patch_gem_version helper	4 years ago
Oliver Günther	a023ccf372	[36517] Fix placeholder filter returning query object, not AR collection (#9071 ) We depend on the query for correct sorting by name. https://community.openproject.com/work_packages/36517	4 years ago
Oliver Günther	3b78be087b	Migrate tslint to eslint (#9064 ) * tslint to eslint migration * Autofix issues * Fix codeclimate path to eslintrc * Extend linter config for use with ng lint * Change prefix to op in angular lints	4 years ago
Oliver Günther	d329db23ff	Finish user invite modal (#9061 ) * Fix some ium stylings * Extend create service to also test with empty names * Add PrincipalLike type to pass around non-created placeholder refs * Add icon-context * Move principal rendering to its own module * Fix emit create new placeholder to principals * Revert op-principal for now * Add memberships form API to properly post * Fix types for returned principals * Move untilDestroyed in role * Filter input if not string in role-search * Pass correct inputs to success component * Return principal after saving membership * Fix small stuff around the ium * Fix the way HalResources are selected and passed * Move principal module to be exported by common * Disable quotemark in tslint until eslint is enabled * Fix image path in success * Adapt modal to run all steps in one within the modal helper component * Several fixes to modals * Fix ium success component styles, * Registration modal y-overflow * Add SMTP parameters to .env.example * Add disabled option to op-option-list, disabled placeholder users for non-ee instances * Add correct ee link to placeholder user option * Fix build * Removed unused sass files * Fix principal search not found indicator, added placeholder add image * Fix enterprise edition url, use dirty instead of touched check * Use backend class names for frontend principal types * Fix duplicate import and principal type usage * Also disable banners if with_ee is present in test * Extend specs for placeholders * Fix disabled attribute * Extend spec WIP * Improved inline-validation styles, fixed more PrincipalType usages * Add group happy path test, fix more PrincipalType usage * Fix a translation * Revert line deletion * Rewrite same spec examples into shared examples * Fix name of shared example * Dont run assets:clean to remove angular assets * Output whether assets are there at all * Fix placeholder path * Revert "Output whether assets are there at all" This reverts commit `42219c2755`. Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>	4 years ago
Oliver Günther	95327c7be0	[36304] Load and fall back to english locale due to crowdin bug (#9066 ) https://community.openproject.com/wp/36304	4 years ago
Oliver Günther	c4c4cc9042	Bump Angular to 11.2 (#9054 ) * Bump Angular to 11.2 * Restructure package.json dependencies * Fix absolute templateURLs that are no longer supported * Fix promise types after removed promises-a-plus pkg * Revert karma bump as its breaking tests	4 years ago
ulferts	247c8e913e	fix row rerendering with limited permissions If the user has limited permission, e.g. no right to reorder, the first row, used for sorting, has had a different class set. When rerendering that row, the class set is expected but not found. The patch * Adds the expected classes * Increases the robustness whenever the expectation is not met in case other places make the same mistake of not adding the necessary classes	4 years ago
Aleix Suau	0358f89abf	Download pdf on a new tab (#9004 )	4 years ago
ulferts	1dabcbc566	fix templated check on boolean filters The check for templated failed for boolean filters as true was returned where a string was expected	4 years ago
Aleix Suau	44cf9e0c5e	Epic/placeholder users frontend (#8977 ) * Add new button added to select-edit-field * Permissions Service + show button if canInviteUsersToProject * Permissions Service + show button if canInviteUsersToProject * Add initial invite user modal * Small change to invite user modal * Small use rmodal changes * Builds * Added invite user modal title translation * Changed modal to module * Figured out basic modal setup * Fixed build * Started adding option-list component * Adding reactive forms * vim * Reactive forms working for option-list * op-form-field is implemented, project-selection step works * Working on principal step * Basics of principal selection are done * Remove console logs * Added role step and role api bindings, updated directory structure * Added basics of message step * Added summary page * Add in-project check for selected principal * Add documentation for principal filters * Create modal-heading component * Fix principal emit * Add API calls to summary component * Work on translations, rework close fn * Added translations * Fixed styling * Add autofocus, fix typing * Improve typing * Add form-binding directive to fix form-field * Fixed typescript errors * Fix more translations * Codeclimate and TSLint errors * Failing test commented with TODO * Codeclimate fixes * Codeclimate fixes * Open invite user modal from user selection * Remove console and debugger calls * Opening modal from CreateAutocompleterComponent * Add new button added to select-edit-field * Permissions Service + show button if canInviteUsersToProject * Permissions Service + show button if canInviteUsersToProject * Codeclimate and TSLint errors * Failing test commented with TODO * Codeclimate fixes * Codeclimate fixes * Add initial invite user modal * Small change to invite user modal * Small use rmodal changes * Builds * Added invite user modal title translation * Changed modal to module * Figured out basic modal setup * Fixed build * Started adding option-list component * Adding reactive forms * vim * Reactive forms working for option-list * op-form-field is implemented, project-selection step works * Working on principal step * Basics of principal selection are done * Remove console logs * Added role step and role api bindings, updated directory structure * Added basics of message step * Added summary page * Add in-project check for selected principal * Add documentation for principal filters * Create modal-heading component * Fix principal emit * Add API calls to summary component * Work on translations, rework close fn * Added translations * Fixed styling * Add autofocus, fix typing * Improve typing * Add form-binding directive to fix form-field * Fixed typescript errors * Fix more translations * Refactor/op modal (#8978) * Initial modal refactoring * Updated modal imports * More modal module imports * Fix one more import * Fixed some styles * Fixed failing modal specs * Fix more spec selectors * Fix more specs * Updated backend modals * Improved code style * Fix export modal styles * Fix wiki export modal * Fix more specs * Fix webhooks modal * Added loading indicator back into modals * Fixed wp preview modal * InviteUserButtonComponent in * InviteUserButtonComponent in * InviteUserButtonComponent in MultiSelectEditFieldComponent and SelectEditFieldComponent * Remove extraneous module * Add Dragula import * Remove empty spec * Fix option-list component * Remove group creation from invite user modal * Write feature spec * Fix TS errors * Add Placeholder and Group apis to the frontend * Better api typing * Remove unnecessary interface * Remove group creation call Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com> Co-authored-by: Oliver Günther <mail@oliverguenther.de> Co-authored-by: Benjamin Bädorf <hello@benjaminbaedorf.eu>	4 years ago
ulferts	b51aebd397	update new feature box to 11.2 features (#9041 )	4 years ago
ulferts	9edf745085	Fix/group mention links (#9036 ) * turn group mentioning into link * add profile button to group edit page * Include built ckeditor Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago

... 2 3 4 5 6 ...

8389 Commits (a90bbc7834d21ba98c123799ad7cca21777c57ea)