openproject

Commit Graph

Author	SHA1	Message	Date
Aleix Suau	f5d2a7467b	Feature/36382 multi selection for project custom fields base (#9164 ) * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * Provide DynamicFieldsService in root so it can be used independently * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * _isResourceSchema based on parent?.location * Scope DynamicFieldsService to DynamicFormComponent * Added backend validation method to FormsService * Remove form from DynamicForm when not isStandaloneForm * Allow multiple form keys to validate * Remove form from non standalone forms * Remove duplicated button * Fix: dynamic form with ng-template not showing validations * DynamicForm programatic validation * Hide the submit button input * Unify ckeditor spacings with other dynamic-form elements * Basic fixes to invalid dynamic form fields * Fix invalid styles for dynamic inputs * Updates to form styles, add op-form and op-fieldset * Soften inputs to 2px * Update input styles globally * Fix selectors in copy spec * Undo new project route Will be handled in separate PR * Add separate module for field controls Otherwise it will not be found in the FormattableEditField component * Fix paths now having a trailing slash due to ui-router * Remove new project lazy route * Add data attribute to locate fields * Fix spec by locating field with data * Accept that ng-select can be cut off No idea why that changed in this PR though? * Fix success message to match tests * Redirect settings to generic to match angular path * Fix other project spec * Remove fdescribe * Fix missing cv with magic wait time for now * Remove broken angular tests * Fix routing spec * Import field controls module in wp module * Wait after inserting link into ckeditor It looks like the formly field doesn't get the current ckeditor value before saving * Decouple settings fetching from dynamicform mode (Standalone/FormControl) Co-authored-by: Oliver Günther <mail@oliverguenther.de> Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
Cyril Rohr	b4086b2968	Standalone CI docker container (#8943 )	4 years ago
Henriette Darge	b3dd61946e	[32880] Display scheduling mode in work package view (full, split & table) (#8410 ) * Show icon next to start date depending on the scheduling mode * Show modal when opening date edit fields which shall be able to change the dates and the scheduling mode * Introduce flatpickr as a datepicker for the modal of the dateEditField * Use new datepicker within opDatePickerComponent * Reuse existing Datepicker class for better code abstraction * Set dates only when Instance is ready * Let augmentedDatePicker use generic DatePicker class, too. * Remove jQuery UI datepicker specific styles as they do not apply any more. * Use localized strings in new datepicker * Close datepicker only on click outside * Allow single and multi selection of dates and save changes * Update schedulingMode button correctly && remove unused method * Show combined field for start and end date within the WP single view * Show normal datepicker for most date fields and the modal with the extended datepicker only for startDate * Add datepicker edit field and component helper * Correctly save start and end date * Show correct default value for dateEditFields && Adapt some tests to new datepicker and combined date field * Fix date editor spec * Fix expecting datepicker for start/due date as milestone * Prevent overflow on body by using modal-portal class && make edit input for combinedDates visible again to show something in a create form * Only output one debounced change event for op datepicker * Show combined datepickerModal for dueDate in table, too && save correct scheduling value * Hide modal if the showing component gets destroyed * Correctly check for closed datepicker * Add spec for toggling scheduling mode * Fix setting dates to modal * Avoid too many (unnecessary) close events and use keydown instead * Fix date setting and add custom field date spec * Change layout of combined date picker modal * Switch from a range date picker to a multiple selection in order to be able to set only start or due date && Highlight date field that is changed next * Highlight range manually * Highlight dueDate initially when the user clicked on the due date field && handle special case that one of the values is not set yet. In this case we don't want to keep both values but only the newly clicked. * Move helper functions to own class && Improve the range selection to be able highlight ranges over multiple months && Prevent that a start date > due date can be chosen by setting minDate and maxDate * Adapt test to new way of changing the scheduling mode * Handle case that the user clicks on a already selected date and thus deselects it Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	afeb1a42af	[31859] Save date with confirm button when empty https://community.openproject.com/wp/31859	5 years ago
ulferts	799fa82983	edit time entry via modal	5 years ago
Oliver Günther	e31f66dd74	[31312] Filter only for the one relevant available_project The version autocompleter loads all available projects to filter in the frontend. It was also wrongly inheriting AND using the create-autocompleter component at the same time. Instead it is now reusing the same template and subclassing it. https://community.openproject.com/wp/31312	5 years ago
Henriette Dinger	6f92035ccc	Rename EditField classes used for tests and remove WorkPackage reference	5 years ago
Henriette Dinger	f47a75d153	[31023] Preparation for project edit fields: Generalize edit and display fields currently work package specific (#7726 ) * Check edit fields for Work package dependencies * Make EditForm, NotificationService, EditContext indepenedent of Work Packages * Make EventsService independent of WorkPackages * Start renaming WpNotificationService (WiP) * Fix more references * Fix typescript errors * Add basic halEditingService * Rename to global halResourceEditingService (WiP) * Move typing from class to methods (WiP) * Fix typescript errors * Remove space in type * Add test project widget && generalize the editFieldGroup * Rename editing portal service [ci skip] * Rename WpEditFieldComponent * Rename WpDisplayFields * Rename display-XX-field to XX-display-field [ci skip] * Add WP specific ID field to distinguish between resources * Re-add state in work package resource * Generalize display field renderer * Rename spent-time to wp-spent-time and fix highlight specifics [ci skip] * Actually load the project schema and make field editable * Make edit-field-group.component an edit-form.component and subclass EditForm * Remove edit context in favor of specialized EditForm * Add special cases for work package editing * Fix edit actions bar * Fix codeclimate issues * Use WorkPackageNotificationService if necessary * Override NotificationService for WPs to allow WP specififc notifications (WiP) * Correctly provide wpNotification service Because the ui-router doesn't seem to correctly use the parent element's injector, we need to provide the wpNotification service not in the wp-base, but rather the wp-list component as well as in the isolated query space. * Allow to filter halEvents for specific resourceTypes (e.g. WorkPackage) * Remove superfluous cell class constant * Start renaming selectors for wp-edit-field into generics * Remove wp-table--cell-span in favor of display field selector * Consolidate other display and edit field styles * Provide specialized service for transitions in active edit forms * Remove superfluous overflowSelector * Accept that date field contains some work package specifics * Ignore unreadable files * Provide the changeset for work packages as a hook Since hal resource editing service is provided per query space, we cannot register them once (would only work globally) * Fix dangerfile * Remove another todo in halResourceNotification service * Fix npm TestBed for changed dependencies * Show inplace edit field in project details widget * Fix highlighting in single view * Provide HalResourceEditingService outside of project context * Used typedState for single-view * Also provide wpNotification service in split view * Correct check for resource type in eventsService * Fix getSchemaName in display field renderer * Fix passing ids into `halEditing.stopEditing` * Do not globally inject the halResourceEditingService There's a bug(?) in ui-router that gives you the global service before the parent injected service for a ui-view * Fix wpCreate service on copying and parallel creation * Remove test project widget * Revert changes for project details widget	5 years ago
Oliver Günther	872fba5892	Fix styling of task lists	5 years ago
Henriette Dinger	8fcfe631c0	Adapt tests to immediate save of input fields on focus loss	5 years ago
Henriette Dinger	646945b1ba	Increase available space for autocompleter in table and reduce label to save space	6 years ago
Henriette Dinger	147d4f4c9f	Add test for inline creation of versions from within WP view && adapt tests to new component	6 years ago
Henriette Dinger	07623bcc27	Add user name to the avatar in WP views and adapt tests accordingly	6 years ago
Henriette Dinger	81963ace58	Adapt tests to the user avatar being shown in the table andWP view	6 years ago
Henriette Dinger	f955b7edd1	Remove already selected entries from multi-select field	6 years ago
Henriette Dinger	1b8aa2b3e2	[29257] Auto completion for work package attributes (#6988 ) * Introduce ng-select component on WP pages * Remove multiselect switch within multiselect component * Append autocomleter dropdown to attribute group to better handle the two colum layout * Add overflow selector to edit contexts to allow adding to it * Set correct element to append to on WP table and WP view * Make dropdown in Subject row visible and start fixing tests * Fix tests * Append wp autocomplete dropdown to body * Pass user activation requests to edit field [ci skip] * Directly open select fields on click * Include ng-select from own fork * Add path to tsconfig.json to resolve the module * Make attributes group id fix, so that it stays the same after reinitialisation (e.g. type change) [ci skip]	6 years ago
Oliver Günther	3ba6913960	Implement read-only work package attributes based on status	6 years ago
Jens Ulferts	df4c9376d4	attempt to stabilize feature specs	6 years ago
Oliver Günther	a694f9a581	[28580] Correctly replace the work package to avoid invalid update link The permission to edit the work package is controlled through the HAL link workPackage.update For new work packages, add_work_packages permission leads update link of /api/v3/projects/X/work_packages/form When saving the work package, no update links is returned (correct, since you don't have the permission). The returning HAL+JSON is merged back into the frontend resource, leaving the old update link, which is now invalid. https://community.openproject.com/wp/28580	6 years ago
Oliver Günther	900cc7f985	[28123] Avoid balloon editor, instead use full and constrained classic build https://community.openproject.com/wp/28123	6 years ago
Jens Ulferts	319f33e924	remove textile	6 years ago
Oliver Günther	2a90971b4f	Ensure input field is enabled when editing it	7 years ago
Henriette Dinger	89e8c316a5	[25512] More prominent work package status selector (2) (#5999 ) * Add new WP status selector button [WIP] * Change styling and add little permission handling * Store changed status * Adapt new styling * Show status depending on the changeset * Remove status button from create form && reduce height of info row * Adjust test cases, add success message, support for help texts and transfer css variables [ci skip]	7 years ago
Oliver Günther	b15f07ea32	Scroll to element when blocked by overflow The details view blocks certain elements of the table, causing clicks to no longer work in newer Firefoxen This is mainly caused by https://bugzilla.mozilla.org/show_bug.cgi?id=1295538	7 years ago
Oliver Günther	2e521a49e3	[26304] Save inline-create and split view together (#5923 ) We only have the one `new` work package and changeset, so we can't handle multiple views creating different work packages. [ci skip]	7 years ago
Oliver Günther	280c00d50f	Fix more tests	7 years ago
Oliver Günther	3cb9408faf	Fix tests	7 years ago
Oliver Günther	56b67e9f9e	Consolidate existing WorkPackageField and TableWorkPackageField	7 years ago
Oliver Günther	c8ef6e1a4d	Strengthen specs (Try #2 ) (#5686 ) * Don't use expect in retry_block It doesn't raise an exception, but only marks the example erroneous * Replace textile_link cuke * Replace wp search cuke with existing spec We only need to test for the href, no need to check that the page exists. * Also remove pagination cuke, its part of the search-spec [ci skip]	7 years ago
Oliver Günther	cbf6671402	Housekeeping/strengthen specs (#5650 ) * Try to strengthen CF spec * Removing randomly failing old TL cuke [ci skip]	8 years ago
Oliver Günther	b3b047a904	Extract retriable into helper with logging	8 years ago
Oliver Günther	8de452b006	Use retriable to retry code blocks, not examples	8 years ago
Oliver Günther	2eb762182d	Move set_attribute into work package field so table spec can profit	8 years ago
Oliver Günther	76ac1b319a	Use waiting test for `WorkPackageField#editable?`	8 years ago
Oliver Günther	81c79d82ae	Only check expect_active! when no error occurs	8 years ago
Oliver Günther	e4511ec3a7	Retry setting single attributes in AbstractWorkPackage	8 years ago
Oliver Günther	d0311d8f28	Fix input_types for some attributes and make error message more useful	8 years ago
Oliver Günther	e3f1b42df3	Rewrite AbstractWorkPackage#set_attrbiutes	8 years ago
Jens Ulferts	bafee7a5ab	adapt specs after gem bump	8 years ago
Jens Ulferts	112f2d398a	remove class that is then replaced Because of the use of replace: true within the wp-display-attr, the classes of the first element get merged with whatever classes are defined on the calling dom element. As the classes on the calling dom elemnt suffice, we do not need that extra class.	9 years ago
Jens Ulferts	54b3136449	adapt spec inplace trigger selector	9 years ago
Oliver Günther	809aacdbff	Rubocop	9 years ago
Oliver Günther	a132a27454	Add type switching spec	9 years ago
Oliver Günther	ef94a15660	[23120,23121] Add required fields, labels to wp-edit-fields (#4421 ) * Add default label (name) to fields * Mark fields as required when schema says so * Work around xvfb :invalid state	9 years ago
Oliver Günther	7efaa7954b	Fix global create spec	9 years ago
Oliver Günther	7fc5d13b7f	[23075][23087] Force selection of values when select is required (#4389 ) This changes the disabled default option for required select fields to select that by default and disable it. This causes a required field to have a default selection of Please select similar to the Rails selects. https://community.openproject.com/work_packages/23075/activity Angular doesn't seem to respect the string 'null' option correctly when removing an assigned field. Instead, the model is set to undefined and we need to check for that. https://community.openproject.com/work_packages/23087/activity	9 years ago
Oliver Günther	30cb8771a3	Fix custom_field spec	9 years ago
Jens Ulferts	8125281286	ensure to not have a nil selector	9 years ago
Jens Ulferts	3f3649af0e	fix edit work package attribute spec	9 years ago

8 Commits (ac154bd0bb6a488e973207d40a22169f334ef865)