openproject

Commit Graph

Author	SHA1	Message	Date
Jan Sandbrink	2b7261b2ee	move assembly of reports list into controller	9 years ago
Jan Sandbrink	8e4321959e	improve code style	9 years ago
Oliver Günther	f47f61bcbf	Work around outdated group SQL The `Group.includes(:users)` call from the GroupsController seems to return an outdated / incomplete result of the members. You can verify that by calling `@group.reload` after the affected line, which will yield the correct result. I assume that this has something to do with the HABTM association `:users` for which a similar issue appears to be still open. Using `eager_loading` directly seems to fix the issue, however we have to remove :memberships here as it requires a condition.	9 years ago
Jan Sandbrink	dfb9a5cd20	remove remaining AR find_by_x finders - most of them were removed by @myabc in the rails4 branch - some where reintroduced due to parallel development to that branch - still some occurences left that will hit custom implementations	9 years ago
Oliver Günther	dfb8ac4853	Add basic checkout instructions This commit adds very basic checkout instructions similar to `openproject-checkout` to repositories. Issues: * Uses table style for checkout component, as exact styling is unclear * Adds compressed table style with less padding * Checkout settings are best organized in a Hash with keys per SCM * vendor. Using default settings, a lot of new setting values would be introduced * Checks for Hash in SettingsController * Currently can't use SettingsHelper, as it requires single setting values	9 years ago
Jan Sandbrink	2a65240e52	always include relevant columns - caller does not need to do it anymore - caller is still allowed to do it, because it can also add own conditions...	9 years ago
Jan Sandbrink	1c2aabbc45	allow sorting of WP lists	9 years ago
Jan Sandbrink	bc36704611	allow to get queries via APIv3 - one of those missing endpoints - adapted resource spec to be closer to other resource specs - specified error behaviour (missing permissions) -> change: not being allowed to see a query results in 404	9 years ago
Alex Coles	53a224bf76	Remove mutation method calls on AR::Relation See: * `6eeea9d1` * http://guides.rubyonrails.org/upgrading_ruby_on_rails.html#mutator-methods-called-on-relation Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Oliver Günther	988c9f38a7	Cucumber fixes * Use correct locale for testing * Global namespace refs	9 years ago
Oliver Günther	21d3af35b1	Set allowed mime types to respond_to This sets the allowed response types to be used with `respond_with`. Note that this will again need to be moved with 4.2 http://guides.rubyonrails.org/4_2_release_notes.html#respond-with-class-level-respond-to	9 years ago
Oliver Günther	6eeea9d1da	Avoid mutator sort on relations https://github.com/rails/rails/pull/13314 removed mutator methods (e.g., `Array#sort!`) from relations. This commit enforces either an ordering on the query itself where applicable, or uses a non-mutator sort.	9 years ago
Alex Coles	62fd6b1d02	Fix UsersController mass-assignment ArgumentError Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	16bbaba2c1	Fix MyController mass-assignment ArgumentError Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Oliver Günther	5129f05678	Fix NameError for Pagination	9 years ago
Henriette Dinger	ba7f5c0891	Add pagination and column sorting to admin projects table * Adds a last activity column. * Removes tooltips from projects table in according with PM * Refactors sort_helper to correctly initialize default sort criteria * Add a placeholder 'information section' which matches the visual text size and icon. If this is used more often, this should be turned into its own LSG item * Default sort order is lft, but is unavailable in colums, thus a user should be able to reset the user-selected sorting. Currently we work around this by clearing the session sort entry. Users have to click on the projects menu item to return to the default sort. Relevant work package: https://community.openproject.org/work_packages/18800	9 years ago
Oliver Günther	2769e16819	[21275] Show information on storage paths as admin/info section This commit adds a separate section in the admin/info section to show used and available storage for: * Attachment storage * Manageable repository vendors	9 years ago
Oliver Günther	14a394842d	Extract SCM authorization routines into policies per vendor	9 years ago
Philipp Tessenow	373473c563	Add git support to repository authentication script Refactors the original PR from #1629 * dispersed authorization methods in SysController * refactored and updated SysController specs	9 years ago
Oliver Günther	0b583c3ccf	Extend autofetching of commits into update repository information This commit extends the previous functionality of autofetch commits into internal updating of repository information, which encompasses: * Commit information (changesets) * Disk space information They are now both retrieved when browsing the repository and the latter is fetched asynchronously whenever the last update is older than the timeout setting. This timeout setting is now user-configurable.	9 years ago
Oliver Günther	1d6ed59450	Move project required disk space counting to sql This adds a model section `Project::Storage` that allows counting required disk space for wikis, work packages, and repositories in SQL for all projects and on-demand for a single project. This removes all dependencies introduced from the ruby-based counting (i.e., the acts_as_ountable gem).	9 years ago
Oliver Günther	3ccde73519	Allow automatic creation of manageable repositories through a setting This commit allows manageable repositories to be automatically created by default whenever a new project is created and the repository module is activated. Relevant work package: https://community.openproject.org/work_packages/21277	9 years ago
Tim Habermaas	5a57a5bf9d	[Refactor] Make wp_hashes_with_string depend solely on its parameters.	9 years ago
Tim Habermaas	d0426dcf17	[Refactor] Use ActiveRecord#find_by_id instead of #find and rescue.	9 years ago
Stefan Botzenhart	87a3413ad3	Strip all passed values for non-array values	9 years ago
Jens Ulferts	6e01b27f18	rename service's method to be in accordance with proc	9 years ago
Jens Ulferts	c471080e08	set locale before API v3 request The mechanism was extracted from the rails stack where the locale is taken based on (in that order): * The user's preferences * The accept_language header * The system settings Only languages, that are enabled by the instance are valid. If one is selected (e.g user preference), that is not enabled by the instance, a fallback is taken.	9 years ago
Henriette Dinger	d8952e0a00	menu item gets correct background when being selected	9 years ago
Henriette Dinger	fc446643ba	corrected naming so that colors menu item gets correct background when selected	9 years ago
Jan Sandbrink	e8836d844e	hide global queries from project-scoped WP lists	9 years ago
Jan Sandbrink	f9051bba3e	display diff of containing aggregated journal ... instead of displaying the diff for the requested journal only - this should provide the best forward compatibility of links - even when aggregation timeframes are changed intermittently	9 years ago
Alexander Bach	a8e1aadec7	replace changed_data by details working towards making the alias obsolete...	9 years ago
Jens Ulferts	bdf20ef94d	extract work package move/copy to own service	9 years ago
Jens Ulferts	309254bf20	explicitly hand over the current user	9 years ago
Oliver Günther	c16c1e75d4	Extend SysController to allow WS to check / update storage	9 years ago
Oliver Günther	06d203141e	Remove outdated flash message Managed repositories are always deleted, even if the configuration states otherwise. The specific flash message concerning deletion of managed repositories is thus wrong and was removed.	9 years ago
Markus Kahl	dd496297fd	don't use random language as user's language If a user's language is not set ('') the code just used any valid language.	9 years ago
Jens Ulferts	67d8e7f240	remove DefaultData::Loader from source All of it is now handled by db:seed which needs to run anyway	9 years ago
Oliver Günther	f03008ec94	Require admin for destroy_info	9 years ago
Oliver Günther	c5b200d7a0	Review corrections - Remove repositories paths using project.id instead of `project_id` - Allow managed repositories to be unlinked in the instance (But doesn't remove repository directory). - Remove leftover settings partial	9 years ago
Oliver Günther	0284d11f21	Corrections from review - destroy_info: remove superfluous JS confirm dialog. - destroy_info: change notification type into severe warning - destroy_info: Remove delete button highlight and back button for consistency with styleguide. TODO: think of other ways to guide the user back (also applies to project destroy_info) - remove typo in 'repositories.errors.unauthorized' - empty repository: Render warning view (repositories/empty) instead of 500 exception notification. - revert reformat on code changed in rails4 branch. - create repository: Show managed flash part only when the repository is managed - delete repository: Show error when configuration no longer allows manageable (other ways tbd.) - repository controller: JS redirect wrapped inside format.js - repository settings: Select hidden when instance exists Specs: - Add routing spec for `get #destroy_info`	9 years ago
Oliver Günther	319bd21daf	Moved managed repository lifetime entirely to the model.	9 years ago
Oliver Günther	1e8c873544	Remove filesystem adapter This commit removes the entire FileSystem repository and adapter. It rids all specs (core and legacy) of remaining uses of this adpater and replaces it with a temporary subversion repository, where necessary. We also need to remove remaining filesystem instances from the database, otherwise users will receive errors when accessing said repositories on the Frontend. This does not destroy any data on filesystem, but database information on the repositories (remarks) are lost.	9 years ago
Oliver Günther	b0c0d0a53f	Avoid fishy factory delegation.	9 years ago
Oliver Günther	da27a552a1	Frontend extensions and build refactoring - switched to toggleable-attribute-groups to provide means for adding buttons in the attribute header (e.g., delete button). - added separate destroy_info page with different notifications for managed and linked repositories to ensure ramifications of removing physical repositories are communicated to the user. - Fixed several issues regarding scm_type selection and the building of repositories. Open questions still concern the question of acessing unsupported repositories (e.g., the soon-to-be-removed filesystem adapter). Acessing the class should will then throw an error, but we still have to allow users to remove the affected repository (somehow).	9 years ago
Oliver Günther	2b39d8fbdf	Cleaning up, Rubocop	9 years ago
Oliver Günther	abc597a6d2	First draft implementation of radio-based frontend.	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - Configuration: Currently replaces the existing options in `configuration.yml`. - Implementation specifics: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Oliver Günther	7ebac37c14	Repository Management - Refactoring and Preparation Related work package: [#20415](https://community.openproject.org/work_packages/20415). This is a combined refactoring and extraction effort of local SCM functionality for SVM, Git adapters in preparation for the explicit lifetime management of repositories in #20416 and implementation of (local) repository storage quota in #18393. This PR is still heavily WIP and for the time being, depends on the legacy specs for testing. To run the tests, execute the following steps: ~~~ rake test:scm:setup:all rake spec:legacy ~~~ I'm open for ideas on how we integrate scm adapters tests into current specs. --- - [x] Exchange `IO::Open` for `Open3` to avoid countless manual exitcode checks - [x] Extract local functionality in its own Module - [] Extend `LocalClient` module with links to create/delete services for #20415 - [x] Break down unbearable local parse routines (Hound will be over the place until fixed - but down from 260 to < 20) - [x] `entries` - [x] `revisions` - [] local repository factory - [] Specs - [] Fix / Modernize - [] More adapter-related specs	9 years ago
Alexander Bach	ee14628c09	Move send_notification to event origin	9 years ago

1 2 3 4 5 ...

2884 Commits (ac3f7ef5c84491c2b82191c4c5512f21abddd843)