openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	bf89e934b3	set the default value for newly build custom values Most of the time, the getter #custom_field_values is used with unbeknown to the caller will build custom values for not covered custom values. This method always assigned nil to the value of the newly build custom value when it should have used the default value. Once that is fixed, all models including acts_as_customizable will again have set the default values for custom fields correctly. This is true regardless of wether the custom value is added before or after the creation of the model. Only for work_packages is the additional method #set_default_values! required as the availble_custom_field might change during a request upon a switch in project and/or type.	4 years ago
ulferts	8dfc5e8803	fix touching the customizable on removing custom_values Before the commit, the existing custom_values where attempted to be reused but there was no deterministic behaviour with which reusing them was attempted. Additionally, the existing values where always changed (or they would receive the current value again) whenever values where provided, regardless of whether those values actually changes. There was no explicit flag that a value was removed. This poses a couple of problems: * Even if no new values where provided the order of the custom values as stored in the db might change leading to journal entries that where not actually caused by the user. * If values where only removed, due to the missing explicit removal flag, it became luck whether an existing custom value was actually changed. Only then would the customized object be touched leading to an update of cached fragments, i.e. representers. * Because the values where updated all the time, the performance would suffer. * Removed custom values where removed right away and not only after save. This commit introduces an explicit flag for removal and does not alter existing custom values. This might have the drawback of creating a custom value even when a value, chosen to be removed by the user, could be reused but this should be negligible. It also has the drawback of introducing a flag to be maintained.	4 years ago
ulferts	e2961fba14	replaces reform & custom error handling Replaces reform by a simple layer of Disposable + ActiveModel::Validations for contracts. Additionally removes the custom error handling where OpenProject added symbols to keep the ability to identify faulty attributes while having non standard format (deviates from `%{attribute} %{message}`). Changes to active record now allow us to define the format of a message on i18n level, e.g. `%{message}`. Therefore the patching can be removed. Reform plans to remove support for ActiveModel::Validations in version 4.0 at the latest but even today, support for it is hapazard. As we do not need the full stack of Reform anyway, we can solely rely on Disposable.	4 years ago
ulferts	983709db89	rewrite acts as journalized to create journals in sql	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	5869966f12	relay available_custom_fields call to cacheable class method That way, we avoid n+1 queries for the available custom field especially in scenarios like schemas and api collections where a set of models is queried for their custom fields	5 years ago
ulferts	18d0450ee9	use default rails autosave If the custom values are saved (i.e. created) in an after save block, their saved_changes are empty	5 years ago
Oliver Günther	64e6fae1b8	[30442] Use formatted custom value in xls export This also fixes localized output of custom fields such as float https://community.openproject.com/wp/30442	5 years ago
Jens Ulferts	d04b86da9c	introduce custom eager loading for work package list Reduces the amount of AR models instantiated when handing wp#index requests by: * Calculating part of the checksum for caching in the db. This is done by using the id and the updated_at/on field of associated models whose representation is cached in the wp representer. * Reusing instantiated models for multiple associations. e.g instances of Project are used in various places (the work package itself, it's ancestors and children). Instead of using Rails' eager loading which would instantiate a project potentially once for every association path, the code now assigns the same instance to all those associations. Additionally, the commit streamlines the creation of custom field injected representers. Now only one class is created for all work packages when before it would be one class for every uniq set of custom fields. On top of that, the class can be reused if the set of custom fields does not change.	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
ulferts	e8930af3e9	Fix/copy project with required custom fields (#6083 ) * remove no longer required before_action * fill custom_field_values on project copy The option, whether to copy custom_values is replaced by always filling in the values from the copied from project * copy wp custom fields on wp copy * refactor projects copy controller [ci skip]	7 years ago
ulferts	a8c1953cf5	always return a custom value if it is available in the customizable (#6075 ) [ci skip]	7 years ago
Oliver Günther	8fcfc834a3	[25269] Add typed_custom_value_for to retrieve CF value names To provide a common interface to get _ALL_ values for the given custom field id (either multi or single value), this PR adds `typed_custom_value_for` which maps all custom_values (if any) to their `typed_value`s. This is a requirement to output all values in `QueryCustomFieldColumn`.	8 years ago
Jens Ulferts	56b41a8b95	fix altering values of multi list cf	8 years ago
Markus Kahl	f5a57e3f42	list custom field normalisation and multi select	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	7fff018c17	avoid repeated custom_field getter/setter method creation	8 years ago
Jens Ulferts	f833cd2753	add test for mysql flag	8 years ago
Oliver Günther	2454624fde	Retain partial message for custom field to customizable	9 years ago
Oliver Günther	01e1141139	Use pre-generated error message from custom field Instead of generating a new error message when applying custom field errors on the customizable model, simply copy the already existing error message from the custom field, and save the symbol for later API processing. This saves both time and avoids errors when CFs require additional attributes for humanizing the error messages.	9 years ago
Jens Ulferts	cadc397239	create all custom field acessors on representer injection	9 years ago
Oliver Günther	f03728c156	Retain partial message for custom field to customizable	9 years ago
Oliver Günther	9a1ccce4e3	Use pre-generated error message from custom field Instead of generating a new error message when applying custom field errors on the customizable model, simply copy the already existing error message from the custom field, and save the symbol for later API processing. This saves both time and avoids errors when CFs require additional attributes for humanizing the error messages.	9 years ago
Jens Ulferts	0980f01a95	copy over symbol in custom value to customizable We need to have access to the original symbol so that the API v3 can post process the errors on the custom fields just like it does every other field. When only a string is provided, the symbol :unknown is stored which will lead to the API rendering error messages like "can't be blank" (without the erroneous field name).	9 years ago
Alex Coles	bbe8ec184a	Migrate acts_as_customizable has_many to lambda Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	a6c54cb25f	Migrate AR finder/query methods in lib code Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	a6212fb304	Fix syntax (w/Rubocop) in lib code Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	88b99db223	only respond to valid custom_field_n accessors it is not enough that the CF exists, it actually has to be a CF that can be used on that work package	10 years ago
Jan Sandbrink	fb44594d1f	style	10 years ago
Jan Sandbrink	d8bc15a6bd	remove NO-OP code	10 years ago
Jan Sandbrink	f0197b4323	style	10 years ago
Jan Sandbrink	fb486c1921	fix validation in type changing cases	10 years ago
Jan Sandbrink	d1e3e2d543	simplify loop	10 years ago
Jan Sandbrink	a59df82ca1	only create CF accessor methods on demand	10 years ago
Jan Sandbrink	9986466e15	use direct CF accessors in CF injector	10 years ago
Jan Sandbrink	e3537be022	add methods to directly access custom fields	10 years ago
Jan Sandbrink	1bf1cf2c1b	ignore custom values that are to be deleted - fixing the last failing test	10 years ago
Jan Sandbrink	7219eebee5	fix failing test unit tests requires to run validations for custom values every time, so we do it there was no clear indication on why they should not run always, it was not apparent either	10 years ago
Jan Sandbrink	e4ee92aa3e	forbid validation of associated custom values this SHOULD already be the default, however specs failed here because of additional validation that took place. Those validations stopped by adding the validate-parameter. Better don't ask why I guess... Development and Production mode behaved as documented though (validate false by default)	10 years ago
Jan Sandbrink	36bb955f7c	add custom value errors to customizable - allows to relate error messages to their custom field - allows to use errors.full_message correctly for custom values - might break specs... we will see that soon	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 [ci skip]	10 years ago
Alex Coles	ca2a1a5afc	Prefer #map over #collect in lib code Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	2f75bf4aff	Fix an indent in acts_as_customizable.rb Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	dabd7ba88a	Fix bad rubocop auto-correct affecting procs Switch to stabby lambdas, where consistent. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	45297523c2	Fix syntax (w/Rubocop) in lib code Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e7400af52a	Use 1.9+ Hash syntax in lib code Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Johannes Wollert	8b096975fe	updates copyright headers updates more copyright more copyright headers	11 years ago
Philipp Tessenow	a1e67dd460	new copyright header #1903	11 years ago
Hagen Schink	7650f53e8a	Removes debug statement	11 years ago
Hagen Schink	d0ca65dbaf	Introduces journable Journable introduces a connection between a journal and the journalized object.	11 years ago

50 Commits (ac4c15791a906bc693793030da234862f441df3a)