53 Commits (acdd9cf674be2fa9c8f483afba77f5070a9ab10e)

Author	SHA1	Message	Date
Oliver Günther	dbc1e8a848	Fix saving by enter	7 years ago
Oliver Günther	3a6f2e2278	[26044] Handle escape in field handler and reference form in table (#5828) ... * [26044] Handle escape in field handler and reference form in table Mousetrap was used to trigger escape on the field, but since we already have a keydown handler attached to it, we can re-use it for cancelling the field editing. While fixing this, I found out that the table edit context uses a new form for each field, which means the edit handler of the previous field is lost. A new reference context is held in the table to return existing forms, if any. In the single view, this is tied to the $scope of the edit field group, and thus ensure only one form exists. * Fix specs of long text fields now no longer escape-able. [ci skip]	7 years ago
ulferts	2f9d7f408a	Fix/wp table switch to milestone (#5825) ... * map date name in changeset * handle date switch in wp form * Don't stub_const for services that may exist before hand This will cause the const to be evaluated already, so that stub_const has no effect there. This is why this fails depending on the order on travis, but not locally/isolated. [ci skip]	7 years ago
ulferts	06a11ade58	fix milestone date edit in wp table (#5820) ... [ci skip]	7 years ago
Oliver Günther	d49aec0dc7	Reset form when creating a new inline row	7 years ago
Oliver Günther	3c357aeca2	Remove unused startEditing ... We no longer need to set the current value, since we fall back to the resource value.	7 years ago
Oliver Günther	3968c26104	Fix clearing the edit form upon cancelling the edition	7 years ago
Oliver Günther	0bc6e4bc40	Reject the form update ONLY when trying to save	7 years ago
Oliver Günther	9515b58f49	Reject submission earlier when validationErrors in form	7 years ago
Oliver Günther	591c665639	Store only the changeset in a state, not the form itself ... With the changeset being the authoritive source of the changes to a work package, we can pass it around. Also, a temporary resource for viewing the changes made to the work packages is available through the editing service. This is required since we need to show the WP resource as it were if the changes were applied.	7 years ago
Oliver Günther	589f228776	Create resource that contains the changeset and form	7 years ago
Oliver Günther	9687734a97	Only add to changes once changed	7 years ago
Oliver Günther	6663939ce9	Allow initialization with a new form resource ... Avoids loading the form again when the single view initializes the form editing.	7 years ago
Oliver Günther	b1945d97df	Correct focussing on new fields when switching	7 years ago
Oliver Günther	e9bd077d9b	Allow traversal from one single-view to the other (e.g. split -> full) ... This requires us to keep changes open if we're starting to edit other fields.	7 years ago
Oliver Günther	4a8a16f82c	Don't gulp errors in PromiseLike	7 years ago
Oliver Günther	2987715c40	Update the form on special fields for global create	7 years ago
Oliver Günther	6b537b8132	Fix overridden setter/getter in multivalue select field	7 years ago
Oliver Günther	c811ef4ba5	Update fields when changeset resource is updated	7 years ago
Oliver Günther	e9cda39e3f	Keep erroneous fields open and instead only set their errors	7 years ago
Oliver Günther	8e07376912	Create separate changeset object to provide resource and schema	7 years ago
Oliver Günther	b1c8a7fc4e	Handle intermittently closed edit fields ... [ci skip]	7 years ago
ulferts	6e444f7359	fix redirecting when pressing enter on wp create (#5787) ... [ci skip]	7 years ago
Oliver Günther	ac61f3650e	Reject fields to be refreshed, but no longer in the schema	7 years ago
Oliver Günther	b54dde0735	Don't scope subscription in WP edit form to table	7 years ago
Oliver Günther	308eb555ea	Refresh open fields instead of redrawing all content	7 years ago
Oliver Günther	9b6e9a1371	Extract click position mapper for input fields for re-use	7 years ago
Oliver Günther	280c00d50f	Fix more tests	7 years ago
Oliver Günther	3cb9408faf	Fix tests	7 years ago
Oliver Günther	f49e9c93ef	Replace wpEditModeState and wpEditForm with one directive	7 years ago
Oliver Günther	c00d53de90	Implement single view context for previous edit fields	7 years ago
ulferts	c1f43435e0	Fix/link on inline create success message (#5717) ... * provide saved work package to fix created message link The created message link needs to use the newly created work package (the one returned on the POST request) in order to have the correct id set. * fix styling [ci skip]	7 years ago
Oliver Günther	6ebd1185ea	[25342] Display editing blocked notification in table (#5542) ... https://community.openproject.com/projects/openproject/work_packages/25342	8 years ago
Oliver Günther	ff8da4435c	[25172] Force activation of field when user requested it ... The wp edit form currently checks for an active field before accepting a request to activate it. However, it appears to exist an external effect (refresh possibly) that closes the field without resetting the form. We should allow activating the field regardless of it being active currently to avoid this error.	8 years ago
Oliver Günther	c800efc7b2	Remove template rendering in wp-display-fields ... This fixes a recurring compiling of a template in a new scope that is never cleared. The SimpleTemplateRenderer is still in use for the edit field functionality in the table, however there we have an explicit lifetime that can be controlled through the EditFieldHandler. Thus, it keeps a reference to the scope used to compile the field, and destroys it upon deactivation.	8 years ago
Oliver Günther	0b3ed9b113	[25026] Indicate fields of type WorkPackage to not be editable (#5357) ... [ci skip]	8 years ago
Roman Roelofsen	88f4b30ac9	Added ReactiveComponents (#5260) ... Replace reactive-fassade with reactivestates npm package.	8 years ago
Oliver Günther	49c6744f50	Place edit fields into separate container ... That allows us to refresh cells without caring about a potential hierarchy indicator within the cell.	8 years ago
Oliver Günther	2c92551a3a	[23658] Remember and set cursor position when opening input fields ... This adds a callback to the edit field rendering process to allow modifying the now-in-dom edit field. Using the Range/Selection API, we can now find out where the user clicked and forward that information to the field.	8 years ago
Oliver Günther	7e8dc321fa	Inline create work packages in new work package table	8 years ago
Oliver Günther	32472da1dd	Enforce strictNullChecks	8 years ago
Oliver Günther	e8595ac0a3	TypeScript: Enforce noImplictAny	8 years ago
Oliver Günther	ac15c6e6ea	Fixes after last dev rebase	8 years ago
Oliver Günther	18f6294914	Properly close fields when submitting without changes	8 years ago
Oliver Günther	9a3b0c1561	Review feedback	8 years ago
Oliver Günther	fb0025f9a6	Add debug logging and fix codeclimate issues	8 years ago
Oliver Günther	0ac5316fc2	Update more intelligently when a row is being edited ... Fixes the following bug: When grouping by type, and switching the type to another with a required CF, the column expansion of this CF redraws the table, which overrides the group since the type is switched.	8 years ago
Oliver Günther	850c0fc565	Fix global mousetrap exposer	8 years ago
Oliver Günther	8a5dbbb043	Remove workPackageId number|string dualism ... States always expect strings, so we should treat the ids as such.	8 years ago
Oliver Günther	5f6c265706	Introduce separate click/keypress handlers	8 years ago