2734 Commits (ade58e0511adfcd7e7ed6773dfa265cf0f20ef94)

Author	SHA1	Message	Date
Oliver Günther	d36c7d6591	Fix committers array access ... When adding a new committer to a repository, the user collection was `compact!`ed, which no longer exists on relations with Rails 4+. Thanks to @gehasia for spotting and proposing a fix for the bug.	9 years ago
Oliver Günther	02b5b8dda1	Add simple YAML extraction of ENV overrides ... Allows users to pass arrays or hashes via `[foo,bar]` and `{ foo: bar }` notation via inline YAML syntax.	9 years ago
Oliver Günther	d9c3500d90	Fix autoload issues	9 years ago
Jens Ulferts	bd8a74d02f	fix some slips	9 years ago
Jens Ulferts	cbc46418a2	fully qualify referenced classes	9 years ago
Jens Ulferts	2986233a5c	remove non existing module reference	9 years ago
Jens Ulferts	0d6f420afc	Revert "less magic on default query columns" ... This reverts commit 2293c3735b.	9 years ago
Jens Ulferts	2f764b84b9	Revert "less magic on default query columns" ... This reverts commit 2293c3735b.	9 years ago
Jens Ulferts	9399c23e3b	split up pdf_exporter into separate files	9 years ago
Jens Ulferts	bcc5165285	allow multi line headers in pdf	9 years ago
Oliver Günther	04398738f2	Allow Repository.disabled_types to be strings ... When passing configuration settings through ENV (e.g., packager), we can't pass arrays as configuration settings. This PR allows `Repository.disabled_types` to be set as a String in ENV, e.g., through `OPENPROJECT_SCM_SUBVERSION_DISABLED__TYPES='existing,foobar'`.	9 years ago
Jens Ulferts	2293c3735b	less magic on default query columns ... Use the columns defined to be default for a new query as a default for a new query upon initialization. A caller can chose to overwrite this. This prevents the columns from getting readded when no column is selected. It also allows to improve the performance of the work_packages#index call because an SQL query with less columns is considerably faster.	9 years ago
Jens Ulferts	30e96820a8	reintroduce the visible_condition ... Doing so, we can use it in the WorkPackage::SpentTime and by that have one dependency less	9 years ago
Jens Ulferts	81bb6c6e5c	remove instance variable caching ... Caching is no longer usefull here as the AR::Scope is cached but not the results of that scope. It was usefull when the queries for work packages where cached.	9 years ago
Jens Ulferts	6dfd97d678	avoid loading project on query initialization ... The knowledge, whether the query has a project associated is only required for the edit case but was determined right at query initialization. This is now changed to a lazy evaluation	9 years ago
Jens Ulferts	0267938c36	introduce spent_time model	9 years ago
Oliver Günther	dcc031dbcf	Pass project to custom field context in bulk mode ... List custom fields such as `user` uses the project to identify potential options for the custom field selection. In bulk mode, that context was not passed to the cf helper.	9 years ago
Markus Kahl	b83d76fe35	show proper error on failure instead of 500	9 years ago
Oliver Günther	937f0ad9d8	Fix handling of mail attributes in MailHandler	9 years ago
Oliver Günther	aaeb58ad53	Add separate regex-based delimiter for incoming mails ... This adds a simple additional field to let the input body of mails be delimited by a regex provided by the user, since all other delimiters are escaped before being used by regex. Since we don't want to force existing user of the feature to change their settings, simply removing the regex escape is not a viable option.	9 years ago
Henriette Dinger	2d8bdb1180	Sort the WP custom fields alphabetically when used as filter in timeline	9 years ago
Jens Ulferts	d6c32b212a	use wp for localization string ... The l10n files already refer to it as wp, so the code should also do that.	9 years ago
Jens Ulferts	ee16a5730d	improve performance of projects table ... The purpose of the subqueries is for them to be factored into a sum. Therefore rows that are null and filtered out rows count the same - 0. But performance wise it makes a lot of difference if the row needs to be kept in the query or if it is removed early on. This commit changes the query to no longer keep rows for which no attachment exists by turing the LEFT JOIN into a JOIN. By that, all containers without an attachment are ruled out very fast. If a LEFT JOIN is used, all rows for work packages and wiki/wiki_pages are returned even if they have no attachment.	9 years ago
Jens Ulferts	061a71bb32	fix setting custom values on version	9 years ago
Jens Ulferts	567c844c98	limit joined members ... Prevents to have all the user's members joined on a query for a project's available_assignees and available_responsibles. Not only the memberships the query is interested in (the one of the project) was joined but all the memberships the user had. So the more memberships the users have, the slower the query did become.	9 years ago
Oliver Günther	8dc9b592c4	Fix merge hickup	9 years ago
Jens Ulferts	2516e9c0e7	allow to disambiguously group by responsible association ... Before the commit, the result for a count on a query grouped by responsible would be of the schema { id: count, id2: count2 }. For other attributes, e.g. assignee it is { user: count, user2: count2}. The difference is caused by using :responsible_id for grouping which is necessary as the association causes an ambiguous reference in the issued db query. That problem has been fixed in rails/master (c2d33c4abf). But as long as the fix is not backported, we will have to overwrite a method of ActiveRecord::Calculations	9 years ago
Jens Ulferts	b8c7d77683	unpersisted WPs are considered leaves	9 years ago
Markus Kahl	7f88ba5b22	removed attachments#show; only #download remains	9 years ago
Markus Kahl	c7c6bc2e6a	prevent unnecessary s3 access to see if file is readable	9 years ago
Jens Ulferts	4600b48b38	avoid extra loop	9 years ago
Jens Ulferts	b33244ea67	only check for existence in db ... Avoids loading the whole object	9 years ago
Jens Ulferts	9ba1633fe3	optimize soonest_start calculation	9 years ago
Jens Ulferts	11d7e428ad	reuse version calculation on eager loaded projects ... Eager loading projects assigns the same object instance to each work package having the same project_id. When the first project evaluates the assignable versions, the result can be memoized to be used by other work package having the same project	9 years ago
Jens Ulferts	e544eb0653	eager load associations required for validation	9 years ago
Jens Ulferts	9f6138b05e	fix outdated comment	9 years ago
Stefan Botzenhart	5ccdbaa3ef	Permit parent_id only if user is allowed to create subprojects	9 years ago
Stefan Botzenhart	a42e89f987	Permit parent_id for project	9 years ago
Stefan Botzenhart	1f53f5472e	Code style enhancements to fight against bad scoring	9 years ago
Stefan Botzenhart	e13641bdd2	Improve according to rubocop	9 years ago
Jens Ulferts	c2a0a2b0f5	speed up and correct spent_time computation	9 years ago
Jens Ulferts	8065c66256	eager loading associated objects, the dirty way	9 years ago
Markus Kahl	3c17be3261	retain old behaviour per default to be safe	9 years ago
Markus Kahl	e482eee87e	don't require custom field container per default	9 years ago
Markus Kahl	aa58b7deca	allow arbitrary custom field IDs	9 years ago
Markus Kahl	d4293532d9	do not block time entry custom fields	9 years ago
Oliver Günther	a339373d0f	Allow responsible_id in projects settings ... This fixes two issues: 1. `responsible_id` was missing in allowed params for projects controller / settings. 2. When the value is not set from Rails, undefined is showing. There may be a workaround solely in the frontend, but for now I return (none) to the autocompletion as a responsible name instead of an empty string.	9 years ago
Oliver Günther	353039fcfe	Allow PermittedParams to receive new keys from plugins ... Previously, PermittedParams allowed only the extension of existing keys with new attributes from plugins. Since we now need to extend strong_params from global roles in impermanent memberships, we can prevent load-order dependencies by injecting a new key in the permitted params hash into the core.	9 years ago
Mohamed Wael Khobalatte	80192f6986	Do away with eval ... Eval is unnecessary here. Sure the code has slighly more duplication, but no where near enough to warrant an eval.	9 years ago
Mohamed Wael Khobalatte	e10cc2d6ad	Pass project_id instead of project instance to version_attributes	9 years ago