76 Commits (aedd23e1049945845dcd3c77eb51862e92943d1e)

Author	SHA1	Message	Date
Oliver Günther	c775dc8031	[29942] Better error messages for permission failures ... [ci skip] https://community.openproject.com/wp/29942	6 years ago
Oliver Günther	1a16c039a2	Add an avatar endpoint to avoid loading user API ... [ci skip]	6 years ago
Oliver Günther	1b5fc32366	Avoid before blocks and raw params access for IDs ... Grape's validation runs after a `before` block so we should avoid using raw params there and instead using `declared(params)` which returns only the validated whitelisted params, much like a permitted params hash.	6 years ago
ulferts	1850622f20	Feature/versions api update (#7299) ... Feature/versions api update [ci skip]	6 years ago
Oliver Günther	a290203bdd	Fix attachment error message ... [ci skip]	6 years ago
Oliver Günther	5b49b33b21	Prepare for core integration	6 years ago
Oliver Günther	352099089c	Prepare for core integration	6 years ago
Jens Ulferts	824aca3146	do not cause new error on error handling ... If container is nil, ruby should not fail because of it when logging the error	6 years ago
Oliver Günther	3d936d99dd	[28431] Don't render attachment with downloadLocation ... The downloadLocation may contain a temporary URL as it is with the case of AWS. https://community.openproject.com/wp/28431	6 years ago
Oliver Günther	223284c401	[28171] Output claimed attachments on wiki representer ... https://community.openproject.com/wp/28171	6 years ago
Jens Ulferts	0d22112e0e	replace rails based attachment forms and lists completely	6 years ago
Jens Ulferts	7f740a8178	extend to posts and plugins	6 years ago
Jens Ulferts	146e358b50	enable uploading attachments for budgets	6 years ago
Jens Ulferts	319f33e924	remove textile	6 years ago
Jens Ulferts	312dbba5a1	fix wrong method name for external attachments	6 years ago
Jens Ulferts	e58a96515c	allow setting attachments through wp post/patch	7 years ago
Jens Ulferts	b3b1f7d9a3	add documents resource (with attachments) to api	7 years ago
Jens Ulferts	5dae0ef4d5	add endpoint for unattached attachments	7 years ago
Jens Ulferts	6a8a1eb495	add download endpoint to attachment resource	7 years ago
Jens Ulferts	441735fb4f	extend attachments api to board posts	7 years ago
Jens Ulferts	9b2458c23c	extend attachments api to wiki_pages	7 years ago
Jens Ulferts	ce21ee20f7	cached representers	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Oliver Günther	e7de9169f1	Add internal error with message to Fog uploading failures ... [ci skip]	7 years ago
Oliver Günther	ac389b869d	Fix other request specs by adding json header	7 years ago
Oliver Günther	4d0bad7efc	Allow endpoints to override content types (attachments!)	7 years ago
Oliver Günther	9937307c7c	[25968] Use OpenStruct instead non-required hashie (#5794) ... https://community.openproject.com/wp/25968 [ci skip]	7 years ago
ulferts	7154caec85	Fix/consolidate representers (#5732) ... * consolidate representers Minimizes the need for extensive payload representers by: * introducing the payload_representer module which removes all non writable propertyies from a representer * introducing the resource/resources/associated_resource/associated_ressources helper methods which provide a framework for having a representer suitable for parsing and rendering Additionally increases the importance of the contracts by using them to calculate the writeable attributes. * remove unused endpoint [ci skip]	7 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465) ... * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Markus Kahl	7f88ba5b22	removed attachments#show; only #download remains	9 years ago
Jan Sandbrink	85f60d8bbc	Also allow to add attachments to a WP with permission to add WPs ... This is neccessary to allow adding attachments, after creating a new work package. The undesired part is, that it also allows you to add attachments long after creating the WP.	9 years ago
Jan Sandbrink	6e9ed008fb	Enforce passing of current_user into representers ... Thereby permission checks will no longer silently fail if no user was passed. This uncovered a lot of places where we actually expected a user to be passed, when it wasn't. This was especially true for collections. The basic idea is, that virtually all representers could change their behaviour based on the current user. Representers where this is not the case (e.g. Digest), can still explicitly opt-out.	9 years ago
Jan Sandbrink	f121e610db	Pass current_user into all AttachmentRepresenters	9 years ago
Jan Sandbrink	3f269e43ae	Add link to delete an attachment to its representer	9 years ago
Jan Sandbrink	5d473e9a9c	fix HTTP response of DELETE attachment ... this was wrongfully HTTP 202 (Accepted), which would only be valid if we did the deletion in a delayed/deferred way. For now using HTTP 204 (No Content), since we have no response body.	9 years ago
Jan Sandbrink	b332ef06aa	make collection representer explicitly unpaginated	9 years ago
Jan Sandbrink	fd3312a0f2	extract attachment storing into service ... - service cares about adding a journal too - only store the attachment when the journal can be saved (i.e. the WP is valid)	9 years ago
Jan Sandbrink	88e052a53e	style ... [ci skip]	9 years ago
Jan Sandbrink	dcd2a3b03c	rework error instantiation ... - multiple errors are no longer a special case of specific errors - there is a separate error class to represent multiple API errors - convert ActiveRecord errors to API errors in a single place, ideally work with API errors from there on	9 years ago
Alex Coles	a6212fb304	Fix syntax (w/Rubocop) in lib code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	8e015c9e95	add specs for metadata representer	10 years ago
Jan Sandbrink	08fa23d82e	please the hound	10 years ago
Jan Sandbrink	6075d3d7c9	extract method	10 years ago
Jan Sandbrink	c4e51404c2	move uploaded file creation out of api endpoint	10 years ago
Jan Sandbrink	7d443154b3	parse attachment metadata using a representer ... - adding general error handling for parse errors - changing the default error message for parse errors, which was very form specific before	10 years ago
Jan Sandbrink	603f30f794	some cleanup ... I just extracted some methods... the basic mess is the same, but hidden behind some methods... think of a pig with make up, it looks good, but it is still a pig.	10 years ago
Jan Sandbrink	ee05610d5d	add specs for the unhappy pathes ... those are quite a lot of specs for an integrative test however at the moment there is (too) much logic in the endpoint itself, so this seems to be neccessary	10 years ago
Jan Sandbrink	9a9d6aca2c	ensure correct file size errors are displayed	10 years ago
Jan Sandbrink	9cd03b0586	correct (but ugly) upload error handling	10 years ago