218 Commits (af7ac3333535a2796ba5c77114c29e794b7d97a6)

Author	SHA1	Message	Date
Jens Ulferts	5c06dda316	users allowed new statuses no longer receive an edit menu entry ... They are not allowed to call the work_package#edit action anyway	10 years ago
Jens Ulferts	1513a19b84	readd experimental controllers and add authorization to them	10 years ago
Alex Coles	0b941955ce	Fully qualify ::Type class constant ... This fixes a naming collision with AR internals: undefined method `find' for ActiveRecord::AttributeMethods::Serialization::Type:Class Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jens Ulferts	da721fd6d0	specs for json instead xml	10 years ago
Jens Ulferts	3c730ef131	enforces authorization for experimental api	10 years ago
Michael Frister	8d08e71ed5	API v2: Change boolean value to use true/false ... While this is not the OpenProject API, we use true/false for other APIs and for other parameters in the application, like `layout=false`. true/false also seems more intuitive.	10 years ago
Jens Ulferts	f91256fef9	remove no longer required experimental controller	10 years ago
Jens Ulferts	befb9f054e	removes unnecessary visibility filter on Version scope ... Authorization is handled an project level here and thus does not need to be done for the version itself. Authorising on the Version in addition has the drawback to only return versions in projects which the user can see work packages in. It does not take into account that the version can be shared.	10 years ago
Michael Frister	959c4ba405	API v2 PE index: Allow disabling parent rewiring ... Allow disabling rewiring - this exposes parent IDs of work packages invisible to the user. When requesting single work packages via IDs, the rewiring fails as it assumes that all visible work packages are loaded, which they might not be. For a work package with a parent visible to the user, but not included in the requested IDs, the parent_id would thus be nil. Disabling rewiring allows fetching work packages with their parent_ids even when the parents are not included in the list of requested work packages. There's also a case when rewiring is not used at all: When not providing a project id and requesting via /api/v2/planning_elements.json?ids=[...]. In this case parent_ids were and are always shown. This is pretty inconsistent, but that's the way API v2 is. Btw, planning_elements.json returns 404 when not giving an ids parameter. Apparently, the way custom fields are returned is also different between the general planning elements endpoint and the project-specific one. I didn't look into this, though.	10 years ago
Hagen Schink	32f0c4851e	Remove superfluous let statement	10 years ago
Hagen Schink	a4e07cfbce	Test version ids filter	10 years ago
Hagen Schink	eec14f6113	Remove show endpoint	10 years ago
Hagen Schink	e3506bcb14	Aggregate projects for shared versions	10 years ago
Hagen Schink	a250b0262e	Test projects references in shared versions	10 years ago
Hagen Schink	2b61ea9aff	Test handling of shared versions	10 years ago
Hagen Schink	812d889f81	Add specs for API v2 version show	10 years ago
Hagen Schink	ac7870f185	Add specs for API v2 version index	10 years ago
Hagen Schink	7a84d371f2	Use simple require for spec helper	10 years ago
Alex Coles	515c9dff5b	[wip] Add Versions List, Version API (v2) resource ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Hagen Schink	1a4f254015	Fix specs	10 years ago
Hagen Schink	46e4b5a061	Change to new RSpec syntax for some more statements	10 years ago
Hagen Schink	f6353003d9	Add specs	10 years ago
Ion Biziiac	6bd377176d	Add specs for Possible to see list of types without being logged in	10 years ago
Jens Ulferts	85bb7e58c6	only applies default filter if no query attribte is provided	10 years ago
Till Breuer	2c4483544c	Merge branch 'dev' into feature/adding-and-removing-watchers ... Conflicts: app/assets/javascripts/angular/work_packages/controllers/work-package-details-controller.js karma/tests/controllers/work-package-details-controller-test.js lib/api/v3/work_packages/work_package_representer.rb	10 years ago
Jens Ulferts	433f707843	only open wp on initial load of wp#index	10 years ago
Hagen Schink	63ace93877	Add specs	10 years ago
Alex Coles	789e13a479	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 2.3.1 with the following command: transpec -f * 46 conversions from: it { should ... } to: it { is_expected.to ... } * 9 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 1 conversion from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 1 conversion from: describe 'some request' { } to: describe 'some request', :type => :request { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Alex Coles	e137ed8135	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 2.3.1 with the following command: transpec * 72 conversions from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 57 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 49 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 34 conversions from: obj.should to: expect(obj).to * 27 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 8 conversions from: describe 'some feature' { } to: describe 'some feature', :type => :feature { } * 7 conversions from: describe 'some helper' { } to: describe 'some helper', :type => :helper { } * 5 conversions from: be_true to: be_truthy * 5 conversions from: describe 'some request' { } to: describe 'some request', :type => :request { } * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 1 conversion from: before { example } to: before { |example| example } * 1 conversion from: describe 'some mailer' { } to: describe 'some mailer', :type => :mailer { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	11 years ago
Richard	2072662b61	Fixed exp api work packages controller specs.	11 years ago
Hagen Schink	e2a89d77dd	Test that anonymous users can read public CFs	11 years ago
Hagen Schink	f035d3f213	Test custom fields of public projects are visible	11 years ago
Hagen Schink	d6d6374257	Fix let layout	11 years ago
Hagen Schink	06f92ccfd6	Test duplicate handling	11 years ago
Hagen Schink	b2da7d3878	Test WP custom fields visible for all are handled	11 years ago
Hagen Schink	97ac24f647	Test admins can see all custom fields	11 years ago
Hagen Schink	579d009239	Test custom fields are filtered by membership	11 years ago
Hagen Schink	7aed23e438	Test anonymous access is denied	11 years ago
Jens Ulferts	e13fa469b8	release/3.0: fixes fickle spec	11 years ago
Jens Ulferts	e6bfe613b2	fixes fickle spec	11 years ago
Jens Ulferts	6579338f9c	fixes permissions on work package context menu	11 years ago
Ion Biziiac	d637354013	Add specs for Fix: APIv2 does not rewire parents correctly	11 years ago
Alex Coles	36c8fa0f2b	Move experimental "v3" API to /api/experimental ... Endpoints implemented with Rails Controllers will eventually be removed, in favour of the Grape implementation added in ac2c89c0. Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	efe24e1049	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 1.12.0 with the following command: transpec * 100 conversions from: it { should ... } to: it { is_expected.to ... } * 17 conversions from: expect(collection).to have(n).items to: expect(collection.size).to eq(n) * 10 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 9 conversions from: be_true to: be_truthy * 9 conversions from: expect(obj).to have(n).errors_on(...) to: expect(obj.errors_on(...).size).to eq(n) * 8 conversions from: obj.should to: expect(obj).to * 4 conversions from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 2 conversions from: be_false to: be_falsey * 2 conversions from: expect(obj).to have(n).error_on(...) to: expect(obj.error_on(...).size).to eq(n) * 2 conversions from: pending 'is an example' { } to: skip 'is an example' { } * 1 conversion from: before { example } to: before { |example| example } * 1 conversion from: expect(collection).to have_at_least(n).items to: expect(collection.size).to be >= n * 1 conversion from: obj.unstub(:message) to: allow(obj).to receive(:message).and_call_original * 1 conversion from: pending to: skip	11 years ago
Jens Ulferts	90e1a9863e	reduces memory and increases performance of api planning_element#index ... OpenStruct requires significant more memory and is slower than simple structs	11 years ago
Alex Coles	81682a7417	Fix whitespace in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	f7ffe743bb	Add skeleton spec for "API v3" QueriesController ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	f504de3853	Add basic specs for auxiliary "API v3" Controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	43c1415039	Remove tangential code from WorkPackagesController ... This code now belongs elsewhere, e.g. ProjectsController. Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	d30ce48539	Begin replacement of server-rendered context menu ... Removes WorksPackages::ContextMenusController, its views and specs, and ContextMenuHelpers. This patch begins the work needed to serialise a given WorkPackage's 'actions' in the v3 API response, based on a user's permissions. This should support a client-rendered context menu (or any other contextual UI for that matter). Much code was simply copy-and-pasted from ContextMenusController into Api::V3::WorkPackagesController. This code still requires considerable refactoring and optimisation. Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago