18558 Commits (b1351acb00402b90be7f242924fb7956e9f10887)

Author	SHA1	Message	Date
Oliver Günther	b265818e3b	When attachment is not saved, use filename property	3 years ago
Oliver Günther	f60b86da2d	Add parser error if invalid metadata json	3 years ago
Oliver Günther	b94b0e630d	Fix filesize validation on prepared uploads	3 years ago
Oliver Günther	7f1b777d45	Add presence check to filename	3 years ago
Oliver Günther	287111c574	Add prepare service and contract	3 years ago
Oliver Günther	c59c57ad76	Make attachments API BaseServices compatible	3 years ago
Oliver Günther	84cafdbe07	Add setting for whitelist	3 years ago
Wieland Lindenthal	ecfa0349e7	Fix #33448: Format WP column "BCF snapshot" as string (#9652) ... Render an "X" if there is at least one viewpoint for the associated BCF issue. https://community.openproject.org/wp/33448	3 years ago
Oliver Günther	b7b15495e3	[32867] Generalize me associated action for custom fields ... https://community.openproject.org/work_packages/32867	3 years ago
Oliver Günther	fe3cf855d3	Fix duplicating the row default-value ... The default value still had references to the previous value, causing it to be shifted in positions	3 years ago
Oliver Günther	9a68bc6c06	Fix custom fields reordering	3 years ago
Oliver Günther	5854a34124	[37866] Add attachment_created event and webhook (#9418) ... * [37866] Add attachment_created event and webhook * Remove other usages of direct attachment creation * Add attachment webhook spec * Fix other webhook specs * Fix attachment adding in mail_handler * Don't set content_type outside attachment#file= * Fix unrelated spec Co-authored-by: ulferts <jens.ulferts@googlemail.com> (cherry picked from commit d2ce834e23)	3 years ago
Oliver Günther	ac16c37214	Deprecation warning for < postgres13 in admin/info ... https://community.openproject.org/work_packages/38047	3 years ago
Markus Kahl	d624f795cb	fixed and updated ee configuration	3 years ago
Oliver Günther	ca599f15c6	[38325] Using existing gem for email validations ... Our email validation is too strict for RFC compliant emails. Instead of trying to do it ourselves (email validation regexps are hard!), let's just use a gem to do that for us. Note: The gem also has a strict mode that could be optionally enabled. This however results in some emails on community to become invalid. I left it on the default mode for now. https://community.openproject.org/work_packages/38325	3 years ago
Markus Kahl	b8c04551b8	fixed cache key so it works in spec too ... during tests `Setting.column_names` returned strings rather than symbols which is why setting caching didn't work as expected	3 years ago
Markus Kahl	4ff17038f2	fix mailer config reload ... It wasn't reloaded because the SMTP settings were still cached in the request store which only was reset afterwards	3 years ago
Markus Kahl	dc89c9a46d	Revert "try to fix NPE when adding user to group at times" ... This reverts commit 3f4b303c79.	3 years ago
Markus Kahl	3f4b303c79	try to fix NPE when adding user to group at times	3 years ago
Oliver Günther	3bfbdfbce9	Fix when errors is not actually present	3 years ago
Oliver Günther	ca0629f5cf	Fix service specs	3 years ago
Markus Kahl	1538666c23	prevent possible infinite loops by making sure not to re-use errors objects ... app/services/work_packages/update_ancestors_service.rb:51 may introduce an infinite loop otherwise if one tries to delete a work package which has validation errors	3 years ago
Oliver Günther	843779c483	[38017] Don't remove group users if no replacement provided ... https://community.openproject.org/wp/38017	3 years ago
Oliver Günther	980447ab51	Prevent backtracking regexp in MessagesController (#9447)	3 years ago
Oliver Günther	99a8b3f140	Fix how we gather and derive sampling traces for sentry (#9395) ... We previously defined a fixed tracing rate AND a sampling tracer in the backend, which result in everything to be traced regardless of the actual rate. We now define a base rate for certain requests, so that we can exclude health checks and other things. The configuration is now a factor (0 = off, default) (1 = use suggested rates), any other value x (x multiplied by suggested rates)	3 years ago
Oliver Günther	a28e1b916e	Fix link to disable-password-login to docs	3 years ago
ulferts	a8c075e258	[#37583] Error "Identifier is invalid" (#9373) ... * [#37583] Error "Identifier is invalid" Happens when creating a project that starts with a digit or a hypen. The functionality is added by extending acts_as_url to support a custom_rule lambda. https://community.openproject.org/work_packages/37583 * handle empty base_url in acts_as_url custom_rule	3 years ago
Markus Kahl	038b6f5da2	extracted pg_dump command into method so it can be patched if necessary	4 years ago
Oliver Günther	fc090ac024	[37136] Disable delete button and check for deletion (#9338) ... https://community.openproject.org/wp/37136	4 years ago
ulferts	20a9f91a22	ensure project status is saved (#9325) ... aweseome_nested_set, used for maintaining the project hierarchy, reloads the project after saving. Any change to an associated model, e.g. the status, is lost upon reloading. Thus, saving of the status needs to take place before saving the project. This is safe to do since it is carried out in a transaction and all the validations are run for the status as well. https://community.openproject.org/work_packages/37464	4 years ago
Wieland Lindenthal	44d57d36c6	Fix #37136: Restrict deletion of placeholder users (#9294)	4 years ago
Markus Kahl	2bf74725b2	fixed password confirmation during token reset (#9314)	4 years ago
ulferts	6cda6ad4fd	enforces dependent project modules being active (#9311) ... Project modules, e.g. calendar can define dependencies, e.g. work packages. An error message is now displayed if a user enables a project module without the dependency being active in the project as well. Also fixes a serious bug in the Shared::ServiceContext module. Whenever a failing service result is returned, every change to the database is to be rolled back. This was not true when a model was provided since the changes where carried out within an inner transaction	4 years ago
Oliver Günther	c9a80b8653	[#37299] Remove validation for project identifier presence (#9296) ... [OP#37299](https://community.openproject.org/wp/37299)	4 years ago
Oliver Günther	9630b74524	Use format_time to format backup time (#9309) ... https://community.openproject.org/wp/37298	4 years ago
ulferts	0c2d87b4eb	choose wp type by position only (#9297) ... There was a misconception in the code related to the `is_default` field. The `is_default` field only governs whether a type is enabled by default in a new project or not.	4 years ago
ulferts	08ce0a5436	Fix/attachment journalizing (#9292) ... * update the container timestamp upon attachment creation That way, the journal subsequently created on the journalized container will bear the expected timestamp * update container timestamp on attachment deletion Without it, the journal created after the deletion will bear the wrong timestamp * avoid bumping lock_version on attachment adding/destroy	4 years ago
Oliver Günther	2cf8cd0d84	[37290] Use login service for logging in user (#9290) ... This correctly sets the last login date among other things https://community.openproject.org/wp/37290	4 years ago
Oliver Günther	cac2bf8716	[37262] Fix modal header icons (#9285) ... * [37262] Fix modal header icons https://community.openproject.org/work_packages/37262 * Add autoheight to onboarding modal * Render avatar of the user * Fix different padding for header and align all center This allows to render different things, not just icons (avatar) while centering all correctly	4 years ago
ulferts	0eae14072e	translate "overview" copy option	4 years ago
Oliver Günther	32cbff3a78	[37197] Use setting names in error messages (#9286) ... This avoids wrongly translated content https://community.openproject.org/work_packages/37197	4 years ago
Oliver Günther	ec56455edd	[37124] Handle the case when estimated hours was set to 0.0 (#9280) ... https://community.openproject.org/wp/37124	4 years ago
ulferts	9edc7244a9	fix displaying `multi` toggle in cf form (#9269)	4 years ago
Oliver Günther	1ac2de19ff	[35328] Allow more default overrides (#9262)	4 years ago
Oliver Günther	6c75e16dc4	[37140] Use acts_as_url to generate unique slug for identifier (#9250) ... * Use acts_as_url to generate unique slug for identifier * Re-enable project identifier spec now handled in backend * Add integration spec for set attribute service * Adapt spec for new empty identifier * Avoid double error messages for empty identifier acts_as_url may return an empty string depending on the name, but the empty presence validation will suffice in this case, we don't need the invalid validation * Fix stubbed errors object accessed by acts_as_url * Avoid trying to get the upstream unique attribute in case of errors * Remove sequential_project_identifiers setting * Adapt spec to review feedback	4 years ago
Oliver Günther	2f09095524	[36720] Disable login button after submit (#9254)	4 years ago
Oliver Günther	af4922ebf6	[37124] Add formatter classes for estimated hours and generalize (#9252) ... Only xls exporter had formatter classes which are generic enough to replace all other exporter formating methods. https://community.openproject.org/wp/37124	4 years ago
ulferts	d90d47e6b6	Feature/user invite from members for non admins (#9244) ... * users having manage_user can add users from member administration * linting and typo correction	4 years ago
Oliver Günther	fa3481523b	Avoid running oauth cleanup job after every authentication (#9241) ... * Avoid running oauth cleanup job after every authentication * Also run attachments job as 'cron' job	4 years ago
ulferts	1f18dfca1a	legacy_spec to spec	4 years ago