openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	5129f05678	Fix NameError for Pagination	9 years ago
Alex Coles	f320305531	Revert "Temp. comment includes in API v2 ProjectController" `FriendlyId::Finders` should ensure an identifier-aware `find` on an `ActiveRecord::Relation` chain. This reverts commit `51512f1522`.	9 years ago
Alex Coles	347f363026	Remove unloadable from controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
peter	6a7ab0edb8	fix invalid response for /api/v2/authentication.json	9 years ago
Alex Coles	0ad3cfb4b2	Prefer do…end for controller respond_to blocks `rubocop -a` does not currently normalise formatting consistently (see `ec1bb39f`). Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	75cecdb21a	Omit extraneous [] in APIv2 CustomFieldsController Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	0942d7335b	Add explicit join references in controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	2d9cfd97f4	Remove deprecated Relation#all in controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	51512f1522	Temp. comment includes in API v2 ProjectController `includes().find` appears to have issues with polymorphic associations in Rails 4.0.x. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	e02eb0181d	Migrate AR finder/query methods in controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	ec1bb39f9b	Fix syntax (w/Rubocop) in (Rails) controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in `74228b59`. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	a464c01203	Force bool coercion in API v2 WorkflowsController Boolean values are not properly coerced when using `.select` with custom SQL String on PostgreSQL. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 [ci skip]	10 years ago
Alex Coles	3629ded2ae	Handle ActionController::ParameterMissing globally See `6d11fac2`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	6d11fac2f8	Handle ActionController::ParameterMissing in APIv2 This is a behaviour difference with the strong_parameters plugin for Rails 3.2, which does this by default. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	8a28b1a730	Prefer #map over #collect in (Rails) controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	bb0e6e6aa5	Fix syntax (w/Rubocop) in (Rails) controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	336446c59d	Use 1.9+ Hash syntax in (Rails) controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	0604de3d8b	Fully qualify ::Type class constant See `0b941955`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jens Ulferts	d7486ab811	allows api v2 types controller accessible for :view_work_packages permission	10 years ago
Jens Ulferts	61c05affd4	checks for permission before api/v2/types#index	10 years ago
Jens Ulferts	077e0b2f78	types controller is admin only now	10 years ago
Alex Coles	0b941955ce	Fully qualify ::Type class constant This fixes a naming collision with AR internals: undefined method `find' for ActiveRecord::AttributeMethods::Serialization::Type:Class Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	7ff6f4fe94	Fully qualify parent class in API v2 Controllers This fixes the following issue: Circular dependency detected while autoloading constant Api::V2::ProjectsController Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Michael Frister	f88443714e	API v2: Document some useless code	10 years ago
Michael Frister	8d08e71ed5	API v2: Change boolean value to use true/false While this is not the OpenProject API, we use true/false for other APIs and for other parameters in the application, like `layout=false`. true/false also seems more intuitive.	10 years ago
Jens Ulferts	befb9f054e	removes unnecessary visibility filter on Version scope Authorization is handled an project level here and thus does not need to be done for the version itself. Authorising on the Version in addition has the drawback to only return versions in projects which the user can see work packages in. It does not take into account that the version can be shared.	10 years ago
Jens Ulferts	2f8920f3c7	minor code improvements	10 years ago
Michael Frister	959c4ba405	API v2 PE index: Allow disabling parent rewiring Allow disabling rewiring - this exposes parent IDs of work packages invisible to the user. When requesting single work packages via IDs, the rewiring fails as it assumes that all visible work packages are loaded, which they might not be. For a work package with a parent visible to the user, but not included in the requested IDs, the parent_id would thus be nil. Disabling rewiring allows fetching work packages with their parent_ids even when the parents are not included in the list of requested work packages. There's also a case when rewiring is not used at all: When not providing a project id and requesting via /api/v2/planning_elements.json?ids=[...]. In this case parent_ids were and are always shown. This is pretty inconsistent, but that's the way API v2 is. Btw, planning_elements.json returns 404 when not giving an ids parameter. Apparently, the way custom fields are returned is also different between the general planning elements endpoint and the project-specific one. I didn't look into this, though.	10 years ago
Hagen Schink	218e7dbd96	Implement version ids filter	10 years ago
Hagen Schink	eec14f6113	Remove show endpoint	10 years ago
Hagen Schink	e3506bcb14	Aggregate projects for shared versions	10 years ago
Hagen Schink	dfceb77656	Query projects shared versions	10 years ago
Hagen Schink	33cb83aa55	Implement version index with multiple projects	10 years ago
Hagen Schink	d08c0cb34d	Extract methods used for multiple project selection	10 years ago
Alex Coles	515c9dff5b	[wip] Add Versions List, Version API (v2) resource Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jens Ulferts	32506ccab5	removes no longer required before filter The only action requiring the call to assign_planning_elements is the index action. This action receives it's work packages by calling the assign_planning_elements method from other methods.	10 years ago
Jens Ulferts	e4d58b33ab	removes no longer required before filter The only action requiring the call to assign_planning_elements is the index action. This action receives it's work packages by calling the assign_planning_elements method from other methods.	10 years ago
Hagen Schink	08c55efd49	Consider ids parameter	10 years ago
Hagen Schink	0710c1df39	Don't use a before filter for parsing ids parameter	10 years ago
Hagen Schink	f44cca280e	Consider ids parameter	10 years ago
Hagen Schink	181347566c	Let anonymous user access public custom fields	11 years ago
Hagen Schink	c87cf9b7bf	Remove duplicate WP custom fields	11 years ago
Hagen Schink	5065215415	Filter WP custom fields by membership	11 years ago
Hagen Schink	6ce1f68d7e	Deny anonymous access	11 years ago
Ion Biziiac	4a13ce44c3	Fix APIv2 does not rewire parents correctly	11 years ago
Jens Ulferts	90e1a9863e	reduces memory and increases performance of api planning_element#index OpenStruct requires significant more memory and is slower than simple structs	11 years ago
Alex Coles	1900e9b55d	Fix whitespace in (Rails) controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Michael Frister	3f9595fde9	Fix api/v2/projects/level_list	11 years ago

1 2 3 4

196 Commits (b15002becaf3537ba6ff4a2bef1256ed544dc3ce)