openproject

Commit Graph

Author	SHA1	Message	Date
Alex Coles	d906650a16	Remove AssociationsMapper remnants in WorkPackage Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	17940bf02c	change validation of WP children - do not add error on a symbol called :#123 (123 is the childrens ID) - this is against the semantics of ActiveRecord::Errors - creating symbols in a loop used to be a bad idea (might be better today) - it breaks error messages in the APIv3 (which is due to APIv3 working beyond the borders of AR errors, not the best of ideas...) - use :base instead, the place for unlocatable errors - include the fact that #123 refers to a child element in the error message Basically I feel that this makes the children validation cleaner and better. But somehow I fear, that there is some code out there that depends on the fact that error keys like :#123 existed...	9 years ago
Jan Sandbrink	218c75e765	fix update_by! user when not providing notes - previously the created Journal Entry would have been made by the specified user or the User.current, dependent whether :notes were provided or not - now the journal entry is always made by the specified user	9 years ago
Alex Coles	29d9814347	Prefer Project.allowed_to to .allowed_to_condition Use `ActiveRecord::Relation#merge` to merge scopes. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	b3a54ec3e8	Add Project.allowed_to returning AR::Relation Same purpose as (and calls to) `Project.allowed_to_conditions`, but builds an `ActiveRecord::Relation` instead of a SQL String. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	df9e56c8e0	Remove duplication in News.latest(_for) methods Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	e712a45cf2	Remove duplication in Project.latest(_for) methods Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	e2d9a7746f	Remove unloadable from models Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	0d2c139672	Remove unloadable from helper Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	347f363026	Remove unloadable from controllers Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
peter	6a7ab0edb8	fix invalid response for /api/v2/authentication.json	9 years ago
Alexander Bach	18ebdc9a9e	Some settings cleanup	9 years ago
Alexander Bach	984f3dcc4a	Add setting for journal aggregation time	9 years ago
Alex Coles	bbd6943928	Fix block delimiter in MailHandler Missed by rubocop auto-correct. [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	8fd535769a	Fix bad rubocop auto-correct in journal_manager.rb Reported as issue upstream: https://github.com/bbatsov/rubocop/issues/2021 [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	8b4be7f749	Indent fix in RepositoriesController for Rubocop [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	a3af19a8ff	Indent fix in SysController for Rubocop [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	093a6a8a98	Minor indent fix in News model for Rubocop [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	12d891ceb8	Fix missing space around blocks in MailHandler Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	acd23b8046	Fix missing space around block in MyController Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	0ad3cfb4b2	Prefer do…end for controller respond_to blocks `rubocop -a` does not currently normalise formatting consistently (see `ec1bb39f`). Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	75cecdb21a	Omit extraneous [] in APIv2 CustomFieldsController Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Florian Kraft	c4a27100c3	rename subject attribute to something more meaningful Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	f8d69c5212	address hound complaints Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Mihail Maxacov	6e965d9e3d	buttons and functional view	9 years ago
Mihail Maxacov	76521e956e	barely breathing wp form	9 years ago
Jan Sandbrink	2c19f97345	centralize knowledge of WP autocomplete url - project information is not needed anymore - the endpoint format was fixed anyway (also accepted parameters)	9 years ago
Jan Sandbrink	f86e0ef591	uglify order statement at least this one DOES work...	9 years ago
Jan Sandbrink	253785622c	specify order in the Rails 3 way ascending is the default anyway	9 years ago
Jan Sandbrink	9cb9957bbb	also accept auto complete requests without query	9 years ago
Jan Sandbrink	d2eeb27c84	eliminate instance variable	9 years ago
Jan Sandbrink	c9f0fba192	increase readability of wp->hash conversion it might use more lines, but I hope there is a gain in readability	9 years ago
Jan Sandbrink	8897235fa4	rewrite find into where, order and limit	9 years ago
Jan Sandbrink	194f1814e1	always return a valid scope though WorkPackage works like a scope most of the time, it is not a scope e.g. you can't directly call :order on WorkPackage Note: I would have loved to already do it the Rails 4 way and call :all However in Rails 3 :all returns an Array and not a Relation, so we will have to wait for the Rails 4(.1) Upgrade to replace :scoped with :all :( Sorry @myabc	9 years ago
Jan Sandbrink	e51a4005ff	try to increase readability - extract scopedeterminition into an extra method - always use "outer" if statements in index method	9 years ago
Jan Sandbrink	280e333f18	explain why some code exists	9 years ago
Jan Sandbrink	2854584cb2	use more clear scopes for autocompletion lets see if that really makes stuff more understandable... I (personally) found the old definition of "all" to be too narrow. Now there is: scope == "all": I want to search over all WPs scope == "relatable": I want to search over all WPs that are relatable to WPs in the given project (via project_id) no scope: If I specified a project search over the WPs of that one, otherwise search everywhere (like "all")	9 years ago
Jan Sandbrink	45815cb9f3	rename query to scope sounds more understandable to me, but I am biased, I guess...	9 years ago
Jens Ulferts	34928de9c9	no reload on timelog delete Please refer to https://docs.angularjs.org/api/ng/directive/ngHref for the different combinations of href, ng-href and ng-click within an a tag.	9 years ago
Alex Coles	851f23712f	Prune commented code in TimelinesController [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	c967e61097	Revert "Work-around Project nested set errors on PG" This issue should be fixed in our Rails 4(.1)-compatible fork of awesome_nested_set. See: `7bd473e845` This reverts commit `0c56b72d2a`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	5a25c32b2f	Revert "Work-around WorkPackage nested set errors on PG" This issue should be fixed in our Rails 4(.1)-compatible fork of awesome_nested_set. See: `7bd473e845` This reverts commit `2ea2c776e3`.	9 years ago
Alexander Bach	c42dad3270	Correct comment	9 years ago
Alexander Bach	2f9c9178df	Fix regex properly	9 years ago
Alexander Bach	248f11fba8	Correct style	9 years ago
Alex Coles	7cb1e43d53	Restore CustomField.for_all include option Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	c02804b0eb	Teach acts_as_searchable a references option * Update usages in models. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Vadim Costin	591428e1a7	change the holder of notiffication messages	9 years ago
Vadim Costin	32d6a02642	add bottom margin for stackable alert messages	9 years ago
Alex Coles	8afb27578f	Add missing explicit join reference in Version Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago

... 2 3 4 5 6 ...

11155 Commits (b320ea9c91e0e5dcd35feaca73510481027fe3d0)