openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	2b39d8fbdf	Cleaning up, Rubocop	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - Configuration: Currently replaces the existing options in `configuration.yml`. - Implementation specifics: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Oliver Günther	7ebac37c14	Repository Management - Refactoring and Preparation Related work package: [#20415](https://community.openproject.org/work_packages/20415). This is a combined refactoring and extraction effort of local SCM functionality for SVM, Git adapters in preparation for the explicit lifetime management of repositories in #20416 and implementation of (local) repository storage quota in #18393. This PR is still heavily WIP and for the time being, depends on the legacy specs for testing. To run the tests, execute the following steps: ~~~ rake test:scm:setup:all rake spec:legacy ~~~ I'm open for ideas on how we integrate scm adapters tests into current specs. --- - [x] Exchange `IO::Open` for `Open3` to avoid countless manual exitcode checks - [x] Extract local functionality in its own Module - [] Extend `LocalClient` module with links to create/delete services for #20415 - [x] Break down unbearable local parse routines (Hound will be over the place until fixed - but down from 260 to < 20) - [x] `entries` - [x] `revisions` - [] local repository factory - [] Specs - [] Fix / Modernize - [] More adapter-related specs	9 years ago

Author

SHA1

Message

Date

Oliver Günther

2b39d8fbdf

Cleaning up, Rubocop

9 years ago

Oliver Günther

05b27c1b98

Asynchronous creation, deletion of repositories from OP.

This PR begins the push towards management of repository lifetime
from within OpenProject.

What this currently provides is the following:

  - A mixin `ManageableRepository`, included by `Repository::{Git,
      Subversion}` to provide an interface to repo management
  - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and
  deleting (`DeleteRepositoryService`)
  - Customized rendering of subforms in the repository settings for
  arbitrary SCM vendors.

TODOS:
  - [x] Provide sane ground to work on ( cf. PR #3149 )
  - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated
        from within a Helper.)
  - [x] Ease integration of arbitrary SCM vendors
  - [x] Display meaningful error / warning when user looks at bare
  repository (currently outputs 500, as Git HEAD / svn revision is not
          available)
  - [x] I18n
  - [ ] Specs (in progress)
    - [x] Fix legacy specs
  - [ ] Decide what to do with `Filesystem` adapter.

Open Questions:

  - **Configuration**: Currently replaces the existing options in
  `configuration.yml`.
  - **Implementation specifics**:
    - Sub-projects repositories reside in a hierarchy below their parents
    - How should the delayed_job react upon failure? (esp. creation of
            repositories)

Relevant work package: https://community.openproject.org/work_packages/20416
Merge dependent on PR #3149

9 years ago

Oliver Günther

7ebac37c14

Repository Management - Refactoring and Preparation

Related work package: [#20415](https://community.openproject.org/work_packages/20415).

This is a combined refactoring and extraction effort of local SCM functionality for SVM, Git adapters in preparation for the explicit lifetime management of repositories in #20416 and implementation of (local) repository storage quota in #18393.

This PR is still heavily WIP and for the time being, depends on the **legacy specs** for testing.
To run the tests, execute the following steps:

~~~
rake test:scm:setup:all
rake spec:legacy
~~~

I'm open for ideas on how we integrate scm adapters tests into current specs.

---

- [x] Exchange `IO::Open` for `Open3` to avoid countless manual exitcode checks
- [x] Extract local functionality in its own Module
  - [] Extend `LocalClient` module with links to create/delete services for #20415
- [x] Break down unbearable local parse routines (Hound will be over the place until fixed - but down from 260 to < 20)
  - [x] `entries`
  - [x] `revisions`
- [] local repository factory
- [] Specs
  - [] Fix / Modernize
  - [] More adapter-related specs

9 years ago

3 Commits (b4229072063f2df8e1f4ab2cfa3ab9ea464bcb7b)