144 Commits (b52a2d744b692b960f0c625b6b63fcba1417d534)

Author	SHA1	Message	Date
ulferts	d90d47e6b6	Feature/user invite from members for non admins (#9244) ... * users having manage_user can add users from member administration * linting and typo correction	4 years ago
Oliver Günther	6dc662b1e4	[36243][30226] Different avatars for placeholders and groups (#9169) ... * Fix members autocompleter to allow hrefs * Add rendering of different avatar types * Remove unused code in backend avatar rendering * Add very basic test that the avatar gets customized per type * Allow avatar rendering in the CreateAutocompleter * Restructure avatars into BEM css * Remove avatar-classes in favor of passing size from backend * Remove to avoid confusion We use tracking with both href and , and was introduced to avoid a property called href to be overridden, but that was never a problem before. So from now we can safely use .href * Fix broken principal avatar in user activity * Ensure filters get updated even if the form is not reloaded There was a bug in conditionallyLoadForm that checked the property of link (always undefined) and would thus always reload a form. What we actually need is a form that gets reloaded only when the query link changes, but still update services from the updated query, such as filters * Adapt specs to changes classes * Rename op-principal-avatar to op-avatar	4 years ago
ulferts	9fa5599392	Feature/member notifications (#8958) ... * spec with correctly scoped links * move db check into own file - fix deprecation * basic spec for member creation service * use constants for all notifications * send an OP notification after member has been created * send an OP notification after member has been updated * mails on group member added Depending on whether the membership existed before or not, an updated or a created notification is send. This is done asynchronously. * move all mail sender background jobs into namespace * wip * wip * correct handling group member notifications * add setting enable/disable mail sending on member alterations * use services in members controller * move Notifiable to OpenProject * remove member after save hooks * cleanup/testing/linting * render member mails in receiver locale * remove add_member! method * use mailer layout for all mailers * Update app/services/groups/cleanup_inherited_roles_service.rb Co-authored-by: Oliver Günther <mail@oliverguenther.de> * use around callback to avoid prepending * handle nil params Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
Oliver Günther	cdf3cf4c34	[36136] Rework members page to show name and avatars for principals (#8973) ... * Rewrite members page to output name column * Remove white-space nowrap for long login names in administration * Extend member specs * Allow query instance to be used in table cell * Fix memberships specs with changed columns * Add order for email * Review feedback * Allow x to close add member form * WIP sort firstname/lastname * Make status sortable * Extract order_by_name into the order class * Re-add but deprecate order_by_name It's still in use in combination with some special scopes (custom actions for example) that I don't want to remove right now * Rewrite order_by_name into scope	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961) ... * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	5b95eb4412	remove outdated member autocompltion code (#8811)	4 years ago
ulferts	99ea02197f	ensure users are added as new members before groups ... That way, conflicts between a group containing an also added user and that user are prevented. As a user cannot be member of a project twice, an error is produced if the group will add the user as a member and then the user is added in its own right. On the other hand, a user may first be added as member and then a group containing the user may also be added. By simply sorting by group vs. user we can ensure that users are always added first.	4 years ago
ulferts	5968c0b18a	Fix/replace custom i18n function (#8681) ... * replace custom i18n function calls * remove custom i18n method	4 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Markus Kahl	e52d4f3f9c	remove dead code (add tab script in members controller)	5 years ago
ulferts	a93ecca5a8	Feature/members api show (#7308) ... * basic members collection response * complete member index end point * document versions#index * remove user association from members There is already a more generic principals association. Having both causes confusion and leads to duplicate loading of models * linting * remove disabled test * add members#show api end point * add project and principal to member representer * replace member.user reference with principal * use principal reference in project members association * modernize roles api * complete member representer rendering * replace remnants of user association * add member schema api endpoint * have dedicated available projects end point for versions * linting * limit roles to assignable ones in schema * rename member to membership in api * remove remnants of user in member * spec fixes * use available_projects endpoint in versions board * add eager loading to memberships#index * members create form api endpoint * ensure role exists for default assignment * extract switch for users/groups to work_packages representer * document membership create form * add l10n expected in specs * strengthen the usage of a delete base service * use base class for set attributes service * fix alias in service * add create endpoint to members api * document members create endpoint * linting * adapt to altered service signature * use default endpoint for wp#get * use CF infused representer [ci skip]	6 years ago
Markus Kahl	22e1e7a593	fixed members enterprise restriction condition	7 years ago
Markus Kahl	60b8def1c9	user limits for enterprise edition	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
ulferts	daa1a4d4b7	fixes filtering members by group (#5800) ... additionally fixes: * with "all" selected, all members are shown, not only those being active, invited or registered * with "locked" selected, locked users are now displayed. * the Project#members_principals associations lacked the `references` method which lead to the users table being undefined in the resulting query. In order to achive the bug fixes, the member filtering is now based on the query engine also used for users, queries, work_packages, ... As a lot of the members filters are very similar to user filters (in fact, a lot of the members filter work on the users model), those filters are shared via modules. [ci skip]	7 years ago
ulferts	7154caec85	Fix/consolidate representers (#5732) ... * consolidate representers Minimizes the need for extensive payload representers by: * introducing the payload_representer module which removes all non writable propertyies from a representer * introducing the resource/resources/associated_resource/associated_ressources helper methods which provide a framework for having a representer suitable for parsing and rendering Additionally increases the importance of the contracts by using them to calculate the writeable attributes. * remove unused endpoint [ci skip]	7 years ago
Oliver Günther	0c5528051d	[25042] Show no results for member search ... Instead of showing the general 'No results' view as if the project had no members, show a notice that no results where found for the search and also show the filter cell at all times.	8 years ago
Oliver Günther	18c2d9ffb2	[24907] Fix invalid flash access in accessibility members page	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Markus Kahl	5c6ba1723b	show all members by default	8 years ago
Jens Ulferts	888e962b16	reenable responsible autocompleter	8 years ago
Oliver Günther	fe0e8dd919	Rename before_filter to before_action	8 years ago
Markus Kahl	1f4a1e1001	updated specs to new integrated add-member functionality	8 years ago
Markus Kahl	492bbcd068	refactor user filter to allow impermanent memberships integration	8 years ago
Markus Kahl	6538d3a2b1	use correct URL for clear button in user filter	8 years ago
Markus Kahl	a7f880a306	add members directly in index view	8 years ago
Markus Kahl	a230ce5e23	further simple member screen refactoring to allow plugins to integrate	8 years ago
Markus Kahl	b55b682805	enhanced member screen; members and user table refactoring using cells	8 years ago
Oliver Günther	6e0c2ee94b	Create observe-field replacement in angular	8 years ago
ulferts	a5275aeebe	remove no longer employed js action (#4671)	8 years ago
Markus Kahl	71b327f5db	invite user feature including regression test for #21789	9 years ago
Markus Kahl	92a3b89997	don't offer to invite who is already a member	9 years ago
Markus Kahl	a0be1030b7	show user name in deletion notices	9 years ago
Markus Kahl	0102f299e0	delete invited users when removed as member	9 years ago
Markus Kahl	3738329078	delete invited users when removed from project	9 years ago
Markus Kahl	3428181894	only admins may invite new users	9 years ago
Markus Kahl	5b41431400	don't invite members without given roll	9 years ago
Markus Kahl	ac8a096488	polish considering remarks through review and houndci	9 years ago
Markus Kahl	1319e1fe34	extracted member's roles feature spec from cuke ... fixed bug while at it (no error message when choosing no role)	9 years ago
Markus Kahl	5c3241ee50	fixed error messages feature (as feature spec) ... - dropped cuke - fixed a bug inviting Anonymous when no user selected - dropped obsolete test	9 years ago
Markus Kahl	23ba7981bf	use project identifier in members path	9 years ago
Markus Kahl	bc563ea977	more helpful flash messages for project members view	9 years ago
Markus Kahl	738f385cb1	more polish	9 years ago
Markus Kahl	2f5018c1d0	extract members tab; invite members via email	9 years ago
Alex Coles	0ad3cfb4b2	Prefer do…end for controller respond_to blocks ... `rubocop -a` does not currently normalise formatting consistently (see ec1bb39f). Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	ec1bb39f9b	Fix syntax (w/Rubocop) in (Rails) controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	2640852fe3	Fix MembersController#autocomplete_for_member routing ... * make routing less convoluted (as in 18835799). Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago