openproject

Commit Graph

Author	SHA1	Message	Date
Wieland Lindenthal	c4c2149d98	Fix: 36299 -- Allow to modify login when global permission :manage_users present (#9026 ) * Refactoring: Create shared examples for user contracts * Users::UpdateContract spec added * Add spec for updating the login of a user * Add spec for permitted params when global permission to :manage_user * Remove spec for :login updates for user UpdateContractSpec The writability of the login attribute is not part of the contract (yet). * Use user contract for checking writability of user attributes * Fixing user contract specs. * use persisted user in spec Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Wieland Lindenthal	ffa5ac84a8	Allow deletion of placeholder users when permission of :manage_placeholder_user give (#9018 ) * Refactoring: Rename permission :add_user and :add_placholder_user to :manage_user and :manage_placeholder_user * Add deletion to :manage_placeholder_user permission label * WIP: Check :manage_placeholder_user permission before deletion Specs still missing * In controller rely on authorize_global for deleting placeholder users * Add deletion_info for placeholder users * Extend specs * Set placeholder users to locked when deleting * Review feedback Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Wieland Lindenthal	a18954b2c9	Placeholder user services and administration (#8944 ) * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
Oliver Günther	109ade62da	Allow editing auth_source as a global user (#8954 )	4 years ago
Oliver Günther	2cde433326	Remove usages of AnyFixture (#8987 ) AnyFixture will create once instance of a factory for reuse in a number of specs. This will work fine until we require a clean slate for a specific example. As we have numerous tests that test like the database is empty, we get a number of disadvantages: - After an example with `with_clean_fixture` metadata, the fixture will only be regenerated after the next example that uses it. This means the order of execution will change the number of objects in the DB. - The more `with_clean_fixture` we have, the smaller the performance advantage of AnyFixture will result in. - You cannot use an AnyFixture in a spec that needs a clean slate. This should be obvious but was overlooked by myself.	4 years ago
Oliver Günther	3c9be3bdbe	[35507] Allow global permission to add and edit users (#8937 ) * Add global permission for add_user * Rename fieldset for global roles to "Global" * Add permission to admin actions * Add index action to add_user permission * Redirect to first admin item if only one * Hide status action for non admins * Break down user form into partials for easier rendering * Disable some user form tabs for non-admins * Make users API and services conformant with endpoints * Fix references to DeleteService#deletion_allowed? * Authorize add_user on show as well * Only show invite user toolbar item with permission * Fix Delete Service spec * Fix the way user prefs are handled in service * Ensure session_id is treated as string This causes a cast error otherwise as it passes rack session locally * Fix service call on onboarding controller * Fix service call on users controller * Add delete spec for global user * Hide login attribute again when adding a new user * Render auth source correctly in simple form * Fix creating invited users through service The invitation requires the mail attribute to be present. Previously, there was a manual error added to the mail. As the errors are now determined by the contract + model, we now end up with all missing properties as errors. * Properly constraint attributes for non-admins * Add specs for global user * Start working on how to update password from UsersController that code is a mess... * Change permitted_params spec to include non-admin params * Fix create user service spec * Remove mail_notification param from users controller It's not part of the contract/params passed to user * Remove todos * Extend docs * Correct the way backlogs patches into the user settings * Remove superfluous UpdateUserService * Rewrite duplicated update service examples into common shared example * Remove duplicate password writable check * Base Users::DeleteContract on base delete contract * Move checks for active users into the UserAllowedService * Restore password writable check as it is not an attribute * Fix menus for global user * Allow global users to add custom fields * Allow global user add permission to reinvite user * Fix changed var name in update service spec * Ensure also invited or registered users can be authroized This ensure that e.g., invited users can also be set as watchers * fix typo Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot Removes the deprecation	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Oliver Günther	c284109d70	User contract: Require password set when status is `active`	8 years ago
Oliver Günther	826ec7b7b6	Add CreateUserService and User contracts	8 years ago
Jan Sandbrink	6e9ed008fb	Enforce passing of current_user into representers Thereby permission checks will no longer silently fail if no user was passed. This uncovered a lot of places where we actually expected a user to be passed, when it wasn't. This was especially true for collections. The basic idea is, that virtually all representers could change their behaviour based on the current user. Representers where this is not the case (e.g. Digest), can still explicitly opt-out.	9 years ago
Jan Sandbrink	4c232e786b	split specs for unpaginated and paginated collections	9 years ago
Jan Sandbrink	b332ef06aa	make collection representer explicitly unpaginated	9 years ago
Jens Ulferts	da588b812c	harmonize api decorators	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 [ci skip]	10 years ago
Alex Coles	93924e13e7	Remove required keyword args to support Ruby 2.0.x This is not duplicate of #2267. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Hagen Schink	6af688abf4	Adapt specs to path helper usage	10 years ago
Hagen Schink	a482205aec	Test that collections adhere to the specifiction	10 years ago
Hagen Schink	85aeb8d0f3	Remove dependency to reform models from specs	10 years ago
Alex Coles	5afc11f19e	Fix syntax (w/Rubocop) in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	34780d5fc4	Use keyword args in VersionCollectionRepresenter An ArgumentError should be raised if a project is not passed. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	49dd4645d2	Correct Version List Resource self link Modify VersionCollectionRepresenter#initialize to allow for a :project option. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ddff625e2f	Add Version List API resource User Story # 14053 (Task # 14077) Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	3ace7a0ed1	Add skeleton Project API Resource User Story # 14053 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	c82bd01a1e	Move Representer specs under spec/lib/api/v3 For unit-style specs the file structure should mirror that of application code. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Richard	d4e1d563e4	updated spec for new user name property.	10 years ago
Marek Takac	c832f713ee	Added some properties to the API user representer	10 years ago
Marek Takac	c8143cbebf	Fixed typo	10 years ago
Marek Takac	f4a24187d0	Added spec for API activity representer	10 years ago
Alex Coles	789e13a479	Convert specs to RSpec 2.99.0 syntax with Transpec This conversion is done by Transpec 2.3.1 with the following command: transpec -f * 46 conversions from: it { should ... } to: it { is_expected.to ... } * 9 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 1 conversion from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 1 conversion from: describe 'some request' { } to: describe 'some request', :type => :request { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Marek Takac	e1ad040b3a	Created API attachment representer	10 years ago
Johannes Wollert	8b096975fe	updates copyright headers updates more copyright more copyright headers	11 years ago
Hagen Schink	d25b3f2366	Adds adjuvant error messages	11 years ago
Philipp Tessenow	a1e67dd460	new copyright header #1903	11 years ago
Martin Czuchra	62c91d17aa	Restores original migrations. This changes everything, again! Changing migrations was not the right way to to do it. Instead, this restores the original migrations and adds a new migration that includes all changes that are needed for the changed models.	12 years ago
Martin Czuchra	46ffcfc195	Refactors current timelines API into api/v2.	12 years ago
Martin Czuchra	7963fe3521	Updates copyright notice in timelines sources.	12 years ago
Martin Czuchra	c1bfd5202a	Open-sources timelines. This represents the timelines plugin that was merged with the OpenProject core and which had its history squashed. The timelines plugin development was sponsored by; Deutsche Telekom AG <opensource@telekom.de> Requirements engineering and management were provided by; Deutsche Telekom AG <opensource@telekom.de> Finn GmbH <info@finn.de> During the timelines development, the following authors have contributed commits; Martin Czuchra <m.czuchra@finn.de> Nils Kenneweg <n.kenneweg@finn.de> Romano Licker <r.licker@finn.de> Gregor Schmidt <g.schmidt@finn.de> Jens Ulferts <j.ulferts@finn.de> Johannes Wollert <j.wollert@finn.de> Quality Assurance was provided by; Erdem Kabadayi <e.kabadayi@telekom.de> Julia Pape <j.pape@finn.de> Christian Rijke <c.rijke@finn.de> Thomas Vogel <th.vogel@external.telekom.de>	12 years ago

14 Commits (b52a2d744b692b960f0c625b6b63fcba1417d534)