24738 Commits (b70f073a73d9f2919fc85272e473ea4236ac55ee)

 

All Branches   

Search

Author	SHA1	Message	Date
Oliver Günther	d5a3b21049	Scroll to element only when visible ... Introduces a simple helper plugin to determine whether an element is `visible()`.	9 years ago
ulferts	b99dfc9511	Merge pull request #3517 from NobodysNightmare/feature/clever_journal_aggregation ... Improve performance for aggregated journal diffs	9 years ago
Jan Sandbrink	caf05e9b1a	Simplify joins clause	9 years ago
Oliver Günther	de96916dac	Minor corrections ... This commit addresses the following minor corrections from review: 1. Remove constant URI: It breaks karma, and I can't really tell why 2. Avoid using Object.values Appeared to be supported by chrome, but causes the protractor failure. This also switches the ordering to binary (unshift, push) as that's all we need for now. 3. Remove location.hash when jumping to element `$location.hash` may take precedence over `scrollIntoView` ocassionaly, thus we forcefully remove the location hash when updating the work package on a particular field 4. Avoid showing comment success when empty When opening the comment field, and then submitting on another field with comment being empty and open, the comment was not submitted, but a successful comment notification was still sent. 5. Fix issues for IE 10+ * Force min-height to be set on the element, as IE tends to return 0 as height when empty 6. Misc. * Avoid undefined in comment text * Avoid resizing [msd-elastic] textareas * Rename `add_journal` to `create_journal` Correct wrong bracket for reject function	9 years ago
Oliver Günther	7f602664fc	Allow focussing an element after work package has been updated ... This commit allows comments or fields to specify a callback after the work package has been updated. This is currently used to scroll to the element (such as the inserted comment), whenever the work package has loaded.	9 years ago
Oliver Günther	9bd4e06d29	Use promises in submitFields methods to defer updating ... As submitting comments and fields in one go requires work packages to be submitted first, we can use promises to ease the processing of each and abort early, e.g., when the WP couldn't be updated, we don't want to submit the comment.	9 years ago
Oliver Günther	d1a1020097	Workaround for focus event on user activity ... It seems that the user activity doesn't correctly handle blur events. I do not know why, but to provide a workaround, I've forced setting the focus for the quote and edit buttons.	9 years ago
Oliver Günther	8da4ac0d63	Restore empty description submit	9 years ago
Oliver Günther	cce8c378a3	Consistent styling of description, watcher and comment ... This re-applies the input styling for comment, and makes it consistent across description and watcher fields.	9 years ago
Oliver Günther	c3589353cb	Scroll to textarea controls when editing and space available	9 years ago
Oliver Günther	7cd7697fab	Replace autogrow with angular-elastic ... angular-elastic provides us with an option to always insert an additional newline to provide smoother animations. This also changes animations to CSS rather than `jQuery.animate`.	9 years ago
Henriette Dinger	27c60cf667	Incorporate review feedback ... * Notification when comment is created * Better binding to editing comments * Quote with inserted text fixed	9 years ago
Oliver Günther	887091f5f1	Fix stale object from fixed lock_version in legacy spec ... The affected test used the next lock_version, which now fails as the journal no longer saves the container.	9 years ago
Oliver Günther	3ca36e1e1d	Parallel sending of comment and fields in WP split view ... Parallel submitting of comments alongside WP edits wasn't possible natively due to the increased lock_version in work packages, caused by `touch`ing and explicitly saving the work package in the process of adding a journal. This commit works around this issue by updating the timestamp columns directly, bypassing optimistic locking in the work package table. This allows comments to be submitted transparently with other fields to the user, while actually, we send it in two subsequent steps.	9 years ago
Oliver Günther	5732eee3d3	Propagate and distribute field and comment submits in WP Field Service ... This commit allows parallel saving of comments and fields, however this currently results in a conflicting modification due to two saves with thes same lock version.	9 years ago
Oliver Günther	51509e6b34	Editing of comments with in-place button styles and preview ... This commit changes the comment edit and cancel buttons to reflect the in-place editing style. Also allows previewing of edited comments and also shows a notification-box when comments are edited.	9 years ago
Oliver Günther	0883cf9834	Replace exclusive-edit with transcluded comment directive ... This commit removes the somewhat superfluous exlusiveEditController in favor of event-based passing of quoted text to the correct comment field. The comment directive now decides for itself whether it wants to be placed above or below the activities and uses transclusion for that purpose. Editing comments is now no longer exlusive, but that shouldn't be necessary anyway.	9 years ago
Oliver Günther	3b5518e8db	Fix invalid ng-show on comments ... With multiple `ng-show`, the latter element will be selected, even when its hidden. This causes the quote button to (appear to) malfunction when sorting descending. HUGE props to @ulferts for finding that one.	9 years ago
Oliver Günther	0aed8bb310	Test for comment input	9 years ago
Oliver Günther	3bfad28db0	Correct comment behavior with optional notifications ... This allows submitting comments with and without notification for the created journal. Using hyperagent resource on activities, the resource `addComment` is replaced when executing `fetch` on the link. This breaks subsequent comment requests. This is fixed by requesting manually on the resource link using `$http`. This commit also provides the functionality required to comment with or without notification propagation, and changes the backend to comply to the APIv3 specification, which defines comments to be sent as a JSON `{ comment: { raw: 'my comment' } }`. This commit also provides: * Displaying the comment input on overview depending on sort setting * Disable inplace controls when comment is empty * correctly hiding the comment based on link availability	9 years ago
Oliver Günther	f589f565a6	Correct height when expanding inplace textareas with autogrow ... When using `.-autogrow` on textareas in inplace edit (e.g., description), the height is not correctly set as the selector is not visible. Only when starting to EDIT the textarea, the changes are being picked up and height is set correctly. This commit thus provides a second event listener to `focusin` events that cause the textareas to resize properly.	9 years ago
Oliver Günther	e168258e42	Remove replaced activity_comment	9 years ago
Henriette Dinger	01d47ea851	Editable comment field ... This provides the basic functionality to deliver a comment field in the in-place editing style. Adds the `autogrow` plugin This still breaks a number of features currently, such as formatted previewing.	9 years ago
ulferts	aa12c2d8a2	Merge pull request #3519 from oliverguenther/feature/unsupported-browsers ... Include Firefox <= 38 in unsupported browsers	9 years ago
Continuous Integration	8afd380e36	Update reference to OpenProject-Translations	9 years ago
ulferts	ecf84691e6	Merge pull request #3525 from opf/fix/remove_obsolete_signup_translation ... removed obsolete translation	9 years ago
Jan Sandbrink	2913ff3d17	Use language prefix fallback for user language too ... e.g. use "en" instead of "en-GB", if only "en" is available	9 years ago
Jan Sandbrink	caf6ec07c7	Use SetLocalizationService in LocaleHelper	9 years ago
Markus Kahl	17447ee9f8	removed obsolete translation	9 years ago
Jan Sandbrink	654aff766f	Merge pull request #3521 from jonasheinrich/feature/migrate_docs_to_github ... Feature/migrate docs to GitHub	9 years ago
Oliver Günther	0990ccedf8	Include Firefox <= 38 in unsupported browsers	9 years ago
Jonas Heinrich	e208be946d	Add link to detailed guide	9 years ago
Jonas Heinrich	aebd467abd	Move doc about creating plugins	9 years ago
Jonas Heinrich	0021ca3fed	Fix style	9 years ago
HDinger	3da076937d	Merge pull request #3518 from Azure7111/fix/danger_zone_validation ... Fix danger zone validation	9 years ago
Continuous Integration	7e5327ca2a	Update reference to OpenProject-Translations	9 years ago
Continuous Integration	d71cf4f0c9	Update reference to OpenProject-Translations	9 years ago
Continuous Integration	7717941646	Update reference to OpenProject-Translations	9 years ago
Continuous Integration	19bdcc889b	Update reference to OpenProject-Translations	9 years ago
Continuous Integration	939eb5e68b	Update reference to OpenProject-Translations	9 years ago
Jonas Heinrich	1489acdb1a	Add doc about creating OmniAuth Plugin ... [ci skip]	9 years ago
Jonas Heinrich	f104c16dae	Adds doc about creating plugin ... [ci skip]	9 years ago
Jonas Heinrich	4d53af9938	Adds documentation about setting up a development setting ... [ci skip]	9 years ago
Markus Kahl	f2173379da	refactored user create feature spec	9 years ago
Jonas Heinrich	6729d70790	Adds code review guidelines ... [ci skip]	9 years ago
Jonas Heinrich	e53bb79343	Add doc about installing plugins ... [ci skip]	9 years ago
Jan Sandbrink	26574521d3	Prefill predecessors for results of multiple journables too	9 years ago
Jan Sandbrink	0343e12c83	Prefill predecessor when it is already known ... Getting the predeccessor of a journal is a common operation. When computing the journals for a single journable, it is easily possible to prefill the predecessor (because we know all the journals). Doing this avoids an N+1 query later on (in case the journals are used to display diffs).	9 years ago
Alexander Bach	21333fc432	Adjust living style guide	9 years ago
Alexander Bach	90dd94ba74	Validate user input during typing	9 years ago