223 Commits (b863b1c5e7568a4b8e1e54940f0e62eac8b3af73)

Author	SHA1	Message	Date
Alex Dik	5aeccc2d2c	Reduce fieldController redundancies ... [ci skip]	9 years ago
Alex Dik	bd86311e26	Refactor inplace-edit directory structure ... [ci skip]	9 years ago
Alex Dik	1b3b570ee1	Replace UI Select with default HTML elements ... [ci skip]	9 years ago
Alex Dik	dd80914f58	Ask user for confirmation when changing states ... [ci skip]	9 years ago
Alex Dik	e92a154725	Implement cancel button for fullscreen edit ... Input values are set to their initial values when one restarts editing.	9 years ago
Alex Dik	1d8341fdbd	Reset user input when cancel button is used in edit mode	9 years ago
Alex Dik	42e27e41a3	Make user input stay when switching between views	9 years ago
Alex Dik	5c9975fd64	Implement WP-edit save button	9 years ago
Alex Dik	99348cadb7	Refactor EditableFieldsService and EditPaneController ... Move isActiveField and getPendingFormChanges to EditableFieldsState service.	9 years ago
Alex Dik	c751e0c23c	Disable WP edit buttons for users without update permissions	9 years ago
Alex Dik	40167485a9	Add work package edit actions toolbar (save & cancel) ... Saving the work package does not work as of yet.	9 years ago
Alex Dik	880cd83485	Implement WP editing in list overview	9 years ago
Alex Dik	aa01eb1f79	Implement work package editing in fullscreen view	9 years ago
Jens Ulferts	eadd29b188	extract behaviour into own directive	9 years ago
Jens Ulferts	f96938bc0f	open select on space as well	9 years ago
Jens Ulferts	ca6e387ddd	remove ineffective and unnecessary reqire [sic] statement	9 years ago
Jens Ulferts	b319cc1837	open file select on enter	9 years ago
Magdalena Kafka	4b1e0b55a6	Remove toggle all link from wp table	9 years ago
Jens Ulferts	dbfcfb49b7	Revert "Merge pull request #3646 from furinvader/16364-fullscreen-edit" ... This reverts commit cddeebbf43, reversing changes made to 44ba79e900.	9 years ago
Alex Dik	b422907206	Reduce fieldController redundancies ... [ci skip]	9 years ago
Alex Dik	0faeeff74c	Refactor inplace-edit directory structure ... [ci skip]	9 years ago
Alex Dik	5dbb78fe79	Replace UI Select with default HTML elements ... [ci skip]	9 years ago
Alex Dik	46bb3540cc	Ask user for confirmation when changing states ... [ci skip]	9 years ago
Alex Dik	5ab24dc7a6	Implement cancel button for fullscreen edit ... Input values are set to their initial values when one restarts editing.	9 years ago
Alex Dik	9ec5cd8ea6	Reset user input when cancel button is used in edit mode	9 years ago
Alex Dik	92009a1dd7	Make user input stay when switching between views	9 years ago
Alex Dik	be5beca5ca	Implement WP-edit save button	9 years ago
Alex Dik	9b290d18f3	Refactor EditableFieldsService and EditPaneController ... Move isActiveField and getPendingFormChanges to EditableFieldsState service.	9 years ago
Alex Dik	7d86b2977c	Disable WP edit buttons for users without update permissions	9 years ago
Alex Dik	b9bf6d0274	Add work package edit actions toolbar (save & cancel) ... Saving the work package does not work as of yet.	9 years ago
Alex Dik	c6e1632af4	Implement WP editing in list overview	9 years ago
Alex Dik	c662325ba8	Implement work package editing in fullscreen view	9 years ago
Oliver Günther	9ad48023ed	Always allow attachment upload for new work packages ... af73d60773 introduced a check whether the work package contains a link addAttachment (i.e., the user is allowed to :edit_work_packages). For new work packages, this link is not available, thus we need to provide some alternative as for now, when adding work packages it is always possible to add attachments (given the :add_work_packages permission).	9 years ago
Alex Dik	0b7f369fbe	Undo escaping of work package links	9 years ago
Tim Habermaas	af73d60773	Hide attachment dropzone if user has no rights to upload files.	9 years ago
Tim Habermaas	ed23d6eb7f	Fix links from work packages table to fullscreen view.	9 years ago
Tim Habermaas	e5fceb38be	Fix non-camelcased name. ... Thanks, @houndci.	9 years ago
Tim Habermaas	bc5df6e051	Point work package link from table to new angular show view.	9 years ago
Oliver Günther	d5a3b21049	Scroll to element only when visible ... Introduces a simple helper plugin to determine whether an element is `visible()`.	9 years ago
Oliver Günther	de96916dac	Minor corrections ... This commit addresses the following minor corrections from review: 1. Remove constant URI: It breaks karma, and I can't really tell why 2. Avoid using Object.values Appeared to be supported by chrome, but causes the protractor failure. This also switches the ordering to binary (unshift, push) as that's all we need for now. 3. Remove location.hash when jumping to element `$location.hash` may take precedence over `scrollIntoView` ocassionaly, thus we forcefully remove the location hash when updating the work package on a particular field 4. Avoid showing comment success when empty When opening the comment field, and then submitting on another field with comment being empty and open, the comment was not submitted, but a successful comment notification was still sent. 5. Fix issues for IE 10+ * Force min-height to be set on the element, as IE tends to return 0 as height when empty 6. Misc. * Avoid undefined in comment text * Avoid resizing [msd-elastic] textareas * Rename `add_journal` to `create_journal` Correct wrong bracket for reject function	9 years ago
Oliver Günther	7f602664fc	Allow focussing an element after work package has been updated ... This commit allows comments or fields to specify a callback after the work package has been updated. This is currently used to scroll to the element (such as the inserted comment), whenever the work package has loaded.	9 years ago
Oliver Günther	9bd4e06d29	Use promises in submitFields methods to defer updating ... As submitting comments and fields in one go requires work packages to be submitted first, we can use promises to ease the processing of each and abort early, e.g., when the WP couldn't be updated, we don't want to submit the comment.	9 years ago
Oliver Günther	8da4ac0d63	Restore empty description submit	9 years ago
Oliver Günther	c3589353cb	Scroll to textarea controls when editing and space available	9 years ago
Henriette Dinger	27c60cf667	Incorporate review feedback ... * Notification when comment is created * Better binding to editing comments * Quote with inserted text fixed	9 years ago
Oliver Günther	3ca36e1e1d	Parallel sending of comment and fields in WP split view ... Parallel submitting of comments alongside WP edits wasn't possible natively due to the increased lock_version in work packages, caused by `touch`ing and explicitly saving the work package in the process of adding a journal. This commit works around this issue by updating the timestamp columns directly, bypassing optimistic locking in the work package table. This allows comments to be submitted transparently with other fields to the user, while actually, we send it in two subsequent steps.	9 years ago
Oliver Günther	5732eee3d3	Propagate and distribute field and comment submits in WP Field Service ... This commit allows parallel saving of comments and fields, however this currently results in a conflicting modification due to two saves with thes same lock version.	9 years ago
Oliver Günther	0883cf9834	Replace exclusive-edit with transcluded comment directive ... This commit removes the somewhat superfluous exlusiveEditController in favor of event-based passing of quoted text to the correct comment field. The comment directive now decides for itself whether it wants to be placed above or below the activities and uses transclusion for that purpose. Editing comments is now no longer exlusive, but that shouldn't be necessary anyway.	9 years ago
Oliver Günther	0aed8bb310	Test for comment input	9 years ago
Oliver Günther	3bfad28db0	Correct comment behavior with optional notifications ... This allows submitting comments with and without notification for the created journal. Using hyperagent resource on activities, the resource `addComment` is replaced when executing `fetch` on the link. This breaks subsequent comment requests. This is fixed by requesting manually on the resource link using `$http`. This commit also provides the functionality required to comment with or without notification propagation, and changes the backend to comply to the APIv3 specification, which defines comments to be sent as a JSON `{ comment: { raw: 'my comment' } }`. This commit also provides: * Displaying the comment input on overview depending on sort setting * Disable inplace controls when comment is empty * correctly hiding the comment based on link availability	9 years ago