54 Commits (b8942af11b81ef599c90a45a146c44ef0a235d8e)

Author	SHA1	Message	Date
Oliver Günther	a92575e3ec	Use distinct(*) on aggregated journal to avoid duplicate raw journals ... https://community.openproject.com/wp/33744	4 years ago
Oliver Günther	c6b9c8ff02	Use distinct(*) on aggregated journal to avoid duplicate raw journals ... https://community.openproject.com/wp/33744	4 years ago
ulferts	e14679d0b3	avoid loading aggregated journals repeatedly when patching	4 years ago
ulferts	7f39a3b08f	allow fetching activities by an id referencing a subsumed journal ... AggregatedJournals might contain a set of native journals. This change allows fetching an aggregated journal the id of any journal included in the aggregated. This provided clients with more available references to an aggregated journal. This is particularly helpfull in case the aggregated journal includes more journals than the client expects. This might happen when the journable is updated in the meantime. E.g. a user adds a screenshot to the last comment within the time frame available for aggregation; a user adds a comment, alters an attribute and wants to change the comment. At the same time, this change limits the aggregated journals created in the database to a particular journable. This has a severe performance impact as without the focus on a particular journable, potentially millions of journals will be aggregated to then only fetch one individual result.	4 years ago
ulferts	983709db89	rewrite acts as journalized to create journals in sql	5 years ago
ulferts	64d0f57d85	Feature/aggregated activities (#8221) ... * use cte for aggregated journal * Revert "use cte for aggregated journal" This reverts commit 5fedefefdd. * add another subselect that could later on be provided from the outside * allow passing a nukleous sql to aggregated journals * wip - using aggregated journal for activity * new sql for aggregated journals * start implementing new aggregated query * additional documentation * consolidate activity functionality * simplify by turing into instance methods * move activity fetcher out of redmine * remove verb verification made obsolete Without catchall routes, the dispatching handles it * remove duplicate authorize check * refactor activities controller * refactory activity fetcher * cache avatar file * sort choosable events * remove legacy spec covered by contemporary * speed up aggregated journals via CTE * instance var might never have been set * ensure the event_types are always transmitted * correctly reset the avatar cache * fix avatar fetcher expectation regarding wiki pages * adapt spec [ci skip]	5 years ago
ulferts	0acff96c09	fix journal noop? check	5 years ago
ulferts	59f907560e	no mail on empty wp update	5 years ago
ulferts	a6e87c9dcb	display retracted message on empty journals	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	d37bdb71f0	extract methods	5 years ago
Wieland Lindenthal	2935a46096	WIP: Spike to display BCF viewpoint snapshots in WP activity tab.	5 years ago
Oliver Günther	4666fbb4e0	[30415] Fix missing project reference in journal ... https://community.openproject.com/wp/30415	5 years ago
ulferts	9c3206220b	remove mysql specific code throughout the application	5 years ago
Oliver Günther	5de0b9a2d8	Go through brakeman warnings	6 years ago
Oliver Günther	1bbad019fe	Correctly escape aggregated journal notes_id ... [ci skip]	6 years ago
Oliver Günther	a358d45e5f	Correctly escape aggregated journal notes_id ... [ci skip]	6 years ago
Oliver Günther	79befe97b3	Bump capybara and rspec	6 years ago
Jens Ulferts	440f101f7e	enforce order when numbering for journal aggregation ... Otherwise journals recreated later (e.g. when recreating the initial journal) can end up with wrong numbering	6 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	8065c66256	eager loading associated objects, the dirty way	9 years ago
Jens Ulferts	3734b3a232	limit aggregation to one journable ... With only .where("#{table_name}.id = ?", notes_id) appended, the DB would aggregated all (from all journables of all types) and then select the one that is necessary. This takes a considerable amount of time. The commit will limit the aggregation to one journalizable.	9 years ago
Jan Sandbrink	26574521d3	Prefill predecessors for results of multiple journables too	9 years ago
Jan Sandbrink	0343e12c83	Prefill predecessor when it is already known ... Getting the predeccessor of a journal is a common operation. When computing the journals for a single journable, it is easily possible to prefill the predecessor (because we know all the journals). Doing this avoids an N+1 query later on (in case the journals are used to display diffs).	9 years ago
Jan Sandbrink	dfb9a5cd20	remove remaining AR find_by_x finders ... - most of them were removed by @myabc in the rails4 branch - some where reintroduced due to parallel development to that branch - still some occurences left that will hit custom implementations	9 years ago
Jan Sandbrink	b322fafc25	remove workaround for type conversion in PSQL ... as of Rails 4 this should no longer be neccessary	9 years ago
Jan Sandbrink	3fe8b33f78	enforce disabled aggregations ... due to limited time resolution we can't assume that a setting of 0 will implicitly disable aggregation	9 years ago
Jan Sandbrink	d47d6685ed	filter for right journal on SQL level	9 years ago
Jan Sandbrink	f9051bba3e	display diff of containing aggregated journal ... ... instead of displaying the diff for the requested journal only - this should provide the best forward compatibility of links - even when aggregation timeframes are changed intermittently	9 years ago
Jan Sandbrink	e405605343	fix wrongful notificaiton delivery	9 years ago
Jan Sandbrink	285b7f5437	move on-behalf-delivery into notification mailer	9 years ago
Jan Sandbrink	974523c370	partly address an edge case that can prevent notification delivery ... "partly" because the current implementation is still "vulnerable" if the succeeding journal gets outdated in the same way as the preceeding one. The edge-case of the edge-case....	9 years ago
Jan Sandbrink	6c1e4dbf4f	send aggregated notifications ... - only sending the last mail of an aggregation chain - displaying the aggregated state of the change - replaces old classes for mail notifications - old special error handling for missing users is obsoleted, since recipients are determined at jobs runtime - special cases for missing author and journal are considered	9 years ago
Jan Sandbrink	1ff8f15fbd	explicitly define order of groups in PSQL ... Always remember kids: SQL databases do not guarantee an order if you don't ask for one! That is why PostgreSQL sometimes found a predecessor for an aggregated journal that was not supposed to have one: Based on internal decisions the order of rough groups was not ascending (as expected implicitly) and master and addition would switch places. ALWAYS SPECIFY AN ORDER IF YOU EXPECT ONE!	9 years ago
Jan Sandbrink	a2b952f549	improve exception message on missing journable.id ... previously an invalid MySQL statement would have been indicated, which is correct but not very helpful. On PSQL this will also lead to a DB lockup (at least on environments known to me)	9 years ago
Jan Sandbrink	cefa25b189	fix predecessor implementation	9 years ago
Jan Sandbrink	563cb3c5c7	migrate APIv3 to aggregated journals ... - turns out agrgegated journals needed more features - turns out specs were incomplete and bogus	9 years ago
Jan Sandbrink	f65f9e3e2d	remove the AR portion of aggregated journals ... - this prohibits doing stupid things like saving aggregated journals - should make clear that aggregated journals are not real journals...	9 years ago
Jan Sandbrink	3a87b269fa	allow to fetch aggregated journals for a journable ... - this should be faster (or at least easier to optimize) than applying a WHERE to the whole scope - also starting to diverge from using classic ActiveRecord in aggregated journals	9 years ago
Jan Sandbrink	a8ab1024b5	clarify explanations ... typos, wording and stuff	9 years ago
Jan Sandbrink	5f06a8900d	better PSQL compatibility for aggregated journals	9 years ago
Jan Sandbrink	f02b32faad	override :initial? for AggregatedJournal ... the simple approach of looking at the version number does not work, because aggregated journals can have gaps in their versions (and there might be no version 1)	9 years ago
Jan Sandbrink	a5152e9875	use the actual setting for the aggregation time	9 years ago
Jan Sandbrink	88169a46de	expose id of "master" as notes_id ... - make spec assertions more detailed by comparing all the attributes	9 years ago
Jan Sandbrink	3c3b03bbcc	make SQL compliant for both MySQL and PSQL	9 years ago
Jan Sandbrink	405aa2d524	add PostgreSQL-compatible group numbering	9 years ago
Jan Sandbrink	3b7b0ec289	Enhance AggregatedJournals to correctly merge journals with notes ... Aggregation should now follow the rules previously defined for merging journals (see code comments). Jens (@ulferts) and I developed the SQL for this. I hope the explanatory comments make it a quite readable SQL experience.	9 years ago
Jan Sandbrink	ddbc8a4ba7	remove obsoleted helper	9 years ago
Jan Sandbrink	885d8d734f	add basic spec for aggregated journals	9 years ago