openproject

Commit Graph

Author	SHA1	Message	Date
Benjamin Bädorf	831921a79a	Add attribute help texts to dynamic forms (#9215 ) * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * Provide DynamicFieldsService in root so it can be used independently * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * _isResourceSchema based on parent?.location * Scope DynamicFieldsService to DynamicFormComponent * Added backend validation method to FormsService * Remove form from DynamicForm when not isStandaloneForm * Allow multiple form keys to validate * Remove form from non standalone forms * Remove duplicated button * Fix: dynamic form with ng-template not showing validations * DynamicForm programatic validation * Hide the submit button input * Unify ckeditor spacings with other dynamic-form elements * Basic fixes to invalid dynamic form fields * Fix invalid styles for dynamic inputs * Updates to form styles, add op-form and op-fieldset * Soften inputs to 2px * Update input styles globally * Add basic dynamic forms attribute help texts * Add attribute help texts to dynamic forms This reshuffles a ton of files and modules to fix circular dependency issues around the OP common module. Mainly the following circular dependencies where resolved: common -> help texts -> modal -> common attachments -> common a11y -> common modal, attachments and a11y now directly depend on the modules/components they were using form common common -> help texts -> modal -> focus attachments -> icon, a11y a11y -> none * Fix spec build * attribute-help-text workin in dynamic forms * Add attribute help texts for fieldsets * Fix groups * Fix dynamic form groups even better * Fix selector on attribute Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Wieland Lindenthal	33443c154e	Update IFC Viewer with latest Xeokit updates (#9207 ) * Bump @xeokit/xeokit-gltf-to-xkt to version 1.0.0 * Bump Xeokit SDK and Xeokit BIM Viewer * Overwrite XEOKIT orthogonal/perspective toggle icon * Add styles for section tool and its menu * Remove SAO deactivation for non default models. Performance of SAO has improved ever since Xeokit's FastNavPlugin was created. * bump xeokit sdk and bim viewer * IFC viewer toolbar adoption for section plane tool. * Fix spec after xeokit bump * Feature 33880 Add Edit/Delete/Add model buttons in Models tab * Paths to xeokit's bim viewer code changed * Bumping xeokit packages * Fix default_spec.rb for scopes	4 years ago
Aleix Suau	f5d2a7467b	Feature/36382 multi selection for project custom fields base (#9164 ) * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * Provide DynamicFieldsService in root so it can be used independently * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * Projects form working with formly 50% * Removed console.log * Working with formattable * Working with formattable * Input with id and label * Input with id and label * Useless dependencies removed * Saving forms + required labels with * * First backend validation approach * Removed reload on type change + keep model on route changes * Handlig backend validations with setError * Formatting the form model to submit * Make up refactor * working with op-form-field * Form creation moved to the service * Working with op-form-field wrapper * Working with validation and op-form-field * Working with []CustomFields * Clean up * Clean up * Clean up * Clean up * Form routing working * Notification on form error and success * Refactor + removed useless dynamic form observable * DynamicFieldsService with tests * Refactor: inputs catalog + catch form load error * Filter out non writable fields * Refactor: naming consistency * Cleaning comments * dynamic-fields-service tests + wrapper component * DynamicForm Tests * @ngx-formly/core dependency added * Cleaning up * DynamicForm working as a FormControl * Getting route params sync * Global FormsService: submit + formatting + error handling * Fix: @Optional() FormGroupDirective in OpFormFieldComponent * Code climate fix * Removed CdkTextareaAutosize because of CDK issue 22469 * DynamicFormComponent tests * Dynamic input test helpers + boolean and text tests * Refactor edit fields to avoid circular dependencies in the dynamic forms * Naming fix * IntegerInputComponent tests * SelectInputComponent tests * Fix: duplicated identifier on inputs * Extract toolbar to be reused for now Still TBD whether we want to move them right now to the frontend? * Create new project route and redirect to rails view after saving * fieldsSettingsPipe + hide 'identifier' on projects * Handling multi-values (also as links) and passwords * Some TODOs removed * FormattableTextareaInputComponent tests * _isResourceSchema based on parent?.location * Scope DynamicFieldsService to DynamicFormComponent * Added backend validation method to FormsService * Remove form from DynamicForm when not isStandaloneForm * Allow multiple form keys to validate * Remove form from non standalone forms * Remove duplicated button * Fix: dynamic form with ng-template not showing validations * DynamicForm programatic validation * Hide the submit button input * Unify ckeditor spacings with other dynamic-form elements * Basic fixes to invalid dynamic form fields * Fix invalid styles for dynamic inputs * Updates to form styles, add op-form and op-fieldset * Soften inputs to 2px * Update input styles globally * Fix selectors in copy spec * Undo new project route Will be handled in separate PR * Add separate module for field controls Otherwise it will not be found in the FormattableEditField component * Fix paths now having a trailing slash due to ui-router * Remove new project lazy route * Add data attribute to locate fields * Fix spec by locating field with data * Accept that ng-select can be cut off No idea why that changed in this PR though? * Fix success message to match tests * Redirect settings to generic to match angular path * Fix other project spec * Remove fdescribe * Fix missing cv with magic wait time for now * Remove broken angular tests * Fix routing spec * Import field controls module in wp module * Wait after inserting link into ckeditor It looks like the formly field doesn't get the current ckeditor value before saving * Decouple settings fetching from dynamicform mode (Standalone/FormControl) Co-authored-by: Oliver Günther <mail@oliverguenther.de> Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>	4 years ago
Benjamin Bädorf	68949daa03	Feature/35521 ium capabilities (#9158 ) * Started experimenting with capabilities * Started adding akita store * Use current user store to filter projects * Work on integrating capabilities * Added capability checks * Fix project select * Working on ium specs * Change ng select option list format * Fix proejct search label * Fix some specs * Fix issue with principal select * Add spec for missing placeholder user capabilities * Add new capability specs, fix existing ones * Fix import * Update shrinkwrap * Add JSDoc deprecations Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Philipp Tessenow	a46de71009	[#36204 ] Add new GitHub plugin tab enabling users to copy git actions (#9027 ) * Let GitHub integration show changes in a separate tab * added new github integration icons to icon font * add tab content: working tab-header and copy-menu * modernise github_integrations ruby code * refactored some code to be more modern ruby (if wrote most of it 7 years ago and couldn't look at some parts without squinting too much) * make some intended-to-be-private module methods actually private * fixed all rubocop errors in the /modules/github_integration * re-organized tests a little * gave our rubocop.yml some RSpec-related defaults -- happy to discuss these, but I think we can live with these as a good starting point 👆 all without actually (intentionally) changing the behaviour * removed dead angular template code * codeclimate found more things than rubocop :) * removed create-pr-button since we decided against implementing that feature * added missing translations * properly cache the github related part of the wp api * lower case pull requests in translations * fix specs	4 years ago
Oliver Günther	693d01f8c7	Bump Sentry and implement log handling in core (#9133 ) * Bump Sentry and implement log handling in core * Manually insert the sentry middlewares * Also add user locale as tags * Add performance tracing * Update sentry host to sentry2 * Update frontend sentry-reporter to the new sdk * Silence delayed_job's own logger since activejob logs already Delayed::Job will otherwise always log all arguments, which we disable by design * Remove default sentry host	4 years ago
Oliver Günther	3b78be087b	Migrate tslint to eslint (#9064 ) * tslint to eslint migration * Autofix issues * Fix codeclimate path to eslintrc * Extend linter config for use with ng lint * Change prefix to op in angular lints	4 years ago
Oliver Günther	c4c4cc9042	Bump Angular to 11.2 (#9054 ) * Bump Angular to 11.2 * Restructure package.json dependencies * Fix absolute templateURLs that are no longer supported * Fix promise types after removed promises-a-plus pkg * Revert karma bump as its breaking tests	4 years ago
Oliver Günther	1ef61291f1	Bump Angular to 11.0 (#8913 ) * Bump Angular to 11 * Bump fullcalendar * Bump uirouter * bump typescript and rxjs fixup! bump typescript and rxjs * Run angular update migrations * Fix deprecated options in serve, they are kept in builder * Replace node-sass with sass and fix errors * Include all ts files again to fix warnings We have scripts that should be contained but are only loaded dynamically. It seems this trips up TS to print warnings that these files are unused, which they really aren't. * Address typescript compilation errors and warnings due to 4.0 upgrade * Link to styles.css not js with updated sass * Only reposition dropdown if appendTo is set * Initialize resource property in edit field component Correctly update field component and handler properties Always use the changeset schema Fix removed property in custom text	4 years ago
Benjamin Bädorf	660884f50a	Fix various problems with the docker setup and frontend changes (#8846 ) Fix various problems with the docker setup and frontend changes * Set the node version to the same one that is used in the final packages and that is required in package.json * Change the order of operations for backend container building * Set the npm dependencies back to where they were * Change browserslist rules for firefox * Fix some docker commands for pullpreview * Add b12f as a pullpreview admin Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Benjamin Bädorf	5f45ee07ab	Move development docker-compose file to the main directory (#8798 ) * Move development docker-compose file to the main directory This requires us to move some other files around, like the pullpreview and example docker-compose file for production setups. This commit also does some housekeeping, like removing some old files and deduping configuration. * Updated to selenium grid * Fix in-Docker Selenium tests The Selenium tests now run inside a Docker Chrome Container. Backwards compatability with non-docker setups is not guaranteed, though it should not be hard to implement with a couple of small fixes. * Updated docker development documentation * Improved test timings, changed the documentation * Updated docker testing again * Run npm in the frontend directory * Really run npm in the frontend directory * Also run npm in frontend when setting up travis cache * Change directory for one command only * Change default test driver name * CI test change fixes * Fixed syntax error * Added dev check * Trying to fix firefox resizing * Trying to get tests running * Stop resizing firefox * Fixed apple icon spec * fix host in url helpers for omniauth spec * Fix omniauth specs * Fix docs * Small fixes to docker tests * Added package.json back in * Change env variables Co-authored-by: Markus Kahl <machisuji@gmail.com>	4 years ago
Benjamin Bädorf	724a4514fd	Fix calendar widget resize when adding or removing other widgets (#8784 ) * Fix calendar widget resize when adding or removing other widgets The fullcalendar dependency only reacts to the `document.resize` event. However in our case the widget can also resize when neighboring widgets are added or removed. This fix adds a `ResizeObserver` listener to account for that. It is supported in all evergreen browsers. * Explicitly add resize observer typings The typings file for ResizeObserver was not being autoloaded. This commit adds the typings explicitly, making sure tsc picks up on them. * Move typings include to a different file	4 years ago
ulferts	81f3fac35b	bump fullcalendar (#8816 )	4 years ago
ulferts	514e37b3c8	run npm audit fix (#8817 )	4 years ago
Benjamin Bädorf	fbf375d480	Updated local development docker setup There are now separate containers for testing purposes, and the frontend container is a node-only image. Containers run with a user that has the current user id and gid, making sure that any files that are installed by bundler or npm are user-owned. Selenium tests can be ran, but not all of them work yet.	4 years ago
Benjamin Bädorf	a8dfb55345	Updated local development docker setup There are now separate containers for testing purposes, and the frontend container is a node-only image. Containers run with a user that has the current user id and gid, making sure that any files that are installed by bundler or npm are user-owned. Selenium tests can be ran, but not all of them work yet.	4 years ago
Wieland Lindenthal	363f40ee94	Bump Xeokit to SDK 1.3.91 and BIM viewer 1.8.6.	4 years ago
Oliver Günther	e40ab67ff2	Bump fullcalendar to 5.1	4 years ago
Oliver Günther	3ec2e09133	Perform upgrade to angular 10	4 years ago
Oliver Günther	d952b1e23d	Bump uirouter	4 years ago
Oliver Günther	895c33f64b	Bump ng-select	4 years ago
ulferts	1eae814b27	run `npm audit fix`	4 years ago
Oliver Günther	10e21154f7	Move asset pipeline javascripts to frontend (#8482 ) * ove reporting and reporting_engine js to frontend page * Replace webhook assets javascript * Add path augment service to dynamically load scripts * Remove JS-Files that are not used/not needed any more * Include AugmentingModule correctly * Remove special handling for checkbox selection which is outdated and two jquery libs that are not used any more * Load scripts dynamically that are not needed globally * Move plugin JS to frontend * Move toggable fieldsets to global listeners * Move top-menu to global listeners and convert to TS * Move action_menu to frontend and port to TS * Move settings listener to frontend * Remove global js assets that were not used anyway * Move date range to timelog dynamic script where it's still used until removed * Move colors to global-listeners and port to TS * Replace tooltip with simple form instructions on the one place used Tooltips were only used at the one place in our application, when changing a users password. We can simply remove it there and use a modern solution the next time we need a tooltip * Move danger zone validation to frontend and port to TS * Move colorcontrast to backlogs vendor where it's used now * Remove contents of application.js.erb * Move project and user scripts to dynamically loaded * Move onboarding tour to dynamically loaded * Use correct syntax for jQuery so that $ is known keyword within this function * Fix onboarding tour * Fix onboarding tour for scrum tour * Fix specs after moving JS * Remove application.js.erb * Move locales and ckeditor to the frontend to dynamically load * Remove bundles caches These are no longer being used since angular cli * Ensure locales are exported before angular Co-authored-by: Henriette Darge <h.darge@openproject.com>	4 years ago
Oliver Günther	82d32f78d2	Add extract-css option Extract-css will result in a separate CSS bundle to be loaded	4 years ago
Henriette Darge	37e653d881	Remove bourbon gem and load fonts manually instead. Further use correct variable definitions	4 years ago
Henriette Darge	b3dd61946e	[32880] Display scheduling mode in work package view (full, split & table) (#8410 ) * Show icon next to start date depending on the scheduling mode * Show modal when opening date edit fields which shall be able to change the dates and the scheduling mode * Introduce flatpickr as a datepicker for the modal of the dateEditField * Use new datepicker within opDatePickerComponent * Reuse existing Datepicker class for better code abstraction * Set dates only when Instance is ready * Let augmentedDatePicker use generic DatePicker class, too. * Remove jQuery UI datepicker specific styles as they do not apply any more. * Use localized strings in new datepicker * Close datepicker only on click outside * Allow single and multi selection of dates and save changes * Update schedulingMode button correctly && remove unused method * Show combined field for start and end date within the WP single view * Show normal datepicker for most date fields and the modal with the extended datepicker only for startDate * Add datepicker edit field and component helper * Correctly save start and end date * Show correct default value for dateEditFields && Adapt some tests to new datepicker and combined date field * Fix date editor spec * Fix expecting datepicker for start/due date as milestone * Prevent overflow on body by using modal-portal class && make edit input for combinedDates visible again to show something in a create form * Only output one debounced change event for op datepicker * Show combined datepickerModal for dueDate in table, too && save correct scheduling value * Hide modal if the showing component gets destroyed * Correctly check for closed datepicker * Add spec for toggling scheduling mode * Fix setting dates to modal * Avoid too many (unnecessary) close events and use keydown instead * Fix date setting and add custom field date spec * Change layout of combined date picker modal * Switch from a range date picker to a multiple selection in order to be able to set only start or due date && Highlight date field that is changed next * Highlight range manually * Highlight dueDate initially when the user clicked on the due date field && handle special case that one of the values is not set yet. In this case we don't want to keep both values but only the newly clicked. * Move helper functions to own class && Improve the range selection to be able highlight ranges over multiple months && Prevent that a start date > due date can be chosen by setting minDate and maxDate * Adapt test to new way of changing the scheduling mode * Handle case that the user clicks on a already selected date and thus deselects it Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Wieland Lindenthal	07c3eb2640	Bump Xeokit BIM viewer to 1.7.95 and SDK to 1.2.1	4 years ago
ulferts	7763cb5b5c	run npm audit fix	4 years ago
Wieland Lindenthal	5fc190b40e	update xeokit bim viewer and xeokit sdk	4 years ago
ulferts	995cde02c7	run `npm audit fix`	5 years ago
bsatarnejad	de3da86ee2	update package.json	5 years ago
Wieland Lindenthal	e9371af978	Bump Xeokit Bim Viewer to 1.7.83 and SDK to 0.9.98 (#8350 ) * Bump xeokit-bim-viewer to 1.7.83 and SDK to 0.9.98 * Show pivoting point in IFC viewer	5 years ago
Henriette Dinger	9478ee7df5	Bump ngSelect to version 4.0.0	5 years ago
Wieland Lindenthal	f9730e10ed	Bump Xeokit Bim Viewer to 0.9.94 and SDK to 1.7.6	5 years ago
Wieland Lindenthal	755b6cb365	Bump xeokit viewer to 1.7.5 and SDK to 0.9.92	5 years ago
Oliver Günther	28e6476935	Bump angular to 9.1.0	5 years ago
ulferts	924bf91019	run npm audit fix	5 years ago
Oliver Günther	e725fda677	Bump xeokit viewer	5 years ago
Oliver Günther	1686a63dc0	Bump viewer again to fix	5 years ago
Wieland Lindenthal	6fe6f2504e	Bump xeokit to viewer 1.6.9 and SDK 0.9.3	5 years ago
Wieland Lindenthal	2ec0b8218e	Don't block whole screen when loading models Update Xeokit viewer to 1.6.8 and SDK to 0.9.0	5 years ago
Oliver Günther	81e8e7ab2a	Revert "Xeokit updates"	5 years ago
Wieland Lindenthal	6271f6caa5	Bump xeokit to viewer 1.6.9 and SDK 0.9.2	5 years ago
Oliver Günther	85e9c35a9c	Introduce base mixin for observing until component destroyed Ivy introduces changes that break the previous version of `untilComponentDestroyed(this)` for when a base class is involved. To mitigate this, we need to use the following pattern from now on: - Extend the class from our helper class `UntilDestroyedMixin` - Call super() in the constructor - Replace `untilComponentDestroyed(this)` with `this.untilDestroyed()` - Remove empty `ngOnDestroy` functions, as they are defined in the mixin - If ngOnDestroy is not empty, make sure you call `super.ngOnDestroy()` - You no longer have to use `implements OnDestroy` in these components	5 years ago
Wieland Lindenthal	1047639a44	Don't block whole screen when loading models Update Xeokit viewer to 1.6.8 and SDK to 0.9.0	5 years ago
Oliver Günther	bef21b1ae9	Show notifications and move to last shown index	5 years ago
Oliver Günther	f6a8544e33	Use special es2015 browserlist for frontend	5 years ago
Oliver Günther	5fc0e6e7bb	Bump fullcalendar/integration	5 years ago
Oliver Günther	f0d6faa223	Provide access to service directly from path helper [ci skip]	5 years ago
Oliver Günther	5c3be42fa8	Build frontend API resources for BCF topics	5 years ago

1 2 3 4 5 ...

345 Commits (b95f24a8dbde4ff1ae929a48b2b77c9c2c89cba6)