openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
ulferts	cc4ed56e2a	use AR`s scope method instead of singleton class method (#8976 ) * use AR`s scope method instead of singleton class method By using the scope method, all of Rails` checks and method definition usually done on a method are now also performed on the extracted scope methods `5f3ff60084/activerecord/lib/active_record/scoping/named.rb (L154-L190)` * turn scope classes into modules	4 years ago
Wieland Lindenthal	efbd3e9b41	Placeholder user backend (#8935 ) * Add missing copyright note to AnonymousUser [ci skip] * Addin PlaceholderUser model and its associations * Ensure PlaceholderUser do not "leak out" uncontrolled * Extract Associations for User and PlaceholderUser. - remove obsolete #assigned_issues - remove obsoete #:responsible_for_issues - add specs and factory for PlaceholderUser Adding specs to PlaceholderModel * Migration: enforce uniqueness of lastname for Group and PlaceholderUser * Remove obsolete callback `after_add` on groups association. The association of principals and groups still had a callback `after_add` that called a method `user_added` on the group. That method was not defined anymore as it was removed in commit `d93ff52a27`. * Move validation for #groupname to the right spec. * Cleanup placeholder and group specs * Remove Setting `workpackage_group_assignment` * Refactoring: Extract assignable scope from Project to Member * Refactor: Add Member scope not_locked. * deprecate hacky scope * remove wp_group_assignment specific test case Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	7f34799a33	Chore/reimplement global roles (#8730 ) * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter	4 years ago
ulferts	e2961fba14	replaces reform & custom error handling Replaces reform by a simple layer of Disposable + ActiveModel::Validations for contracts. Additionally removes the custom error handling where OpenProject added symbols to keep the ability to identify faulty attributes while having non standard format (deviates from `%{attribute} %{message}`). Changes to active record now allow us to define the format of a message on i18n level, e.g. `%{message}`. Therefore the patching can be removed. Reform plans to remove support for ActiveModel::Validations in version 4.0 at the latest but even today, support for it is hapazard. As we do not need the full stack of Reform anyway, we can solely rely on Disposable.	4 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230 ) Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Oliver Günther	70bc14625d	Fix unwatch_from_permission_change when project nil https://sentry.openproject.com/share/issue/a58124f215d04e139b4a4336e6fa3a16/	5 years ago
ulferts	a93ecca5a8	Feature/members api show (#7308 ) * basic members collection response * complete member index end point * document versions#index * remove user association from members There is already a more generic principals association. Having both causes confusion and leads to duplicate loading of models * linting * remove disabled test * add members#show api end point * add project and principal to member representer * replace member.user reference with principal * use principal reference in project members association * modernize roles api * complete member representer rendering * replace remnants of user association * add member schema api endpoint * have dedicated available projects end point for versions * linting * limit roles to assignable ones in schema * rename member to membership in api * remove remnants of user in member * spec fixes * use available_projects endpoint in versions board * add eager loading to memberships#index * members create form api endpoint * ensure role exists for default assignment * extract switch for users/groups to work_packages representer * document membership create form * add l10n expected in specs * strengthen the usage of a delete base service * use base class for set attributes service * fix alias in service * add create endpoint to members api * document members create endpoint * linting * adapt to altered service signature * use default endpoint for wp#get * use CF infused representer [ci skip]	6 years ago
Jens Ulferts	ac59ad6a89	introduce group resource stub	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Oliver Günther	dae84cffb0	Extract editing member into a separate service Would have liked to use the contract here to validate the role_ids before they're being written to attributes, but that doesn't seem to work.	7 years ago
Oliver Günther	b2b499a7fd	[25686] Use collection_check_box in membership page This adds a hidden field for when no checkbox is selected, however it adds the caveat that non-selected values are transmitted as empty values, thus we have to filter them again in the backend.	7 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	8c364aff89	optimize watcher pruning on group modifications Less db queries when * removing a member from a group * removing a group from a project * removing a group Mostly this is done by * adding eager load statements where neessary * pruning watchers only once Please note, that the last is only possible via hack which consists of passing a flag which prevents calling prune when we already know that the pruning will take place later on anyway.	8 years ago
Jens Ulferts	3246747ae0	adapt to newly introduced query	8 years ago
Markus Kahl	d2bc4202ad	make group deletion fast	9 years ago
Mohamed Wael Khobalatte	972b04d86e	Refactor to allow for strong params We no longer need attr_accessible.	9 years ago
Oliver Günther	319c728b1a	Core notifications to alleviate third-party plugins This commit provides some helpers to alleviate SCM vendor plugins: * Provide code notifications when project, members and users are changed. * Allow Repository:* to determine base URL themselves (when no common URL is available) * Open Git adapter for subclassing (Gitolite)	9 years ago
Markus Kahl	86248f400e	groups are never disposable	9 years ago
Markus Kahl	3738329078	delete invited users when removed from project	9 years ago
Markus Kahl	df36876d21	User ⊆ Principal ∧ Principal ⊄ User I.e. calling Member#principal will always work. On the other hand calling #user will fail if the member is a group.	9 years ago
Alex Coles	b2790b8db1	Migrate deprecated .update_all with conditions Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	df51b6ed99	Fix syntax (w/Rubocop) in (Rails) models Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 [ci skip]	10 years ago
Alex Coles	1d1ec0ef37	Prefer #map over #collect in (Rails) models Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	6fe9535b1f	Fix syntax (w/Rubocop) in (Rails) models Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	721101ed25	Use 1.9+ Hash syntax in (Rails) models Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Ion Biziiac	2a1695ffaf	Add the method to_s in the Member model	10 years ago
Alex Coles	d872d91d0d	Fix typos, spelling in model comments Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Johannes Wollert	8b096975fe	updates copyright headers updates more copyright more copyright headers	11 years ago
Johannes Wollert	d6d0661ca2	render prettier errors when trying to add a member without roles/principals	11 years ago
Markus Kahl	f7355c1820	include ForbiddenAttributeProtection in correct file (model instead of controller)	11 years ago
Markus Kahl	0fca8ddf31	use strong params instead of attr_protected in member	11 years ago
Hagen Schink	1cb831877b	Renames issue category to category	11 years ago
Philipp Tessenow	a1e67dd460	new copyright header #1903	11 years ago
Michael Frister	cd8859b16a	Refactor member role management Rename methods so they make clear whether they save and/or potentially destroy a member.	11 years ago
Michael Frister	3ffbec5309	Add tests for added Member role methods Might not all work	11 years ago
Michael Frister	a66ccfb0f2	Refactor Member and MemberRole: Disallow Member.destroy MemberRoles can't be destroyed by themselves anymore, but Member must be asked to do this. This allows Member to have control over validating that each Member has at least one MemberRole and over deleting the Member itself when no MemberRole is left. An ugly piece of code makes MemberRole.destroy raise an Exception when something tries to call it. This should prevent people from accidentally using it.	11 years ago
Michael Frister	4bddfe5263	MembersController: Fix Member being destroyed when editing roles When removing all existing roles and adding a new role, the member was destroyed before the new roles could be added. This might be the result from a change in rails: `c2362461cd`	11 years ago
Philipp Tessenow	0ca9fcd4e7	fix member role_empty validation because add_on_empty was used, it failed to invalidate the member object if there all roles are marked for deletion (but are still present)	11 years ago
Jens Ulferts	21459a384f	provide every possible file with a short copyright notice This was done using the rake task: rake copyright:update	12 years ago
Christian Rijke	1b997cd7ee	bug fix: removing a user from a group should also delete project memberships if the user has no own roles left in the project.	12 years ago
Martin Linkhorst	94c6527976	there's no attribute called role	12 years ago
Martin Linkhorst	71fe49e862	DEPRECATION FIX: use validate :method_name instead of overwriting the validate method	12 years ago
Martin Linkhorst	40562c0c08	DEPRECATION FIX: use before_destroy :method_name instead of overwriting the before_destroy method	12 years ago
Romano Licker	d9069356e1	display errors correctly when adding a member to a project - when nothing is selected - when a user is missing - when a role is missing	13 years ago
Romano Licker	01f8886a63	fixes: couldn't switch roles on a user & ensure correct error handling the remove_member_if_empty callback was executed deleting the member entirely it should not be possible to remove all roles from a member thus we can remove the callback for good the ui now prevents the user from setting no role (raises an error) if he wants to delete a member he can use the delete button which is much more intuitive.	13 years ago
Jens Ulferts	3511600c0a	adjust members_controller to work with the protected attributes * member received autosave option so that changes can be saved in a single transaction	13 years ago

1 2

76 Commits (b9b249aa2fa131f14ab3bb2be105fefd402002fd)