openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	7ecf08e005	rework changed_by_system (#9043 ) Before, it was implemented by passing the changed attribut keys over to the contract to whitelist them. This lead to: * The contract interface becoming bloated * Having to rely on the knowledge of the developer not to falsely whitelist an attribute. The developer would also have to make sure to not perform a mass assignment after the attribute has been whitelisted The new approach it to integrate the behaviour into the model which is first altered in the service before it is scrutinized in the contract. The information about the changed attributes is now stored inside the model which removes the necessity to flag the whitelisted attribute separately. Additionally, the exact change is tracked. So if an attribute is set to one value inside a whitelisted block there is no risk in later on performing a mass assignment. This comes at the cost of extending the models which is weird also it is build into the default SetAttributesService so child classes do not have to worry. One might include the module into every AR model but currently we only need it for a very specific use case.	4 years ago
Oliver Günther	34f8e9dff8	Validate admin guard for all settings writers (#9012 ) * Validate admin guard for all settings writers * Add spec to test access to all links under admin * Fix broken specs * Keep only UpdateContract and add spec * Move admin settings under their own namespace for clarity Move all admin related settings under ::Admin::SettingsController * Fix more paths and views for settings Adds another spec to ensure all links in admin can be viewed by admin * Fix wrongly changed settings path for repositories page * Use plugin name for plugin settings	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	ae2edad19b	Fix/copy project wiki notifications (#8777 ) * rename to convey applicability to all journal notifications * adapt journal completed job to handle wiki content * remove empty module * create wiki_content mail service * introduce copy/create service and contract for wiki pages * specify set attributes and create contract for wiki pages * copy the content attributes * use wiki page create service when copying wiki * introduce specifc service for copying wiki pages The contract disables checks for permissions on the wiki page. The copy_projects permission should suffice to copy everthing in a project * copy wiki pages top down to rewrite hierarchy * limit copied attachments to copied type	4 years ago
ulferts	9e2287bfcc	rename and inflect according to zeitwerk	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	4eab6effe1	merge changed_by_system into contract options	5 years ago
ulferts	3dabb46dd9	allow copying projects without parent project reference	5 years ago
ulferts	57f7da4f39	reuse project services in controller	5 years ago
Oliver Günther	aa9897561b	[28455] Ensure model contracts are initiaited immediately before saving	6 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
ulferts	2f9d7f408a	Fix/wp table switch to milestone (#5825 ) * map date name in changeset * handle date switch in wp form * Don't stub_const for services that may exist before hand This will cause the const to be evaluated already, so that stub_const has no effect there. This is why this fails depending on the order on travis, but not locally/isolated. [ci skip]	7 years ago
Jens Ulferts	3c6a93283b	simple code prettifications	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	2f14b793b5	extract contract related methods of service into concern	9 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 [ci skip]	10 years ago
Alex Coles	45297523c2	Fix syntax (w/Rubocop) in lib code Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Johannes Wollert	8b096975fe	updates copyright headers updates more copyright more copyright headers	11 years ago
Philipp Tessenow	a1e67dd460	new copyright header #1903	11 years ago
Christian Ratz	a2e69908e1	Changeable footer - adds OpenProject::Footer object - added small padding right for footer	12 years ago
Jens Ulferts	21459a384f	provide every possible file with a short copyright notice This was done using the rake task: rake copyright:update	12 years ago
Holger Just	91070236db	Set source encoding to UTF-8	13 years ago
Holger Just	07185fb169	[#436 ] Remove trailing whitespace	14 years ago
Eric Davis	99507a0391	[#197 ] Upgrade the copyright in the code files	14 years ago
Eric Davis	e131c3b531	[#197 ] Remove old copyrights	14 years ago
Jean-Philippe Lang	116091a1d2	Fixes platform determination under JRuby (#1804 ). git-svn-id: http://redmine.rubyforge.org/svn/trunk@1753 e93f8b46-1217-0410-a6f0-8f06a7374b81	16 years ago
Jean-Philippe Lang	0153954ebb	Added a simple rake task to fetch changesets from the repositories: rake redmine:fetch_changesets git-svn-id: http://redmine.rubyforge.org/svn/trunk@1155 e93f8b46-1217-0410-a6f0-8f06a7374b81	17 years ago
Jean-Philippe Lang	027bf93849	added svn:eol-style native property on /app files git-svn-id: http://redmine.rubyforge.org/svn/trunk@333 e93f8b46-1217-0410-a6f0-8f06a7374b81	18 years ago
Jean-Philippe Lang	96f83cc8f0	trunk moved from /trunk/redmine to /trunk git-svn-id: http://redmine.rubyforge.org/svn/trunk@67 e93f8b46-1217-0410-a6f0-8f06a7374b81	18 years ago
Jean-Philippe Lang	310a0f924a	0.3 unstable git-svn-id: http://redmine.rubyforge.org/svn/trunk@12 e93f8b46-1217-0410-a6f0-8f06a7374b81	19 years ago
Jean-Philippe Lang	6b7650e2f0	Initial commit git-svn-id: http://redmine.rubyforge.org/svn/trunk@4 e93f8b46-1217-0410-a6f0-8f06a7374b81	19 years ago

15 Commits (b9b249aa2fa131f14ab3bb2be105fefd402002fd)