openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	ca599f15c6	[38325] Using existing gem for email validations Our email validation is too strict for RFC compliant emails. Instead of trying to do it ourselves (email validation regexps are hard!), let's just use a gem to do that for us. Note: The gem also has a strict mode that could be optionally enabled. This however results in some emails on community to become invalid. I left it on the default mode for now. https://community.openproject.org/work_packages/38325	3 years ago
Oliver Günther	ccfa29c728	Move license and copyright docs to root, fix names and references	3 years ago
Oliver Günther	b8bb7546b0	[38706] Make login lookups in auth source sso case-insensitive https://community.openproject.org/work_packages/38706	3 years ago
ulferts	63ad2e8dd1	Generate IAN near real time (#9570 ) * destroy notifications upon journal destruction * breakup spec by journable * have a dedicated job for scheduling journal completed events * generate notifications in delayed job * route wiki journal events through notifications * combine mail sending for notifications into single job * robustness if a journal is deleted * linting * differentiate BaseJournal and AssociatedJournal BaseJournal holds the data of a journal that reflects the columns in the journaled model while AssociatedJournal reflects the columns of a model associated to the journaled model via a has_many/one association * route news journal events through notifications This does not yet include notifications for comments on news * include news comment in notification workflow * have the whole workflow in a single state machine job * include forum message in notification workflow * include document in notification workflow * less dependencies from acts as watchable * fix, test and document workflow job	3 years ago
Oliver Günther	83253981d2	[38325] Using existing gem for email validations Our email validation is too strict for RFC compliant emails. Instead of trying to do it ourselves (email validation regexps are hard!), let's just use a gem to do that for us. Note: The gem also has a strict mode that could be optionally enabled. This however results in some emails on community to become invalid. I left it on the default mode for now. https://community.openproject.org/work_packages/38325	3 years ago
Oliver Günther	4fa5e38c3d	[34901] Set timezone when switching to user The meeting mailer uses `format_time` helper which only works for User.current, but then also uses `Time.zone` which is set only when using `with_locale_for`. We need to rework both, but as a workaround, we can set the locale for the user when switching to it. https://community.openproject.org/work_packages/34901	3 years ago
Oliver Günther	9636a08988	[26688] In-app notifications (#9399 ) * Add bell icon to icon font * Add in app notification in top menu * Add fullscreen modal * Add notification modal and items * Style items * Toggle details of item * Mark all read * Add no results box * wip specification for event api * Add events table, query and index * Send out events from WP notification mailer job There we have the recipients present * Add cleanup job for older events with a setting * Hide bell notification when not logged * Add specs for events API index/show * Fix setting yml key * remove pry in event creation * Fix before hook in events API to after_validation * Fix polymorphic association raising exception for aggregated journals * Fix typo in read_ian * Fix yml entry for mentioned * Add read/unread post actions to event API and add specs * Wire up API to frontend * Fix order on events * Switch to unread in notification * Add event query * rename WPEventService * route wp mail sending over events * rename spec methods * author becomes watcher * correct message call signature * rename events to notifications * renname parameter to reflect notification nature * create author watcher for existing work packages * Merge unreadCount from store * Take a stab at polymorphic representers * Fix link generation in polymorphic resources For journals, no title is being generated however * Fix frontend model for context * Use timer for polling * add notification_setting data layer * Fix show resource spec * Fix duplicate class in notification bell item * Add minimal feature spec for notification * API for notification settings * Persist notifications * adapt work package notification creation to notification settings * extract notified_on_all * consolidate wp#recipients * concentrate wp notification in journal service * simplify methods * Remove unused patch endpoint * Add specs for rendering and parsing notification settings * Contract spec * Update service spec * adapt specs * Angular notifications frontend commit `e29dced646` Author: Wieland Lindenthal <w.lindenthal@forkmerge.com> Date: Mon Jun 21 17:34:50 2021 +0200 Create Akita store and query for notification settings commit `1a45c26c1a` Author: Wieland Lindenthal <w.lindenthal@forkmerge.com> Date: Mon Jun 21 11:09:25 2021 +0200 Remove tabs from notificaition settings page commit `0ea21e90c1` Author: Oliver Günther <mail@oliverguenther.de> Date: Sun Jun 20 21:55:48 2021 +0200 WIP in app settings * migrate notification data * add project visible filter to project query * Add inline-create and table display grouped by project * Add notifications under admin/users * Remove notifications partial * Rename notififcations store to user preferences store * Add setting for self_notified and hook that up to the backend * Add aria-label to table checkboxes * Restyle table and toolbar * replace remains of mail_notifications attribute * initialize notification settings for new user * adapt my_preferences references * reenable no self notified for documents * adapt specs * Avoid has_many :notifcation_settings Rails magically autosaves the user's preferences when the user gets saved, which somehow also tries to save the notfifications even when unchanged. This breaks some specs such as the avatar upload spec. As we can't update the assocation through rails anyway, just delegate to the user for reading instead. * Restore update method of notification settings * Restore update spec * fix spec syntax * lint scss * linting * Fix content_tag for bell icon * Add feature specs for notification settings * Disable ContentTag cop * use visible filter to get projects for notification The visible filter will reduce the project list down to the set of projects visible to the user provided as a parameter. This includes public projects. * test for actual mail sending * adapt me resource path this.apiV3Service.users.me changed its type in `0d6c0b6bc7` * Implement changed migration * Linting * Add actor to notification representer * Fix factory creating a duplicate WP journal * Add work packages loading and journal details to notification entry component * IAN basic facets, keep and expanded states. * Fix notification bell spec * Render body separately and add auto updating relative time * Add fixedTime title * Add actor to notification entry * Fix clicking links on work package and project * Tiny styling changes on entry row * Disable count in notification if larger than 99 (wont fit) * Introduce virtual scrolling to entry table * allow delaying & prevent mail sending if ain read Introduces a setting to delay mail sending after a journal aggregation time has expired. That way, users can confirm a notification in app. If they do before the delay expires, no mail is sent out additionally for that user. * consolidate notifications (in&out) into shared admin menu Co-authored-by: ulferts <jens.ulferts@googlemail.com> Co-authored-by: Wieland Lindenthal <w.lindenthal@forkmerge.com>	3 years ago
Oliver Günther	5920ace376	[37024] Make system user permanent admin (#9192 ) * [37024] Make system user permanent admin https://community.openproject.org/wp/37024 * Yield self from run_given * Fix count for admin in bim seeder	4 years ago
Oliver Günther	2d22930bdb	[36746] Unset plain password accessor after saving (#9157 ) * [36746] Unset plain password accessor after saving Otherwise, this password remains and is validated again due to "user.register!" which then fails with an exception https://community.openproject.org/wp/36746 * Don't try to use user.password after saving it now gets cleared * Remove user.password usage in specs The user password attribute is an accessor that now gets deleted after saving so tests can no longer depend on it being present after created from a Factory * Also retain user password in mail handler	4 years ago
Oliver Günther	f4dfd6c6c6	[36238] Extract and fix user references in other objects (#9007 ) * Move replacing invalid references into separate job for principals * Write migration to remove existing invalid custom values and responsible * Fix other specs * Fix other specs * rewrite replacing user in records * consolidate principal deletion * include placeholder users in spec Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Wieland Lindenthal	a18954b2c9	Placeholder user services and administration (#8944 ) * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
ulferts	cc4ed56e2a	use AR`s scope method instead of singleton class method (#8976 ) * use AR`s scope method instead of singleton class method By using the scope method, all of Rails` checks and method definition usually done on a method are now also performed on the extracted scope methods `5f3ff60084/activerecord/lib/active_record/scoping/named.rb (L154-L190)` * turn scope classes into modules	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961 ) * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
Oliver Günther	e4c9506e56	[36081] Increase max lengths of user/group names (#8948 ) * Unset DB limits for user attributes * Validate groups in synchronized groups * Extend limitations and fix specs	4 years ago
Wieland Lindenthal	efbd3e9b41	Placeholder user backend (#8935 ) * Add missing copyright note to AnonymousUser [ci skip] * Addin PlaceholderUser model and its associations * Ensure PlaceholderUser do not "leak out" uncontrolled * Extract Associations for User and PlaceholderUser. - remove obsolete #assigned_issues - remove obsoete #:responsible_for_issues - add specs and factory for PlaceholderUser Adding specs to PlaceholderModel * Migration: enforce uniqueness of lastname for Group and PlaceholderUser * Remove obsolete callback `after_add` on groups association. The association of principals and groups still had a callback `after_add` that called a method `user_added` on the group. That method was not defined anymore as it was removed in commit `d93ff52a27`. * Move validation for #groupname to the right spec. * Cleanup placeholder and group specs * Remove Setting `workpackage_group_assignment` * Refactoring: Extract assignable scope from Project to Member * Refactor: Add Member scope not_locked. * deprecate hacky scope * remove wp_group_assignment specific test case Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	6cce947cbd	Chore/rename timestamps (#8765 ) * rename timestamps on time entry * add updated_at filter/order for time entries * rename on cost entries as well This will make handling in the cost query easier * adapt specs * linting * adapt project activity * update references to updated_on * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter * remove outdated model file * rename timestamps * allow specifying timestamp column for aaj * reload column information * further rename of created_on * include updated_at into journal creation * adapt document updated_at calculation * remove references to JournalVersion	4 years ago
ulferts	3b0f7367fd	move to proper module	4 years ago
ulferts	c54e895ad4	lookup existing user for mapping case insensitive	4 years ago
ulferts	6826f90ee2	Feature/remove timelog (#8557 ) * rename costs, introduce budgets * move files from costs to budgets * rename cost_object to budget * remove unused code * move hook - should be turned into standard code in the long run * move type attributes change over to budgets * move patch to work_package proper * move budget menu item up * combine reporting, time and cost module * remove rails based time_entries & reports code * rename cost object filter * adapt menu spec expectations * use cost project module name in administration * include timeline labels in migration * properly place budget linking method * fix permitted params * remove outdated routing spec * adapt budget request specs * ensure order of descendent updates * remove outdated specs * fix checking for reporting to be enabled * fix displaying spent units * fix time entries activity event url * reenable current rate tab * fix path on budget page * allow bulk editing of budgets only in one project scenario * fix sanitizing reference in controller * include module required for format_date * fix reference to correct units from work package spent units * linting * remove outdated spec * remove outdated views and permission references * remove acts_as_event from time_entries There is no atom link for time entries * remove acts_as_event from projects There are no atom links for projects * introduce budget filter for cost reports * remove actions added to removed controller * move time entries to the costs module * factor in view_own permission when calculating time entry visibility * linting * move mounting of time entries * include budgets into api v3 documentation	4 years ago
ulferts	983709db89	rewrite acts as journalized to create journals in sql	5 years ago
Oliver Günther	273ae7e443	Add creation of users based on on-the-fly register [ci skip]	5 years ago
Oliver Günther	93577fb31d	[32748] Remove whitespace from login and mail https://community.openproject.com/wp/32748	5 years ago
ulferts	9e2287bfcc	rename and inflect according to zeitwerk	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	611462b03c	memoize anonymous in request store	5 years ago
Markus Kahl	9922cc1fe4	made deleted user locked; exclude builtin users from active_or_registered Because active_or_registered are users which are meant to be worked with in the system. We may want to rename this to something else.	5 years ago
Markus Kahl	ddb40187ba	added regression spec for active users and fixed anonymous user's status	5 years ago
Oliver Günther	51e8387e78	Remove builtin status [ci skip]	5 years ago
Oliver Günther	56a75602a6	[31609] Make system user active	5 years ago
ulferts	5ee801b549	cache roles for project	5 years ago
Henriette Dinger	9c2a920955	Correct group filter && and apply filters to userAutocompleter to search only for members who are not yet in the group	5 years ago
Oliver Günther	2fc4416601	Store User.current in current thread	5 years ago
ulferts	9c3206220b	remove mysql specific code throughout the application	5 years ago
Wieland Lindenthal	d703331001	Fix auto loading for SystemUser	6 years ago
Oliver Günther	67b3e575ce	[28036] Give admin all roles in a project https://community.openproject.com/wp/28036	6 years ago
Oliver Günther	5de0b9a2d8	Go through brakeman warnings	6 years ago
Henriette Dinger	ec7627e0e7	Add migration to remove impaired column from database	6 years ago
Oliver Günther	8d51fd5f92	Fix empty mail hitting find_by_mail with regex [ci skip]	6 years ago
Oliver Günther	e41d85e9c7	Implement OAuth applications CRUD	6 years ago
Oliver Günther	823acf2cae	[28828] Implement regexp-based suffix lookup for mail addresses Finds all users with the mail address matching the given mail Includes searching for suffixes from a new setting +Setting.mail_suffix_separtors+. For example: - With Setting.mail_suffix_separators = '+' - Will find 'foo+bar@example.org' with input of 'foo@example.org' - Will fall back to normal lookup if mail recipient already contains suffix character https://community.openproject.com/wp/28828	6 years ago
Oliver Günther	436beec32d	[28519] Fix hide-section in my page https://community.openproject.com/wp/28519	6 years ago
Oliver Günther	b08a5874f5	Remove project responsible and type	6 years ago
Oliver Günther	d4d15ac6cb	[28091] Fix project responsible and add spec https://community.openproject.com/wp/28091	6 years ago
Markus Kahl	45dc8bcd02	rebased and updated on ldap/omniauth fix	6 years ago
Markus Kahl	dad7e6b125	LDAP/OmniAuth on-the-fly registration user limits	6 years ago
Markus Kahl	57776c78ee	override user preference time zone as fallback instead of writing preference	7 years ago
Markus Kahl	56e9843b3c	user default time zone setting	7 years ago
Jens Ulferts	654ea4c041	linting	7 years ago

1 2 3 4 5 ...

352 Commits (bb2e2e6054b73433a9c3632a6f659c37227fad1b)