1489 Commits (bc32443428856165e83ce86ff8ac4063109e1ac9)

Author	SHA1	Message	Date
Oliver Günther	5d43198a88	Fix joining of integer values in escaped template ... This results in an internal error if trying to add multiple filter values. Let rails handle the escaping instead. [ci skip]	4 years ago
ulferts	e2961fba14	replaces reform & custom error handling ... Replaces reform by a simple layer of Disposable + ActiveModel::Validations for contracts. Additionally removes the custom error handling where OpenProject added symbols to keep the ability to identify faulty attributes while having non standard format (deviates from `%{attribute} %{message}`). Changes to active record now allow us to define the format of a message on i18n level, e.g. `%{message}`. Therefore the patching can be removed. Reform plans to remove support for ActiveModel::Validations in version 4.0 at the latest but even today, support for it is hapazard. As we do not need the full stack of Reform anyway, we can solely rely on Disposable.	4 years ago
ulferts	7e7b9132e3	Fix/child scheduling restrictions (#8584) ... * allow free scheduling children of manualy scheduled parents If a parent has a follows relations with another work package, that relationship also limites children of the work package. But if the work package is scheduled manually, this creates a scheduling barrier. Children of a manually scheduled work package are not hampered by the follows relationships of the parent or other ancestors. * simplify soonest_start query * eager load * extract to scope	4 years ago
ulferts	38d2707946	Fix/wp sums in db (#8580) ... * remove apparently unused methods * have specs for wp query sums * grouped sums in sql * sql for total sums * alter interface of all_grouped_sums Since we now fetch all sums in one sql statement it no longer makes sense to fetch the group sums individually * remove now unused method * extract method * Add material_costs to summing * add labor_costs to group sums * add overall costs to sum * fix sum grouping descision * fix summable? check * remove work_package_list_summable_columns setting Now all summable columns are always summed. The user no longer needs to select summing up in the settings. Selecting the column to be displayed and activiating sums will suffice * fix flickering spec	4 years ago
ulferts	6826f90ee2	Feature/remove timelog (#8557) ... * rename costs, introduce budgets * move files from costs to budgets * rename cost_object to budget * remove unused code * move hook - should be turned into standard code in the long run * move type attributes change over to budgets * move patch to work_package proper * move budget menu item up * combine reporting, time and cost module * remove rails based time_entries & reports code * rename cost object filter * adapt menu spec expectations * use cost project module name in administration * include timeline labels in migration * properly place budget linking method * fix permitted params * remove outdated routing spec * adapt budget request specs * ensure order of descendent updates * remove outdated specs * fix checking for reporting to be enabled * fix displaying spent units * fix time entries activity event url * reenable current rate tab * fix path on budget page * allow bulk editing of budgets only in one project scenario * fix sanitizing reference in controller * include module required for format_date * fix reference to correct units from work package spent units * linting * remove outdated spec * remove outdated views and permission references * remove acts_as_event from time_entries There is no atom link for time entries * remove acts_as_event from projects There are no atom links for projects * introduce budget filter for cost reports * remove actions added to removed controller * move time entries to the costs module * factor in view_own permission when calculating time entry visibility * linting * move mounting of time entries * include budgets into api v3 documentation	4 years ago
Markus Kahl	c1b82bad00	direct uploads to S3 for attachments including IFC models ... Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	655f021b92	add derived dates to the work package resource ... The derived dates are the minimum/maximum of the descendant's dates. As long as the work package is scheduled automatically, the derived and non derived dates should be equal althoug the derived dates will be null in case non descendants exists. But if the user decides to activate manual scheduling the dates can deviate. The derived dates can then help to display the deviation to the user. This commit however does not alter the front end. The dates are eager loaded on the work package index commit using the same mechanims already introduced for spent time. The patched cost attributes, which are also eager loaded, are now eager loaded in the core as well so the patch is removed. As those attributes are now part of the core (although in a different module) it no longer makes sense to rely on patching for this.	4 years ago
bsatarnejad	1fbc75b96d	writing a test for estimated-hours filter with none and zero values	4 years ago
bsatarnejad	5f0b48617c	writing a test for estimated-hours filter with none and zero values	4 years ago
ulferts	829648e1ad	remove operators not applicable to only subprojects filter ... The none operator does not make sense as it means that no work package will be returned. And the all operator will be the same as not having the filter at all. There is a minor change in the UI in this change in that the order of the opertors of the subproject filter is altered. But this should not be a problem for the user and leads to a simpler implementation.	4 years ago
ulferts	3a3a48e267	journalize changes to the scheduling mode	4 years ago
ulferts	7065c162fd	disregard manually scheduled nodes when scheduling work package graphs ... Instead of fetching all work packages from a subset of the whole graph constructed by hierarchy and follows relationships upon scheduling, only work packages eligible for automatic rescheduling are returned. In order to avoid quering the database multiple times, the whole subgraph is returned at once using a recursive CTE.	4 years ago
Oliver Günther	2fed3ee301	Add filter to select only (non-) milestones	4 years ago
Oliver Günther	b1a99353e2	Extend attribute help text for projects and allow images ... Attribute help text so far could only be added to work packages. This commit adds support for projects and adds the help texts to widget headers for status and description modals in the overview tab as well as extending the attachable mixin to allow uploading images. Uploaded attachments are to be expected to be visible regardless of permissions, thus this also adds an option to make attachments visible to all	4 years ago
Oliver Günther	95d1549858	Move legacy project copy spec to service spec	4 years ago
Oliver Günther	62d76b32c7	Fix specs	4 years ago
Oliver Günther	154afc3c7f	Restore custom style rendering with css variables ... Uses the css variables to set the default values instead of using the previously ruby-defined variables	4 years ago
Henriette Darge	b7ab9483ed	Remove too much spaces from the project name before saving it. Otherwise the spaces will cause problems later, e.g when trying to delete the project	4 years ago
ulferts	e20910a2c9	remove unused service ... The last call to the `reschedule_after` method was removed in #690e0ffc60.	4 years ago
Markus Kahl	3f13bc5fef	enforce token domain	5 years ago
ulferts	983709db89	rewrite acts as journalized to create journals in sql	5 years ago
ulferts	abac033cd4	adds the `not equals` operator to subprojects	5 years ago
Oliver Günther	70348e2e1e	Allow to override path to the CA used by LDAP connections	5 years ago
ulferts	7d82fea80e	avoid fixtures in seeding spec	5 years ago
ulferts	79409370ee	ensure thread safety of journal notifications	5 years ago
ulferts	1773a89c5e	return true to signal success	5 years ago
ulferts	a6689a9006	let first notification setting dominate child setting	5 years ago
ulferts	2ed7a69943	rely on caller to reset the journal notification setting ... By forcing the caller to disable mail sending via a block, we can also ensure that the value is reset. But by it, we can allso allow disabling mail sending for multiple save_hook runs which was not possible before.	5 years ago
ulferts	67ade5002d	extract journal notification setting to separate class	5 years ago
Oliver Günther	dab04415c4	Fix indentation from editorconfig	5 years ago
Oliver Günther	80e747e0c6	Fix test by calling service with system user ... Adds this to the factory to avoid using the system user all over the place	5 years ago
Oliver Günther	e4dcc6c5ea	Avoid usage of `users <<` pattern in group ... This will no longer trigger the addition	5 years ago
Oliver Günther	a8c6e45a92	Add LDAP auth source filter functionality	5 years ago
ulferts	cf735714d3	order independent contains operator (#8315) ... * order independent contains operator This for example affects the search which relies on the subject filter with the contains operator being active. * remove legacy query spec The query is generally covered rather well in the new specs. [ci skip]	5 years ago
ulferts	e5749d9817	order independent contains operator (#8315) ... * order independent contains operator This for example affects the search which relies on the subject filter with the contains operator being active. * remove legacy query spec The query is generally covered rather well in the new specs. [ci skip]	5 years ago
ulferts	973ebd1fac	replace legacy specs	5 years ago
ulferts	64d0f57d85	Feature/aggregated activities (#8221) ... * use cte for aggregated journal * Revert "use cte for aggregated journal" This reverts commit 5fedefefdd. * add another subselect that could later on be provided from the outside * allow passing a nukleous sql to aggregated journals * wip - using aggregated journal for activity * new sql for aggregated journals * start implementing new aggregated query * additional documentation * consolidate activity functionality * simplify by turing into instance methods * move activity fetcher out of redmine * remove verb verification made obsolete Without catchall routes, the dispatching handles it * remove duplicate authorize check * refactor activities controller * refactory activity fetcher * cache avatar file * sort choosable events * remove legacy spec covered by contemporary * speed up aggregated journals via CTE * instance var might never have been set * ensure the event_types are always transmitted * correctly reset the avatar cache * fix avatar fetcher expectation regarding wiki pages * adapt spec [ci skip]	5 years ago
ulferts	4cb0d0ff91	Feature/delayed bcf export (#8275) ... * delayed bcf export * remove unnecessary eager loading * Update rxjs polling statement with loading indicator * Avoid error handling due to JSON parsing * delay all wp list exports Co-authored-by: Oliver Günther <mail@oliverguenther.de> [ci skip]	5 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230) ... Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
ulferts	830451d9f9	remove unused changes module	5 years ago
Oliver Günther	308f901853	Remove superfluous test sql ... [ci skip]	5 years ago
Oliver Günther	977deb4782	[32808] Allow null handling in custom fields based on direction ... Due to the way the order statements are constructed, we cannot provide null handling from within `order_statements.rb`, since the direction is append behind it, and null handling in postgres needs to be behind the direction. Thus we can provide a null handling that is based on the direction only https://community.openproject.com/wp/32808	5 years ago
ulferts	0b15db3c9a	rename fixed_version to version	5 years ago
ulferts	185a4058f7	adapt version filter spec	5 years ago
ulferts	125d51c2b8	enable SortCriteria to handle sort bys Procs	5 years ago
ulferts	4002be7c58	adapt spec expectation	5 years ago
ulferts	d65cd0d211	reuse sql string	5 years ago
ulferts	95fd58cff7	replace order_by_date with order_by_semver_name	5 years ago
ulferts	9c78d48cea	allow args on scope method	5 years ago
ulferts	e7359bcd94	have scoped methods available in model class	5 years ago