2398 Commits (bc4fb9521734486f2c55a16b046fc04107a2185f)

Author	SHA1	Message	Date
Jan Sandbrink	1ff8f15fbd	explicitly define order of groups in PSQL ... Always remember kids: SQL databases do not guarantee an order if you don't ask for one! That is why PostgreSQL sometimes found a predecessor for an aggregated journal that was not supposed to have one: Based on internal decisions the order of rough groups was not ascending (as expected implicitly) and master and addition would switch places. ALWAYS SPECIFY AN ORDER IF YOU EXPECT ONE!	9 years ago
Jan Sandbrink	d8cfa271cd	try to improve readability of JournalManager ... - using useful names - using rubys awesome syntax to avoid nested list accesses (e.g. k[0][1])	9 years ago
Alexander Bach	3053d0f875	Add more positivity	9 years ago
Alexander Bach	281842bd28	Prevent duplicate notifications	9 years ago
Alexander Bach	6424ce2b13	Remove legacy module	9 years ago
Jan Sandbrink	a2b952f549	improve exception message on missing journable.id ... previously an invalid MySQL statement would have been indicated, which is correct but not very helpful. On PSQL this will also lead to a DB lockup (at least on environments known to me)	9 years ago
Jan Sandbrink	cefa25b189	fix predecessor implementation	9 years ago
Jan Sandbrink	563cb3c5c7	migrate APIv3 to aggregated journals ... - turns out agrgegated journals needed more features - turns out specs were incomplete and bogus	9 years ago
Jan Sandbrink	6a0ef38f5f	extract get_changes into own module	9 years ago
Oliver Günther	aec6593ca0	Provide functionality to override settings and views for checkout ... This commit provides the functionality required by the checkout plugin (and possibly others) to change certain attributes and extend views in the repositories settings scope.	9 years ago
Alexander Bach	dde4144889	Migrate deprecated naming	9 years ago
Alexander Bach	a3db107236	Extract recipients as method	9 years ago
Alexander Bach	5fea667954	Return recipients as users instead of mail addresses	9 years ago
Alexander Bach	cd1a3e4a7b	Improve method naming	9 years ago
Alexander Bach	36d8bf8e42	Extract guard clause	9 years ago
Alexander Bach	8c51577e37	Clear up method name	9 years ago
Alexander Bach	196b5e049e	Move comment	9 years ago
Alexander Bach	04f9f64980	Remove and fix additional send_notification	9 years ago
Alexander Bach	2bca02a6b4	Get rid of class variable	9 years ago
Jan Sandbrink	f65f9e3e2d	remove the AR portion of aggregated journals ... - this prohibits doing stupid things like saving aggregated journals - should make clear that aggregated journals are not real journals...	9 years ago
Alexander Bach	7fd2fd52bd	µ-style improvement	9 years ago
Alexander Bach	c771325d0b	Improve class naming	9 years ago
Alexander Bach	66b3978280	Move listener registration	9 years ago
Oliver Günther	c5b200d7a0	Review corrections ... - Remove repositories paths using project.id instead of `project_id` - Allow managed repositories to be unlinked in the instance (But doesn't remove repository directory). - Remove leftover settings partial	9 years ago
Jan Sandbrink	3a87b269fa	allow to fetch aggregated journals for a journable ... - this should be faster (or at least easier to optimize) than applying a WHERE to the whole scope - also starting to diverge from using classic ActiveRecord in aggregated journals	9 years ago
Oliver Günther	0284d11f21	Corrections from review ... - destroy_info: remove superfluous JS confirm dialog. - destroy_info: change notification type into severe warning - destroy_info: Remove delete button highlight and back button for consistency with styleguide. TODO: think of other ways to guide the user back (also applies to project destroy_info) - remove typo in 'repositories.errors.unauthorized' - empty repository: Render warning view (repositories/empty) instead of 500 exception notification. - revert reformat on code changed in rails4 branch. - create repository: Show managed flash part only when the repository is managed - delete repository: Show error when configuration no longer allows manageable (other ways tbd.) - repository controller: JS redirect wrapped inside format.js - repository settings: Select hidden when instance exists Specs: - Add routing spec for `get #destroy_info`	9 years ago
Oliver Günther	319bd21daf	Moved managed repository lifetime entirely to the model.	9 years ago
Oliver Günther	e1bdb41bcd	More complete specs wrt. coverage, cleanup	9 years ago
Oliver Günther	1e8c873544	Remove filesystem adapter ... This commit removes the entire FileSystem repository and adapter. It rids all specs (core and legacy) of remaining uses of this adpater and replaces it with a temporary subversion repository, where necessary. We also need to remove remaining filesystem instances from the database, otherwise users will receive errors when accessing said repositories on the Frontend. This does not destroy any data on filesystem, but database information on the repositories (remarks) are lost.	9 years ago
Oliver Günther	da27a552a1	Frontend extensions and build refactoring ... - switched to toggleable-attribute-groups to provide means for adding buttons in the attribute header (e.g., delete button). - added separate destroy_info page with different notifications for managed and linked repositories to ensure ramifications of removing physical repositories are communicated to the user. - Fixed several issues regarding scm_type selection and the building of repositories. Open questions still concern the question of acessing unsupported repositories (e.g., the soon-to-be-removed filesystem adapter). Acessing the class should will then throw an error, but we still have to allow users to remove the affected repository (somehow).	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. ... This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - **Configuration**: Currently replaces the existing options in `configuration.yml`. - **Implementation specifics**: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Oliver Günther	7ebac37c14	Repository Management - Refactoring and Preparation ... Related work package: [#20415](https://community.openproject.org/work_packages/20415). This is a combined refactoring and extraction effort of local SCM functionality for SVM, Git adapters in preparation for the explicit lifetime management of repositories in #20416 and implementation of (local) repository storage quota in #18393. This PR is still heavily WIP and for the time being, depends on the **legacy specs** for testing. To run the tests, execute the following steps: ~~~ rake test:scm:setup:all rake spec:legacy ~~~ I'm open for ideas on how we integrate scm adapters tests into current specs. --- - [x] Exchange `IO::Open` for `Open3` to avoid countless manual exitcode checks - [x] Extract local functionality in its own Module - [] Extend `LocalClient` module with links to create/delete services for #20415 - [x] Break down unbearable local parse routines (Hound will be over the place until fixed - but down from 260 to < 20) - [x] `entries` - [x] `revisions` - [] local repository factory - [] Specs - [] Fix / Modernize - [] More adapter-related specs	9 years ago
Jan Sandbrink	a8ab1024b5	clarify explanations ... typos, wording and stuff	9 years ago
Jan Sandbrink	5f06a8900d	better PSQL compatibility for aggregated journals	9 years ago
Jan Sandbrink	f02b32faad	override :initial? for AggregatedJournal ... the simple approach of looking at the version number does not work, because aggregated journals can have gaps in their versions (and there might be no version 1)	9 years ago
Jan Sandbrink	a5152e9875	use the actual setting for the aggregation time	9 years ago
Jan Sandbrink	88169a46de	expose id of "master" as notes_id ... - make spec assertions more detailed by comparing all the attributes	9 years ago
Jan Sandbrink	3c3b03bbcc	make SQL compliant for both MySQL and PSQL	9 years ago
Jan Sandbrink	405aa2d524	add PostgreSQL-compatible group numbering	9 years ago
Jan Sandbrink	3b7b0ec289	Enhance AggregatedJournals to correctly merge journals with notes ... Aggregation should now follow the rules previously defined for merging journals (see code comments). Jens (@ulferts) and I developed the SQL for this. I hope the explanatory comments make it a quite readable SQL experience.	9 years ago
Jan Sandbrink	ddbc8a4ba7	remove obsoleted helper	9 years ago
Jan Sandbrink	5ed1ff28c1	styling	9 years ago
Jan Sandbrink	885d8d734f	add basic spec for aggregated journals	9 years ago
Jan Sandbrink	ec720a0533	make aggregation capable for MySQL and PSQL ... - also give the time threshold a useful meaning (number of seconds)	9 years ago
Jan Sandbrink	d6533b100c	first spike for aggregatable journals	9 years ago
Alexander Bach	7e0c7c352e	Move event to fire after its sure that a journal will stay	9 years ago
Alexander Bach	0cf0468ebf	Add default value for send_notification	9 years ago
Alexander Bach	ee14628c09	Move send_notification to event origin	9 years ago
Alexander Bach	a5f4eb1e8b	First event-based draft ... Unifies Journal- and WorkPackageObserver Removes them as observers Makes new JournalListener more classy	9 years ago
Alexander Bach	c22ce53a7a	Add journal_created event	9 years ago