openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	0de11dffab	Unsafe anchor URL generation in text formatting	7 years ago
ulferts	58991c2b40	Fix/add missing types link to project representer (#6128 ) * add missing types link to project representer * fix rubocop violations [ci skip]	7 years ago
Oliver Günther	25b84e8270	Implement macro button for WP create (#6110 ) [ci skip]	7 years ago
Oliver Günther	8fa78e4b5a	Fix more specs	7 years ago
Oliver Günther	7dc9df3aee	Adapt specs to factory pattern	7 years ago
Jens Ulferts	690e0ffc60	wp create/update/destroy via services	7 years ago
Oliver Günther	0c44f7b501	Fix i18n spec	7 years ago
Oliver Günther	b9cd75e07e	Remove gravatar functionality from core [ci skip]	7 years ago
Jens Ulferts	6fdd122534	merge wp tree and relations into typed_dag Instead of having the tree/hierarchy information for work packages and the relations between the work packages separated into two tables all the information is now stored in the relations table. To support this, the typed_dag plugin is used. Notable changes: * relations_to and relations_from are swapped. relations_to has all relations that point to another work package (from_id = work_package.id) and relations_from contains all relations that lead to the work package from another one (to_id = work_package.id). This change is merely in the code. The db information is left untouched. * For follows/precedes to_id and from_id are swapped in the db. Because of that, "follows" is now the canonical name instead of "precedes". This is done so that hierarchy relations and follows relations point into the same direction which allows to easily detect cyclic relationships that would lead to infinit scheduling. * the columns `root_id`, `lft`, `rgt` do no longer exist in the wp table. * the column `relation_type` does no longer exist in the relations table. * For every type of relation a column (integer) does now exist in the relations table (e.g. hierarchy, block, follow) * Separate associations exist for every type of relation into two directions. E.g. Work packages following the current one can be accessed via `work_package.precedes`	7 years ago
Wieland Lindenthal	4e22681e78	User mentions feature (#5897 ) * Extend syntax for linking users via their ID * Allow login names for linking user profiles. * User require_relative for legacy tests * Add specs for login name based user links; Fixes other specs, too. * Notify mentioned users * Notify linked users; - require quotes for login names in user links as login names can contain spaces, dots that are typical word boundaries - Adding specs * For the decision who gets notified due to mentions only the visibility permissions of the recipient are relevant. * Rubucop satisfaction * Add autocomplete for user names to work pack package descriptions and activity - Uses API V3 Principals endpoint. - Extends API endpoint with name filter and name order. - Make it activate when user types an "@" or a "user#" - Still for work packages only. * Directly show a list of users after typing '@' and allow navigating list with cursor keys * Add an '@' before the rendered user link * Adopting spec as WP autocompleter now expects whitespace before hash sign * Adding spec for using user autocompleter * Introduce magic pageSize of 0 for maximum length * Add id filter for principals * Allow pagination for principals and protect from falling back to a too low default value * Fixing specs * fixing typo in spec * Add magic number 0 for user custom fields * Add a toParams method for ApiV3FilterBuilder * User ApiV3FilterBuilder in path helper service * Add test for mentions principals to path helper * WIP * Convert auto complete helper to TS [ci skip]	7 years ago
Oliver Günther	fc50bb72a1	[26237] Add configuration option for default comment order (#5896 ) https://community.openproject.com/wp/26237 https://community.openproject.com/wp/25932 [ci skip]	7 years ago
Oliver Günther	342a30f7eb	Make configuration hash indifferent (#5893 ) [ci skip]	7 years ago
Oliver Günther	26332c446b	[25739] Allow copying of attachments in wiki and work package (#5889 ) * [25739] Allow copying of attachments in wiki and work package https://community.openproject.com/wp/25739 * [25769] Fix duplicate wiki menu item On creation, a wiki always gets its default wiki menu item. we don't need that upon copying however, since the wiki menu items will be copied. [ci skip]	7 years ago
Oliver Günther	ddcf35f3f7	Fix invalid value_objects being passed to representer There are queries that seem to pass values not available in APIv3 path helper to the instance representer. ``` Original error: #<NoMethodError: undefined method `anonymous_user' for API::V3::Utilities::PathHelper::ApiV3Path:Class Did you mean? anonymous?> Stacktrace: /opt/openproject/lib/api/v3/queries/filters/query_filter_instance_representer.rb:82:in `block (2 levels) in <class:QueryFilterInstanceRepresenter>' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/relation/delegation.rb:38:in `map' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/relation/delegation.rb:38:in `map' /opt/openproject/lib/api/v3/queries/filters/query_filter_instance_representer.rb:80:in `block in <class:QueryFilterInstanceRepresenter>' ```	7 years ago
Oliver Günther	ed1a0c87de	[25999] Make timeline labels configurable https://community.openproject.com/wp/25999	7 years ago
ulferts	9c8f7f3ca1	read operations for time_entries via api v3 (#5776 ) * read operations for time_entries via api v3 Introduces the endpoints: * GET /api/v3/time_entries * GET /api/v3/time_entries/:id * GET /api/v3/time_entries/activities/:id The index action for time entries can be queried by the following filters: * project_id * user_id * work_package_id The implementation is exposing the database structure mostly one to one with the exception of some renaming and the hiding of the activities' complexity, where only the activity used systemwide is referenced regardless of whether a project specific override exists or not. * allow custom values for time entries [ci skip]	7 years ago
Markus Kahl	52d87ff81b	Feature/remote repos (#5796 ) * support working locally on remote repositories * refactoring * specs for remote git repos * do not use %x because it's unsafe * fixed spec (create new temp dir for repo) * allow both escaped and unescaped strings * code climate [ci skip]	7 years ago
ulferts	0c1c8d443a	don't use project as cache key if project is nil (#5806 ) [ci skip]	7 years ago
Oliver Günther	ab9a9baee7	[26002] Add date as writable when type is milestone (#5804 ) https://community.openproject.com/wp/26002 [ci skip]	7 years ago
Oliver Günther	162401d962	[25768] Parse/Output estimated hours with seconds precision Was truncated to minutes before. https://community.openproject.com/wp/25768	7 years ago
Wieland Lindenthal	e627081675	Resolve design variables to allow clearer placeholders for input fields	7 years ago
ulferts	75f501e897	Fix/custom field lacking options (#5768 ) * enforce having at least one custom option for a list cf Removes the hand written nested attributes handling by accept_nested_attributes_for. Removes the arbitrary boundary of having 500 custom options. * i18n for custom option mgmt [ci skip]	7 years ago
Oliver Günther	c71d473ce1	Fix form builder failing spec Caused by https://github.com/opf/openproject/pull/5765	7 years ago
ulferts	7154caec85	Fix/consolidate representers (#5732 ) * consolidate representers Minimizes the need for extensive payload representers by: * introducing the payload_representer module which removes all non writable propertyies from a representer * introducing the resource/resources/associated_resource/associated_ressources helper methods which provide a framework for having a representer suitable for parsing and rendering Additionally increases the importance of the contracts by using them to calculate the writeable attributes. * remove unused endpoint [ci skip]	7 years ago
Edward Betts	437bbd51bf	correct spelling mistakes (#5748 ) [ci skip]	7 years ago
Oliver Günther	9fabaaaf13	Show only attributes from the type attributes and status, project	7 years ago
Oliver Günther	ec6b856686	Add directive to show help text modal	7 years ago
Oliver Günther	57356059af	Create /help_texts endpoint	7 years ago
ulferts	7ad39ec35f	Fix/cache query representers (#5711 ) * cache various query representers json representation * sort by * columns * group by * filter instance schemas * fix custom option path [ci skip]	7 years ago
ulferts	835c18f91e	render empty href on invalid list cf (#5688 ) [ci skip]	7 years ago
Oliver Günther	aa386f994d	[25606] Saving query with nil group_by does not apply it (#5684 ) This was caused by the groupBy deserialization only applying when it is non-nil [ci skip]	7 years ago
ulferts	65c7db3120	avoid side effects on calls to attribute_groups (#5677 ) Without the deep_dup, the call to attribute_groups used to alter the type's attribute_groups deeply nested attribute_groups property. As a result, the second call to attribute_groups would be different from the first one. This became most apparent when rending the schema for a couple of work packages all sharing the same type. As the type was reused to render the schema, but the project might have changed, only the first schema for the type was accurate, while subsequent schemas for that type lacked attributes [ci skip]	7 years ago
ulferts	a100a13e6f	deal with wildcard in http accept language header (#5674 ) Having a * in the HTTP_ACCEPT_LANGUAGE header is valid, but OP did not deal with it correctly. On top of that, it accepted every input from that header and turned it into a regexp. [ci skip]	7 years ago
Oliver Günther	1d0b09fa5f	Merge release/7.1 into dev (#5667 ) * [25580] Remove Settings callbacks from avatar_helper `register_callbacks` will not work if its used to update a class-level variable. We might want to think about removing this entirely, however impermanent-memberships is still using it to update the database after a change. https://community.openproject.com/projects/openproject/work_packages/details/25580 * change toolbar button height (#5664) https://community.openproject.com/projects/openproject/work_packages/255 11/activity [ci skip] * Fix/relations drawing (#5663) * improved drawing of timeline relation lines * Improved relations data flow * Timeline relations: Load relations once the timeline becomes visible * - Fixed SwitchState failing test - Version bump ReactiveStates - cleanup [ci skip] * Set indention of breadcrumb for correct alignment * remove wiki icon for wiki submenu in main menu (#5665) [ci skip] * Add missing class * Fix table hierarchies previous values [ci skip]	7 years ago
Oliver Günther	0ae7d320e6	[25580] Remove Settings callbacks from avatar_helper `register_callbacks` will not work if its used to update a class-level variable. We might want to think about removing this entirely, however impermanent-memberships is still using it to update the database after a change. https://community.openproject.com/projects/openproject/work_packages/details/25580	7 years ago
Oliver Günther	507c2d26ea	Remove fromType, toType	7 years ago
ulferts	f4b36edccb	Feature/save zoom in query 7 1 (#5637 ) * Implement timeline zoom level as query enum * Implement query zoom handling in frontend Had to refactor: 1. The zoom level enum in the frontend cannot properly be matched to strings so I chose a separate type instead to map to the string retrieved from /sent to the query 2. The way query updates are done through the states. The previous implementation only worked for one single attribute state. For the timeline state, it does not make sense to split that into two, so I delegate to the state to handle checking and updating the query. * Extend feature spec for zoom saving * Refactor URLParamsHelper into TS service * Fix comparison in table query services * Remove reference to allowedValues [ci skip]	7 years ago
Oliver Günther	7d62d846a2	Implement relation columns as secondary render pass	7 years ago
Oliver Günther	f3df45cef4	Extend backend relations API with WP type information This saves the doubled frontend request just to find out which types work packages of a specific relation have. Since the connection between work package types and relation types are very close, we should always send them.	7 years ago
ulferts	55695ed756	adds query columns by relation type (#5625 ) [ci skip]	7 years ago
ulferts	cea23ce333	Fix/sort version filter options (#5630 ) * have version filter options ordered by name * Fixes filter options on global queries (returned types instead of versions) * Adds the name order to be available generally * code prettification [ci skip]	8 years ago
ulferts	20dd8a6e0a	Feature/work package id filter (#5614 ) * add filter for work packages by id to query * hide the id filter in front end As we do not yet have satisfying means to display the filter values for selection, we hide the filter and use it internally only [ci skip]	8 years ago
ulferts	ace7098eb3	add relations columns to query (#5606 ) * add relations columns to query * refactory query columns * rename QueryColumn to QueryColumn::Property QueryColumn is now only an abstract supertype [ci skip]	8 years ago
ulferts	41aea10480	fix user/version cf rendering in forms (#5610 ) [ci skip]	8 years ago
Oliver Günther	d6b8b92037	Implement query zoom handling in frontend Had to refactor: 1. The zoom level enum in the frontend cannot properly be matched to strings so I chose a separate type instead to map to the string retrieved from /sent to the query 2. The way query updates are done through the states. The previous implementation only worked for one single attribute state. For the timeline state, it does not make sense to split that into two, so I delegate to the state to handle checking and updating the query.	8 years ago
Oliver Günther	6b372acae6	Implement timeline zoom level as query enum	8 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465 ) * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
Oliver Günther	94234bd5ee	[25432] Correctly transmit hasDefault to frontend (#5603 ) The default value for CFs is '', which is obviously not nil despite not being a default, however the frontend only _always_ shows the attribute when it is required and has no default. This PR also adds a 'always visible' flag to the form configuration when the CF is set required. [ci skip]	8 years ago
ulferts	d9aab230fd	Fix/empty filters on export (#5579 ) * place empty filter set in representation url This will allow the empty filter set to override the default filter (status - open) * remove now unused method * persist having no filter in the url params Otherwise, the default filter (status - open) will reappear on reload [ci skip]	8 years ago
ulferts	8b823a6861	bump rails to 5.0.3 (#5544 ) * bump rails to 5.0.3 * adapt specs * fix specs * avoid naming conflict in association method Because of https://github.com/rails/rails/pull/28246, association methods can currently collide [ci skip]	8 years ago

1 2 3 4 5 ...

920 Commits (bcaa72dc66c647514641e723594be05d52b05a76)