161 Commits (bd3d6273897a819282e6189c1b4e2ee07d2fc242)

Author	SHA1	Message	Date
Christophe Bliard	48a4f1b6ad	lint with rubocop --autocorrect (safe cops only)	2 years ago
Oliver Günther	1bf7dda371	Fix logging out the user after multiple visits with auth source sso ... An optimization returned the user early if the logged in user matches the user from the auth header. In this case, the session was not populated with user_from_auth_source marker. In turn, when logging out, the user was no longer redirected correctly. https://community.openproject.org/wp/42735	2 years ago
Oliver Günther	6b93d6e5fe	Don't return from transaction block	2 years ago
Christophe Bliard	a33524ef6d	remove ruby magic comment for utf-8 ... ruby interprets source encoding as utf-8 since 2.0.0, making magic comment redundant and useless	3 years ago
Christophe Bliard	bc8d423ec2	update copyright information for 2022	3 years ago
Oliver Günther	048e9476b3	Use SetAttributesService when retrieving user	3 years ago
Oliver Günther	62c646af50	[40511] Retrieve user from login instead of passing it to session ... https://community.openproject.org/wp/40511	3 years ago
Oliver Günther	04964f21e2	[40248] Remember the back_url when initiating auth_source_sso ... When the user creates a new session through auth source sso, they are being logged in through `logged_user=` which calls the login service and redirects back afterwards. But there is no back_url set, resulting in a my page redirect. https://community.openproject.org/wp/40248	3 years ago
Oliver Günther	dea629ce70	[40240] Return the original authenticated user in case of optional sso ... https://community.openproject.org/wp/40240	3 years ago
Oliver Günther	aa651df116	[39807] Use SetAttributesService in invite ... https://community.openproject.org/work_packages/39807	3 years ago
Henriette Darge	318a0e56fd	Add LinkAttributeFilter to be able to add "target" attribute. Thus the "privacy policy"-link opens automatically in a new tab	3 years ago
Oliver Günther	0fce502a69	Convert document create/update into services	3 years ago
Oliver Günther	ccfa29c728	Move license and copyright docs to root, fix names and references	3 years ago
Oliver Günther	a1177700b6	Fix and test auth-source-sso case insensitivity	3 years ago
Oliver Günther	b8bb7546b0	[38706] Make login lookups in auth source sso case-insensitive ... https://community.openproject.org/work_packages/38706	3 years ago
Oliver Günther	f7c2644f53	Fix auth source login when user changes	3 years ago
Oliver Günther	b7696a6c5c	[37553] Make user run through authentication stages after header SSO (#9458) ... https://community.openproject.org/wp/37553	3 years ago
Oliver Günther	e9d7c374cc	[37868] Whitelist for attachment mime types and extensions on upload (#9431) ... * Add setting for whitelist * Make attachments API BaseServices compatible * Add prepare service and contract * Correctly pass the filename to the UploadedFile * Add presence check to filename * Fix expected validation message * We no longer raise a multipart error when metadata is empty * Fix filesize validation on prepared uploads * Add parser error if invalid metadata json * When attachment is not saved, use filename property * Return correct error message on JSON parser erroro * Fix specs * Use attachment upload representer * Fix direct uploads mocks with new service layer * Lint * Fix export job using attachment service * Fix IFC controller using attachment prepare service * Fix export job * RenameRename params_getter to params_source * Fix mail handler using attachment service * Fix usage of attachment create service in documents * Reuse shared examples for document attachment spec * Fix stubbed attachment service in export job spec * Use admin user in backup spec * Fix export job for bim * Fix attachment integration spec * Fix issues_controller spec * Make budget resource spec reuse common examples * Fix attachment parsing representer spec * Replace prepare part of attachment spec into separate service spec * Clear cache for login spec * Convert document create/update into services * Budget services * Allow options to be passed to property twin * Remove setting author on budget initialize * Replace meetings update with services * Replace ifc models attachment handling with services * Don't check uploader if changed by system * Fix uploader being changed by system * Replace wiki page attach_files with attachable services * Replace avatar saving * Replace snapshot attach_files * Skip double validation when container present * Set snapshot through attachment service * Remove attach_files * Validate content type in contract * Enforce writing the content type without accepting user input * Expect changed content_type * Fix content of viewpoint image to get correct content type * Fix tsv spec * Add create contract spec * Bypass whitelist in internal services when conflicting with user * Fix expects in specs after whitelist bypass * Render contract errors for wiki * Add before_hook to bodied to allow to pre-authorize permissions * Budget errors from contract * Document errors from contract	3 years ago
Oliver Günther	2cf8cd0d84	[37290] Use login service for logging in user (#9290) ... This correctly sets the last login date among other things https://community.openproject.org/wp/37290	4 years ago
Oliver Günther	34f8e9dff8	Validate admin guard for all settings writers (#9012) ... * Validate admin guard for all settings writers * Add spec to test access to all links under admin * Fix broken specs * Keep only UpdateContract and add spec * Move admin settings under their own namespace for clarity Move all admin related settings under ::Admin::SettingsController * Fix more paths and views for settings Adds another spec to ensure all links in admin can be viewed by admin * Fix wrongly changed settings path for repositories page * Use plugin name for plugin settings	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961) ... * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
luz paz	3683042c9b	Fix typos in user facing and non-user facing code ... Found via `codespell v2.1.dev0`	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Oliver Günther	84d9d17bc1	Add debugging output to sso header ... [ci skip]	4 years ago
ulferts	5968c0b18a	Fix/replace custom i18n function (#8681) ... * replace custom i18n function calls * remove custom i18n method	4 years ago
Oliver Günther	de86dcd26a	[34427] Do not output empty success flash in omniauth flow ... https://community.openproject.com/wp/34427	4 years ago
Oliver Günther	6881f3d347	[33696] Retain autologin cookied request in session ... https://community.openproject.com/wp/33696	4 years ago
Oliver Günther	6d6d6aeb09	Ensure we set `just_registered` only for users that were just created	4 years ago
Oliver Günther	f1e25499cd	Need to pass controller to sevice for OIDC callback ... OIDC sets a cookie in the login hook so we need some access to the controller	4 years ago
Oliver Günther	0411b87482	Correctly activate registration stages after omniauth/register	4 years ago
Oliver Günther	fc99f8596a	Fix account controller specs	4 years ago
Oliver Günther	d2a6886230	Retain flash values when logging in user	4 years ago
Oliver Günther	2ef33d2a3a	Add helper to look for an error key in the ServiceResult errors	4 years ago
Oliver Günther	4b0509b197	Create separate service to get an active user from Omniauth ... Omniauth login flow is quite elaborate. It does: - check whether the request is valid (perfect use case for contract) - find or initialize a user from the auth hash - try to register that user according to Setting.self_registration This PR introduces two services to do these things 1. The omniauth request flow handler 2. A registration service to handle user activation/registration according to setting	4 years ago
Oliver Günther	86b8ffc326	[30007] Allow users to enable CORS on APIv3 resources ... Allows a setting and configuration option to allow access to APIV3. Setting allows us to selectively enable this for cloud instances too. https://community.openproject.com/wp/30007	4 years ago
Markus Kahl	56ee0cef92	allow omni-auth user to switch to password on reinvitation ... also make sure to delete passwords on reinvitation so users switching to omni-auth can't still login using the old password	4 years ago
Oliver Günther	bb739672bf	Test for direct login only after the logout callback was called ... This allows single-log-out flows to happen even if you assigned an omniauth direct login. If you came back from the provider with no SLO happening (a redirect), it will perform the previous check to prevent you being logged in immediately again.	4 years ago
Oliver Günther	211d9cd4eb	Move provider finder into auth plugin	4 years ago
Oliver Günther	2e8d7247e7	Retain session values from a provider	4 years ago
Oliver Günther	e5cd25693f	Allow to find omniauth strategy by name	4 years ago
Oliver Günther	629c73c852	Allow remapping of all existing users if the setting allows it ... Originally, only non-auth-sourced or identity_url users were allowed. But if the setting is set, rather all users should be able to be reidentified.	4 years ago
Oliver Günther	ae65b35c4e	Allow to map internal UID from attributes	4 years ago
Oliver Günther	de31a674b1	Allow to map internal UID from attributes	4 years ago
Oliver Günther	70acb4c80f	[33445] Ensure user is activated if invited and accessing auth source ... https://community.openproject.com/wp/33445	5 years ago
Oliver Günther	60ea0a62f4	Debug output for info hash ... [ci skip]	5 years ago
Oliver Günther	bb8b6efef6	Add logout URL for header based SSO	5 years ago
Oliver Günther	e36f8b389c	Allow an optional auth_source_sso flag	5 years ago
ulferts	9e2287bfcc	rename and inflect according to zeitwerk	5 years ago
ulferts	3e4d21e052	extract email settings into own menu item	5 years ago