openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	54e0aab55f	linting	8 years ago
Jens Ulferts	1c6ed96679	use less string sql	8 years ago
Jan Sandbrink	f36a4d3576	Move visibility check into a scope of query	8 years ago
Jens Ulferts	8c916f12f3	eager load cf translations	8 years ago
Oliver Günther	05a54adced	Serialize column_names as arrays Currently, column_names on production systems are either 1. YAML-serialized Arrays of column names (duh) 2. An empty string '' 3. nil The two latter are invalid with Rails 5 and cause the following error: ``` NoMethodError (undefined method `map' for "":String): app/controllers/api/experimental/concerns/v3_naming.rb:70:in `json_query_as_v3' app/controllers/api/experimental/work_packages_controller.rb:85:in `query_as_json' app/controllers/api/experimental/work_packages_controller.rb:51:in `index' app/middleware/reset_current_user.rb:47:in `call' ``` This commit forces Array serialization and fixes previous queries with the empty values.	8 years ago
Jens Ulferts	1a597e180b	first step towards generalizing the query and its filters	8 years ago
Oliver Günther	9ff3bd8ad9	Add temporary hash-like check for AC::Params	8 years ago
Jens Ulferts	ffc4737ada	no longer pass two attributes to ActiveRecord::Base#initialize	8 years ago
Alex Dik	e5900f7e3c	Fix 6.0.4 merge artifacts	8 years ago
Oliver Günther	513f491256	[23814] Include subprojects in filter With #4771, subprojects were no longer included in the query results unless an explicit subproject filter is set. This commit re-enables the `Setting.display_subprojects_work_packages?` check. https://community.openproject.com/work_packages/23814	8 years ago
Jens Ulferts	3246747ae0	adapt to newly introduced query	8 years ago
Jens Ulferts	03c372fd47	use project condition to avoid extra db call	8 years ago
Jens Ulferts	63ef13fd48	avoid loading whole object when only interested in id	8 years ago
Jens Ulferts	3f85c86f1a	improve performance on wp query working on subprojects	8 years ago
Jens Ulferts	f9573910de	add spent_time to wp table The column is neither sortable nor groupable as this would cause performance problems.	9 years ago
ulferts	29bd679361	Fix/no text cf columns (#4413 ) Removes custom field columns from the query when the custom fields has field_format == text. Displaying long text is not feasible inside the small space the work package table offers.	9 years ago
Oliver Günther	c7f7b17088	[22969] Switch subject and type (#4334 ) This changes position of column "subject" and "type"	9 years ago
Oliver Günther	022c60c6d2	[13702] Default columns: Move subject left, remove priority This moves the subject as a default column directly next to Type, and removes prirority from the default set of columns.	9 years ago
Jens Ulferts	0d6f420afc	Revert "less magic on default query columns" This reverts commit `2293c3735b`.	9 years ago
Jens Ulferts	2f764b84b9	Revert "less magic on default query columns" This reverts commit `2293c3735b`.	9 years ago
Jens Ulferts	2293c3735b	less magic on default query columns Use the columns defined to be default for a new query as a default for a new query upon initialization. A caller can chose to overwrite this. This prevents the columns from getting readded when no column is selected. It also allows to improve the performance of the work_packages#index call because an SQL query with less columns is considerably faster.	9 years ago
Jens Ulferts	6dfd97d678	avoid loading project on query initialization The knowledge, whether the query has a project associated is only required for the edit case but was determined right at query initialization. This is now changed to a lazy evaluation	9 years ago
Oliver Günther	8dc9b592c4	Fix merge hickup	9 years ago
Jens Ulferts	2516e9c0e7	allow to disambiguously group by responsible association Before the commit, the result for a count on a query grouped by responsible would be of the schema { id: count, id2: count2 }. For other attributes, e.g. assignee it is { user: count, user2: count2}. The difference is caused by using :responsible_id for grouping which is necessary as the association causes an ambiguous reference in the issued db query. That problem has been fixed in rails/master (`c2d33c4abf`). But as long as the fix is not backported, we will have to overwrite a method of ActiveRecord::Calculations	9 years ago
Mohamed Wael Khobalatte	972b04d86e	Refactor to allow for strong params We no longer need attr_accessible.	9 years ago
Jan Sandbrink	1e4427f400	Uniformly format QueryColumns - wrap all columns parameter-wise - ensure that none exceeds the 100 character limit per line	9 years ago
Jan Sandbrink	02e7b9f5a8	Move summing of column values into QueryColumn - letting a column indicate whether it is summable (avoiding errors when trying to sum the "subject" or other silly things) - summing normal QueryColumns SQL side - doing SQL side filtering for CF-columns to improve performance for sparsely filled custom fields Possible improvements: - fully computing custom field sums SQL side (for dense custom fields) - only using a single query for all summed columns, instead of one SQL query per column	9 years ago
Jan Sandbrink	08ef41b14d	increase type compatibility of :sql_for_field it is expecting a string array anyway (and casting to integer on demand) still that makes ints not less valid...	9 years ago
Jan Sandbrink	92bb497a66	rename parameter/update code doc it is actually expected to be an array...	9 years ago
Jan Sandbrink	e978876acc	fix expectations in legacy spec - real code is actually able to deal with arrays being returned from sortable - simplified group by sorting	9 years ago
Jan Sandbrink	04895aeffb	ensure sortability of all user columns I am not seeing any other unsortable columns, so this might make the API exposed "sortable" property obsolete (exposed in experimental API)	9 years ago
Jan Sandbrink	1cf3d1c8ee	remove superfluous length call	9 years ago
Jan Sandbrink	1c2aabbc45	allow sorting of WP lists	9 years ago
Alex Coles	787a35c9db	Add explicit join references in models Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	624b50d5bb	Remove deprecated Relation#all in models Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	6d93fa3d76	Add Query#connection to avoid deprecation warnings Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	67c84961a0	Migrate model has_many conditions to lambda Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	064d66449a	Migrate AR finder/query methods in models Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	df51b6ed99	Fix syntax (w/Rubocop) in (Rails) models Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in `74228b59`. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 [ci skip]	10 years ago
Jens Ulferts	0fa28f14dc	avoid id naming collisions on query statements	10 years ago
Alex Coles	1d1ec0ef37	Prefer #map over #collect in (Rails) models Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	6fe9535b1f	Fix syntax (w/Rubocop) in (Rails) models Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	721101ed25	Use 1.9+ Hash syntax in (Rails) models Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Mihail Maxacov	fc42e45bfd	fix sorting by wp id not displayed in modal	10 years ago
Alex Coles	0b941955ce	Fully qualify ::Type class constant This fixes a naming collision with AR internals: undefined method `find' for ActiveRecord::AttributeMethods::Serialization::Type:Class Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Markus Kahl	61d7fbe34c	spec for menu items with identical names	10 years ago
slawa	4ed6654c7d	Check if member with selected role is assigned to selected project	11 years ago

1 2 3 4 5 ...

321 Commits (be0f900b51f75c0d2ab89ed5e0ee9cc5fc2d08ad)