openproject

Commit Graph

Author	SHA1	Message	Date
Jan Sandbrink	b374ebdd7f	store messages alongside error symbols - allows to skip translation part in ErrorBase - allows to have correct translations containing placeholder values	9 years ago
Jan Sandbrink	a9d28d3fb6	fix some errors uncovered by specs - bad default values - missing attribute sanitation - style	9 years ago
Jan Sandbrink	662f99808a	apply basic attribute name transformations those are the ones that were present earlier already. They do not cover the hard cases, where the backend has completely different names form the API	9 years ago
Jan Sandbrink	dcd2a3b03c	rework error instantiation - multiple errors are no longer a special case of specific errors - there is a separate error class to represent multiple API errors - convert ActiveRecord errors to API errors in a single place, ideally work with API errors from there on	9 years ago
Jan Sandbrink	3e87d10980	fix bogus errors in contracts - AR tried to read properties that are undefined on the contract (:error_read_only) - now that we actually use Contract properties the copy-validations stuff started to do things, however: - we already went another path to simultaneously validate contract + model - validation was apparently broken, e.g. though the subject was not empty, there were subject :blank errors	9 years ago
Jan Sandbrink	13b9042293	treat all 422 errors the same for forms That means: Do render the form for all HTTP 422 errors, problems are highlighted within the form	9 years ago
Jan Sandbrink	a0e2c26deb	define properties on contract Actually it is documented that a :property needs to be defined on the contract (see https://github.com/apotonick/reform#contracts). We just did not do that until now, because it was not neccessary when abusing AR::Errors as hard as we did.	9 years ago
Jan Sandbrink	ac9cffe741	remove tautology and add apropriate specs	9 years ago
Jan Sandbrink	c7207f0330	resort errors in WP contracts - use attributes as keys and error messages as value - AM errors immediately turn message symbols into translated strings, this makes them hardly processable -> patch some helper methods onto AM::Errors and everything is fine forever	9 years ago
Jan Sandbrink	eec35308ce	use contract directly in WP create too	9 years ago
Jan Sandbrink	ce0b906d91	dirty trick to allow using a Hash as mock also removes default value from initializer, which was never sane	9 years ago
Jan Sandbrink	e5dd8732fc	fix stupid mistakes - reference to method by old name - not knowing how to call a super-method	9 years ago
Jan Sandbrink	88d7944bb1	hide error merging behind contract.validate	9 years ago
Jan Sandbrink	e22334a5f6	rename local	9 years ago
Jan Sandbrink	025f3f589e	remove side effect from Validation.create I just don't know what the original author thought...	9 years ago
Jan Sandbrink	0b7b4bf329	extract error merging into contract	9 years ago
Alex Coles	29d9814347	Prefer Project.allowed_to to .allowed_to_condition Use `ActiveRecord::Relation#merge` to merge scopes. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	3abb8c7fa4	Remove unloadable from lib code Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jonas Heinrich	f396563911	Adapt version to corresponding OpenProject core version.	9 years ago
Alex Coles	8338b7a6e1	Update OP::Authentication to use uppercase headers Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jonas Heinrich	ff158d8cbd	Adapt version to corresponding OpenProject core version.	9 years ago
jonasheinrich	ee17a821ad	Bump version to 4.2.0	9 years ago
Alex Coles	69aaa74e5f	Update OP::Authentication to use uppercase headers Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	1bcbad97d5	Indent fix in acts_as_searchable [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	0ad3cfb4b2	Prefer do…end for controller respond_to blocks `rubocop -a` does not currently normalise formatting consistently (see `ec1bb39f`). Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	c02804b0eb	Teach acts_as_searchable a references option * Update usages in models. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	2e040a7830	Replace deprec. with_scope in acts_as_searchable * Migrate AR finder/query methods, etc. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	837265c257	Fix API v3 WorkPackageSchema for AR::Relation Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	071e9eed7c	Add explicit join references in TextFormatting Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	9abbe5c4f7	Remove deprecated Relation#all in lib Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Markus Kahl	6fa07f060f	fixed default realm	9 years ago
Markus Kahl	a770bf762c	follow warden default, which is true for store	9 years ago
Markus Kahl	c33c9b60e3	looks like the store default is true	9 years ago
Markus Kahl	3865ce4f1f	polish	9 years ago
Markus Kahl	6902dc1766	lookup key directly	9 years ago
Markus Kahl	bcd981df5c	consider X-Authentication-Scheme; opt scoped realm	9 years ago
Markus Kahl	d854df5175	suppress browser prompt on authenticate failure	9 years ago
Alex Coles	b6be1d560b	Temp. silence acts_as_searchable deprecations This plugin needs to be rewritten for Active Record 4. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	b2790b8db1	Migrate deprecated .update_all with conditions Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	0c729dae54	Replace deprecated calls to Model.scoped Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	bdbb3c6a6a	Migrate acts_as_tree has_many to lambda Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	f83365ebab	Migrate acts_as_attachable has_many to lambda Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	53524637ec	Migrate acts_as_journalized has_many to lambda Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	bbe8ec184a	Migrate acts_as_customizable has_many to lambda Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	71cd6d834a	Migrate pagination scopes to use lambda/block Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	a31559cc01	Migrate nested_set scopes to use lambda/block Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	a6c54cb25f	Migrate AR finder/query methods in lib code Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	35ef50b868	Fix syntax (w/Rubocop) in tasks Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	a6212fb304	Fix syntax (w/Rubocop) in lib code Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in `74228b59`. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago

... 2 3 4 5 6 ...

3370 Commits (bed42fa28fb0bbea16b0d4ff6914984faaf2ebd4)