openproject

Commit Graph

Author	SHA1	Message	Date
Travis CI User	860b5c4213	update locales from crowdin [ci skip]	4 years ago
Travis CI User	fa85b45c63	update locales from crowdin [ci skip]	4 years ago
Wieland Lindenthal	a18954b2c9	Placeholder user services and administration (#8944 ) * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Aleix Suau	6895974095	Default to previous value or 0 when invalid decimal separator (#8904 ) * Default to previous value or 0 when invalid decimal separator * Removing useless check and formatting	4 years ago
ulferts	51102b23f6	increase limit on rspec memoized helpers	4 years ago
Benjamin Bädorf	f5f3cc03db	Revert "Fix EXPOSE of Dockerfile for prod (#8993 )" (#9002 ) This reverts commit `68fe70070c`.	4 years ago
Oliver Günther	cb5fbb6a72	Use the configured variable for expiry https://github.com/opf/openproject/pull/8941	4 years ago
Oliver Günther	8df966abff	Use the configured variable for expiry (#8985 ) https://github.com/opf/openproject/pull/8941	4 years ago
ivangriggs	06db2c2659	Docs: Update "Manage Users" to add missing functionality and clarification (#8981 ) * Various spelling errors or incorrect quote characters [ci skip] (7 README.md files changed) * Various spelling errors, 'smart' characters, fixed some invalid links [ci skip] (11 README.md files changed) (if I knew how to generate the HTML I could check the pages) * Updated as a "Gateway" for "How to 'get' OpenProject" to give all the options. I have used texts from other documentation and from the OpenProject website, but may need OP staff review [ci skip] * update locales from crowdin [ci skip] * Fix typo beeing->being in spec/ and modules/ * FIx typo nucleous-> nucleus in app/ and modules/ (#8947) * Documentation: Administration > Users & Permissions > Users Added missing functionality, clarified existing doc. [ci skip] * Changes to Pull Request as per review (part) [ci skip] * Changes to Pull Request as per review (remainder) [ci skip] Co-authored-by: pi@rpi99 <pi@pi-gen.pitowers.org> Co-authored-by: Travis CI User <travis@example.org> Co-authored-by: luz paz <luzpaz@users.noreply.github.com>	4 years ago
ivangriggs	ff12673481	Docs: Update "Manage Users" to add missing functionality and clarification (#8981 ) * Various spelling errors or incorrect quote characters [ci skip] (7 README.md files changed) * Various spelling errors, 'smart' characters, fixed some invalid links [ci skip] (11 README.md files changed) (if I knew how to generate the HTML I could check the pages) * Updated as a "Gateway" for "How to 'get' OpenProject" to give all the options. I have used texts from other documentation and from the OpenProject website, but may need OP staff review [ci skip] * update locales from crowdin [ci skip] * Fix typo beeing->being in spec/ and modules/ * FIx typo nucleous-> nucleus in app/ and modules/ (#8947) * Documentation: Administration > Users & Permissions > Users Added missing functionality, clarified existing doc. [ci skip] * Changes to Pull Request as per review (part) [ci skip] * Changes to Pull Request as per review (remainder) [ci skip] Co-authored-by: pi@rpi99 <pi@pi-gen.pitowers.org> Co-authored-by: Travis CI User <travis@example.org> Co-authored-by: luz paz <luzpaz@users.noreply.github.com>	4 years ago
ML-OpenP	4b9ce08630	changed links to .org instead of .com for Community platform [ci skip]	4 years ago
Piyotaro, Kiiroi (きいろいぴよ太郎)	68fe70070c	Fix EXPOSE of Dockerfile for prod (#8993 ) Proxy and web are listening 8080 port. So the Dockerfile should expose 8080 port.	4 years ago
ulferts	8ab0732bc4	add rupocop-rails and rubocop-rspec (#8998 )	4 years ago
Markus Kahl	2cab0bedd7	CustomStyle uses this uploader and doesn't have a content_type method.	4 years ago
ulferts	226ba35985	bump rails (#8995 ) Fixes CVEs: * CVE-2021-22881 * CVE-2021-22880	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
Wieland Lindenthal	b4e24a39bc	Fix: Dev installation docs Update version numbers ... for node, npm, and bundler	4 years ago
Wieland Lindenthal	2fae86f50b	Fix: Dev env installation missing linking frontend plugins etc.	4 years ago
ulferts	a6d5337666	Merge branch 'release/11.1' into dev	4 years ago
Travis CI User	7ccc01d091	update locales from crowdin [ci skip]	4 years ago
ulferts	2eb58888af	Bumped version to 11.1.4 [ci skip]	4 years ago
ulferts	108e5d4c04	Add release-notes file	4 years ago
Travis CI User	62351cd8b2	update locales from crowdin [ci skip]	4 years ago
ulferts	0f6b594604	Merge branch 'release/11.1' into dev	4 years ago
ulferts	3cb2b30a6d	bump rails to 6.0.3.5 (#8996 )	4 years ago
Oliver Günther	cdf3cf4c34	[36136] Rework members page to show name and avatars for principals (#8973 ) * Rewrite members page to output name column * Remove white-space nowrap for long login names in administration * Extend member specs * Allow query instance to be used in table cell * Fix memberships specs with changed columns * Add order for email * Review feedback * Allow x to close add member form * WIP sort firstname/lastname * Make status sortable * Extract order_by_name into the order class * Re-add but deprecate order_by_name It's still in use in combination with some special scopes (custom actions for example) that I don't want to remove right now * Rewrite order_by_name into scope	4 years ago
ulferts	5c112f39e1	fix role api permission checks The authorization on the individual get was handled to early (before instead of after_validation) so that the current user wasn`t set correctly yet. Additionally, there was not dedicated authorization check on the index get action	4 years ago
Oliver Günther	109ade62da	Allow editing auth_source as a global user (#8954 )	4 years ago
Philipp Tessenow	88cee93261	Update codeclimate config to run rubocop again (#8991 ) the "rubocop-1-9" channel could not be found, as it's name is actually "rubocop-1-9-1"	4 years ago
ulferts	40dda5833b	bump carrierwave Fixes https://nvd.nist.gov/vuln/detail/CVE-2021-21288 and https://nvd.nist.gov/vuln/detail/CVE-2021-21305	4 years ago
Oliver Günther	2cde433326	Remove usages of AnyFixture (#8987 ) AnyFixture will create once instance of a factory for reuse in a number of specs. This will work fine until we require a clean slate for a specific example. As we have numerous tests that test like the database is empty, we get a number of disadvantages: - After an example with `with_clean_fixture` metadata, the fixture will only be regenerated after the next example that uses it. This means the order of execution will change the number of objects in the DB. - The more `with_clean_fixture` we have, the smaller the performance advantage of AnyFixture will result in. - You cannot use an AnyFixture in a spec that needs a clean slate. This should be obvious but was overlooked by myself.	4 years ago
Oliver Günther	f55609f3b1	Update README.md	4 years ago
ulferts	97f8677cc7	allow filtering for groups and placeholders on user cfs Extends the ability of filtering work packages based on user typed work package custom fields by values of the classes: * Group * PlaceholderUser	4 years ago
Oliver Günther	35add6e5e1	Add note regarding LDAP group sync member/memberof [ci skip]	4 years ago
Oliver Günther	a65992c354	Allow placeholder and group assignment to custom field (#8972 ) * Allow placeholder and group assignment to custom field * Review feedback	4 years ago
ulferts	82a5914e11	hide manualSort filter from user visible filters	4 years ago
ML-OpenP	1b4a16a818	documentation for #36056 "Remove setting "Allow assignment to groups" " [ci skip]	4 years ago
Oliver Günther	3234dae862	Revert "Enable tests on pull_request_target" This reverts commit `ed718185f5`.	4 years ago
Travis CI User	d1df2ff8aa	update locales from crowdin [ci skip]	4 years ago
ulferts	30711e740f	add filtering for assignee with placeholder users	4 years ago
ulferts	e9692f85a5	add filtering for assignee with placeholder users	4 years ago
ulferts	441bb340ff	allow pageSize = 0 on manually sorted queries This allows fetching the query without the added burden of having to render the work packages. Rendering the work packages increases the response time heavily.	4 years ago
Cyril Rohr	ed718185f5	Enable tests on pull_request_target	4 years ago
Oliver Günther	90d8dec296	Rewrite duplicated CreateService specs (#8959 ) * Add common base service create service examples * Rewrite user service spec into the common service * Rewrite CustomFields::CreateService spec into common * Rewrite Messages::CreateService into common * Rewrite Projects::CreateService with common example * Rewrite Grids::CreateService spec with common examples * Rewrite BIM::IfcModels::CreateService with common examples * Rewrite Bim::Bcf::Issues::CreateService with new common examples	4 years ago
Oliver Günther	15a2716d95	[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012	4 years ago
ulferts	cc4ed56e2a	use AR`s scope method instead of singleton class method (#8976 ) * use AR`s scope method instead of singleton class method By using the scope method, all of Rails` checks and method definition usually done on a method are now also performed on the extracted scope methods `5f3ff60084/activerecord/lib/active_record/scoping/named.rb (L154-L190)` * turn scope classes into modules	4 years ago
Travis CI User	3ce6aaf070	update locales from crowdin [ci skip]	4 years ago
Aleix Suau	637306edfa	Open pdf exports in new tab	4 years ago
Aleix Suau	b79df877c3	Open pdf exports in new tab	4 years ago
Oliver Günther	4d02e3844a	Fix local feature testing by opt-in ENV variable in ci/docker	4 years ago

... 3 4 5 6 7 ...

58709 Commits (bee673f6f88fac1ab945a131226a3784aab4aba0) All Branches Search

58709 Commits (bee673f6f88fac1ab945a131226a3784aab4aba0)

All Branches