18785 Commits (c24507be341d16c303324850258092ff5be1538b)

Author	SHA1	Message	Date
ulferts	a44493320e	don`t include a non hidden closed reference in daily summary	3 years ago
ulferts	f4d01e37aa	prevent author watcher on work package copy ... Newly created work packages get their author assigned as a watcher. When copying, this would mean that the copying user is now watcher in all of the copied work packages. This commit changes the behaviour to only include the user as a watcher if that user was also watching the source work package.	3 years ago
Markus Kahl	dc89c9a46d	Revert "try to fix NPE when adding user to group at times" ... This reverts commit 3f4b303c79.	3 years ago
Markus Kahl	3f4b303c79	try to fix NPE when adding user to group at times	3 years ago
ulferts	8dfba679a6	introduce resourceId and resourceType filter ... These filters in combination allow filtering notifications via the associated resource, e.g. a work package. When only using the id filter, due to the polymorphic association of the resource, it will not be guaranteed to only return the desired notifications. A different resource, e.g. a meeting might have the same id. But using the resourceType filter by itself also makes sense so that a client can fetch only notifications associated to a subset of resources, e.g. work packages.	3 years ago
Matthew Trescott	50ad15bbaa	Fix repository breadcrumbs with query string instead of path ... Missed in 85a1079e25	3 years ago
ulferts	34467120c3	introduce resourceId and resourceType filter ... These filters in combination allow filtering notifications via the associated resource, e.g. a work package. When only using the id filter, due to the polymorphic association of the resource, it will not be guaranteed to only return the desired notifications. A different resource, e.g. a meeting might have the same id. But using the resourceType filter by itself also makes sense so that a client can fetch only notifications associated to a subset of resources, e.g. work packages.	3 years ago
Wieland Lindenthal	2850eee2b8	fixing logic	3 years ago
Oliver Günther	b1f1a51a4e	Fix duplicating the row default-value ... The default value still had references to the previous value, causing it to be shifted in positions	3 years ago
Oliver Günther	d504855091	Fix custom fields reordering	3 years ago
Wieland Lindenthal	8332b660b4	Satisfy rubocop	3 years ago
Wieland Lindenthal	eff86a228c	Post review modifications ... - Don't use class variables. - Use memoized class instance variables. - Fix class reloading in development environment.	3 years ago
Wieland Lindenthal	4935d3a3d4	Fix #33448: Format WP column "BCF snapshot" as string ... Render an "X" if there is at least one viewpoint for the associated BCF issue. https://community.openproject.org/wp/33448	3 years ago
ulferts	3b0e91938a	add explanation text for remaining notification settings	3 years ago
ulferts	2a6ab15101	add work package scheduled notification setting	3 years ago
ulferts	8cfb94be7d	remove work_package_updated from notified_events	3 years ago
ulferts	09f1a37f3c	add work package prioritized notification setting	3 years ago
ulferts	61357f5091	add work package processed notification setting	3 years ago
ulferts	a1074bcb93	add work package created notification setting	3 years ago
Oliver Günther	cd2d736c18	Prevent self-assignment of work package parent ... The backend doesn't prevent parent self assignment of a work package. I triggered this by accident through an API call and this resulted in an endless loop.	3 years ago
Oliver Günther	dfa73cc8eb	Avoid duplicate errors output	3 years ago
Oliver Günther	934a8b500c	Don't try to use mail attribute if invalid	3 years ago
ulferts	f246346014	add work package commented notification setting	3 years ago
Oliver Günther	80db63feda	[38361] Sort wiki menu items by title ... https://community.openproject.org/wp/38361	3 years ago
Henriette Darge	303dd6bf9f	Introduce mixin for global breadcrumb styles. Thus we can avoid the use of component styles in a global style sheet. Further the number of *breadcrumb.sass files was reduced from three to two (global and component)	3 years ago
Henriette Darge	4dce2872a3	Don't allow users without permission to see the project modules list	3 years ago
Oliver Günther	c3e57f79ea	Use alternative {{ ... }} syntax	3 years ago
Oliver Günther	3bfbdfbce9	Fix when errors is not actually present	3 years ago
Oliver Günther	ca0629f5cf	Fix service specs	3 years ago
Oliver Günther	83253981d2	[38325] Using existing gem for email validations ... Our email validation is too strict for RFC compliant emails. Instead of trying to do it ourselves (email validation regexps are hard!), let's just use a gem to do that for us. Note: The gem also has a strict mode that could be optionally enabled. This however results in some emails on community to become invalid. I left it on the default mode for now. https://community.openproject.org/work_packages/38325	3 years ago
Markus Kahl	1538666c23	prevent possible infinite loops by making sure not to re-use errors objects ... app/services/work_packages/update_ancestors_service.rb:51 may introduce an infinite loop otherwise if one tries to delete a work package which has validation errors	3 years ago
Henriette Darge	8917a928e4	Change google logo and take care that auth plugin logos are correctly shown	3 years ago
Oliver Günther	5ccb5af99e	Use the setting formatter to replace the static base url	3 years ago
Oliver Günther	a1f1bf2c50	Add status to mail digest	3 years ago
ulferts	c0452ca90e	prevent self notification unless activated	3 years ago
Oliver Günther	b7874852ec	Delete the notification when the WP gets destroyed	3 years ago
Oliver Günther	4fa5e38c3d	[34901] Set timezone when switching to user ... The meeting mailer uses `format_time` helper which only works for User.current, but then also uses `Time.zone` which is set only when using `with_locale_for`. We need to rework both, but as a workaround, we can set the locale for the user when switching to it. https://community.openproject.org/work_packages/34901	3 years ago
Oliver Günther	c931320508	Add setting for letter_opener in Rails development mode	3 years ago
Oliver Günther	5d52ac0a26	Replace and delete users in notifications once deleted ... https://sentry2.openproject.com/organizations/sentry/issues/480	3 years ago
ulferts	e612907033	use recipient language for digest rendering	3 years ago
ulferts	0761a98b4c	exclude deleted work packages from digest rendering	3 years ago
Oliver Günther	123fc5758c	[38092] Add fallback reason in mailer ... https://community.openproject.org/work_packages/38092	3 years ago
luzpaz	2ae53bd252	Fix typos in user facing and non-user facing code (#9497) ... * Fix typos in user facing and non-user facing code Found via `codespell -q 3 -S ./config/locales -L ba,nd,parms,sur,varius` * Fix strings in specs	3 years ago
Oliver Günther	bcdc67cd52	[38078] Fix bulk controller not setting send_notifications ... With the bulk controller not setting notifications, the default is send_notification = true. All subsequent calls to disable notification sending is ignored, so the call in the WorkPackages::UpdateService is ignored. This PR also renames the "Send emails" option to the more appropriate term now. https://community.openproject.org/work_packages/38078	3 years ago
Oliver Günther	c683af254c	[38066] Use the services to update the user ... https://community.openproject.org/wp/38066	3 years ago
Oliver Günther	7382822e12	[38085] Also send ATTACHMENT_CREATED on direct upload completed ... https://community.openproject.org/wp/38085	3 years ago
ulferts	2b43c550b3	avoid creating a journal for a to be destroyed work package ... Work packages with attachments where saved once for every attachment upon destruction. This led to custom fields being rewritten and a journal being created. Those created records where removed right away, since the work package was destroyed so the problem was only perceivable as poor performance. On the other hand, we had reports of users not being able to destroy work packages. While it is pure speculation that this change fixes the problem it at least makes deadlocks less likely since journaling is performed with a mutex and that no longer takes place now. The `after_remove` callback is no longer necessary as journaling is triggered in the services now.	3 years ago
ulferts	938c6e5619	exclude full text columns from attachment model ... Currently, the fulltext columns `fulltext`, `fulltext_tsv` and `file_tsv` are never displayed in the application. As such they are currently purely used internally when the are involved in the fulltext search. Having them included in the AR model Attachment will lead to a lot of data being loaded. Such a column can contain megabytes of data. This is costly twice: when fetching the data from the database and when instantiating the model in ruby. As the data is never displayed, they can be ignored for now using `ignored_columns`. This changes the SQL for fetching from `SELECT "attachments"."*" ...` to `SELECT "attachments"."id", "attachments"."file" ...` (without the excluded columns) The alternative would have been to create a new table for the fulltext information and this might still be an option once the requirements on the columns increase. For now, this change is simpler.	3 years ago
Benjamin Bädorf	87cd178270	Fixed more linting errors (#9452) ... * Fixed more linting errors * Update the selector of the focus directive to opFocus * Update the selector and BEM class of the focus-within directive * More linting fixes * Remove unused directives, merge focus and autofocus directive, remove now empty a11y module * Some small fixes * Fix ReorderDeltaBuilder * Fix failing specs, linting * Fix a couple of linting errors * Reenable linting rules for unsafe any * Reset broken code, update some html coding style	3 years ago
Henriette Darge	76a6cf3208	Allow editing list CustomFields even if they do not allow MultiValues (#9474)	3 years ago