971 Commits (c27b65edc8a0fa45f52943188c44ee38a03e8d6f)

Author	SHA1	Message	Date
Jens Ulferts	757f6a53d7	eager load preference to avoid N+1 queries	9 years ago
Jan Sandbrink	58aa36ae2a	Check for nil representers explicitly ... Passing nil as model into a representer happens usually only due to an error. If a subclass needs to be able to pass nil as represented, it can specify that by overrding. This however, should be an exception, not the rule.	9 years ago
Oliver Günther	de96916dac	Minor corrections ... This commit addresses the following minor corrections from review: 1. Remove constant URI: It breaks karma, and I can't really tell why 2. Avoid using Object.values Appeared to be supported by chrome, but causes the protractor failure. This also switches the ordering to binary (unshift, push) as that's all we need for now. 3. Remove location.hash when jumping to element `$location.hash` may take precedence over `scrollIntoView` ocassionaly, thus we forcefully remove the location hash when updating the work package on a particular field 4. Avoid showing comment success when empty When opening the comment field, and then submitting on another field with comment being empty and open, the comment was not submitted, but a successful comment notification was still sent. 5. Fix issues for IE 10+ * Force min-height to be set on the element, as IE tends to return 0 as height when empty 6. Misc. * Avoid undefined in comment text * Avoid resizing [msd-elastic] textareas * Rename `add_journal` to `create_journal` Correct wrong bracket for reject function	9 years ago
Oliver Günther	3ca36e1e1d	Parallel sending of comment and fields in WP split view ... Parallel submitting of comments alongside WP edits wasn't possible natively due to the increased lock_version in work packages, caused by `touch`ing and explicitly saving the work package in the process of adding a journal. This commit works around this issue by updating the timestamp columns directly, bypassing optimistic locking in the work package table. This allows comments to be submitted transparently with other fields to the user, while actually, we send it in two subsequent steps.	9 years ago
Oliver Günther	0883cf9834	Replace exclusive-edit with transcluded comment directive ... This commit removes the somewhat superfluous exlusiveEditController in favor of event-based passing of quoted text to the correct comment field. The comment directive now decides for itself whether it wants to be placed above or below the activities and uses transclusion for that purpose. Editing comments is now no longer exlusive, but that shouldn't be necessary anyway.	9 years ago
Oliver Günther	3bfad28db0	Correct comment behavior with optional notifications ... This allows submitting comments with and without notification for the created journal. Using hyperagent resource on activities, the resource `addComment` is replaced when executing `fetch` on the link. This breaks subsequent comment requests. This is fixed by requesting manually on the resource link using `$http`. This commit also provides the functionality required to comment with or without notification propagation, and changes the backend to comply to the APIv3 specification, which defines comments to be sent as a JSON `{ comment: { raw: 'my comment' } }`. This commit also provides: * Displaying the comment input on overview depending on sort setting * Disable inplace controls when comment is empty * correctly hiding the comment based on link availability	9 years ago
Alex Coles	2f659e76a9	Fix deprecated Model.exists? arg in UpdateContract ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	0702683116	Fix bad method call for version custom fields ... exploring the down sides of isolated unit testing :(	9 years ago
Jan Sandbrink	338f9d40d0	Fix (untested) relation representer ... This one still is not very APIv3, but there ain't no time to improve it... The angular frontend also seems to rely on the quirks with the relation type changing depending which work package embeds the relation.	9 years ago
Jan Sandbrink	88ed4d2df9	Promote ::create to a common interface method ... This one is already used by the representers that require a custom field injector. However, by having a separate method this also means collections (or the new DecoratorFactory) need to take care and call the ::create method instead of ::new. I therefore made create the default interface to create representers, which is now used by Factories and Collections. Note: I did not yet change all representer instantiations to ::create. I hope this will happen gradually.	9 years ago
Jan Sandbrink	6e9ed008fb	Enforce passing of current_user into representers ... Thereby permission checks will no longer silently fail if no user was passed. This uncovered a lot of places where we actually expected a user to be passed, when it wasn't. This was especially true for collections. The basic idea is, that virtually all representers could change their behaviour based on the current user. Representers where this is not the case (e.g. Digest), can still explicitly opt-out.	9 years ago
Jan Sandbrink	f121e610db	Pass current_user into all AttachmentRepresenters	9 years ago
Jan Sandbrink	3f269e43ae	Add link to delete an attachment to its representer	9 years ago
Jan Sandbrink	e7a6ae629e	Add specs for update links with missing permissions ... - also (for now) remove title text which was not localized - consistently use link helpers for the corresponding specs	9 years ago
Jan Sandbrink	aad39544f5	Hide addAttachment link when user is not allowed	9 years ago
Jan Sandbrink	5de0f15898	Correctly link activities ... - they might not be embedded - create an endpoint for activities - document it properly - adapt angular client	9 years ago
Jan Sandbrink	14a55b82d1	Do not embed linked resources in WP collections	9 years ago
Jan Sandbrink	5d473e9a9c	fix HTTP response of DELETE attachment ... this was wrongfully HTTP 202 (Accepted), which would only be valid if we did the deletion in a delayed/deferred way. For now using HTTP 204 (No Content), since we have no response body.	9 years ago
Jens Ulferts	db3681661d	fixes attachment download path in api ... Kudos to @oliverguenter for the fix	9 years ago
Jan Sandbrink	f9cb083481	in production handle internal API errors gracefully ... - still allow for useful errors during development - let all own exceptions inherit from StandardError, the thing you should use for own errors...	9 years ago
Alexander Bach	83643c37d2	Remove project homepage field from API	9 years ago
Jan Sandbrink	d8ec635e9e	simplify interface for assignable values ... - one method to rule them all - eases overriding -> does not require to define method for new types on base class - allows to infer values_callback from property name (schema representer)	9 years ago
Jan Sandbrink	9ac9524d28	change attribute registration via plugin to be more generic ... - now also registers the attribtue as writable in the schema	9 years ago
Jan Sandbrink	819b69fd66	move auth check out of before block ... different endpoints under work_packages require different permissions	9 years ago
Jan Sandbrink	9e8d051027	reintroduce form_embedded argument for schema ... we can't live without it :/	9 years ago
Jan Sandbrink	2a8659d0f4	split parsing and applying of filters/sort	9 years ago
Jan Sandbrink	cc45136701	refactor 404 auth error ... no separate method needed, let authorize_by_policy behave like well known auth methods (accepting a block)	9 years ago
Jan Sandbrink	32e638449b	hide lockVersion from work package columns	9 years ago
Jan Sandbrink	8e4321959e	improve code style	9 years ago
Jan Sandbrink	781aac5a20	fix stupid C&P error	9 years ago
Jan Sandbrink	637fadf602	add endpoint to list work package columns in a project	9 years ago
Jan Sandbrink	bfcc769cfd	split implementations for work package schema ... - was already quite case-ish, depending on its creation via WP or via project + type - I plan on adding a third case, which would not improve the situation for a single class	9 years ago
Jan Sandbrink	d5fe64bd5e	move writability decision into WP schema ... - reducing the method count (aka interface size) of the schema - giving it more control - still allow outside override in representer (for plugin compatibility)	9 years ago
Jan Sandbrink	0a73e6bac4	convert attribute names in queries API ... This should make the API more consistent again, accepting and producing the same attribute names on all endpoints	9 years ago
Jan Sandbrink	77f2b2a1cc	align the query representer with APIv3 ... - correctly use datatypes - link to linkable resources (instead of embedding their properties) - add specs	9 years ago
Jan Sandbrink	602d488c66	fix reference to value links	9 years ago
Jan Sandbrink	2ddcd55b71	extract groups into own representer	9 years ago
Jan Sandbrink	bdee4a3f0c	include link to linkable group values	9 years ago
Jan Sandbrink	73716ed40a	improve rubocop-perceived styling	9 years ago
Jan Sandbrink	1009b0f373	improve error handling for JSON parsing parameters	9 years ago
Jan Sandbrink	c6336fd5a1	add some integrative specs for sum/group/sort/filter	9 years ago
Jan Sandbrink	e6ecd0e97f	some code structuring	9 years ago
Jan Sandbrink	4803cba41c	implement grouping	9 years ago
Jan Sandbrink	7552fab9ce	some work towards readability	9 years ago
Jan Sandbrink	986be45dde	allow to calculate property sums	9 years ago
Jan Sandbrink	af83cb5422	correctly camelize query parameter	9 years ago
Jan Sandbrink	e6c7a0ce9f	add global WP list endpoint	9 years ago
Jan Sandbrink	2d29bc5c21	extract WP collection methods into helper class	9 years ago
Jan Sandbrink	1c2aabbc45	allow sorting of WP lists	9 years ago
Jan Sandbrink	4c0a6f4ba1	pass block parameter through :authorize	9 years ago