2974 Commits (c3c7e17aeb77522ab905de2959d1f302d57d7d29)

Author	SHA1	Message	Date
Mohamed Wael Khobalatte	0e72ec4243	Move to ruby1-9 syntax once and for all	9 years ago
Jens Ulferts	d56ee98ceb	use db bool values for filtering	9 years ago
Mohamed Wael Khobalatte	18ac022927	Add specs for new strong_params methods	9 years ago
Mohamed Wael Khobalatte	6f1d668c39	Fix issue with versions/new being not accessible	9 years ago
Mohamed Wael Khobalatte	602dd749e3	Ensure versions params play well with plugins	9 years ago
Jens Ulferts	3684b77423	replace if condition then true else false	9 years ago
Mohamed Wael Khobalatte	a1bf92212d	Fix legacy and cucumber specs failing because of strong params	9 years ago
Mohamed Wael Khobalatte	d2349cf819	Delete Redmine's safe_attributes implementation ... It was an early implementation of strong_parameters, more or less. Going forward, we should strive to make the whitelisting of attributes a controller responsibility only.	9 years ago
Mohamed Wael Khobalatte	972b04d86e	Refactor to allow for strong params ... We no longer need attr_accessible.	9 years ago
Jan Sandbrink	0c2415460a	Render the identifier as unchangeable in edit mode	9 years ago
Oliver Günther	04ff74ac24	Refactor PermittedParams to class	9 years ago
Jens Ulferts	3734b3a232	limit aggregation to one journable ... With only .where("#{table_name}.id = ?", notes_id) appended, the DB would aggregated all (from all journables of all types) and then select the one that is necessary. This takes a considerable amount of time. The commit will limit the aggregation to one journalizable.	9 years ago
Jens Ulferts	b0a86a69c2	refactor types action on projects controller ... * Introduced a service to reduce complexity in the controller * Used permitted params to ensure params syntax * Introduced a scope for querying for types used by a work package of the project	9 years ago
Mohamed Wael Khobalatte	7e7868b5a9	Send `watcher set` emails only when said watcher allows email notifications.	9 years ago
Jens Ulferts	c3ab585e80	remove dead code	9 years ago
Jens Ulferts	7eb8bdad53	invert setting for self notification ... Using the positive version to make it easier to understand. In order to avoid having to write a migration, the model layer encapsulates the transformation. Direct assignments to :no_self_notified is still possible.	9 years ago
Oliver Günther	b7465b08a6	Remote managed repositories ... This commit starts the work to provide functionality with remote service hooks for managing repositories. The main driver behind this is packager, for which we want apache to be the sole owner of the repositories it delivers, and OpenProject only as a reader, however it benefits other installations as well.	9 years ago
Oliver Günther	acb4431d8a	Implement UserPreferences endpoint ... Provides the implementation to the user preferences endpoint.	9 years ago
Oliver Günther	319c728b1a	Core notifications to alleviate third-party plugins ... This commit provides some helpers to alleviate SCM vendor plugins: * Provide code notifications when project, members and users are changed. * Allow Repository:* to determine base URL themselves (when no common URL is available) * Open Git adapter for subclassing (Gitolite)	9 years ago
Peter Lehwess	ab7ee018fc	Remove summary attribute and all traces of it from Project	9 years ago
Henriette Dinger	49fb85a487	Give icon a margin for vertical alignment and change header in repo danger zone	9 years ago
Jens Ulferts	39455d8386	use AR's own base_class method ... This will reliably find the first class after AR::Base instead of just the first class	9 years ago
Jens Ulferts	18d3c0a4d7	correclty filter journal attributes ... Only the removal of sympols works now (probably after the rails upgrade)	9 years ago
Mohamed Wael Khobalatte	30ea542a00	Do away with second group selection and related specs/js code	9 years ago
Jens Ulferts	d279e2a3ce	use delegation for available assignees/responsibles ... And only spec that delegation. The specs on project test the actual behaviour.	9 years ago
Jens Ulferts	0ef7b213ba	turn possibe assignees/responsibles into scopes	9 years ago
Jens Ulferts	0b2f482797	move :preference to principal ... This allows for eager loading preference. As the UserPreferences are pretty specific to users we don't want groups to actually receive a UserPreference, though. The methods added by has_one are therefore undefined on the Group model.	9 years ago
Jens Ulferts	0579f4906b	provides scope to order by name ... The order is determined by the currently active setting	9 years ago
Jan Sandbrink	ebbd928a18	Remove outdated comments	9 years ago
Jens Ulferts	4bfc4cc8b2	sort versions case insensitive	9 years ago
Jan Sandbrink	9d68773b05	Use an advisory lock that is released on COMMIT/ROLLBACK ... for MySQL this seems to be the only available workaround that is not destroying running transactions. Note that TransactionalLock is a self-developed gem, that will emulate PostgreSQL style advisory locks, that are automatically released at transaction end.	9 years ago
Jan Sandbrink	3c335866d1	Fix saving of journal in association ... When moving the code over here I replaced a journable.journals.select(&:new_record?).each(&:save!) with journal.save! I did this because we know that only the latest journal will be unsaved. However, it seems that we actually rely on a side-effect of journable.journals being iterated (journable.journals.to_a works as well). I have no idea whats going on, but I made the unobvious part more obvious...	9 years ago
Jan Sandbrink	aaf4637138	Ensure that concurrent version updates play well together	9 years ago
Jan Sandbrink	caf05e9b1a	Simplify joins clause	9 years ago
Oliver Günther	3ca36e1e1d	Parallel sending of comment and fields in WP split view ... Parallel submitting of comments alongside WP edits wasn't possible natively due to the increased lock_version in work packages, caused by `touch`ing and explicitly saving the work package in the process of adding a journal. This commit works around this issue by updating the timestamp columns directly, bypassing optimistic locking in the work package table. This allows comments to be submitted transparently with other fields to the user, while actually, we send it in two subsequent steps.	9 years ago
Jan Sandbrink	26574521d3	Prefill predecessors for results of multiple journables too	9 years ago
Jan Sandbrink	0343e12c83	Prefill predecessor when it is already known ... Getting the predeccessor of a journal is a common operation. When computing the journals for a single journable, it is easily possible to prefill the predecessor (because we know all the journals). Doing this avoids an N+1 query later on (in case the journals are used to display diffs).	9 years ago
Markus Kahl	9af0e26623	make user creation/invitation work with plugins ...	9 years ago
Markus Kahl	86248f400e	groups are never disposable	9 years ago
Markus Kahl	3738329078	delete invited users when removed from project	9 years ago
Markus Kahl	ac8a096488	polish considering remarks through review and houndci	9 years ago
Markus Kahl	8882a0a2cc	the session is optional	9 years ago
Markus Kahl	45153a5d1b	dummy LDAP auth source ... I don't care if we have a company LDAP. My thoughts go out to devs* who don't have that. *OpenSource, right?	9 years ago
Markus Kahl	df36876d21	User ⊆ Principal ∧ Principal ⊄ User ... I.e. calling Member#principal will always work. On the other hand calling #user will fail if the member is a group.	9 years ago
Markus Kahl	fecb1b91b7	invited uses should be usable too ... We may need to think of a name that includes active, registered as well as invited users. For now we can think of invited users as registered ones. Just a bit differently.	9 years ago
Markus Kahl	2ce62e3999	user invitation polish	9 years ago
Markus Kahl	43e18dd00c	switch to user invitation by default ... this changes quite many flows. With this user self registration is a separate flow to what happens when an admin creates a user. Users created by admins are 'invited' instead of 'registered'.	9 years ago
Markus Kahl	98ba7ce333	basic user invitation prototype	9 years ago
Alex Coles	d76e97755c	Fix Settings callbacks for ActiveSupport API change ... Identify callbacks with String not Symbol. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	db078e0964	Fix for ActiveRecord::Base.reflections API change ... `WorkPackage.reflections.keys` now returns Strings rather than symbols. This solution is not ideal: calling `to_sym` is often a code smell. It might be acceptable to pass through Strings to `includes`, but this warrants further discussion. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago