847 Commits (c3c7e17aeb77522ab905de2959d1f302d57d7d29)

Author	SHA1	Message	Date
Jens Ulferts	8f1c5d76b7	allow parent project to be set on copy	8 years ago
Jens Ulferts	da7b63eeb7	discard empty and duplicate permissions	8 years ago
Markus Kahl	471733ab05	prevent renaming wiki pages if there will be menu item conflicts	8 years ago
Jens Ulferts	e8dec71010	fix specs	8 years ago
Jens Ulferts	a6d265eb79	force bool custom values to be stored uniformly	8 years ago
Jens Ulferts	181514742f	replace observers by moving functionality inside the observed object ... The observers should have been removed a long time ago and with rails 5 there is https://github.com/rails/rails-observers/issues/52 to consider as well.	8 years ago
Jens Ulferts	ea36f19be2	replace ineffective permission assignments	8 years ago
Jens Ulferts	6fcb2913d4	cast to array before slicing	8 years ago
Jens Ulferts	693090136d	normalize permissions ... With rails 5 it is no longer possible to create an sql like statement via arel which will check whether a serialized array contains a string. AR will only allow to create a match against an array if the column itself is marked to serialize an array. Because of this and in order to increase the normalization of the data, the permissions are no longer serialized and are moved into a separate table instead. While this is still not normalized, it satisfies the needs	8 years ago
Oliver Günther	59da2c6175	Actually rehash on the correct object instance ... `becomes!` does not change the current object (how would it?), so we need to call `hash_password!` on the object returned from it. This also extends the false positive test. The rehash actually happened, but it was hashing the plain as a legacy SHA-1 again.	8 years ago
Oliver Günther	fff21a1229	UserPasswords: Replace salted SHA-1 with bcrypt ... This adds a typed userpassword class for Bcrypt password hashes that replace the previous default of salted SHA1. It still provides a class for SHA1 passwords, however new passwords of that type may no longer be created directly, and passwords are checked whether to upgrade them on every login.	8 years ago
Oliver Günther	98fdadd02c	Add UserSession model to store user_id in sessions	8 years ago
Jens Ulferts	3246747ae0	adapt to newly introduced query	8 years ago
Jens Ulferts	44e4343f05	add integrational tests for Authorization.projects	8 years ago
Jens Ulferts	ff3ecc9e59	employ sql based user allowed scope for acts as watchable	8 years ago
Jens Ulferts	1ddc142fd3	add sql based query to fetch all users being allowed an action	8 years ago
Jens Ulferts	06c6defa51	replaces ruby based permission check for allowed_to? with sql based query	8 years ago
Oliver Günther	65c3ebaa2d	Fix specs	8 years ago
Oliver Günther	35fa92c2ff	Fix specs according to title <-> name swap	8 years ago
Oliver Günther	43fab7884a	Titles no longer need to be unique ... Since the slug is now the unique identifier for the page, we can avoid title conflicts by letting the slug determine unique records.	8 years ago
Oliver Günther	f13226eb7a	Scope unique slugs per wiki_id	8 years ago
Oliver Günther	9a34fe27c7	Migrate wiki titles to URL slugs ... Wiki titles in 6.0 can contain ANY character, which is causing issues for specific characters processed by textile and CGI-escaped before we can actually parse wiki links. To mitigate the issue of linking space/underscored wiki pages, introduce a permalink URL based on the title and create a migration to move old underscored titles (e.g., `base_de_donées` to spaced titles `base de donées`).	8 years ago
Oliver Günther	616ec628b5	Rewrite with_setting specs ... And fix tests that do not expect settings to be cached during the request with RequestStore.	8 years ago
Oliver Günther	4353953605	Improve stored settings as a whole ... Currently, settings are cached on a per-name basis, but that cache is expired everytime *any* attribute is written. Even when a week-old attribute is still valid, its cache is expired as soon another setting is updated due to the max settings cache key. Instead of caching a single attribute, I suggest to cache the entire settings (the total number with plugins is less than 120 and 4KiB in size) and retrieve and deserialize a single value from that hash. That saves us the time to: 1. Locating a single element from database 2. Instantiate a setting object just for deserializing 3. Requesting settings several times by using RequestStore	8 years ago
ulferts	f043409330	adhere to notification settings when notifying about added watcher (#4683) ... The PR will let the users added as watchers be notified according to their settings. Especially https://community.openproject.com/work_packages/22636/activity should be fixed by it. Unfortunately, the #notify_about method on User is not reusable here for all cases as it would have to be adjusted to fit the requirements. But that method is used for a couple of use cases and I did not want to alter it shortly before a release. The method looks weird, though as e.g. the watchers are not taken into account for 'only_my_events' which reads 'Only for things I watch or I am involved in'. Additionally, it does not care for the self_notified? setting.	8 years ago
Oliver Günther	550763ae46	Do not 'inherit' priority from children ... This removes updating of priority values from children to parent work packages.	8 years ago
Markus Kahl	8f0c9ae24d	fixed inherit_done_ratio_from_leaves bug (#4665) ... which could result in parent progress values greater than 100	8 years ago
ulferts	9a6d5585f4	preload permissions before collection rendering (#4646)	8 years ago
Jens Ulferts	8b8951d75a	handle rescheduling when only a start date exists	8 years ago
Jens Ulferts	9e6e29ecdc	limit scheduling to TYPE_PRECEDES	8 years ago
Jens Ulferts	f41fdbfdfb	limit moving backwards when another relation exists	8 years ago
Jens Ulferts	38fb7c396a	initial implementation of moving work packages backwards	8 years ago
Jens Ulferts	a9ab34f450	add specs for rescheduling based on follows relationship	8 years ago
ulferts	af5731a843	remove precedence of default types for a new work_package's type (#4571) ... The 'default' flag is meant to signal the type to be a selected by default when a new project is created	8 years ago
Oliver Günther	5693f6946c	Fix summing done_ratio when estimated_hours is zero (#4528) ... When `estimated_hours` is `0.0`, it is still taken into consideration when weighting average done ratios for a parent. That results in the parent becoming `0%` done. As 0.0 is being set in the frontend as the default value, this is now happening all over the board. A separate PR should refactor the frontend for 5.1. to allow null as a value for estimated_hours.	9 years ago
Henriette Dinger	867b273c8a	Set default wp type	9 years ago
Markus Kahl	a7f7a5f276	added interpolation spec	9 years ago
ulferts	9ab87ff564	always have current status as an option for the new status (#4423) ... The current status will always be available as an option when the work package is queried about what status it can be changed into.	9 years ago
Jens Ulferts	5cbc31392f	move some specs into appropriate file	9 years ago
Jens Ulferts	d1c2578eee	extract new status description into separate spec	9 years ago
ulferts	29bd679361	Fix/no text cf columns (#4413) ... Removes custom field columns from the query when the custom fields has field_format == text. Displaying long text is not feasible inside the small space the work package table offers.	9 years ago
ulferts	eae5321c4e	Feature/latest project activity (#4390) ... The project table is extended to also have the "Latest activity at" column which shows the date of the latest write operation within the project. https://community.openproject.com/work_packages/22858 Models can register for being considered when the latests activity date is calculated. This mechanism can be and is used by core and can also be used by plugins. It is unfortunate, that the mechanisms already in place by acts_as_activity could not be reused, but it would have required a complete rework to make it happen. Another shortcoming of the current implementation are the sql strings generated within Project::Activity. It would have taken more time to rework them into Arel and as the improvable code is limited to one class and a clean interface separates it from the rest of the application I deem it ok to stay that way for now.	9 years ago
ulferts	1f33252f0d	fix date validation warning (#4391)	9 years ago
Oliver Günther	bececbce8f	Integrate openproject-announcements ... This commit integrates the announcement functionality of openproject-announcements. It extends showing the announcement on the homescreen.	9 years ago
Oliver Günther	638340e7b6	Fix rubocop issues	9 years ago
Oliver Günther	e9cd24f2bf	Add support for parent-scoped with_settings data	9 years ago
Oliver Günther	b2490bf958	Fix 'with_settings' specs	9 years ago
Oliver Günther	8fd75e0456	Extend Subversion repository with UTF-8 paths (#4326) ... Provide some test data for UTF-8 encoded paths with Subversion. This confirms the tests of PR #4324. Side note: OS X will decompose some unicode characters into two characters. For example, the LATIN SMALL LETTER O WITH DIAERESIS (U+00F6 `ö`) will be decomposed into o and COMBINING DIAERESIS (U+0308). This obviously breaks SVN path mapping and while you will be able to commit files with decomposed paths, it will wreak havoc when using these characters on repositories manipulated by OSX and other systems. It apepars that Windows, Linux silently ignore these changes. We can't really account for this server side, but unicode-path patches exists for Subversion on OSX. For git, a config setting exists that does just that (`core.precomposeunicode`).	9 years ago
Oliver Günther	9db305439d	[22158] Fix CopyProjectJob notifications ... * Actually send copy job notifications * Skip enqueuing notifications when mails are disabled Aggregated journal notifications are sent after a delay, after which the actual job has long completed.	9 years ago
Markus Kahl	d2bc4202ad	make group deletion fast	9 years ago