101 Commits (c5318308cac7e707f628d479258861a968a61c41)

Author	SHA1	Message	Date
Oliver Günther	a6b4372b09	Always preprocess URLs with CGI.unescape ... This forces redirect URLs to always pass through the escaping process, in order to process escaped paths (`/mysubdir/%2E%2E/secret/`).	9 years ago
Jan Sandbrink	2b7261b2ee	move assembly of reports list into controller	9 years ago
Jan Sandbrink	8e4321959e	improve code style	9 years ago
Jan Sandbrink	dfb9a5cd20	remove remaining AR find_by_x finders ... - most of them were removed by @myabc in the rails4 branch - some where reintroduced due to parallel development to that branch - still some occurences left that will hit custom implementations	9 years ago
Jan Sandbrink	2a65240e52	always include relevant columns ... - caller does not need to do it anymore - caller is still allowed to do it, because it can also add own conditions...	9 years ago
Alex Coles	53a224bf76	Remove mutation method calls on AR::Relation ... See: * 6eeea9d1 * http://guides.rubyonrails.org/upgrading_ruby_on_rails.html#mutator-methods-called-on-relation Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Oliver Günther	988c9f38a7	Cucumber fixes ... * Use correct locale for testing * Global namespace refs	9 years ago
Oliver Günther	6eeea9d1da	Avoid mutator sort on relations ... https://github.com/rails/rails/pull/13314 removed mutator methods (e.g., `Array#sort!`) from relations. This commit enforces either an ordering on the query itself where applicable, or uses a non-mutator sort.	9 years ago
Tim Habermaas	5a57a5bf9d	[Refactor] Make wp_hashes_with_string depend solely on its parameters.	9 years ago
Tim Habermaas	d0426dcf17	[Refactor] Use ActiveRecord#find_by_id instead of #find and rescue.	9 years ago
Jens Ulferts	bdf20ef94d	extract work package move/copy to own service	9 years ago
Jens Ulferts	309254bf20	explicitly hand over the current user	9 years ago
Alexander Bach	ee14628c09	Move send_notification to event origin	9 years ago
Alexander Bach	a5f4eb1e8b	First event-based draft ... Unifies Journal- and WorkPackageObserver Removes them as observers Makes new JournalListener more classy	9 years ago
Alex Coles	0ad3cfb4b2	Prefer do…end for controller respond_to blocks ... `rubocop -a` does not currently normalise formatting consistently (see ec1bb39f). Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Florian Kraft	f8d69c5212	address hound complaints ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Jan Sandbrink	f86e0ef591	uglify order statement ... at least this one DOES work...	9 years ago
Jan Sandbrink	253785622c	specify order in the Rails 3 way ... ascending is the default anyway	9 years ago
Jan Sandbrink	9cb9957bbb	also accept auto complete requests without query	9 years ago
Jan Sandbrink	d2eeb27c84	eliminate instance variable	9 years ago
Jan Sandbrink	c9f0fba192	increase readability of wp->hash conversion ... it might use more lines, but I hope there is a gain in readability	9 years ago
Jan Sandbrink	8897235fa4	rewrite find into where, order and limit	9 years ago
Jan Sandbrink	194f1814e1	always return a valid scope ... though WorkPackage works like a scope *most* of the time, it is not a scope e.g. you can't directly call :order on WorkPackage Note: I would have loved to already do it the Rails 4 way and call :all However in Rails 3 :all returns an Array and not a Relation, so we will have to wait for the Rails 4(.1) Upgrade to replace :scoped with :all :( Sorry @myabc	9 years ago
Jan Sandbrink	e51a4005ff	try to increase readability ... - extract scopedeterminition into an extra method - always use "outer" if statements in index method	9 years ago
Jan Sandbrink	280e333f18	explain why some code exists	9 years ago
Jan Sandbrink	2854584cb2	use more clear scopes for autocompletion ... lets see if that really makes stuff more understandable... I (personally) found the old definition of "all" to be too narrow. Now there is: scope == "all": I want to search over all WPs scope == "relatable": I want to search over all WPs that are relatable to WPs in the given project (via project_id) no scope: If I specified a project search over the WPs of that one, otherwise search everywhere (like "all")	9 years ago
Jan Sandbrink	45815cb9f3	rename query to scope ... sounds more understandable to me, but I am biased, I guess...	9 years ago
Alex Coles	0c729dae54	Replace deprecated calls to Model.scoped ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	ec1bb39f9b	Fix syntax (w/Rubocop) in (Rails) controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	9eb7cfbe9b	actually allow the status to be set while moving ... apparently the status_id param was set to expect an array of values while being moved in this commit: d7f399ab8d Probably because the spec started to expect that when it was moved to be an RSpec test. I am not sure if this was ever a valid thing outside the tests...	9 years ago
Jan Sandbrink	d3ceffddfc	actually allow the status to be set while moving ... apparently the status_id param was set to expect an array of values while being moved in this commit: d7f399ab8d Probably because the spec started to expect that when it was moved to be an RSpec test. I am not sure if this was ever a valid thing outside the tests...	9 years ago
Jan Sandbrink	42ec887384	uglify order statement ... at least this one DOES work...	10 years ago
Jan Sandbrink	0f868f17e2	specify order in the Rails 3 way ... ascending is the default anyway	10 years ago
Jan Sandbrink	9ed5480298	also accept auto complete requests without query	10 years ago
Jan Sandbrink	799f3b9b52	eliminate instance variable	10 years ago
Jan Sandbrink	b265ad88db	increase readability of wp->hash conversion ... it might use more lines, but I hope there is a gain in readability	10 years ago
Jan Sandbrink	b524b0724d	rewrite find into where, order and limit	10 years ago
Jan Sandbrink	dd052d5114	always return a valid scope ... though WorkPackage works like a scope *most* of the time, it is not a scope e.g. you can't directly call :order on WorkPackage Note: I would have loved to already do it the Rails 4 way and call :all However in Rails 3 :all returns an Array and not a Relation, so we will have to wait for the Rails 4(.1) Upgrade to replace :scoped with :all :( Sorry @myabc	10 years ago
Jan Sandbrink	dc71f37587	try to increase readability ... - extract scopedeterminition into an extra method - always use "outer" if statements in index method	10 years ago
Jan Sandbrink	4556da741e	explain why some code exists	10 years ago
Jan Sandbrink	d59b54a63c	use more clear scopes for autocompletion ... lets see if that really makes stuff more understandable... I (personally) found the old definition of "all" to be too narrow. Now there is: scope == "all": I want to search over all WPs scope == "relatable": I want to search over all WPs that are relatable to WPs in the given project (via project_id) no scope: If I specified a project search over the WPs of that one, otherwise search everywhere (like "all")	10 years ago
Jan Sandbrink	75b542725a	rename query to scope ... sounds more understandable to me, but I am biased, I guess...	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Alex Coles	bb0e6e6aa5	Fix syntax (w/Rubocop) in (Rails) controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	336446c59d	Use 1.9+ Hash syntax in (Rails) controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	1900e9b55d	Fix whitespace in (Rails) controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Till Breuer	adeb2e4a27	Don't render ok in bulk#delete if clean up is required	11 years ago
Till Breuer	d67bc8b975	Temporarily allow for ajax calls to bulk controller ... Undo when API V3 is ready	11 years ago
Alex Coles	d30ce48539	Begin replacement of server-rendered context menu ... Removes WorksPackages::ContextMenusController, its views and specs, and ContextMenuHelpers. This patch begins the work needed to serialise a given WorkPackage's 'actions' in the v3 API response, based on a user's permissions. This should support a client-rendered context menu (or any other contextual UI for that matter). Much code was simply copy-and-pasted from ContextMenusController into Api::V3::WorkPackagesController. This code still requires considerable refactoring and optimisation. Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago