2834 Commits (c5318308cac7e707f628d479258861a968a61c41)

Author	SHA1	Message	Date
Jan Sandbrink	b524b0724d	rewrite find into where, order and limit	10 years ago
Jan Sandbrink	dd052d5114	always return a valid scope ... though WorkPackage works like a scope *most* of the time, it is not a scope e.g. you can't directly call :order on WorkPackage Note: I would have loved to already do it the Rails 4 way and call :all However in Rails 3 :all returns an Array and not a Relation, so we will have to wait for the Rails 4(.1) Upgrade to replace :scoped with :all :( Sorry @myabc	10 years ago
Jan Sandbrink	dc71f37587	try to increase readability ... - extract scopedeterminition into an extra method - always use "outer" if statements in index method	10 years ago
Jan Sandbrink	4556da741e	explain why some code exists	10 years ago
Jan Sandbrink	d59b54a63c	use more clear scopes for autocompletion ... lets see if that really makes stuff more understandable... I (personally) found the old definition of "all" to be too narrow. Now there is: scope == "all": I want to search over all WPs scope == "relatable": I want to search over all WPs that are relatable to WPs in the given project (via project_id) no scope: If I specified a project search over the WPs of that one, otherwise search everywhere (like "all")	10 years ago
Jan Sandbrink	75b542725a	rename query to scope ... sounds more understandable to me, but I am biased, I guess...	10 years ago
Alex Coles	bc5abb34ab	Remove explicit require_dependency of Principal ... This should no longer be necessary (thanks also to 8edff983). This effectively reverts 423152fa06 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alexander Bach	cbe64452a8	Improve initialization readability	10 years ago
Alex Coles	077e42ba06	Make VersionsController#update use PATCH ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alexander Bach	6c08706c22	Improve initialization readability	10 years ago
Alex Coles	2640852fe3	Fix MembersController#autocomplete_for_member routing ... * make routing less convoluted (as in 18835799). Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ae97716087	Make MyController#account use PATCH ... Now routes form helper-generated request correctly. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ab0864062e	Make WikiController#rename use PATCH ... Now routes form helper-generated request correctly. http://weblog.rubyonrails.org/2012/2/26/edge-rails-patch-is-the-new-primary-http-method-for-updates/ Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	4a69d2505a	replace ternaries returning booleans ... - foo ? true : false was replaced where foo already was bool - foo ? true : false was kept, when the ternary did a bool conversion - foo ? false : true was replaced by either negation or replacing == with != Note: I intentionally left one occurence that is fixed in another running PR and would cause a conflict	10 years ago
Alex Coles	a464c01203	Force bool coercion in API v2 WorkflowsController ... Boolean values are not properly coerced when using `.select` with custom SQL String on PostgreSQL. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	55a2207631	Replace GroupUser join model w/ habtm association ... Active Record 4.x does not generate correct DELETE SQL statements when deleting groups for a given `User` (the `GroupUser` join model does not have a primary key). Callbacks (e.g. `after_remove`) *are* invoked on `has_and_belongs_to_many` associations. This effectively reverts 6c5239c4e2 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Florian Kraft	f78d1b6254	use toolbar component in news sections ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Alex Coles	1ee9b8ee98	Update includes syntax in GroupsController queries ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	dcd75d2a52	"fix" too much space before content in Wiki ... This is a dirty hack to achieve the goal. Nobody should ever have to do this in his live, but there are deadlines and issues considered important... This fixes the issue the dirty way, but it works and has few implications on all other parts of the application. I hope someone will come and delete those lines quickly...	10 years ago
Markus Kahl	d26382362f	jQuery all the way	10 years ago
Markus Kahl	deae307c19	fixed quoting ... Element IDs were out of sync. Added feature spec.	10 years ago
Alex Coles	54ff7af6e7	Add/update Copyright headers in app code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alexander Bach	8bbc880e6c	Actually include columns	10 years ago
Markus Kahl	560d970b0f	in-regex comments	10 years ago
Markus Kahl	4abd716dd6	more comments	10 years ago
Markus Kahl	52fe1da137	don't redirect back to logout	10 years ago
Jan Sandbrink	9f9dc16ed5	make dynamic ID column behave like hardcoded one	10 years ago
Alexander Bach	d23ede7afd	Fix custom field group sums	10 years ago
Markus Kahl	c3fa89e5db	disable password choice config	10 years ago
Jens Ulferts	13e0940171	only display scm options if they are configured	10 years ago
Jens Ulferts	b37ea687e2	showing error messages on scm updates	10 years ago
Alex Coles	fda43ac304	Replace VersionsController#create RJS with jQuery ... Matches `CategoriesController#create` implementation: see 4cc9aaf8. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	07d4ea4edd	Fix version select style on wp form inline create ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jean-Philippe Lang	b9439a2ed3	[XSS Vulnerability] Escape flash messages (#19117). ... git-svn-id: http://svn.redmine.org/redmine/trunk@14016 e93f8b46-1217-0410-a6f0-8f06a7374b81	10 years ago
Jens Ulferts	dd44451b6e	fix parameter naming	10 years ago
Jens Ulferts	5e2e44ee70	fix previewing work package journal notes	10 years ago
Jens Ulferts	fdd3bd80b6	fix test_unit tests	10 years ago
Florian Kraft	69697f7e6a	update project dependency forms	10 years ago
Florian Kraft	b45713d7af	fix the api reportings controller	10 years ago
Jens Ulferts	65de31a7c7	use tabular form builder for project module selection ... * Extends the tabular form builder with the ability to generate check boxes for values that are an array. * Fixes module_enabled? to actually return a boolean * Adapts projects_controller to changed params structure.	10 years ago
Florian Kraft	c24bf1969a	rename method	10 years ago
Florian Kraft	bf90240874	Refactor ReportingsController to be more readable	10 years ago
Florian Kraft	cc2afee99c	fix controller response ... As the diff action claims to be more generic, react with a 404 instead of a 403 whenever the journable type is not a WorkPackage. This makes the the use of the diff action less generic, as a user will still need the view_work_pacakges permission to access the diff action.	10 years ago
Florian Kraft	22853c8b46	Fix the coding style via rubocop	10 years ago
Florian Kraft	cb2f3f30d6	Fix error where anyone could read the diff of a WP ... With this fix it is no longer possible to view a description diff without the necessary permissions. The error was reported by Jan Sandbrink in https://community.openproject.org/work_packages/16974.	10 years ago
Jonas Heinrich	5bf6fb88b9	Adds success message	10 years ago
Florian Kraft	f17a7c608e	fix a project nil call on querying visibility ... this fixes an internal error by checking a connected project first before calling visible? on it. This should fix the internal error reported by Nadejda Parpulova in https://community.openproject.org/work_packages/18460	10 years ago
Alex Coles	64b288af36	Remove MessagesHelper includes ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Markus Kahl	ba7d247817	use IDs in CopyProjectJob; send mail synchronously ... also moved the job into the workers directory	10 years ago
Markus Kahl	dc14f36fc6	spec Attachment#show	10 years ago