2974 Commits (c57313c4cecc1738768262c064762283d7664f9c)

Author	SHA1	Message	Date
Jens Ulferts	8c364aff89	optimize watcher pruning on group modifications ... Less db queries when * removing a member from a group * removing a group from a project * removing a group Mostly this is done by * adding eager load statements where neessary * pruning watchers only once Please note, that the last is only possible via hack which consists of passing a flag which prevents calling prune when we already know that the pruning will take place later on anyway.	8 years ago
Jens Ulferts	701f196c25	eager load user and version custom fields in wp representer	8 years ago
Markus Kahl	91b2645460	fixed pagination	8 years ago
Jens Ulferts	94b1e5e220	rework Watcher.prune for performance ... Makes use of being able to check for a batch of permissions (either by user or by project) to drastically reduce the time required for pruning watchers. Additionally, we load all watchers that satisfy the combination of belonging to on of the users passed belonging to a watchable scoped to one of the projects passed at once.	8 years ago
Oliver Günther	7dc45bcea8	[24311] Fix n+2 query in MemberRole	8 years ago
Jens Ulferts	2c382b9d3d	use request store to mitigate n+1 query	8 years ago
Jens Ulferts	8c916f12f3	eager load cf translations	8 years ago
Oliver Günther	65ca248914	Do not extend query for scope	8 years ago
Oliver Günther	086f1ef40b	[24272] Fix enabled_modules usage in project copy	8 years ago
cklein	9c59621c1e	Auto hide popups. ... https://community.openproject.com/work_packages/24152	8 years ago
Oliver Günther	be58cfed78	Extend Query to accept a different scope to search on	8 years ago
Jens Ulferts	15899a98ba	never override .name - it messes with reloading	8 years ago
Jens Ulferts	d1f0aaf74b	cleanup class variables	8 years ago
Jens Ulferts	c71a675ecd	introduce true/false db representation constants for cf	8 years ago
Jens Ulferts	a5a13cf8d7	remove problematic distinct	8 years ago
Oliver Günther	a4df9f9bb6	Write accessors to model and default_scope as methods ... Otherwise, they are define when the query is loaded and that might be before other descendants of user are known.	8 years ago
Jens Ulferts	d4e71fd67e	add user query and enabled it in the users api	8 years ago
Oliver Günther	05a54adced	Serialize column_names as arrays ... Currently, column_names on production systems are either 1. YAML-serialized Arrays of column names (duh) 2. An empty string '' 3. nil The two latter are invalid with Rails 5 and cause the following error: ``` NoMethodError (undefined method `map' for "":String): app/controllers/api/experimental/concerns/v3_naming.rb:70:in `json_query_as_v3' app/controllers/api/experimental/work_packages_controller.rb:85:in `query_as_json' app/controllers/api/experimental/work_packages_controller.rb:51:in `index' app/middleware/reset_current_user.rb:47:in `call' ``` This commit forces Array serialization and fixes previous queries with the empty values.	8 years ago
Jens Ulferts	1a597e180b	first step towards generalizing the query and its filters	8 years ago
Markus Kahl	39dbb84373	available relation candidates	8 years ago
Jens Ulferts	6c5177d8bf	fix reverse and sym of new relation types	8 years ago
Jens Ulferts	bcff977924	prevent circular dependency of 'from' relations ... The previous implementation to detect circular dependencies was limited to detecting those circles, that originated in the 'to' work package of a relation. It did not prevent circles where the 'from' work package is involved. Now, both branches are checked. While this removes the immediate issue, it also increases the time required for saving a relation. As long as our database does not provide us the capacity for recursive queries, this cannot be helped.	8 years ago
Jens Ulferts	c3013d6272	lazy load query filters and extract them into classes ... This allows us to only load the values we actually need instead of loading all the values regardless of whether we need them. This is especially usefull in the api where we currently never need those values. Note, that this is a glitch in my opinion as we do not check whether the filter value is valid.	8 years ago
Jens Ulferts	f60118e260	replace deprecated uniq by distinct	8 years ago
manuschiller	84f42b8586	adds new relation types and patch method to update relations" q	8 years ago
Jens Ulferts	8f1c5d76b7	allow parent project to be set on copy	8 years ago
Jens Ulferts	fc3f04f7c1	remove dead code	8 years ago
Jens Ulferts	6c69cb5583	improve query generated by spent time join ... The former query joined all work packages with their descendants which resulted in a very poor performance.	8 years ago
Jens Ulferts	a5ec412f3d	harmonize saving plugin settings	8 years ago
Jens Ulferts	01bbc0face	harmonize settings#value to not be AC::Params	8 years ago
Markus Kahl	9fc18f6bf6	must be a path if we can't parse it as an URI ... also even if it was an URI, it's no good if it's invalid	8 years ago
Jens Ulferts	da7b63eeb7	discard empty and duplicate permissions	8 years ago
Markus Kahl	471733ab05	prevent renaming wiki pages if there will be menu item conflicts	8 years ago
Jens Ulferts	a6d265eb79	force bool custom values to be stored uniformly	8 years ago
Jens Ulferts	a22b0dfd2b	force options on timelines to be a hash ... There used to be a mix of Hash and ActionController::Parameters in the database	8 years ago
Oliver Günther	4fab8974ce	Fix legacy search controller spec after permitted params	8 years ago
Oliver Günther	8391a9c0d2	Use PermittedParams to allow search parameters	8 years ago
Oliver Günther	9ff3bd8ad9	Add temporary hash-like check for AC::Params	8 years ago
Jens Ulferts	9cef3656bf	replace deprecated table_exists	8 years ago
Jens Ulferts	c00a2602e2	fix permitting custom field value params	8 years ago
Jens Ulferts	2dd3a9a339	use AR .arel_table to avoid deprecation	8 years ago
Oliver Günther	47cf64f46e	Avoid checking for Hash on params	8 years ago
Oliver Günther	7e8f21f5a6	Check presence on RolePermission	8 years ago
Oliver Günther	117dfa4e2d	Legacy: Fix functional projects controller spec	8 years ago
Oliver Günther	4224430a9e	Unescape HTML entities after `strip_tags`	8 years ago
Oliver Günther	2cc285251a	Fix invalid self-reference	8 years ago
Jens Ulferts	db6d2c6ffd	use project.id specifically to avoid db error	8 years ago
Jens Ulferts	181514742f	replace observers by moving functionality inside the observed object ... The observers should have been removed a long time ago and with rails 5 there is https://github.com/rails/rails-observers/issues/52 to consider as well.	8 years ago
Jens Ulferts	3b9df1f3e0	adapt sanitizer used	8 years ago
Jens Ulferts	05f0bc2a5b	replace deprecated merge!	8 years ago