238 Commits (c5be3022efcafcd34138e81ad0dfcd9cf43d481b)

Author	SHA1	Message	Date
Oliver Günther	726241bc95	[30532] Don't submit notification mails for parent changes ... https://community.openproject.com/wp/30532	5 years ago
ulferts	cc0145daf6	prevent useless edits to wp status ... In case the fixed version and the status of a work package are both closed, the status of a work package cannot be altered any more. Attempting it will result in an error. Before the fix, the possible status calculation would not factor in that situation and the status would be marked as writable regardless as well. Therefore, the frontend would display a list of statuses even though selecting one would do nothing at all. Now, the status property is marked as non writable in such a situation and the status list will only contain the current status. As we only fetch the form after a click on the edit field, we can only disable the field after that which is a bit weird.	5 years ago
ulferts	a93ecca5a8	Feature/members api show (#7308) ... * basic members collection response * complete member index end point * document versions#index * remove user association from members There is already a more generic principals association. Having both causes confusion and leads to duplicate loading of models * linting * remove disabled test * add members#show api end point * add project and principal to member representer * replace member.user reference with principal * use principal reference in project members association * modernize roles api * complete member representer rendering * replace remnants of user association * add member schema api endpoint * have dedicated available projects end point for versions * linting * limit roles to assignable ones in schema * rename member to membership in api * remove remnants of user in member * spec fixes * use available_projects endpoint in versions board * add eager loading to memberships#index * members create form api endpoint * ensure role exists for default assignment * extract switch for users/groups to work_packages representer * document membership create form * add l10n expected in specs * strengthen the usage of a delete base service * use base class for set attributes service * fix alias in service * add create endpoint to members api * document members create endpoint * linting * adapt to altered service signature * use default endpoint for wp#get * use CF infused representer [ci skip]	6 years ago
ulferts	1850622f20	Feature/versions api update (#7299) ... Feature/versions api update [ci skip]	6 years ago
Oliver Günther	5b49b33b21	Prepare for core integration	6 years ago
Oliver Günther	3ba6913960	Implement read-only work package attributes based on status	6 years ago
Jens Ulferts	8d7a59806a	remove unused service ... Has been part of the timelines functionality	6 years ago
Jens Ulferts	26f984c64e	avoid sending mail in unit spec	6 years ago
Oliver Günther	3807bc4f7f	[28446] Rename due date to finish date ... https://community.openproject.com/wp/28446	6 years ago
Wieland Lindenthal	57892d782b	Satisfy spec and code climate	6 years ago
Jens Ulferts	a8e5ab619f	adapt to core's altered eager loading	7 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot ... Removes the deprecation	7 years ago
Oliver Günther	61afac09cc	FactoryGirl => FactoryBot (belongs to opf/openproject#6304)	7 years ago
Jens Ulferts	b3a11a0fd9	replace deprecated references to changes in after_save hooks	7 years ago
Jens Ulferts	77cd58a1b2	fix error access	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Jens Ulferts	a1812699f0	validate actions	7 years ago
Jens Ulferts	42e5933545	improve wp#index performance by eager loading custom actions	7 years ago
Jens Ulferts	d20960b998	add role condition	7 years ago
Jens Ulferts	886273ee86	initial implementation of conditions - status	7 years ago
Markus Kahl	3cf3a77b07	added aggregated wp journal ready event for notifications	7 years ago
ulferts	a8c1953cf5	always return a custom value if it is available in the customizable (#6075) ... [ci skip]	7 years ago
Jens Ulferts	690e0ffc60	wp create/update/destroy via services	7 years ago
Jens Ulferts	6fdd122534	merge wp tree and relations into typed_dag ... Instead of having the tree/hierarchy information for work packages and the relations between the work packages separated into two tables all the information is now stored in the relations table. To support this, the typed_dag plugin is used. Notable changes: * relations_to and relations_from are swapped. relations_to has all relations that point to another work package (from_id = work_package.id) and relations_from contains all relations that lead to the work package from another one (to_id = work_package.id). This change is merely in the code. The db information is left untouched. * For follows/precedes to_id and from_id are swapped in the db. Because of that, "follows" is now the canonical name instead of "precedes". This is done so that hierarchy relations and follows relations point into the same direction which allows to easily detect cyclic relationships that would lead to infinit scheduling. * the columns `root_id`, `lft`, `rgt` do no longer exist in the wp table. * the column `relation_type` does no longer exist in the relations table. * For every type of relation a column (integer) does now exist in the relations table (e.g. hierarchy, block, follow) * Separate associations exist for every type of relation into two directions. E.g. Work packages following the current one can be accessed via `work_package.precedes`	7 years ago
ulferts	2f9d7f408a	Fix/wp table switch to milestone (#5825) ... * map date name in changeset * handle date switch in wp form * Don't stub_const for services that may exist before hand This will cause the const to be evaluated already, so that stub_const has no effect there. This is why this fails depending on the order on travis, but not locally/isolated. [ci skip]	7 years ago
Jens Ulferts	1d66745a5d	fix additional workflows for assignee and roles	7 years ago
ulferts	c0b709530c	Fix/replace deprecations (#5533) ... * replace alias_method_chain * remove deprecation silencing * bump controller-testing * introduce permitted params for settings * replace various deprecations in controllers * remove deprecation silencing for legacy_specs * remove `puts` from spec * replace deprecated access to errors * remove unnecessary AR::Parameters usage in spec * specify error to expect * replace deprecations * replace deprecated action calls in legacy function specs * replace deprecations in functional controller tests * replace deprecations in controllers/controller_specs * remove params parser which does not seem to be in effect It is registered for the content type :exclude which makes no sense as it should deal with :json. The desired behaviour of the api dealing with parsing errors is working with or without the code. * replace deprecations in unit specs * replace alias_method_chain [ci skip]	7 years ago
Edward Betts	437bbd51bf	correct spelling mistakes (#5748) ... [ci skip]	7 years ago
Oliver Günther	8fcfc834a3	[25269] Add typed_custom_value_for to retrieve CF value names ... To provide a common interface to get _ALL_ values for the given custom field id (either multi or single value), this PR adds `typed_custom_value_for` which maps all custom_values (if any) to their `typed_value`s. This is a requirement to output all values in `QueryCustomFieldColumn`.	8 years ago
ulferts	21571ac3a2	Fix/add child rescheduling (#5499) ... A work package that is to be added as a child needs to be rescheduled to not validate any constraints posed by relations the parent work package might have [ci skip]	8 years ago
Markus Kahl	b51b8d3106	don't send notifications for selected projects if not enabled	8 years ago
Jens Ulferts	42dd05cd31	encapsulate core's spent_time by placing it in a subquery	8 years ago
Markus Kahl	f5a57e3f42	list custom field normalisation and multi select	8 years ago
Oliver Günther	c05a54b40d	Add ancestors information through separate grouped SQL	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	780906a051	prevent WorkPackage#visible to result in duplicate entries for pluck ... If Project.allowed_to is joined to WorkPackage, the result set will have as many entries, as the user has roles (with the queried for permission) in a given project. Normally, this is not a problem as rails prevents instantiating duplicate WorkPackages on a single call. But when we only pluck, then, in combination with limit, we will end up with too few results as we get duplicate rows and only take the first x once.	8 years ago
Jens Ulferts	6aa7fc5566	fix calculating spent time, labor/material costs when more than one value is present	8 years ago
Jens Ulferts	701f196c25	eager load user and version custom fields in wp representer	8 years ago
Jens Ulferts	1a597e180b	first step towards generalizing the query and its filters	8 years ago
Markus Kahl	104bde6ad7	execute wp notifications as recipient for permissions	8 years ago
Jens Ulferts	26fd453ca4	handle spec permissions the new way	8 years ago
Jens Ulferts	ea36f19be2	replace ineffective permission assignments	8 years ago
Jens Ulferts	ff3ecc9e59	employ sql based user allowed scope for acts as watchable	8 years ago
Oliver Günther	550763ae46	Do not 'inherit' priority from children ... This removes updating of priority values from children to parent work packages.	8 years ago
Markus Kahl	8f0c9ae24d	fixed inherit_done_ratio_from_leaves bug (#4665) ... which could result in parent progress values greater than 100	8 years ago
Jens Ulferts	8b8951d75a	handle rescheduling when only a start date exists	8 years ago
Jens Ulferts	9e6e29ecdc	limit scheduling to TYPE_PRECEDES	8 years ago
Jens Ulferts	f41fdbfdfb	limit moving backwards when another relation exists	8 years ago
Jens Ulferts	38fb7c396a	initial implementation of moving work packages backwards	8 years ago
Jens Ulferts	a9ab34f450	add specs for rescheduling based on follows relationship	8 years ago