62 Commits (c703249baeb0550ec9aee295b523511e6266e0ea)

Author	SHA1	Message	Date
Oliver Günther	f42ff4bdd6	[28543] Validate Type#attribute_groups in contract ... Validating attribute groups is only relevant when creating or updating the type in the administration. There's no need to validate this in the type itself. https://community.openproject.com/wp/28543	6 years ago
Oliver Günther	0d59680815	[28086] Add error when moving to milestone with children ... https://community.openproject.com/wp/28086	6 years ago
Oliver Günther	aa9897561b	[28455] Ensure model contracts are initiaited immediately before saving	6 years ago
Oliver Günther	f3e2100247	Save highlighting mode to query	6 years ago
Jens Ulferts	17efd9c84b	fix adding notes to work packages ... in 395c665627 the to generous interpretation of the :add_work_package_notes, that allowed user having the permission to alter additional attributes was removed. But after the removal a user having the permission was no longer allowed to add notes at all.	6 years ago
Jens Ulferts	abda9056cd	add attachment on new resource via rails form	6 years ago
Jens Ulferts	e58a96515c	allow setting attachments through wp post/patch	7 years ago
Oliver Günther	286d862c38	[27746] When validating the contract, ignore the old parent ... https://community.openproject.com/wp/27746	7 years ago
Jens Ulferts	61dddffc15	move relation_type validation to contract	7 years ago
Jens Ulferts	9bf5d05fdb	add description on custom action ... * turn custom action into fully fledged resource * add description to custom action model * load custom action resource on mouse over and display in title	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Jens Ulferts	f1d81ae2a5	validate conditions	7 years ago
Jens Ulferts	a1812699f0	validate actions	7 years ago
Jens Ulferts	fc10be5a73	use ar name for validation	7 years ago
ulferts	09751f9f25	allow relations to be altered and also inverted (#6120) ... [ci skip]	7 years ago
ulferts	83e605e63c	allow setting parent that has relation via new siblings (#6114) ... [ci skip]	7 years ago
ulferts	bf28dfb830	tweak circular dependency detection when siblings already have a follows relation (#6107) ... Instead of going to root, we now only go up till to's first ancestor not shared with from. That way, we avoid wrongfully detecting transitive follows + hierarchy relations from to's root pointing to from. [ci skip]	7 years ago
Jens Ulferts	a4af690d0e	more leniency with existing follows relations	7 years ago
ulferts	0c8ec533c0	allow creating follows relations among siblings (#6093) ... [ci skip]	7 years ago
ulferts	6b9e7066fd	streamline relation in hierarchy error message (#6056) ... [ci skip]	7 years ago
ulferts	634f45d6fc	prevent circular scheduling relationship (#6062) ... [ci skip]	7 years ago
ulferts	1cc9601d30	Fix/circular dependency error handling (#6040) ... * recreation of reflexive relations is handled by gem * bump typed_dag * adapt method name as typo was fixed in gem * provide l10n for circular relationships * avoid overriding method [ci skip]	7 years ago
Jens Ulferts	763a154eb8	actually execute validations	7 years ago
Jens Ulferts	d2fe896b88	fix error localization in relations ... For reasons beyond me, using validated :to do add an error end seems to be execute in a different context (class) than attribute :to do add an error end The later, has the correct i18n_scope set as it is a child of ::ModelContract.	7 years ago
Jens Ulferts	690e0ffc60	wp create/update/destroy via services	7 years ago
Oliver Günther	ed1a0c87de	[25999] Make timeline labels configurable ... https://community.openproject.com/wp/25999	7 years ago
ulferts	7154caec85	Fix/consolidate representers (#5732) ... * consolidate representers Minimizes the need for extensive payload representers by: * introducing the payload_representer module which removes all non writable propertyies from a representer * introducing the resource/resources/associated_resource/associated_ressources helper methods which provide a framework for having a representer suitable for parsing and rendering Additionally increases the importance of the contracts by using them to calculate the writeable attributes. * remove unused endpoint [ci skip]	7 years ago
ulferts	f4b36edccb	Feature/save zoom in query 7 1 (#5637) ... * Implement timeline zoom level as query enum * Implement query zoom handling in frontend Had to refactor: 1. The zoom level enum in the frontend cannot properly be matched to strings so I chose a separate type instead to map to the string retrieved from /sent to the query 2. The way query updates are done through the states. The previous implementation only worked for one single attribute state. For the timeline state, it does not make sense to split that into two, so I delegate to the state to handle checking and updating the query. * Extend feature spec for zoom saving * Refactor URLParamsHelper into TS service * Fix comparison in table query services * Remove reference to allowedValues [ci skip]	8 years ago
Oliver Günther	6b372acae6	Implement timeline zoom level as query enum	8 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465) ... * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
ulferts	51f5f31d3a	prevent nil with date comparison error (#5508) ... [ci skip]	8 years ago
ulferts	21571ac3a2	Fix/add child rescheduling (#5499) ... A work package that is to be added as a child needs to be rescheduled to not validate any constraints posed by relations the parent work package might have [ci skip]	8 years ago
Oliver Günther	7144f28662	[24972] Make hierarchy mode state part of query	8 years ago
Oliver Günther	34d029d055	[24575] Instrument timeline visibility state through query	8 years ago
Markus Kahl	7235cbbb26	check permission outside of project context correctly	8 years ago
Markus Kahl	6cc211cab0	fixed update_query_spec	8 years ago
Markus Kahl	9f0123a703	query update and query update form wip	8 years ago
Markus Kahl	4b55e72433	be smart	8 years ago
Markus Kahl	9ffbe49bac	make sure project is visible	8 years ago
Markus Kahl	e257294795	validate project if set	8 years ago
Markus Kahl	9e79d02d8f	queries create and create form api endpoints	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Markus Kahl	64db3d3b8a	allow writing admin flag	8 years ago
Markus Kahl	9671e6368a	added missing auth fields to user endpoint	8 years ago
Markus Kahl	6b84e9788c	fixed the relations contract which was sabotaged by delayed_job	8 years ago
Oliver Günther	6cbfc7ffed	[24063] Add Users PATCH endpoint	8 years ago
Oliver Günther	9dc8d09516	Add CreateUser API endpoint and spec	8 years ago
Oliver Günther	c284109d70	User contract: Require password set when status is `active`	8 years ago
Oliver Günther	826ec7b7b6	Add CreateUserService and User contracts	8 years ago
Markus Kahl	6f91bd09b1	code climate	8 years ago