openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	8be49d1c62	only store notification resons for in app (#9419 ) We currently only diplay it for in app. This might change once digests are introduced	3 years ago
ulferts	bd3f182c3d	adapt specs	3 years ago
Oliver Günther	d2ce834e23	[37866] Add attachment_created event and webhook (#9418 ) * [37866] Add attachment_created event and webhook * Remove other usages of direct attachment creation * Add attachment webhook spec * Fix other webhook specs * Fix attachment adding in mail_handler * Don't set content_type outside attachment#file= * Fix unrelated spec Co-authored-by: ulferts <jens.ulferts@googlemail.com>	3 years ago
ulferts	f9b69abeeb	correct expected links to docs	3 years ago
ulferts	f8b28b300c	treat nil value as non false The default BooleanEquals filter treats null same as false. Because of that, notifications that are not meant for ian were displayed. The BooleanEqualsStrict filter only filters for false as expected so that the notifications are not displayed.	3 years ago
Oliver Günther	15b0dc06a8	Fix read status and add spec (#9410 )	3 years ago
ulferts	261b0fa5c3	add bulk read/unread enpoint for notifications	3 years ago
Oliver Günther	9636a08988	[26688] In-app notifications (#9399 ) * Add bell icon to icon font * Add in app notification in top menu * Add fullscreen modal * Add notification modal and items * Style items * Toggle details of item * Mark all read * Add no results box * wip specification for event api * Add events table, query and index * Send out events from WP notification mailer job There we have the recipients present * Add cleanup job for older events with a setting * Hide bell notification when not logged * Add specs for events API index/show * Fix setting yml key * remove pry in event creation * Fix before hook in events API to after_validation * Fix polymorphic association raising exception for aggregated journals * Fix typo in read_ian * Fix yml entry for mentioned * Add read/unread post actions to event API and add specs * Wire up API to frontend * Fix order on events * Switch to unread in notification * Add event query * rename WPEventService * route wp mail sending over events * rename spec methods * author becomes watcher * correct message call signature * rename events to notifications * renname parameter to reflect notification nature * create author watcher for existing work packages * Merge unreadCount from store * Take a stab at polymorphic representers * Fix link generation in polymorphic resources For journals, no title is being generated however * Fix frontend model for context * Use timer for polling * add notification_setting data layer * Fix show resource spec * Fix duplicate class in notification bell item * Add minimal feature spec for notification * API for notification settings * Persist notifications * adapt work package notification creation to notification settings * extract notified_on_all * consolidate wp#recipients * concentrate wp notification in journal service * simplify methods * Remove unused patch endpoint * Add specs for rendering and parsing notification settings * Contract spec * Update service spec * adapt specs * Angular notifications frontend commit `e29dced646` Author: Wieland Lindenthal <w.lindenthal@forkmerge.com> Date: Mon Jun 21 17:34:50 2021 +0200 Create Akita store and query for notification settings commit `1a45c26c1a` Author: Wieland Lindenthal <w.lindenthal@forkmerge.com> Date: Mon Jun 21 11:09:25 2021 +0200 Remove tabs from notificaition settings page commit `0ea21e90c1` Author: Oliver Günther <mail@oliverguenther.de> Date: Sun Jun 20 21:55:48 2021 +0200 WIP in app settings * migrate notification data * add project visible filter to project query * Add inline-create and table display grouped by project * Add notifications under admin/users * Remove notifications partial * Rename notififcations store to user preferences store * Add setting for self_notified and hook that up to the backend * Add aria-label to table checkboxes * Restyle table and toolbar * replace remains of mail_notifications attribute * initialize notification settings for new user * adapt my_preferences references * reenable no self notified for documents * adapt specs * Avoid has_many :notifcation_settings Rails magically autosaves the user's preferences when the user gets saved, which somehow also tries to save the notfifications even when unchanged. This breaks some specs such as the avatar upload spec. As we can't update the assocation through rails anyway, just delegate to the user for reading instead. * Restore update method of notification settings * Restore update spec * fix spec syntax * lint scss * linting * Fix content_tag for bell icon * Add feature specs for notification settings * Disable ContentTag cop * use visible filter to get projects for notification The visible filter will reduce the project list down to the set of projects visible to the user provided as a parameter. This includes public projects. * test for actual mail sending * adapt me resource path this.apiV3Service.users.me changed its type in `0d6c0b6bc7` * Implement changed migration * Linting * Add actor to notification representer * Fix factory creating a duplicate WP journal * Add work packages loading and journal details to notification entry component * IAN basic facets, keep and expanded states. * Fix notification bell spec * Render body separately and add auto updating relative time * Add fixedTime title * Add actor to notification entry * Fix clicking links on work package and project * Tiny styling changes on entry row * Disable count in notification if larger than 99 (wont fit) * Introduce virtual scrolling to entry table * allow delaying & prevent mail sending if ain read Introduces a setting to delay mail sending after a journal aggregation time has expired. That way, users can confirm a notification in app. If they do before the delay expires, no mail is sent out additionally for that user. * consolidate notifications (in&out) into shared admin menu Co-authored-by: ulferts <jens.ulferts@googlemail.com> Co-authored-by: Wieland Lindenthal <w.lindenthal@forkmerge.com>	3 years ago
ulferts	2a015eeac3	Feature/journal aggregation on write (#9396 ) * aggregate journals on write - simple implementation * remove references to aggregated journals on read * rewrite existing journals to be aggregated * remove aggregated journal reference * only delete predecessor if it can be aggregated * fix aggregation condition * adapt specs * remove aggregated journal functionality from production code The code is still necessary in a migration for the time being * adapt specs * use polymorphic belongs_to for journal data The association can then be employed for eager loading * eager load for activity rendering	3 years ago
Oliver Günther	46599dd90e	[37274] Remove accessibleClick (#9355 ) * Remove accessibleClick from wp-single-card * Remove accessibleClick directive itself * Fix context menu with button * Add common mixin for unset-button-styles * relations button * Editable query and toolbar * Resizer button * Replace wp-create button * Replace relation description value * Replace type form * Replace pagination links * Replace button styles for attachment dropzone * Replace accessibleClick in tile-view * Replace inline create * Replace display container with button * Replace text in notification on boards error * Replace global search component * Fix pagination spec * Fix specs * Fix triggering display field on enter * Make search toggle a button * Review feedback	3 years ago
Oliver Günther	a0b92d8575	[37607] Fix pluralization fallbacks (#9388 ) Always use the :other key for falling back to locales, or return nil to ensure the english pluralization keys are used https://community.openproject.org/wp/37607	3 years ago
ulferts	9e66604dec	allow project identifier to begin with numbers (#9377 )	3 years ago
Aleix Suau	7e2e05c88f	Feature/36390 code structure (#9319 ) * core/shared/features in progress * shared/components in progress * Fix rebase errors * core: added admin + apiv3 * shared: attachments + attirbute-help-text * core: OpenprojectAugmentingModule * shared: OpenprojectAutocompleterModule * shared: Autocompleter * feature: backlog * feature: bim * feature: boards * shared: calendar * core: userModule * feature: dashboards * shared: editor * shared: fields * shared: focus * core: globalsearch * shared: grid * shared: grid fix * core: hal * shared: icon * feature: invite user modal * feature: job status * shared: members autocomplete * shared: modal * feature: my page * feature: overview * shared: principal * feature: projects * feature: repoting * core: routing * shared: time entries * shared: OpenprojectWorkPackageGraphsModule * feature: workpackages * core: active window * shared: autofocus * features: wp: back-button * core: browser * shared: collapseible section * core: config * shared: copy-to-clipboard * shared: date-time * shared: helpers: drag-and-drop * shared: draggable autocompleter * shared: dynamic bootstrapper * shared: dynamic forms * features: wp: edit actions bar * shared: EditableToolbarTitleComponent * core: BannersService * shared: OpFormFieldComponent * shared: hide section * shared: highlight col * core: I18 + Sanitizer * shared: isClickedWithModifier * core: LoadingIndicator * core: Modal Heading * core: Model auth * shared: no results * shared: notifications * shared: datepicker * shared: option-list * core: path helper * shared: persistent toggle * shared: remote field * shared: set click position * shared: slide toggle * shared: tabs * shared: drag-scroll * shared: keyCodes * shared: OPSharedModule * global styles: common * core: * import fixes * shared: Enterprise banner * features: wps: filters * features: home screen * import fixes * core: html * import fixes * core: main-menu * features: home screen * shared: modals * shared: op-context-menu * core + shared: current project * core: schema-cache * shared: table-pagination * features: wps: time-entries * shared: user-link * features: wps * features: wps * features: wps: all wp-* components * core: states * Rename: angular4-modules to app.module * core: expression service * Modules just with plugins * Test fixes * added missing content-tabs.component.sass * Replaced with .op-ckeditor--wrapper * Replaced by .op-ckeditor-source-element * Replaced by the entire wysiwyg_editor.rb with dev version * Replacements by ckeditor-augmented-textarea * Fixes ./spec/support/components/work_packages/table_configuration_modal.rb:106 * Fixes ./modules/reporting/spec/features/update_entries_spec.rb:69 * work_packages renamed to work-packages * TimeEntryChangeset moved to helpers * 'filters' moved to wps/components * 'admin' moved to features * HAL moved to shared * plugins moved to features * plugins moved to features * Test fixes * Unit test fixes * plugin generator into /features/plugins * fix sass rule indentation * Revert "plugins moved to features" This reverts commit `f65ccbfd4b`. * Import fixes * Avoid commiting in linked plugins Co-authored-by: ulferts <jens.ulferts@googlemail.com> Co-authored-by: Oliver Günther <mail@oliverguenther.de>	3 years ago
ulferts	a8c075e258	[#37583 ] Error "Identifier is invalid" (#9373 ) * [#37583] Error "Identifier is invalid" Happens when creating a project that starts with a digit or a hypen. The functionality is added by extending acts_as_url to support a custom_rule lambda. https://community.openproject.org/work_packages/37583 * handle empty base_url in acts_as_url custom_rule	3 years ago
Phil Davis	bbe289cadd	Fix various docs typos	3 years ago
Oliver Günther	e40b8367a5	[37555] Fix fullscreen link in notification https://community.openproject.org/wp/37555	3 years ago
ulferts	4cd75489ff	Fix/nil parent rendering (#9339 ) * next apiv_3 undisclosed i18n key * fix parent rendering condition Not having a parent should be visible	3 years ago
ulferts	2f00810e92	Bug/35510 editing project settings removes link to parent project for certain permission constellations (#9336 ) * breakup spec file into individual files * spec changing project without changing parent * have spec specific to project representer rendering * prevent parent from being embedded if user is not allowed to see it * extract urn into constant * handle parsing of a hidden uri * commit hidden uri * extract methods * improve understandability of undisclosed parent property * extract method to increase understandability * centralize information on default/none option * Remove unnecessary cast and cleaner structure * adapt expected fieldset in spec Co-authored-by: Oliver Günther <mail@oliverguenther.de>	3 years ago
Oliver Günther	fc090ac024	[37136] Disable delete button and check for deletion (#9338 ) https://community.openproject.org/wp/37136	3 years ago
Oliver Günther	e363d2f2fd	Remove accessible-by-keyboard a11y component (#9331 ) * Replace accessible-by-keyboard * Replace messed up inplace styles with work-package-comment bem block The styles are not used anymore except for work package comments anyway * Replace split view icons with buttons * Make back-button its own bem block * Replace button in hide-section component * Replace activity buttons * Replace notification icon * Replace collapsible-section * Replace config-menu * Make attribute help text trigger a button * Ensure all buttons are role=button * Replace inplace save controls * Replace relations buttons * Replace relation toggle button * Replace relation row buttons * Replace breadcrumb parent * Replace activities toggler * Remove accessible-by-keyboard component * Fix button role to button type * Fix indent * Bemmify media query * Fix specs	3 years ago
Benjamin Bädorf	a4e136ac92	Fix/37468 dynamic form a11y (#9328 ) * Improve form a11y * Show invalid status only for screenreaders * Improve HTML of dynamic form fieldsets * Remove unused import * Fix specs * Remove merge conflict marker * Fix more specs * Fix project page specific attribute help text spec	3 years ago
ulferts	2b74e8c92b	fix `required` value for properties on project resource (#9337 )	3 years ago
Oliver Günther	8ace160470	[37510] Fix accesing nil fragment in custom field injector (#9335 ) https://community.openproject.org/wp/37510 This got broken in `065dfbddc4` when changing the nil parsing of representable	3 years ago
Aleix Suau	f1a3124098	fix: deletes date properly (#9333 ) * fix: deletes date properly * Close datepicker on escape on input * Add regression spec to date input Co-authored-by: Oliver Günther <mail@oliverguenther.de>	3 years ago
Oliver Günther	195b93ad30	[37463] Pass in work package project to IUM (#9324 ) * [37463] Pass in work package project to IUM https://community.openproject.org/work_packages/37463 * Add projectId from select input formly field	3 years ago
ulferts	20a9f91a22	ensure project status is saved (#9325 ) aweseome_nested_set, used for maintaining the project hierarchy, reloads the project after saving. Any change to an associated model, e.g. the status, is lost upon reloading. Thus, saving of the status needs to take place before saving the project. This is safe to do since it is carried out in a transaction and all the validations are run for the status as well. https://community.openproject.org/work_packages/37464	3 years ago
Oliver Günther	0f040daf39	[37453] Fix user custom fields on new projects not being selectable (#9318 ) * Filter for any members when the project is not persisted * Fix trying to load invite user permission for empty projects * Add spec for setting a user cf for projects	3 years ago
Aleix Suau	af30a8fe39	fix: deletes date properly (#9323 ) * fix: deletes date properly * Close datepicker on escape on input * Add regression spec to date input Co-authored-by: Oliver Günther <mail@oliverguenther.de>	3 years ago
Wieland Lindenthal	44d57d36c6	Fix #37136 : Restrict deletion of placeholder users (#9294 )	4 years ago
Behrokh Satarnejad	bd6ce44eff	[35354]Harmonize work package autocompleters (replacement of wp relations autocompleter) (#9225 ) * replace the autocompleter in wp relations with the new op-autocompleter component * resolve the test errors * make the code simpler * fix the test error	4 years ago
Markus Kahl	2bf74725b2	fixed password confirmation during token reset (#9314 )	4 years ago
ulferts	6cda6ad4fd	enforces dependent project modules being active (#9311 ) Project modules, e.g. calendar can define dependencies, e.g. work packages. An error message is now displayed if a user enables a project module without the dependency being active in the project as well. Also fixes a serious bug in the Shared::ServiceContext module. Whenever a failing service result is returned, every change to the database is to be rolled back. This was not true when a model was provided since the changes where carried out within an inner transaction	4 years ago
Oliver Günther	c9a80b8653	[#37299 ] Remove validation for project identifier presence (#9296 ) [OP#37299](https://community.openproject.org/wp/37299)	4 years ago
ulferts	0c2d87b4eb	choose wp type by position only (#9297 ) There was a misconception in the code related to the `is_default` field. The `is_default` field only governs whether a type is enabled by default in a new project or not.	4 years ago
ulferts	98b04a4d4f	show "new project" option on add_subprojects permission (#9298 ) The "new project" option will only be displayed when the user is in a context, a project, where the add_subprojects permission is granted	4 years ago
Behrokh Satarnejad	06cd178f3d	[35354] Harmonize work package autocompleters (replacing global search box) (#9289 ) * replacement of ng-select with op-autocompleter * removing label and selecting the option with the searched id * resolving the error of not remarking by id * Remove expectation that search input remains the same They are interconnected, so this doesn't matter * Remove setTimeout/outzine zone in favor of ngAfterViewInit * remove commited code and improve outFocus Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	93faf5b5dd	[37278] Treat system_user as user type as well (#9287 ) https://community.openproject.org/wp/37278	4 years ago
ulferts	08ce0a5436	Fix/attachment journalizing (#9292 ) * update the container timestamp upon attachment creation That way, the journal subsequently created on the journalized container will bear the expected timestamp * update container timestamp on attachment deletion Without it, the journal created after the deletion will bear the wrong timestamp * avoid bumping lock_version on attachment adding/destroy	4 years ago
Oliver Günther	2cf8cd0d84	[37290] Use login service for logging in user (#9290 ) This correctly sets the last login date among other things https://community.openproject.org/wp/37290	4 years ago
Oliver Günther	2a40ec0203	[37184] Hide archived projects from project search (#9283 ) https://community.openproject.org/wp/37184	4 years ago
Oliver Günther	5956ede030	[37107] render tabs in component (#9236 ) * Render work package tabs in one component * Move standard tabs into tab service * Move tab-count styles mostly into its own component style * Fix frontend specs * Remove unused texts * Fix routing to split view from button * Fix context menu not opening the tabbed view * Fix watcher tab counter not receiving an rxjs subscription * Fix selector * Fix clicking on relation link to fullscreen * Make WP tabs an instance of scrollable-tabs * Convert the tabs from .tabrow to its own BEM block * Refactor other usages of tabrow into op-tab-row * Fix frontend specs * Make wp modal tabs use scrollable-tabs * Fix disabled tab selectors * Restore scrollability of tabs * Fix import and change detection of graph modal * Fix selector in wp relations spec * Rename tab-count to match component style * Remove narrow style * Fix bem modifier style * Fix styles of scrollable tabs * Fix tab for time entry autocompleter	4 years ago
ulferts	e60f403d7c	attempt to fix flickering spec	4 years ago
Aleix Suau	4700b77033	Feature/36382 improvements (#9266 ) * Show backend validation errors in toast instead of a generic message * Include disabled field values on submit * Documentation improvements * Dumber OpFormFieldComponent: control, error and help settings as @Input * Create fieldGroups programmatical from @Input * fix: new project from themplate. Prioritize backend model * Show backend validation errors in toast instead of a generic message * Include disabled field values on submit * Documentation improvements * Dumber OpFormFieldComponent: control, error and help settings as @Input * Create fieldGroups programmatical from @Input * fix: new project from themplate. Prioritize backend model * Setting template payload through DynamicForm @Input model * Tests fixes * Seet public-read ACL on capybara screenshots * New Project: reset form when template changed + keep name * fix: avoid OpCkeditorComponent >>> FormattableEditFieldComponent >>> OpCkeditorComponent rawValue loop * PR Review changes * Unit tests fixes Co-authored-by: Cyril Rohr <cyril.rohr@gmail.com>	4 years ago
Oliver Günther	bb27cf9903	[37257] Bust cache on settings name format change (#9276 ) * [37257] Bust cache on settings name format change https://community.openproject.org/wp/37257 * add specs for user representer cache busting & avoid patch Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	3fe79329e5	replace legacy spec	4 years ago
ulferts	fe1e742a64	Fix/project in user invite validation (#9272 ) * validate project in invite modal The user might have the manage_member permission in a project but not necessarily in the one the modal is opened in. * resurface invite_user_modal spec deleted in `b50298eb30` * allows users without manage_placeholder to add placeholder to project	4 years ago
ulferts	51bcf7f6d6	Fix/add subproject only flow (#9268 ) * allow users only having add_subproject to create subprojects * remove reference to no longer existing projects controller action	4 years ago
ulferts	9edc7244a9	fix displaying `multi` toggle in cf form (#9269 )	4 years ago
Oliver Günther	780fbf452e	[37158] Hide meta settings when selecting a template (#9257 ) https://community.openproject.org/wp/37158	4 years ago
Oliver Günther	ad07264c4f	[36937] Fix navigation to active wiki item and add spec for it (#9264 ) https://community.openproject.org/wp/36937	4 years ago

1 2 3 4 5 ...

7116 Commits (c8b515127a2c6da719e8e6aeea34e27f18bd7219)