29714 Commits (c9940b22275ab6101c6325d6638e07bda66ca8c4)

 

All Branches   

Search

Author	SHA1	Message	Date
Oliver Günther	1021be7879	Merge pull request #4970 from opf/fix/interactive-table-widths ... [24127, 24072, 24073] Implement interval checking for correct table and header widths	8 years ago
Oliver Günther	5d74674f98	[24132] Also watch available filter values when query is empty ... https://community.openproject.com/work_packages/24132	8 years ago
Oliver Günther	24e0bc1315	Redirect to WP list after successful save.	8 years ago
Oliver Günther	f5ddc78f92	Temporarily use rspec-retry everywhere	8 years ago
Markus Kahl	e7f9564441	whitespace	8 years ago
Markus Kahl	6b84e9788c	fixed the relations contract which was sabotaged by delayed_job	8 years ago
Oliver Günther	c226b133eb	Merge pull request #4982 from opf/feature/23777_attachments_button ... Feature/23777: Add Button to add attachments in work package create and edit form	8 years ago
Oliver Günther	7b91928534	Merge pull request #4984 from opf/fix/24168-preview-buttons-are-too-large ... [24168] Preview buttons are too large	8 years ago
Oliver Günther	9cc6891138	Merge pull request #4983 from opf/fix/24140-layout-error-on-work-package-fullscreen ... [24140] Layout error on work package fullscreen	8 years ago
Oliver Günther	05a54adced	Serialize column_names as arrays ... Currently, column_names on production systems are either 1. YAML-serialized Arrays of column names (duh) 2. An empty string '' 3. nil The two latter are invalid with Rails 5 and cause the following error: ``` NoMethodError (undefined method `map' for "":String): app/controllers/api/experimental/concerns/v3_naming.rb:70:in `json_query_as_v3' app/controllers/api/experimental/work_packages_controller.rb:85:in `query_as_json' app/controllers/api/experimental/work_packages_controller.rb:51:in `index' app/middleware/reset_current_user.rb:47:in `call' ``` This commit forces Array serialization and fixes previous queries with the empty values.	8 years ago
Oliver Günther	f665deea97	Implement interval checking for correct table and header widths ... Multiple bugs exist when parts of the table are being resized instead of the entire window. Currently, after first initialization, the interactive-table updates itself when: 1. The window is being resized (resize listener) 2. A state change has successfully transitioned (e.g., split view opened) 3. The project menu is being toggled In some cases, these listeners will be execeuted when the content of the table is not yet ready. One prominent example is the initial loading of the table when, e.g., the progress column is active and partly out of the window. It will be cut off and not redrawn. When excluding the option of bottom-up notification on when a cell or row changes in the table (pure chaos), the only way to address this is to periodically check the table and header width for changes and update the table accordingly. This is exactly what this commit suggests.	8 years ago
ulferts	26feafe3d0	Merge pull request #4945 from opf/housekeeping/spec-failures ... Experiments on reducing failing specs	8 years ago
Oliver Günther	38acc7c502	Merge pull request #4940 from opf/fix/23981_attachments ... Fix/23981 Adapt changes in wp-attachments to wp-attachments-formattable-field directive	8 years ago
Oliver Günther	f6071ce882	Don't try to match the whole set of themes ... But rather find only the ones we're looking for.	8 years ago
Oliver Günther	c01abe3efa	Expect the subject in the typeahead ... This avoids failures when trying to select a text by its ID only.	8 years ago
CI	99f684189f	Update reference to OpenProject-Translations	8 years ago
milahti	72511adbf9	Update installation-guide.md ... +Added file and path for manual pass of SECRET_KEY_BASE to Apache -removed one unnecessary "put" [ci skip]	8 years ago
Oliver Günther	89ad59a9b7	Merge pull request #4952 from opf/feature/23759_relation_description ... Feature/23759 - Possibility to add custom descriptions to relations	8 years ago
Oliver Günther	bf66db6ef9	Don't try net/ldap connection on CI	8 years ago
Oliver Günther	b3b047a904	Extract retriable into helper with logging	8 years ago
Oliver Günther	8de452b006	Use retriable to retry code blocks, not examples	8 years ago
Oliver Günther	b87e6ef900	Rubocop	8 years ago
Oliver Günther	216d98e618	Don't access the file more than once in export spec	8 years ago
Oliver Günther	2eb762182d	Move set_attribute into work package field so table spec can profit	8 years ago
Oliver Günther	4af87a2be8	Remove have_text matcher in edit spec	8 years ago
Oliver Günther	ebbfd60b30	Use thin as default server	8 years ago
Oliver Günther	76ac1b319a	Use waiting test for `WorkPackageField#editable?`	8 years ago
Oliver Günther	e5aea9ad00	Explictly retry examples	8 years ago
Oliver Günther	983adde5e9	Use uniform seed among all matrix entries ... Uses the current commit hash to construct an identical number for each travis job.	8 years ago
Oliver Günther	4321dc8430	Fix capybara selector	8 years ago
Oliver Günther	bf003f644e	Increase timeout in Capybara	8 years ago
Oliver Günther	43c8714a57	Precompile assets before spec run for feature/cukes/plugins	8 years ago
Oliver Günther	8bf82e73c3	Default to running rake parallel:<TEST_SUITE> ... Allows plugin:specs from downstream repos to run again	8 years ago
Oliver Günther	25a62f490e	Require ParallelTests::Tasks	8 years ago
Oliver Günther	8e9cc782f7	Better eager_load check for CI	8 years ago
Oliver Günther	81c79d82ae	Only check expect_active! when no error occurs	8 years ago
Oliver Günther	64d14634ff	Correctly clear theme double	8 years ago
Oliver Günther	320612b65b	Improve wait time for edit and new specs	8 years ago
Oliver Günther	3cce854bb6	Clear RequestStore when using PathHelper with relative url	8 years ago
Oliver Günther	08f2246c83	Avoid clearing the asset precompilation config ... This should fix all the following errors: ``` ActionView::Template::Error: Asset was not declared to be precompiled in production. Add `Rails.application.config.assets.precompile += %w( favicon.ico )` to `config/initializers/assets.rb` and restart your server Shared Example Group: "renders blocks" called from ./spec/controllers/homescreen_controller_spec.rb:113 # ./lib/open_project/themes/view_helpers.rb:51:in `image_path' # ./app/views/common/_favicons.html.erb:1:in `_app_views_common__favicons_html_erb___2819908702122413135_70214198061180' # ./app/views/layouts/base.html.erb:42:in `_app_views_layouts_base_html_erb___2298418351071688946_70214234431020' # ./spec/controllers/homescreen_controller_spec.rb:38:in `block (2 levels) in <top (required)>' # ------------------ # --- Caused by: --- # Sprockets::Rails::Helper::AssetNotPrecompiled: # Asset was not declared to be precompiled in production. # Add `Rails.application.config.assets.precompile += %w( favicon.ico )` to `config/initializers/assets.rb` and restart your server # ./lib/open_project/themes/view_helpers.rb:51:in `image_path' ```	8 years ago
Oliver Günther	a5a788ddfd	Increase maximum wait time for notifications ... As we tend to synchronize on notifications (Successfully created/udpated), we should increase the maximum wait time for POSITIVE matches. Once the selector has been matched, it is returned, and waiting 9 seconds is better than re-running the entire spec	8 years ago
Oliver Günther	9a20bd04db	Use retry: true for export spec	8 years ago
Oliver Günther	a77e4a4a8d	Introduce rspec-retry ... Enable specs to mark metadata retry: <count> to retry that given example immediately after it fails. Compared to the previous parallel_test re-run all failures, this DOES NOT retry all specs by default.	8 years ago
Oliver Günther	e4511ec3a7	Retry setting single attributes in AbstractWorkPackage	8 years ago
Oliver Günther	d0311d8f28	Fix input_types for some attributes and make error message more useful	8 years ago
Oliver Günther	6c2176febf	Fix activity selector after page reload, should contain 2 entries ... This error was shadowed by the `ensure_page_loaded` helper	8 years ago
Oliver Günther	573eff244a	Avoid shadowing ambigous matches in ensure_page_loaded ... The old activities frontend was loaded several times and required a workaround. This is no longer the case. That statement also shaadowed Capybaras amgigous matches when more than one activity was showing. We thus test for the first activity.	8 years ago
Oliver Günther	0a693c6ce3	Bump capybara-screenshot for doc formatter	8 years ago
Oliver Günther	367a18d452	Fix Setting.app_title order failure	8 years ago
Oliver Günther	54f4bd43f9	Fix order-dependent failure in account_controller_spec	8 years ago