10770 Commits (c9f0fba192ceab706dee6dc8641b76582d21bf39)

Author	SHA1	Message	Date
Jan Sandbrink	c9f0fba192	increase readability of wp->hash conversion ... it might use more lines, but I hope there is a gain in readability	9 years ago
Jan Sandbrink	8897235fa4	rewrite find into where, order and limit	9 years ago
Jan Sandbrink	194f1814e1	always return a valid scope ... though WorkPackage works like a scope *most* of the time, it is not a scope e.g. you can't directly call :order on WorkPackage Note: I would have loved to already do it the Rails 4 way and call :all However in Rails 3 :all returns an Array and not a Relation, so we will have to wait for the Rails 4(.1) Upgrade to replace :scoped with :all :( Sorry @myabc	9 years ago
Jan Sandbrink	e51a4005ff	try to increase readability ... - extract scopedeterminition into an extra method - always use "outer" if statements in index method	9 years ago
Jan Sandbrink	280e333f18	explain why some code exists	9 years ago
Jan Sandbrink	2854584cb2	use more clear scopes for autocompletion ... lets see if that really makes stuff more understandable... I (personally) found the old definition of "all" to be too narrow. Now there is: scope == "all": I want to search over all WPs scope == "relatable": I want to search over all WPs that are relatable to WPs in the given project (via project_id) no scope: If I specified a project search over the WPs of that one, otherwise search everywhere (like "all")	9 years ago
Jan Sandbrink	45815cb9f3	rename query to scope ... sounds more understandable to me, but I am biased, I guess...	9 years ago
Alexander Bach	c42dad3270	Correct comment	9 years ago
Alexander Bach	2f9c9178df	Fix regex properly	9 years ago
Alexander Bach	248f11fba8	Correct style	9 years ago
Alexander Bach	ffd81c4886	Add some polish	9 years ago
Markus Kahl	bcd981df5c	consider X-Authentication-Scheme; opt scoped realm	9 years ago
Markus Kahl	d854df5175	suppress browser prompt on authenticate failure	9 years ago
Alexander Bach	1a52cc1292	Suppress the hound	9 years ago
Alexander Bach	c687c63c71	Fix some project url building with identifiers ... This commit was powered by @ulferts	9 years ago
Alexander Bach	851f8bf3d1	Make validation regex comply with hint	9 years ago
Jan Sandbrink	9f4ebc04a5	fix moving of WPs without specifying a status ... attributes without a value are actually represented by empty strings. Thus only take the status_id if it is :present? (the inverse of :blank?)	9 years ago
Jan Sandbrink	9eb7cfbe9b	actually allow the status to be set while moving ... apparently the status_id param was set to expect an array of values while being moved in this commit: d7f399ab8d Probably because the spec started to expect that when it was moved to be an RSpec test. I am not sure if this was ever a valid thing outside the tests...	9 years ago
Jan Sandbrink	2fbbccb50c	move error handling up ... RecordNotFound would now already occur due to :recipient call in :perform method.	9 years ago
Jan Sandbrink	4bee848f3d	style	9 years ago
Vadim Costin	8e67407ce7	remove unused variables	9 years ago
Jan Sandbrink	7d634d57ad	execute mail jobs in context of their recipient	9 years ago
Jan Sandbrink	95c0d0a013	pull recipient & author up into MailNotificationJob	9 years ago
Jan Sandbrink	d43803ce85	use more specific names than user ... author and recipient are matching the domain they are employed in (mail delivery) closer. Especially the name 'current_user' only happens to be the thing being assigned as author, but does not transport any special meaning in itself.	9 years ago
Jan Sandbrink	0c3562ce49	fix whitespacing in '_issue_details.text.erb' ... empty lines and indentation used for code formatting is immediately visible in the resulting output. I tried to employ some special rules to at least allow for usage of indentation.	9 years ago
Vadim Costin	b09740ca3e	change default notiffication message style	9 years ago
Jan Sandbrink	c775274707	include missing attributes in mails	9 years ago
Jan Sandbrink	96d0cf9462	fix moving of WPs without specifying a status ... attributes without a value are actually represented by empty strings. Thus only take the status_id if it is :present? (the inverse of :blank?)	9 years ago
Evghenii Barhatov	a609680483	Allow raising exceptions from notification jobs	10 years ago
Jan Sandbrink	d3ceffddfc	actually allow the status to be set while moving ... apparently the status_id param was set to expect an array of values while being moved in this commit: d7f399ab8d Probably because the spec started to expect that when it was moved to be an RSpec test. I am not sure if this was ever a valid thing outside the tests...	10 years ago
Oliver Günther	4e666d563a	[ci skip] Fix flickering search by collapsing the search in CSS ... This tiny change should fix the flickering search form in high-load environments by appending `-collapsed` state to the angular element before loading.	10 years ago
Jens Ulferts	fa402cdd58	prevent check-boxes crashing into their label	10 years ago
Vadim Costin	82cfec146c	remove some spaces	10 years ago
Vadim Costin	5f0553dfce	add default font color for message box	10 years ago
Vadim Costin	31f7e52fa8	add simple notification message	10 years ago
Vadim Costin	f95259c337	add a button in alert message	10 years ago
Vadim Costin	5654e45021	add styles for alert messages	10 years ago
Jan Sandbrink	b44b0cd2f9	remove details on spent time from project overview	10 years ago
Jens Ulferts	4ae7d5cafa	remove unsafe html_safe	10 years ago
Oliver Günther	676cb6083e	Rewrite search box as angular directive	10 years ago
Alex Coles	7a16a70e49	Upgrade to livingstyleguide v2 syntax ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	95072f5c7d	Rename style guide doc files from .md → .lsg ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Oliver Günther	af181577f3	Allow overriding the html title for accessible help	10 years ago
Oliver Günther	5ada719136	Consolidate Module menu in header navigation This effectively changes the following menus: ... **Top Menu** - Removed Administration item - Added Item 'Work Packages' -> /work_packages - Added Item 'News' -> /news - Added Item 'Time Sheet' -> /time_entries (if user has a project with view time log permission) **My Menu** - Added Administration item as first position With work packages, time entries, news now residing in the top menu, these buttons are superfluous in the projects overview and are also removed. Relevant work package: https://community.openproject.org/work_packages/20512	10 years ago
Oliver Günther	3b2027b42c	Fixing Accessibility issues ... - Allow s, alt+4 to focus search form - Collapse search on tab out - `::-ms-clear` size and position fix The search form now behaves as following **Keyboard** * Tab until collapsed search (icon) is focused, the search should expand and the input gains focus. * Tab out of the input, icon will gain focus, search should NOT collapse. * Press enter while icon is focused, search form should be submitted. * Tab out of icon to help, search should collapse._ * Pressing `s` or [modifier + 4](https://en.wikipedia.org/wiki/Access_key) should expand the search. **Mouse** * Click on collapsed magnifier, search should expand. * Click on any other element other than input / icon, search should collapse. **Both** * Icon is now flipped when expanded (to resemble the previous state). **Should the collapsed search icon be flipped as well ?**	10 years ago
Oliver Günther	60a2bd6a0f	Reduce space needed by search and help top menu item ... This commit changes two top menu items: 1. Search is by default collapsed to its magnifier icon - Upon clicking it, it is expanded and focus given to the search field - Clicking any hierarchy not in below the wrapper, the search is collapsed again 2. The help button remains as a '?' icon, and loses the caption. Relevant work package: https://community.openproject.org/work_packages/20540	10 years ago
Florian Kraft	b2dffdaa27	work around white space wrapping in FF ... this will prevent the cutting of of the delete icon - the initial problem here is fixed by suppressing the whitespace property via an `icon` class in the table cell holding the icon. Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Florian Kraft	e8fe39cf3e	add hidden for sighted label ... [ci skip] Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Jens Ulferts	e7e65b35ae	password only required for new users ... Because after that, passwords do not have to be set mandatorily for every user update. But for new users it of course is a requred field.	10 years ago
Florian Kraft	d799420e98	moves the `new subproject` to the project settings ... This will also remove the button from the default project show page and rename the copy button to `copy project` Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago