openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	e8595ac0a3	TypeScript: Enforce noImplictAny	8 years ago
Oliver Günther	9a3b0c1561	Review feedback	8 years ago
Oliver Günther	996403fa3b	Remove manualRenderer property No longer required since fields can decide themselves how to render.	8 years ago
Oliver Günther	381b5baa05	Fix npm tests	8 years ago
Oliver Günther	5d0fd744bd	Fix single view wp	8 years ago
Oliver Günther	486097974f	Basic table edit field and error handling functionality	8 years ago
Oliver Günther	e71d17fa0f	New table class with delegated builders and form handlers	8 years ago
Roman Roelofsen	beadcc8b38	Refactoring: angular-rx-utils: - observe() -> observeOnScope() - added observeUntil()	8 years ago
Oliver Günther	48bbb25b36	[24389] Fix initial ID rendering without schema As the work packages from the list response have no schema, but are used to build the table, they initially have no schema yet.	8 years ago
Oliver Günther	25bbf71622	[24366] Show hidden fields as empty and forbid editing in table	8 years ago
Oliver Günther	3b9b487406	Autoload the schemas from the schema states	8 years ago
Roman Roelofsen	62c5823d74	Use reactive fassade for the wp cache service implementation	8 years ago
Alex Dik	4c5eae5b2d	Fix error resource handling	8 years ago
Oliver Günther	74b52eaab8	[23300] Fix date fields not being updated (#4556 ) * Fix date fields not being updated For Milestone rows, start and due date are both mapped to `date` and thus collide with the wpEditForm#callbacks helper that propagate changes from the `wpCacheService` down to edit and display fields. This fails to update the last field since they registers callbacks based on their attribute name. This commit instead suggests to use the wpCacheService directly, since the scopedObservable will handle deregistration correctly on its own. * Remove no-longer-required wpEditForm	9 years ago
Jens Ulferts	473a1107a6	use aria-label to communication "label + value"	9 years ago
Jens Ulferts	43a4ecce5d	remove wpEditField dependency from wpDisplayAttr	9 years ago
ulferts	9fb2f68675	fix hidden label (#4500 )	9 years ago
Roman Roelofsen	ae6087e9f0	Removed timeout defer	9 years ago
Roman Roelofsen	f32b9c90b2	Removed timeout defer	9 years ago
Roman Roelofsen	78417cdd0c	WIP reducing watcher count	9 years ago
Roman Roelofsen	8985c910f7	Reduced Watcher Count	9 years ago
ulferts	48ac7aa6f4	introduce strategy for displaying fields (#4469 ) In order improve the code structure and in order to enable plugins to add display strategies for fields, that are not covered by the core yet, a strategy pattern is introduced for displaying fields. The mechanism is identical to the way EditFields are handled. In fact, the DisplayFields and EditFields now inherit from a common superclass, Field. Also, the service and the factory inherit from a common superclass.	9 years ago
Oliver Günther	2b02d50af5	Remove old values when they're no longer in the schema	9 years ago
Oliver Günther	159a7f0007	Restore custom schema displayAttr functionality I don't really like that displayAttr is exploited for displaying sums, despite the directive clearly targeted to work packages alone. This makes the distinction clearer with a 'customSchema' attribute when not the work package schema is to be used.	9 years ago
Oliver Günther	6e50a03877	Extend wpDisplayAttr test	9 years ago
Oliver Günther	c1f00abf21	Update wp-display-attribute only when changed	9 years ago
Oliver Günther	ca65f078c3	Fix leftover values from wp resource still showing up The display-attr causes old values in the resource to still show up, despite no associated schema being available. I don't think it hurts to have old values in the resource, as long as we can ensure that it's the schema that decides what is showing.	9 years ago
Oliver Günther	cfec719371	display-attr receives updates from wpCacheService	9 years ago
Oliver Günther	6589b6ba50	Initialize edit field when work package is updated in cache	9 years ago
Oliver Günther	2f1d84c7cf	Fix saving/display of boolean custom fields Boolean custom fields were no longer saved since the field was marked as required and thus invalid when unchecked. Even when booleans were unchecked, they were output as 'Yes' since the text was evaluated to become the placeholder `-` before the format helper was called, thus resulting in a truthey value. Also, unchecked booleans are marked as placeholders since they are falsey when empty.	9 years ago
ulferts	de77f7bf48	style inline edit placeholders (#4439 )	9 years ago
Oliver Günther	6549869000	Fix focussing on erroneous fields	9 years ago
Oliver Günther	67e4551387	Mark WorkPackageResource as dirty when values were changed This allows us to check the cache services for changes in the work package and not refresh it from the cache. Currently, this is only relevant for edit all mode, however it may be the entry point for a API merging / refreshing service.	9 years ago
Oliver Günther	b849514904	Separate methods for entering/cancelling by user events	9 years ago
Alex Dik	4d909134fe	Remove wpField directive from wpDisplayAttr	9 years ago
Jens Ulferts	c4e5bab07b	style inline-edit textarea fields	9 years ago
Alex Dik	9bf0b1bbbd	Remove redundant line	9 years ago
Jens Ulferts	e5d874a966	Accessibility for wp-edit fields * Hidden label for all fields once they are activated * aria-labelledby for all fields when they are in read mode * turned visible attribute text on split/fullscreen to be clickable so that it behaves like a label	9 years ago
ulferts	a4c8fa75bb	add ability to activate inline edit fields via keyboard (#4405 ) Allows tabbing on the inline edit field. https://community.openproject.com/work_packages/23076/activity I feel that one scenario is still not supported the way it should be. If the user presses the "ESC" key while being in an inline edit input, the input disappears and the text representation is displayed as desired. But the focus is not placed on the text so it becomes hard to reactivate the field as the user has to start the tabbing journey anew. I couldn't get this to work as the field can only be focused after it reappears.	9 years ago
Alex Dik	91beb49054	Fix wpDisplayAttr directive tests	9 years ago
manuschiller	a2044de1f0	description placeholder fix for empty descriptions	9 years ago
manuschiller	1188a3d466	fix description placeholder for empty descriptions	9 years ago
manuschiller	2ed2313c07	added functionality to display html to wp-display-attr.directive	9 years ago
Alex Dik	74ec77be0c	Rename directive vars of wpDisplayAttr directive	9 years ago
Alex Dik	aa5c8da604	Refactor WP display attr controller	9 years ago
Alex Dik	d6608ba54d	Renam wpTd directive to wpDisplayAttr	9 years ago
Alex Dik	3aa2c05252	Move wp-td directive	9 years ago
Oliver Günther	6e61150c1b	[Inline Edit / Create] Changes and bug fixes (#4336 ) * Open work package on single click when already in split view * Replace (new) with empty string for new IDs * Replace trash icon with cancel icon	9 years ago
Oliver Günther	386d4b53e7	Use default loading of table for details pane (#4335 )	9 years ago
Oliver Günther	02cf2b0efe	[22851] Table Inline Create (#4290 ) * Move the WP create button to the WP buttons directory * Move the keepTab service to the wp-panels directory * Move angular module definitions into separate file * Move the WP create button into a separate file * Use TS in WP create button directive * Refactor the WP create button controller * Move the has-context-menu directive to the components directory * Refactor has-context-menu item focus * Create new button directive and place in table * Export and use wpButton module * Add title to form properties * Add -new modifier to new work package rows * Add WP inline create directive * Reduce error widths to cell span * Save or update work package conditionally * Mark work package as new * Implement the WP inline create button * Style button correctly * Decide when to activate the field for new WPs * Remove padding on -new row * Avoid animation on added -new rows * Avoid writing title when passed from new workPackage * Remove jqMigrate warning * Avoid animations for newly added rows * Add cancel button to inline create row * Track new work packages by custom id If we don't track new work packages, ng-animate will freak out due to the track by expression. We thus track work packages by setting a custom id set from the current date. * Disable focus on errors outside accessibility mode * Add inline create cancel context menu * Conditionally set focus on fields Set focus on the first active field	9 years ago

47 Commits (cab9d33c57acdd79dbef05b73c3e15fd93a5e580)