openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
Oliver Günther	2cde433326	Remove usages of AnyFixture (#8987 ) AnyFixture will create once instance of a factory for reuse in a number of specs. This will work fine until we require a clean slate for a specific example. As we have numerous tests that test like the database is empty, we get a number of disadvantages: - After an example with `with_clean_fixture` metadata, the fixture will only be regenerated after the next example that uses it. This means the order of execution will change the number of objects in the DB. - The more `with_clean_fixture` we have, the smaller the performance advantage of AnyFixture will result in. - You cannot use an AnyFixture in a spec that needs a clean slate. This should be obvious but was overlooked by myself.	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961 ) * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
luz paz	3683042c9b	Fix typos in user facing and non-user facing code Found via `codespell v2.1.dev0`	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Oliver Günther	894ba4ae6d	Ensure LDAP users can get activated with any registration setting LDAP users get an auth_source_id attached to them during registration, since they are effectively not self-registrating in the system, the register service should allow them with any self_registration setting. At the same time, the refactoring ensure that even an LDAP user that logs in for the first time is being redirected to home to get the welcome tour.	4 years ago
Oliver Günther	5663a557ee	Add spec for direct login case	4 years ago
Oliver Günther	211d9cd4eb	Move provider finder into auth plugin	4 years ago
Oliver Günther	fcfb9e7c5f	Add test that slo callback is being called	4 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230 ) Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
Oliver Günther	743cceecb3	[32178] Don't use flash in rendering change password form https://community.openproject.com/wp/32178	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Oliver Günther	7a09d8fcdd	delay all jobs	5 years ago
Markus Kahl	aa15b6c589	added hooks for user registration and first login	5 years ago
Oliver Günther	451331a910	Invalidate session,s extract passwords flow into services	6 years ago
Oliver Günther	183ad1480e	Replace deprecated controller success? with succesful?	6 years ago
Markus Kahl	4d57545715	notify admins if user could not activate due to the user limit	6 years ago
Markus Kahl	dad7e6b125	LDAP/OmniAuth on-the-fly registration user limits	6 years ago
Jens Ulferts	3897b9f37e	fix merge errors	6 years ago
Markus Kahl	54feb0a812	more user limit specs	7 years ago
Markus Kahl	60b8def1c9	user limits for enterprise edition	7 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot Removes the deprecation	7 years ago
Markus Kahl	0b75df7464	handle expired invitation tokens, don't delete them without replacement	7 years ago
ulferts	f1b1aa7839	Fix/back url when already logged in (#6166 ) * use the provided back url when already logged in But check the validity of the back_url to not be used maliciously to redirect users to pages outside our host * minor coding style improvements [ci skip]	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Oliver Günther	3731c012a5	Replace legacy account controller spec	7 years ago
Oliver Günther	518c255c1a	Fix API token usage and specs	7 years ago
Oliver Günther	1f2492bb8b	Implement HashedToken (ExtendedToken from MOTP) in Core	7 years ago
Markus Kahl	4b316ec470	LDAP Single Sign-on (#5888 ) * ldap sso * localise sso failure error * code climate * code climate 2 * code climate 3 * added missing login param * make spec work with SSO module prepended to ApplicationController * polish [ci skip]	7 years ago
Markus Kahl	816861e380	allow registration for invited users as it is no self registration (#5599 ) * allow registration for invited users as it is no self registration * allow post too [ci skip]	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Oliver Günther	54f4bd43f9	Fix order-dependent failure in account_controller_spec	8 years ago
Oliver Günther	92aebdcec4	Fix params deprecation Fixes in spec/controllers: ``` DEPRECATION WARNING: ActionController::TestCase HTTP request methods will accept only keyword arguments in future Rails versions. ```	8 years ago
Henriette Dinger	bb5d0750a2	[22987] [Onboarding] Getting started video screen (2) (#4464 ) * enable foundation.js * built foundation-apps.js using webpack * Add onboarding modal on button click * Fix specs and little bugs * Add show behavior for modal * Pass template data from Rails to zf-modal * Add closing cross and fix style bugs * Re-add onboarding menu * Change ID to class * Fix styling and avatar problems * Fix broken specs caused by foundation && improve implementation * Require openproject-global.css and fix tests	9 years ago
Markus Kahl	ed136cf8f1	make sure registration is not disabled	9 years ago
Oliver Günther	f711a9b49c	Add proper configuration checks for omniauth Fixes the specs by overriding the configuration value, not the concern. Also adds helpers for Setting and OpenProject::Configuration to override their hashes for accessing values. `:with_config`, `:with_settings`.	9 years ago
Markus Kahl	5324b2cc07	drop my first_login; redirect to work packages if possible	9 years ago
Oliver Günther	fcd450af3f	Fix redirect vulnerability `redirect_back_or_default` was vulnerable to some of the URLs found to be vulnerable in redmine, such as `@test.foo`. This commit extracts the whole functionality into a policy and alters the constraints with a path check to avoid these cases. Thanks to @marutosi for pointing this out. http://www.redmine.org/projects/redmine/repository/revisions/14560	9 years ago
Alex Coles	424889897a	Migrate AR finder/query methods in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Markus Kahl	ee4d977c86	another logout back URL spec for good measure	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 [ci skip]	10 years ago
Alex Coles	5afc11f19e	Fix syntax (w/Rubocop) in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	03978767be	Use 1.9+ Hash syntax in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	879fcd49f6	Convert specs to RSpec 2.99.0 syntax with Transpec This conversion is done by Transpec 2.3.6 with the following command: transpec -f * 66 conversions from: it { should ... } to: it { is_expected.to ... } * 53 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 20 conversions from: == expected to: eq(expected) * 19 conversions from: obj.should to: expect(obj).to * 7 conversions from: describe 'some request' { } to: describe 'some request', :type => :request { } * 7 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 7 conversions from: its(:attr) { } to: describe '#attr' do subject { super().attr }; it { } end * 5 conversions from: obj.should_not to: expect(obj).not_to * 4 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 3 conversions from: be_true to: be_truthy * 2 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 2 conversions from: its([:key]) { } to: describe '[:key]' do subject { super()[:key] }; it { } end * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 1 conversion from: be_false to: be_falsey * 1 conversion from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 1 conversion from: describe 'some feature' { } to: describe 'some feature', :type => :feature { } * 1 conversion from: it { should_not ... } to: it { is_expected.not_to ... } For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Martin Linkhorst	8877883c63	given openproject runs in a subdirectory we cannot allow redirecting to a different subdirectory. also tries to catch shenanigans to circumvent the check like ".." in the path.	10 years ago
Markus Kahl	d67f3391c2	fixed specs after moving #disable_password_login?	10 years ago
Till Breuer	2c4483544c	Merge branch 'dev' into feature/adding-and-removing-watchers Conflicts: app/assets/javascripts/angular/work_packages/controllers/work-package-details-controller.js karma/tests/controllers/work-package-details-controller-test.js lib/api/v3/work_packages/work_package_representer.rb	10 years ago
Markus Kahl	a572c6af7f	properly qualify OmniauthLogin everywhere	10 years ago
Markus Kahl	5e0465df57	spec registration with disabled password login	10 years ago

1 2

96 Commits (cd628b5c75060a9e4d3234bddd9ef1c40ebeca78)