openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	4349f48b49	Show warning only when supported, but not enabled	9 years ago
Oliver Günther	3b2e39b425	Avoid errors when missing standard type Adds an extra check for a standard type that otherwise may throw an error when the given `type_ids` array is empty. Previously, this behavior was avoided by the `params[:project]` check in `ProjectsController`.	9 years ago
Oliver Günther	589ba8e7b1	Relocate repositories locally and remote This commit introduces relocating a repository as a followup after a project's identifier has been renamed.	9 years ago
Jens Ulferts	285fc74759	prevent builtin users being presented to an end user	9 years ago
Oliver Günther	abf3f49b51	Refactor services to classes	9 years ago
Jens Ulferts	c3d798269b	use class instead of struct	9 years ago
Jens Ulferts	b0a86a69c2	refactor types action on projects controller * Introduced a service to reduce complexity in the controller * Used permitted params to ensure params syntax * Introduced a scope for querying for types used by a work package of the project	9 years ago
Jens Ulferts	54e559bb2d	code pretification	9 years ago
Jens Ulferts	7eb8bdad53	invert setting for self notification Using the positive version to make it easier to understand. In order to avoid having to write a migration, the model layer encapsulates the transformation. Direct assignments to :no_self_notified is still possible.	9 years ago
Jens Ulferts	2596e7be94	fix accidental disabling of no_self_notified The "account" and "settings" action used to alter the email settings although the user did not send any information regarding email on the request. To clarify the behaviour, a service has been created	9 years ago
Oliver Günther	58ced887a2	Repository Apache module Provides a simple mod-perl based Apache wrapper around remote repositories. As its functionality is very limited, it is probably not of much use outside of the packager context.	9 years ago
Oliver Günther	b7465b08a6	Remote managed repositories This commit starts the work to provide functionality with remote service hooks for managing repositories. The main driver behind this is packager, for which we want apache to be the sole owner of the repositories it delivers, and OpenProject only as a reader, however it benefits other installations as well.	9 years ago
Oliver Günther	319c728b1a	Core notifications to alleviate third-party plugins This commit provides some helpers to alleviate SCM vendor plugins: * Provide code notifications when project, members and users are changed. * Allow Repository:* to determine base URL themselves (when no common URL is available) * Open Git adapter for subclassing (Gitolite)	9 years ago
Oliver Günther	de96916dac	Minor corrections This commit addresses the following minor corrections from review: 1. Remove constant URI: It breaks karma, and I can't really tell why 2. Avoid using Object.values Appeared to be supported by chrome, but causes the protractor failure. This also switches the ordering to binary (unshift, push) as that's all we need for now. 3. Remove location.hash when jumping to element `$location.hash` may take precedence over `scrollIntoView` ocassionaly, thus we forcefully remove the location hash when updating the work package on a particular field 4. Avoid showing comment success when empty When opening the comment field, and then submitting on another field with comment being empty and open, the comment was not submitted, but a successful comment notification was still sent. 5. Fix issues for IE 10+ * Force min-height to be set on the element, as IE tends to return 0 as height when empty 6. Misc. * Avoid undefined in comment text * Avoid resizing [msd-elastic] textareas * Rename `add_journal` to `create_journal` Correct wrong bracket for reject function	9 years ago
Oliver Günther	3ca36e1e1d	Parallel sending of comment and fields in WP split view Parallel submitting of comments alongside WP edits wasn't possible natively due to the increased lock_version in work packages, caused by `touch`ing and explicitly saving the work package in the process of adding a journal. This commit works around this issue by updating the timestamp columns directly, bypassing optimistic locking in the work package table. This allows comments to be submitted transparently with other fields to the user, while actually, we send it in two subsequent steps.	9 years ago
Jan Sandbrink	2913ff3d17	Use language prefix fallback for user language too e.g. use "en" instead of "en-GB", if only "en" is available	9 years ago
Jan Sandbrink	caf6ec07c7	Use SetLocalizationService in LocaleHelper	9 years ago
Oliver Günther	1481afb666	Corrections from review	9 years ago
Oliver Günther	6661f2b6d5	Refuse to delete a repository in OpenProject on FS permission errors This commit changes the behavior of removing repositories. It is no longer possible to remove a managed repository (model) when the underlying repository directory could not be removed. This error originally occurred when Apache committed changes to the repository through mod_svn, which resulted in the OpenProject user being unable to delete a particular subdirectory.	9 years ago
Oliver Günther	7e7386f3b6	Rework instruction display - Defaults to localized instruction when none is provided in the settings - Make readonly input visually clickable, not disabled - Renamed `permission?` to `permissions?`	9 years ago
Oliver Günther	c9d3dabab2	Delete repository: Fix internal error on lacking permissions While rolling out on dev, we found that apache by default modifies the access permissions of a repository. This in turn causes the deletion of a repository to no longer complete sucessfully, but return with a permission error. This error was not caught an escalated into a 500 on the repository settings.	9 years ago
Jan Sandbrink	dfb9a5cd20	remove remaining AR find_by_x finders - most of them were removed by @myabc in the rails4 branch - some where reintroduced due to parallel development to that branch - still some occurences left that will hit custom implementations	9 years ago
Oliver Günther	ef322e89dd	Cleanup	9 years ago
Oliver Günther	dfb8ac4853	Add basic checkout instructions This commit adds very basic checkout instructions similar to `openproject-checkout` to repositories. Issues: * Uses table style for checkout component, as exact styling is unclear * Adds compressed table style with less padding * Checkout settings are best organized in a Hash with keys per SCM * vendor. Using default settings, a lot of new setting values would be introduced * Checks for Hash in SettingsController * Currently can't use SettingsHelper, as it requires single setting values	9 years ago
Oliver Günther	a71ce6f1a5	Refactor SCM config to lowercase / symbols ENV-based configuration for various configs can only provide case-insensitive values for SCM configuration and thus is unable to properly configure, e.g., managed repositories. This refactoring relies on lowercase configuration and symbols to define SCM vendors, and camelizes them to the old notation (e.g., :git => 'Git') when using `Setting.enabled_scms` to remain compatible with previous installations.	9 years ago
Tim Habermaas	1571abc931	[Refactor] Remove useless setters; remove useless mutation of self.	9 years ago
Alex Coles	18b8625ae2	Fix deprecated .update_all in MoveWorkPackageService Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Evghenii Barhatov	6ceb63b2b7	Pass user_id instead of whole User model object in DeleteUserJob	9 years ago
Jens Ulferts	6e01b27f18	rename service's method to be in accordance with proc	9 years ago
Jens Ulferts	c471080e08	set locale before API v3 request The mechanism was extracted from the rails stack where the locale is taken based on (in that order): * The user's preferences * The accept_language header * The system settings Only languages, that are enabled by the instance are valid. If one is selected (e.g user preference), that is not enabled by the instance, a fallback is taken.	9 years ago
Oliver Günther	1b9ba9c4bf	Remove repository project hierarchy This commit removes the project hierarchy introduced with repository management. They are not required, incompatible with mod_dav_svn and provide little to none advantage to storing all repositories in a flat structure for the scale we require.	9 years ago
Jens Ulferts	a8b4ca5e83	remove superfluous safeguard	9 years ago
Jens Ulferts	6f3e289f9a	remove duplicate assignment of custom field values The assignments happens in work_package.copy_from as well	9 years ago
Jens Ulferts	07fab1f315	further method extraction	9 years ago
Jens Ulferts	fcaa4ca886	extract methods to reduce complexity	9 years ago
Jens Ulferts	7a2a0324ae	extract method	9 years ago
Jens Ulferts	6837fffc77	remove instances of User.current	9 years ago
Jens Ulferts	f5437ff077	consolidate specs for move work package service	9 years ago
Jens Ulferts	bdf20ef94d	extract work package move/copy to own service	9 years ago
Oliver Günther	edf713fbd5	Rework managed repositories error handling This commit: - adds error messages for filesystem errors - Forces services and views to use repository.root_url instead of managed_path, which may not be available when config is missing	9 years ago
Jan Sandbrink	62e63b8d08	doc + specs for new service - also move create wp service into new directory (consistent with other things that live under 'app')	9 years ago
Jan Sandbrink	fd3312a0f2	extract attachment storing into service - service cares about adding a journal too - only store the attachment when the journal can be saved (i.e. the WP is valid)	9 years ago
Oliver Günther	ca04363e6d	Allow to delete filesystem managed repositories even when config missing Previously, repositories could not be deleted on disk when the `manages:` configuration entry was removed in the meantime. This commit allows repositories to be deleted in that case because we no longer depend on accessing the managed_root (path for `manages:`).	9 years ago
Oliver Günther	bb2a09490b	Remove delayed running of management workers. This commit (temporarily) removes the delayed creation and deletion of managed repositories for the sake of improvded error handling. After consultation with @ulferts, we suggest to improve the `Delayed::Job` pipeline to create means for identifying jobs (referenced ID) and to create a unified service to manage database AND filesystem access in a transactional manner. Also provides the following corrections: - Improve migration speed - Delete parent projects only by their identifier, not the managed root	9 years ago
Oliver Günther	e1bdb41bcd	More complete specs wrt. coverage, cleanup	9 years ago
Oliver Günther	b0c0d0a53f	Avoid fishy factory delegation.	9 years ago
Oliver Günther	da27a552a1	Frontend extensions and build refactoring - switched to toggleable-attribute-groups to provide means for adding buttons in the attribute header (e.g., delete button). - added separate destroy_info page with different notifications for managed and linked repositories to ensure ramifications of removing physical repositories are communicated to the user. - Fixed several issues regarding scm_type selection and the building of repositories. Open questions still concern the question of acessing unsupported repositories (e.g., the soon-to-be-removed filesystem adapter). Acessing the class should will then throw an error, but we still have to allow users to remove the affected repository (somehow).	9 years ago
Oliver Günther	2b39d8fbdf	Cleaning up, Rubocop	9 years ago
Oliver Günther	abc597a6d2	First draft implementation of radio-based frontend.	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - Configuration: Currently replaces the existing options in `configuration.yml`. - Implementation specifics: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago

1 2 3

141 Commits (ce503e3306d853be7e0862deac8d147580b5c36d)