390 Commits (ce7e9d510e2005d62813a69291e234ead9d81224)

Author	SHA1	Message	Date
Jens Ulferts	693090136d	normalize permissions ... With rails 5 it is no longer possible to create an sql like statement via arel which will check whether a serialized array contains a string. AR will only allow to create a match against an array if the column itself is marked to serialize an array. Because of this and in order to increase the normalization of the data, the permissions are no longer serialized and are moved into a separate table instead. While this is still not normalized, it satisfies the needs	8 years ago
Jens Ulferts	bf7343c312	replace perfectly sane hack for really dirty one	8 years ago
Oliver Günther	d676960107	Add ServiceResult	8 years ago
Oliver Günther	638e8ca735	Build simple service to initialize setting on login	8 years ago
Jens Ulferts	acd58213e1	rewrite sql string in a arel based query	8 years ago
Oliver Günther	8f7151e05f	Add iCalendar support (#118) ... * Add iCalendar support * Implement calendar notifications with icalendar gem * Add organizer	8 years ago
Jens Ulferts	8a8dfdd3de	move project allowed query to authorization	8 years ago
Jens Ulferts	1ddc142fd3	add sql based query to fetch all users being allowed an action	8 years ago
Jens Ulferts	06c6defa51	replaces ruby based permission check for allowed_to? with sql based query	8 years ago
Markus Kahl	1044723c43	Fix: date visibility settings (#4602) ... * fixed type date update/view * view spec for form configuration form * view spec => feature spec * types helper refactoring	8 years ago
Oliver Günther	b58f5fc354	Allow UsersController to search for groups ... Since work packages can be assigned to groups, allow the UserSearchService to work on principal, not only users.	9 years ago
Jens Ulferts	6af269aa55	extract into service and fix date bug ... Creates the type_service hierarchy which contains updating/creating types and handles special the visible_attributes. Also fixes visible_attributes for the "date"/"start_date"/"due_date" fields which may or may not be valid based on whether the type is a milestone	9 years ago
ulferts	2c47657de7	unified date field for milestone work packages (#4437) ... Work packages having a type that is a milestone receive a 'date' attribute in their API resource. Other work packages still have the 'startDate'/'dueDate' attributes. The schema behaves analogous so that such a change is visible to a client. In the cient we can now remove some of the custom behaviour for the date field. The code removal is limited to the new inplace edit implementation as the old implementation can hopefully be removed fully in the near future.	9 years ago
Oliver Günther	d532487f4b	Reset cached custom values when switching project, not only type (#4403) ... When moving/copying to a project or type with different custom_values, the accessor in the work package has to be reset. Otherwise, the first save will be successful, only to fail at the second attempt (e.g., when trying to create a journal note).	9 years ago
Oliver Günther	83306c32c3	Pass the decorated work package to CreateService (#4317) ... Since associations will not be marked `dirty` when they're written by the decorator, we are missing custom field values when creating new work packages. This reverts some of the changes introduced by the create service and passes the decorated work package directly.	9 years ago
Oliver Günther	84ce56446f	Add ServiceResult from dev ... Required for mobile-otp	9 years ago
Jens Ulferts	2b758283c8	explicitly require to avoid "still in tree" error	9 years ago
Jens Ulferts	de33104d11	add a project independent endpoint for work package creation	9 years ago
Jens Ulferts	4cd20973e2	improve CreateWorkPackageService to conform with new interface	9 years ago
Jens Ulferts	2f14b793b5	extract contract related methods of service into concern	9 years ago
Oliver Günther	1360639341	Fix URI escaping of svn checkout paths ... The paths weren't properly escaped for URLs. This fix allows any subdirectory of arbitrary chars to be displayed as a checkout URL. This also fixes an escaping issue in the adapter that prohibits checking folder with special characters which SVN doesn't care about.	9 years ago
Jens Ulferts	f40d84cc02	move contracts from lib/api to app/contracts	9 years ago
Jens Ulferts	34b26a4ff4	add service specific for adding notes to a work package	9 years ago
Jens Ulferts	dd05cf297c	add capability to move work package accross projects to service	9 years ago
Oliver Günther	396dcdd859	Add path-based checkout for SVN	9 years ago
Oliver Günther	93e353939f	Use first type from position ordering ... New work packages through the services are created with default types first (e.g., when children wps are created). For regular work packages, the default sorting order (position) is used.	9 years ago
Oliver Günther	4349f48b49	Show warning only when supported, but not enabled	9 years ago
Oliver Günther	3b2e39b425	Avoid errors when missing standard type ... Adds an extra check for a standard type that otherwise may throw an error when the given `type_ids` array is empty. Previously, this behavior was avoided by the `params[:project]` check in `ProjectsController`.	9 years ago
Oliver Günther	589ba8e7b1	Relocate repositories locally and remote ... This commit introduces relocating a repository as a followup after a project's identifier has been renamed.	9 years ago
Jens Ulferts	285fc74759	prevent builtin users being presented to an end user	9 years ago
Oliver Günther	abf3f49b51	Refactor services to classes	9 years ago
Jens Ulferts	c3d798269b	use class instead of struct	9 years ago
Jens Ulferts	b0a86a69c2	refactor types action on projects controller ... * Introduced a service to reduce complexity in the controller * Used permitted params to ensure params syntax * Introduced a scope for querying for types used by a work package of the project	9 years ago
Jens Ulferts	54e559bb2d	code pretification	9 years ago
Jens Ulferts	7eb8bdad53	invert setting for self notification ... Using the positive version to make it easier to understand. In order to avoid having to write a migration, the model layer encapsulates the transformation. Direct assignments to :no_self_notified is still possible.	9 years ago
Jens Ulferts	2596e7be94	fix accidental disabling of no_self_notified ... The "account" and "settings" action used to alter the email settings although the user did not send any information regarding email on the request. To clarify the behaviour, a service has been created	9 years ago
Oliver Günther	58ced887a2	Repository Apache module ... Provides a simple mod-perl based Apache wrapper around remote repositories. As its functionality is very limited, it is probably not of much use outside of the packager context.	9 years ago
Oliver Günther	b7465b08a6	Remote managed repositories ... This commit starts the work to provide functionality with remote service hooks for managing repositories. The main driver behind this is packager, for which we want apache to be the sole owner of the repositories it delivers, and OpenProject only as a reader, however it benefits other installations as well.	9 years ago
Oliver Günther	319c728b1a	Core notifications to alleviate third-party plugins ... This commit provides some helpers to alleviate SCM vendor plugins: * Provide code notifications when project, members and users are changed. * Allow Repository:* to determine base URL themselves (when no common URL is available) * Open Git adapter for subclassing (Gitolite)	9 years ago
Oliver Günther	de96916dac	Minor corrections ... This commit addresses the following minor corrections from review: 1. Remove constant URI: It breaks karma, and I can't really tell why 2. Avoid using Object.values Appeared to be supported by chrome, but causes the protractor failure. This also switches the ordering to binary (unshift, push) as that's all we need for now. 3. Remove location.hash when jumping to element `$location.hash` may take precedence over `scrollIntoView` ocassionaly, thus we forcefully remove the location hash when updating the work package on a particular field 4. Avoid showing comment success when empty When opening the comment field, and then submitting on another field with comment being empty and open, the comment was not submitted, but a successful comment notification was still sent. 5. Fix issues for IE 10+ * Force min-height to be set on the element, as IE tends to return 0 as height when empty 6. Misc. * Avoid undefined in comment text * Avoid resizing [msd-elastic] textareas * Rename `add_journal` to `create_journal` Correct wrong bracket for reject function	9 years ago
Oliver Günther	3ca36e1e1d	Parallel sending of comment and fields in WP split view ... Parallel submitting of comments alongside WP edits wasn't possible natively due to the increased lock_version in work packages, caused by `touch`ing and explicitly saving the work package in the process of adding a journal. This commit works around this issue by updating the timestamp columns directly, bypassing optimistic locking in the work package table. This allows comments to be submitted transparently with other fields to the user, while actually, we send it in two subsequent steps.	9 years ago
Jan Sandbrink	2913ff3d17	Use language prefix fallback for user language too ... e.g. use "en" instead of "en-GB", if only "en" is available	9 years ago
Jan Sandbrink	caf6ec07c7	Use SetLocalizationService in LocaleHelper	9 years ago
Oliver Günther	1481afb666	Corrections from review	9 years ago
Oliver Günther	6661f2b6d5	Refuse to delete a repository in OpenProject on FS permission errors ... This commit changes the behavior of removing repositories. It is no longer possible to remove a managed repository (model) when the underlying repository directory could not be removed. This error originally occurred when Apache committed changes to the repository through mod_svn, which resulted in the OpenProject user being unable to delete a particular subdirectory.	9 years ago
Oliver Günther	7e7386f3b6	Rework instruction display ... - Defaults to localized instruction when none is provided in the settings - Make readonly input visually clickable, not disabled - Renamed `permission?` to `permissions?`	9 years ago
Oliver Günther	c9d3dabab2	Delete repository: Fix internal error on lacking permissions ... While rolling out on dev, we found that apache by default modifies the access permissions of a repository. This in turn causes the deletion of a repository to no longer complete sucessfully, but return with a permission error. This error was not caught an escalated into a 500 on the repository settings.	9 years ago
Jan Sandbrink	dfb9a5cd20	remove remaining AR find_by_x finders ... - most of them were removed by @myabc in the rails4 branch - some where reintroduced due to parallel development to that branch - still some occurences left that will hit custom implementations	9 years ago
Oliver Günther	ef322e89dd	Cleanup	9 years ago
Oliver Günther	dfb8ac4853	Add basic checkout instructions ... This commit adds very basic checkout instructions similar to `openproject-checkout` to repositories. Issues: * Uses table style for checkout component, as exact styling is unclear * Adds compressed table style with less padding * Checkout settings are best organized in a Hash with keys per SCM * vendor. Using default settings, a lot of new setting values would be introduced * Checks for Hash in SettingsController * Currently can't use SettingsHelper, as it requires single setting values	9 years ago