175 Commits (cec4a03f21cd4789a53226f907d95e773cd6d50d)

Author	SHA1	Message	Date
Oliver Günther	edf04f83f1	Fix inline create specs	7 years ago
Oliver Günther	7318b76084	Fix inline create specs (#6144) ... [ci skip]	7 years ago
Oliver Günther	26dff6132e	Remove default route (#6137) ... * Remove default route * Fix and clean legacy specs * Fix specs * Fix missing ID in request parameters in view specs https://stackoverflow.com/a/21789313 * Fix more invalid routes in specs * Pass parameter to omniauth spec * Add required ID parameter to types controller * Fix invalid omniauth URL * Fix project_id params in repository controller spec * Fix missing project id in projects controller spec * Fix missing params and failure url for omniauth * Fix invalid route name * Temporarily skip broken specs on dev [ci skip]	7 years ago
Oliver Günther	7940d15214	Strengthen refresh spec	7 years ago
Oliver Günther	67b57b8a04	Code style	7 years ago
Oliver Günther	b70a891b47	Correctly use the me_value replacements in the CF filter base	7 years ago
Oliver Günther	89e9d7b301	[26778] Pass empty groupBy to query params ... https://community.openproject.com/wp/26778	7 years ago
Oliver Günther	a98494b86d	[26772] Fix double display of hierarchy elements (#6068) ... Assume the following work package structure |ID | Subject | Type | |--------|-------------|------| |N | Child | Task | |N+1 | Parent | Bug | |N+2 | Grandparent | Task | And the following query: ``` Filter Type = Task Sort by ID asc Hierarchy mode ON ``` You would see the ID N+2 Grantparent twice in the table ``` V Grandparent .. V Parent .... Child V Grandparent ``` This was due to the grandparent being in the filter results, and the deferral check of the hierarchy mode applying only to the immediate parent. That parent is not contained in the list, so the elements were rendered immediately. https://community.openproject.com/wp/26772 [ci skip]	7 years ago
Jens Ulferts	67950b1526	fix code climate offenses	7 years ago
Oliver Günther	e94a78d3a0	[26717] Fix grouping by numeric value ... Values in groups returned by the API are always string, so we need to ensure objects are compared non-strict. https://community.openproject.com/wp/26717	7 years ago
Jens Ulferts	690e0ffc60	wp create/update/destroy via services	7 years ago
Oliver Günther	2b1723913e	Replace or remove more evaluate_scripts	7 years ago
Oliver Günther	6256e5cd92	Scroll to elements before interacting	7 years ago
Oliver Günther	b15f07ea32	Scroll to element when blocked by overflow ... The details view blocks certain elements of the table, causing clicks to no longer work in newer Firefoxen This is mainly caused by https://bugzilla.mozilla.org/show_bug.cgi?id=1295538	7 years ago
Oliver Günther	b0301d8aae	Another try at the wait time for export_spec (#5945) ... * Another try at the wait time for export_spec * Make invalid_query a single example [ci skip]	7 years ago
Oliver Günther	e69cb8b400	[26375] Don't check the type for unloaded work packages (#5944) ... https://community.openproject.com/wp/26375 [ci skip]	7 years ago
Oliver Günther	2e521a49e3	[26304] Save inline-create and split view together (#5923) ... We only have the one `new` work package and changeset, so we can't handle multiple views creating different work packages. [ci skip]	7 years ago
Oliver Günther	fdfb41b327	[26069] Allow passing of me-value link for principal filters again ... The 'me' value is currently automatically normalized to the current user, making it impossible to store queries that reference the current user whenever accessing the query as before.	7 years ago
Oliver Günther	f16319bae4	[25280] Implement danger zone for when deleting work packages (#5881) ... Shows a danger zone modal for one or more (bulk) work package deletion requests. For a single work package: * Shows a confirmation for the single work package * Additionally, lists all children if any For multiple work packages: * List of all work packages to be deleted * Children count per work package if any. https://community.openproject.com/wp/25280 [ci skip]	7 years ago
Oliver Günther	645f0ceba9	Minor inline-create timeline styling fixes (#5849) ... * Fix row mirror in timeline * Add bottom to timeline body * Re-enter new timeline row upon rendered [ci skip]	7 years ago
Oliver Günther	dbc1e8a848	Fix saving by enter	7 years ago
Oliver Günther	7878734e6b	[26006][25518] Replace details icon with context menu, open on first click (#5835) ... * [26006] Replace details icon with context menu * [25518] Open details view on click in table * Show dropdown icons always for mobile * Move context menu column to the right * Add three icon with three horizontal dots * Change context menu icon for three horizontal dots	7 years ago
Oliver Günther	4466832f38	[26044] Fix cancel editing for milestones (#5833) ... https://community.openproject.com/wp/26044 [ci skip]	7 years ago
Oliver Günther	413b70a5f6	[26034] Set default CF values when switching types (#5826) ... Fixes switching to a type with a required CF with a default value set. https://community.openproject.com/wp/26034 [ci skip]	7 years ago
Oliver Günther	8d6b51f6e1	Add spec for edge case that was missed	7 years ago
Oliver Günther	4a8a16f82c	Don't gulp errors in PromiseLike	7 years ago
ulferts	4d95cc815f	Feature/guarded relation columns (#5784) ... * refactor case statement * guard relation columns by enterprise token [ci skip]	7 years ago
ulferts	e60bd97f35	Fix/bump gems (#5770) ... * bump capybara * downgrade selenium-webdriver to get rid of a multitued of log messages Setting the logging preferences had no effect: https://github.com/SeleniumHQ/selenium/wiki/DesiredCapabilities#loggingpreferences-json-object * bump sass * bump openproject-token * bump autoprefixer-rails * bump database_cleaner * bump capybara-screenshot * bump aws-sdk * bump timecop * bump timecop * bump parallel_tests * bump faker * bump retriable * fix specs discovered to be broken by now working within Capybara introduced a proxy for `all` and `within` in v2.14 (6356719043 (diff-3944edd1c2651f608ed8a8bec061a734)). This revaled a couple of tests not working as desired. * skip `npm install` for unit specs [ci skip]	7 years ago
Oliver Günther	825a76f0e6	Add separate names to bulk actions	7 years ago
Oliver Günther	d01595d578	Test more explicitly in query_history spec	7 years ago
Oliver Günther	9b6e9a1371	Extract click position mapper for input fields for re-use	7 years ago
Oliver Günther	280c00d50f	Fix more tests	7 years ago
Oliver Günther	db4410dd1f	Remove single-wp edit in context menu	7 years ago
Oliver Günther	3cb9408faf	Fix tests	7 years ago
Oliver Günther	4a686f16d9	[25490] Add publicity settings for query saving modal (#5737) ... When copying queries, the publicity for other members is copied, but not the query `star` setting (whether it is shown in the project menu or not). This is confusing to the user in two ways: 1. The user does not know whether a query is public or not when copying it 2. It is weird to copy one setting, but not the other This PR suggests to extend the `save as` modal with the visibility settings. To this end, I extracted the visibility form into a separate directive to be re-used from the publish/sharing modal and the save as modal. As://community.openproject.com/projects/openproject/work_packages/25490 [ci skip]	7 years ago
Edward Betts	437bbd51bf	correct spelling mistakes (#5748) ... [ci skip]	7 years ago
Oliver Günther	9e576c9832	Alter specs after removed panel-toggler	7 years ago
Oliver Günther	04d48ecec9	Wait longer for filter values to be loaded	7 years ago
Oliver Günther	aaf9781698	Try to strengthen filter spec	7 years ago
ulferts	d1ddd2d5d2	Feature/toggle between hierarchy and group by (#5720) ... * allow toggling between hierarchy and groupBy * fix icon alignment in query settings dropdown * buffer query updates to prevent duplicate backend requests * simplify focus-within delay [ci skip]	7 years ago
Oliver Günther	8113ed9d19	Show relation rows as regular members of the table ... Still WIP: - Relation column is rendered as all other rows (indicator for dropdown), which is confusing	7 years ago
Oliver Günther	bbdb4bf54f	Print work package type for 'ofType' relation columns	8 years ago
Oliver Günther	569369092d	Avoid setting the workPackageId to ignore clicks	8 years ago
ulferts	16f0cace89	Fix/wp copy with cf (#5638) ... * fix copying cf values on wp copy * use angular copy form if only one wp copied [ci skip]	8 years ago
Oliver Günther	7fa78d97ff	Add spec	8 years ago
Oliver Günther	e877713b0a	[25404] Show timeline context items only when visible (#5590) ... Fixes a check for the timelineVisible state. [ci skip]	8 years ago
Oliver Günther	bf9373120b	[25416] Refresh query on removed query_props with ID set ... When you're navigating to a query and override a filter, then move back to the query, the URL is changed, however the query is not being refreshed. This is due to the checksum being required to be non-null, even though it can possibly become null in the above case.	8 years ago
ulferts	86c2f3d59d	Fix/increase query api robustness (#5574) ... * removes unavailable filters on valid_subset! * remove invalid columns on valid_subset! * cleanup query form and collection * code prettification * add status to spec in order to have valid queries [ci skip]	8 years ago
Oliver Günther	892e39161f	[25370] Explicitly clear query_props for query menu items (#5563) ... [ci skip]	8 years ago
ulferts	2a71172837	prepare the query before reading results (#5547) ... * prepare the query before reading results * use string for list cf filter value because all other list filter also use a string * handle invalid group, columns, sort on query read [ci skip]	8 years ago