68 Commits (d01d33c631b903f8eaeb5044b590a15359f43890)

Author	SHA1	Message	Date
ulferts	60b4b47c75	ensure journal notifications value is reset ... Before, an execption raised within the block would lead to the value not being reset. This happens e.g. when a transaction is canceled. This caused spec failures to occur from time to time e.g. rspec ./spec/models/work_package/openproject_notifications_spec.rb[1:1:1:1] ./spec/requests/api/v3/membership_resources_spec.rb[1:2:3:1] --seed 92792 but might also have unwanted side effects in production	5 years ago
Markus Kahl	67f7985f7f	Revert "Try to debug missing journal version" ... This reverts commit e2e8fd12d1.	5 years ago
Oliver Günther	a971b36ad1	Try to debug missing journal version	5 years ago
Oliver Günther	abfaed8b74	Implement separate version table for journals ... This ensures inserts to the journal versions are atomtic, so we can avoid locking the journals table. https://community.openproject.com/wp/30594	5 years ago
Oliver Günther	77c2a2870a	Remove with_advisory_lock for MySQL	5 years ago
Markus Kahl	993f779dfc	Revert "Try to debug missing journal version" ... This reverts commit e2e8fd12d1.	5 years ago
Oliver Günther	e2e8fd12d1	Try to debug missing journal version	5 years ago
Oliver Günther	1dfa9c1cf2	[30594] Implement separate version table for journals ... This ensures inserts to the journal versions are atomtic, so we can avoid locking the journals table. https://community.openproject.com/wp/30594	5 years ago
Oliver Günther	e4ccc964b3	Use a journalized-scope advisory lock to minimize exclusive locks ... This commit removes transactional_lock (mysql-support only) with `with_advisory_lock` which supports both MySQL and PostgresSQL. For PostgreSQL, which supports more than one advisory lock per session, we can reference the customized type and ID to minimize the locking we do for other work packages.	6 years ago
Jens Ulferts	060e2ea692	linting	6 years ago
Jens Ulferts	076fc17f7c	do not count newline only changes	6 years ago
Jens Ulferts	f3622b2ac8	remove code duplication	6 years ago
Jens Ulferts	77b4863d09	fix journalizing detection for multi field cfs	6 years ago
Jens Ulferts	3091064031	linting	6 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Jens Ulferts	690e0ffc60	wp create/update/destroy via services	7 years ago
Jens Ulferts	6fdd122534	merge wp tree and relations into typed_dag ... Instead of having the tree/hierarchy information for work packages and the relations between the work packages separated into two tables all the information is now stored in the relations table. To support this, the typed_dag plugin is used. Notable changes: * relations_to and relations_from are swapped. relations_to has all relations that point to another work package (from_id = work_package.id) and relations_from contains all relations that lead to the work package from another one (to_id = work_package.id). This change is merely in the code. The db information is left untouched. * For follows/precedes to_id and from_id are swapped in the db. Because of that, "follows" is now the canonical name instead of "precedes". This is done so that hierarchy relations and follows relations point into the same direction which allows to easily detect cyclic relationships that would lead to infinit scheduling. * the columns `root_id`, `lft`, `rgt` do no longer exist in the wp table. * the column `relation_type` does no longer exist in the relations table. * For every type of relation a column (integer) does now exist in the relations table (e.g. hierarchy, block, follow) * Separate associations exist for every type of relation into two directions. E.g. Work packages following the current one can be accessed via `work_package.precedes`	7 years ago
Markus Kahl	f5a57e3f42	list custom field normalisation and multi select	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	0dbd4fa81e	add block to controll when a notifiation is send	9 years ago
Jens Ulferts	39455d8386	use AR's own base_class method ... This will reliably find the first class after AR::Base instead of just the first class	9 years ago
Jens Ulferts	18d3c0a4d7	correclty filter journal attributes ... Only the removal of sympols works now (probably after the rails upgrade)	9 years ago
Jan Sandbrink	3c335866d1	Fix saving of journal in association ... When moving the code over here I replaced a journable.journals.select(&:new_record?).each(&:save!) with journal.save! I did this because we know that only the latest journal will be unsaved. However, it seems that we actually rely on a side-effect of journable.journals being iterated (journable.journals.to_a works as well). I have no idea whats going on, but I made the unobvious part more obvious...	9 years ago
Jan Sandbrink	aaf4637138	Ensure that concurrent version updates play well together	9 years ago
Alexander Bach	a8e1aadec7	replace changed_data by details ... working towards making the alias obsolete...	9 years ago
Jan Sandbrink	d8cfa271cd	try to improve readability of JournalManager ... - using useful names - using rubys awesome syntax to avoid nested list accesses (e.g. k[0][1])	9 years ago
Alexander Bach	8c51577e37	Clear up method name	9 years ago
Alexander Bach	196b5e049e	Move comment	9 years ago
Alexander Bach	04f9f64980	Remove and fix additional send_notification	9 years ago
Alexander Bach	2bca02a6b4	Get rid of class variable	9 years ago
Alexander Bach	7e0c7c352e	Move event to fire after its sure that a journal will stay	9 years ago
Alexander Bach	0cf0468ebf	Add default value for send_notification	9 years ago
Alexander Bach	ee14628c09	Move send_notification to event origin	9 years ago
Alexander Bach	c22ce53a7a	Add journal_created event	9 years ago
Alex Coles	8fd535769a	Fix bad rubocop auto-correct in journal_manager.rb ... Reported as issue upstream: https://github.com/bbatsov/rubocop/issues/2021 [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	df51b6ed99	Fix syntax (w/Rubocop) in (Rails) models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	2bf38a622f	create journal when CF toggles between false + nil ... the changed? method of the JournalManager did handle false values not correctly and considered them blank. However, a boolean CF that is not required can have (technically) three states: - true - false - nil Thus we can't consider nil and false as the same case	10 years ago
Jan Sandbrink	5f19189e71	create CF journal for CF set to false ... This is only an issue when the CustomValue.value is actually false. Legacy code uses stringly typing and thus has values like "1" and "0"	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Alex Coles	02b5c38e11	[hack] Quick workaround for issue saving journals ... Validation failed: Version has already been taken Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	6fe9535b1f	Fix syntax (w/Rubocop) in (Rails) models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
slawa	b9a266154e	Update user references in all BaseJournal subclasses	10 years ago
Mihail Maxacov	e6bde3a7a2	Fix user is shown as deleted incorrectly	10 years ago
Michael Frister	68c7f933af	JournalManager: Fix attempting to create two journals with same version ... Calculate journal version based on existing maximum instead of count. Up to now, when removing a journal note with another journal entry existing afterwards, there could be a single journal with version 2, resulting in validation errors for the next attempt to add a journal.	11 years ago
Alex Coles	a7ad3fff42	Style fixes: Remove unnecessary semicolons ... Because rb != js	11 years ago
Hagen Schink	abe3d9cac9	Remove symbols from journal processing ... This prevents journal processing of lots of objects from exhausting memory	11 years ago
Johannes Wollert	8b096975fe	updates copyright headers ... updates more copyright more copyright headers	11 years ago
Hagen Schink	a927255252	Modifies activity implementation for meetings	11 years ago
Hagen Schink	13b09c3bfd	Adds helper method	11 years ago
Sebastian Schuster	9012596804	Changes from empty string to nil and vice versa are no ... longer recorded as journalized changes	11 years ago