3130 Commits (d1a102009792c833bdf04e51bca1493e22fb0943)

Author	SHA1	Message	Date
Oliver Günther	887091f5f1	Fix stale object from fixed lock_version in legacy spec ... The affected test used the next lock_version, which now fails as the journal no longer saves the container.	9 years ago
Oliver Günther	3ca36e1e1d	Parallel sending of comment and fields in WP split view ... Parallel submitting of comments alongside WP edits wasn't possible natively due to the increased lock_version in work packages, caused by `touch`ing and explicitly saving the work package in the process of adding a journal. This commit works around this issue by updating the timestamp columns directly, bypassing optimistic locking in the work package table. This allows comments to be submitted transparently with other fields to the user, while actually, we send it in two subsequent steps.	9 years ago
Oliver Günther	0aed8bb310	Test for comment input	9 years ago
Oliver Günther	a6b4372b09	Always preprocess URLs with CGI.unescape ... This forces redirect URLs to always pass through the escaping process, in order to process escaped paths (`/mysubdir/%2E%2E/secret/`).	9 years ago
Henriette Dinger	cf38af63eb	Use generic classes for the homescreen blocks and update the LSG	9 years ago
Oliver Günther	fcd450af3f	Fix redirect vulnerability ... `redirect_back_or_default` was vulnerable to some of the URLs found to be vulnerable in redmine, such as `@test.foo`. This commit extracts the whole functionality into a policy and alters the constraints with a path check to avoid these cases. Thanks to @marutosi for pointing this out. http://www.redmine.org/projects/redmine/repository/revisions/14560	9 years ago
Stefan Botzenhart	c32590576a	Ensure work packages index view is reachable through sidebar menu	9 years ago
Markus Kahl	8d2d8e3c5f	adapted specs to reflect latest i18n change	9 years ago
Markus Kahl	481b95df77	fixed specs	9 years ago
Markus Kahl	da58898c29	clear subscription spec	9 years ago
Markus Kahl	129dcc04e0	fixed class name	9 years ago
Markus Kahl	24941f3b74	simplified page module structure	9 years ago
Markus Kahl	00e28415cc	renamed file hoping this will fix travis	9 years ago
Markus Kahl	1319e1fe34	extracted member's roles feature spec from cuke ... fixed bug while at it (no error message when choosing no role)	9 years ago
Markus Kahl	1883f8a60c	fixed members/pagination feature (as spec)	9 years ago
Markus Kahl	56e94fb01f	fixed members/members feature (as spec) ... - dropped cuke - replaced with feature spec - DRY'd the heck out of the cuke (shared_examples ftw?)	9 years ago
Markus Kahl	5c3241ee50	fixed error messages feature (as feature spec) ... - dropped cuke - fixed a bug inviting Anonymous when no user selected - dropped obsolete test	9 years ago
Markus Kahl	717f1125fb	have select support impaired mode too	9 years ago
Markus Kahl	6d14f46b6d	run without js where possible	9 years ago
Markus Kahl	6fa0b07e1e	whitespace	9 years ago
Markus Kahl	80a17229aa	replaced groups cuke by feature spec	9 years ago
Markus Kahl	867a511e70	fixed group memberships feature (as feature spec) ... dropped cuke, dropped redundant scenarios, fixed remaining ones	9 years ago
Markus Kahl	8bbf5da2e4	dropped membership.feature; rewrote as adapted feature spec ... The cuke was broken due to changes in the members view. Writing and adapting cukes is a pain, hence I removed the cuke and replaced it by a feature spec using page objects.	9 years ago
Markus Kahl	4590784a4d	adapted users_controller spec to reflect new behaviour	9 years ago
Markus Kahl	f37520ad19	feature spec for user creation and activation	9 years ago
Markus Kahl	dbc343555b	fixed members_controller spec ... adapted spec to new non-js behaviour	9 years ago
Oliver Günther	91aa16b1f8	Consistency in homescreen / menu labels ... Provides consistency in labels: * types -> work package types * go to my page -> my page * manage groups -> groups * advanced settings -> settings	9 years ago
Oliver Günther	fecd3b3b3e	Simple API for managing the homescreen content ... This commit alleviates the homescreen management from both core and plugins, in order to simply add and remove blocks. Also contains refactoring from review * Consistent block and variable usage * Removed unused labels * Avoid word breaks in multiline enumerations and remove margin from enumerations	9 years ago
Oliver Günther	c49b59b7f2	Add controller and routing specs	9 years ago
Oliver Günther	15273724c3	Homescreen functionality ... This commit adds the homescreen functionality to OpenProject, replacing the default welcome screen. This adds support for: * Blocks of content for various privilege levels (latest projects, users, news, etc.) * Links to common functionality (administration, community) Relevant work package: https://community.openproject.org/work_packages/19722	9 years ago
Oliver Günther	c13afd01c4	Force disabled_types to be symbols ... To avoid exposed types from misconfiguration (or installations where string-based configuration is a requirement), we convert the input from `disabled_types` to be symbols.	9 years ago
Oliver Günther	9ff73c2c31	Set enabled SCM types in storage spec	9 years ago
Oliver Günther	bef80793a0	Small visual corrections for checkout ... This commit provides: * An integrated annotation warning display, when the entry could not be annotated (most often due to it being binary). * Hide current rev_id for subversion when no branch/revision is given.	9 years ago
Jan Sandbrink	4ee163393f	Rearrange mail delivery responsibilities ... - each delivery job delivers only a single mail (like in the past) - a common super-class ensures correct handling of different error conditions (similar to the past) This new structure should allow for an efficient error handling: - fail the mail delivery on a per-recipient basis (i.e. redeliveries on error only affect the user that did not receive a mail) - only fail the delayed job for delivery errors (e.g. network issues, etc) - do not fail the delayed job for rendering errors (which are likely to re-occur on each rendering) -> only log those	9 years ago
Oliver Günther	7cb8d62e92	Fix max_attempts for StorageUpdaterJob ... This sets `max_attempts` for StorageUpdaterJob to 1, as we prefer having an external event retrigger storage counting rather than retrying from delayed_job. The reason behind this is failing counting due to I/O or other unforeseen issues (e.g. mount not available, .. ). In this case, recounting soon after will not solve the problem and only increase load on disk.	9 years ago
Alexander Bach	d2fee1e293	Adjust test expectation to direction changes	9 years ago
Alexander Bach	9fc6ab537e	Add routing specs for modified route	9 years ago
Jan Sandbrink	0702683116	Fix bad method call for version custom fields ... exploring the down sides of isolated unit testing :(	9 years ago
Oliver Günther	d81b20fee4	Restyle navigation and instructons on show and empty ... This commit provides: * Adjustments on breadcrumbs according to styling * Restored indent in repository table * Disallow closing checkout instructions on empty page The repository indent for opened folders was removed in the re-styling of tables in 7a844aa9d5	9 years ago
Jan Sandbrink	6e9ed008fb	Enforce passing of current_user into representers ... Thereby permission checks will no longer silently fail if no user was passed. This uncovered a lot of places where we actually expected a user to be passed, when it wasn't. This was especially true for collections. The basic idea is, that virtually all representers could change their behaviour based on the current user. Representers where this is not the case (e.g. Digest), can still explicitly opt-out.	9 years ago
Oliver Günther	14e74596a3	Allow multiple toolbars to exist, extend toolbar functionality ... Previously, toolbars were thought to be unique on a page and thus identified by id. As repository now contains multiple, this was changed to class-based selectors. This commit also adds functionality in toolbars for: * Including select2 fields (proper scaling). To avoid too small selects, toolbar select2 fields are at least 150px wide * Including inline labels in toolbars * Prepended and appended inputs * Icon-only icons (they require font-size changes and a small offset)	9 years ago
Oliver Günther	5ff736ad55	Force english locale on browser profile	9 years ago
Jan Sandbrink	3f269e43ae	Add link to delete an attachment to its representer	9 years ago
Jan Sandbrink	e7a6ae629e	Add specs for update links with missing permissions ... - also (for now) remove title text which was not localized - consistently use link helpers for the corresponding specs	9 years ago
Jan Sandbrink	e7291fba8c	Unify permission handling in representer spec	9 years ago
Jan Sandbrink	aad39544f5	Hide addAttachment link when user is not allowed	9 years ago
Jan Sandbrink	5de0f15898	Correctly link activities ... - they might not be embedded - create an endpoint for activities - document it properly - adapt angular client	9 years ago
Jan Sandbrink	14a55b82d1	Do not embed linked resources in WP collections	9 years ago
Oliver Günther	22b7d2550e	Fix broken localized tests	9 years ago
Jan Sandbrink	5d473e9a9c	fix HTTP response of DELETE attachment ... this was wrongfully HTTP 202 (Accepted), which would only be valid if we did the deletion in a delayed/deferred way. For now using HTTP 204 (No Content), since we have no response body.	9 years ago