120 Commits (d4209d4da02c59db0841a2a9c078fd66b8836579)

Author	SHA1	Message	Date
Oliver Günther	f07ee8c2b5	Don't use return in block	7 years ago
ulferts	9c8f7f3ca1	read operations for time_entries via api v3 (#5776) ... * read operations for time_entries via api v3 Introduces the endpoints: * GET /api/v3/time_entries * GET /api/v3/time_entries/:id * GET /api/v3/time_entries/activities/:id The index action for time entries can be queried by the following filters: * project_id * user_id * work_package_id The implementation is exposing the database structure mostly one to one with the exception of some renaming and the hiding of the activities' complexity, where only the activity used systemwide is referenced regardless of whether a project specific override exists or not. * allow custom values for time entries [ci skip]	7 years ago
ulferts	7154caec85	Fix/consolidate representers (#5732) ... * consolidate representers Minimizes the need for extensive payload representers by: * introducing the payload_representer module which removes all non writable propertyies from a representer * introducing the resource/resources/associated_resource/associated_ressources helper methods which provide a framework for having a representer suitable for parsing and rendering Additionally increases the importance of the contracts by using them to calculate the writeable attributes. * remove unused endpoint [ci skip]	7 years ago
ulferts	5165906e11	fix saving boolean cf filters, use representer for filter parsing (#5660) ... * fix saving boolean cf filters, use representer for filter parsing * patch roar to allow linked_reseource definitions This enables us to get rid of dedicated representers for links sections when the representer is used for parsing [ci skip]	7 years ago
ulferts	ace7098eb3	add relations columns to query (#5606) ... * add relations columns to query * refactory query columns * rename QueryColumn to QueryColumn::Property QueryColumn is now only an abstract supertype [ci skip]	8 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465) ... * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
Jens Ulferts	8a3eaab831	fix group header for empty multi select groups	8 years ago
Jens Ulferts	8a08856748	replace string object by custom option for list custom fields	8 years ago
Jens Ulferts	f55c9cb6f2	include various representation links into the wp collection rep	8 years ago
Jan Sandbrink	d79ca74c9d	Extract base class out of form representer ... - moving error handling and basic structure of a form into a generic base class - leaving work package specific stuff in WP form representer	8 years ago
Wieland Lindenthal	da9afaa9a2	Not necessarry stuff killed	8 years ago
Markus Kahl	0ff5eb8d3f	attribute groups backend draft 1	8 years ago
Jens Ulferts	82082f8e22	return boolean for boolean cf group	8 years ago
Jens Ulferts	f026a7f561	include groupBy into group object	8 years ago
Markus Kahl	f5a57e3f42	list custom field normalisation and multi select	8 years ago
Jens Ulferts	c4bef2247d	adding filter instance schemas	8 years ago
Jens Ulferts	a022169f23	refactor for linting	8 years ago
Jens Ulferts	473f7ea216	embedding and linking to available columns when embedding query schema	8 years ago
Jens Ulferts	74770c6a63	adding query schema - global query	8 years ago
Jens Ulferts	5f23166840	apply schema renaming to additional representer	8 years ago
Jan Sandbrink	7e5252fcb0	Rename Schema to SchemaRepresenter ... for a better distinction between the represented value and its representer	8 years ago
Jens Ulferts	58df267bc4	link to sort_bys	8 years ago
Jens Ulferts	3f2c0e6a3d	link to column names	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	28127eb8ed	remove unnecessary model initialization	8 years ago
Jens Ulferts	b3a21283c7	replace the rendering of a hash by a specific WorkPackageSumRepresenter ... That way, the sums follow the general implementation schema and plugins are able to customize displaying the sums.	8 years ago
ulferts	9a6d5585f4	preload permissions before collection rendering (#4646)	8 years ago
Oliver Günther	78dc9548f3	[Bugfix] Work package grouping header (#4360) ... * Refactor how table grouping is applied and refreshed Currently, changes to groupBy causes the work package to be immediately refreshed before the actual groups are collected from the backend. This watch has been removed, since its unneeded. The work package table is now tracked by the row id and the current group, which causes the ng-repeat to re-evaluate when the group changes, thus fixing the group header bug. Additionally, we now carry the groupByColumn in the wpTableService, where the other grouping values are derived as well. * Allow nil aggregation group This should fix https://community.openproject.com/work_packages/22816/activity * Hide empty group header when groupName not defined This avoids showing an empty header for inline create row. Also forces the create button to disappear when the table is explictly refreshed (e.g., when grouping on another attribute).	9 years ago
Markus Kahl	50e40f324a	wp form config polish (#4364) ... * allow hiding fields with defaults; consider name_source * sort types by name; move projects config to bottom * updated translations (default => active) * no extra visibility behaviour for new WPs * allow hiding even type; always show details header though otherwise the 'show all attributes' button may vanish * updated specs to include new info	9 years ago
Markus Kahl	5f9579ec1a	put visibility info into wp schema and use that	9 years ago
Markus Kahl	148a3fff14	work package form configuration	9 years ago
Oliver Günther	02cf2b0efe	[22851] Table Inline Create (#4290) ... * Move the WP create button to the WP buttons directory * Move the keepTab service to the wp-panels directory * Move angular module definitions into separate file * Move the WP create button into a separate file * Use TS in WP create button directive * Refactor the WP create button controller * Move the has-context-menu directive to the components directory * Refactor has-context-menu item focus * Create new button directive and place in table * Export and use wpButton module * Add title to form properties * Add -new modifier to new work package rows * Add WP inline create directive * Reduce error widths to cell span * Save or update work package conditionally * Mark work package as new * Implement the WP inline create button * Style button correctly * Decide when to activate the field for new WPs * Remove padding on -new row * Avoid animation on added -new rows * Avoid writing title when passed from new workPackage * Remove jqMigrate warning * Avoid animations for newly added rows * Add cancel button to inline create row * Track new work packages by custom id If we don't track new work packages, ng-animate will freak out due to the track by expression. We thus track work packages by setting a custom id set from the current date. * Disable focus on errors outside accessibility mode * Add inline create cancel context menu * Conditionally set focus on fields Set focus on the first active field	9 years ago
Oliver Günther	62e2d776d5	Avoid RuntimeError when aggregating with nil representers (#4321) ... When aggregating columns, e.g., a custom field that contains nil values, the AggregationGroup receives an empty represented. This commit fixes that by allowing the represented object to be nil ``` RuntimeError (no represented object passed): lib/api/decorators/single.rb:54:in `initialize' lib/api/decorators/aggregation_group.rb:39:in `initialize' lib/api/v3/work_packages/work_package_list_helpers.rb:138:in `new' lib/api/v3/work_packages/work_package_list_helpers.rb:138:in `block in generate_groups' lib/api/v3/work_packages/work_package_list_helpers.rb:132:in `each' lib/api/v3/work_packages/work_package_list_helpers.rb:132:in `map' lib/api/v3/work_packages/work_package_list_helpers.rb:132:in `generate_groups' lib/api/v3/work_packages/work_package_list_helpers.rb:127:in `apply_and_generate_groups' lib/api/v3/work_packages/work_package_list_helpers.rb:42:in `work_packages_by_params' lib/api/v3/work_packages/work_packages_by_project_api.rb:42:in `block (2 levels) in <class:WorkPackagesByProjectAPI>' app/middleware/params_parser_with_exclusion.rb:38:in `call' ```	9 years ago
Jens Ulferts	ff3d42fa33	add a project independent endpoint to create work packages ... Includes the auxillary end points: * form * schema * available_projects	9 years ago
Jens Ulferts	f2eb288e7c	completely fix showing sums	9 years ago
Jens Ulferts	d060d251bf	eager load in decorator ... Eager loads the represented work packages based on a class variable. This might look like it would break encapsulation at first and it does. When it comes to eager loading one has to break encapsulation at some point. At least this way, we are very near to what we are going to represent and thus know which models we need. Additionally, this enables plugins to register for being eager loaded	9 years ago
Jens Ulferts	2cb05bfc27	remove no longer necessary scope alteration	9 years ago
Jens Ulferts	0267938c36	introduce spent_time model	9 years ago
Jens Ulferts	27e2cce32b	add priority to list of attributes inherited from children	9 years ago
Jan Sandbrink	58aa36ae2a	Check for nil representers explicitly ... Passing nil as model into a representer happens usually only due to an error. If a subclass needs to be able to pass nil as represented, it can specify that by overrding. This however, should be an exception, not the rule.	9 years ago
Jan Sandbrink	88ed4d2df9	Promote ::create to a common interface method ... This one is already used by the representers that require a custom field injector. However, by having a separate method this also means collections (or the new DecoratorFactory) need to take care and call the ::create method instead of ::new. I therefore made create the default interface to create representers, which is now used by Factories and Collections. Note: I did not yet change all representer instantiations to ::create. I hope this will happen gradually.	9 years ago
Jan Sandbrink	6e9ed008fb	Enforce passing of current_user into representers ... Thereby permission checks will no longer silently fail if no user was passed. This uncovered a lot of places where we actually expected a user to be passed, when it wasn't. This was especially true for collections. The basic idea is, that virtually all representers could change their behaviour based on the current user. Representers where this is not the case (e.g. Digest), can still explicitly opt-out.	9 years ago
Jan Sandbrink	14a55b82d1	Do not embed linked resources in WP collections	9 years ago
Jan Sandbrink	d8ec635e9e	simplify interface for assignable values ... - one method to rule them all - eases overriding -> does not require to define method for new types on base class - allows to infer values_callback from property name (schema representer)	9 years ago
Jan Sandbrink	9e8d051027	reintroduce form_embedded argument for schema ... we can't live without it :/	9 years ago
Jan Sandbrink	637fadf602	add endpoint to list work package columns in a project	9 years ago
Jan Sandbrink	d5fe64bd5e	move writability decision into WP schema ... - reducing the method count (aka interface size) of the schema - giving it more control - still allow outside override in representer (for plugin compatibility)	9 years ago
Jan Sandbrink	602d488c66	fix reference to value links	9 years ago
Jan Sandbrink	2ddcd55b71	extract groups into own representer	9 years ago
Jan Sandbrink	ee03c7df82	allow filtering using JSON from query representer	9 years ago