4070 Commits (d6b8b920375f5e64c14dca85e77f33f1b8acf028)

Author	SHA1	Message	Date
Oliver Günther	d6b8b92037	Implement query zoom handling in frontend ... Had to refactor: 1. The zoom level enum in the frontend cannot properly be matched to strings so I chose a separate type instead to map to the string retrieved from /sent to the query 2. The way query updates are done through the states. The previous implementation only worked for one single attribute state. For the timeline state, it does not make sense to split that into two, so I delegate to the state to handle checking and updating the query.	8 years ago
Oliver Günther	6b372acae6	Implement timeline zoom level as query enum	8 years ago
Oliver Günther	5b5326db4c	[25438] Fix only saving changed column positions (#5608) ... When changing only the positions of the default query columns, the query incorrectly checked only for the permutation of the default columns, not the actual order. Thus the columns were not actually saved in the query. Additionally, the `observeUntilChanged` incorrectly reflects previous values which causes the movement of a column twice to only result in a move by one position. As this was already suggested to remove in https://github.com/opf/openproject/pull/5597, let's resolve this together in this PR. [ci skip]	8 years ago
Wieland Lindenthal	2dd1f4fc6c	Fix/icon font and alignments (#5605) ... * Center icon font glyphs to harmonize with normal text. * Fix Nato positioning for Win Chrome * Not 100% happy but best X-browser fit approach positioning toolbar button icons and text * Position of project menu toggle icon. * Remove files I added accidentally [ci skip]	8 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465) ... * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
Oliver Günther	94234bd5ee	[25432] Correctly transmit hasDefault to frontend (#5603) ... The default value for CFs is '', which is obviously not nil despite not being a default, however the frontend only _always_ shows the attribute when it is required and has no default. This PR also adds a 'always visible' flag to the form configuration when the CF is set required. [ci skip]	8 years ago
ulferts	483934e91b	refresh wp list after saving in full screen (#5600) ... [ci skip]	8 years ago
Oliver Günther	3c283ea512	Render table sums row in separate directive (#5595) ... * Render table sums row in separate directive * Fix JS error on setSelection It is not supported for [type=number] input fields. [ci skip]	8 years ago
Henriette Dinger	cb9ad7ba17	[25356] Icons in toolbar not aligned correctly (#5568) ... * Icon alignment in toolbar * Styling: newline after comma in CCS selector. No functional change. Just my personal preference. * Extra class for toolbar buttons that are icons only to make them a square. * Improve documentation for generating icon font [ci skip]	8 years ago
ulferts	96b20eae2a	fix old timeline legend width calculation (#5594) ... The calculation of an element's width was assigned to the wrong variable in #e04cc7e5794273103306a19ebbece0feb9cc192d [ci skip]	8 years ago
Oliver Günther	e877713b0a	[25404] Show timeline context items only when visible (#5590) ... Fixes a check for the timelineVisible state. [ci skip]	8 years ago
ulferts	1afcc57bd1	Fix/autocomplete multiple times (#5588) ... * $compile after changing dom via ajax response This enables the autocompleter implemented via an angular directive to work after a user has been added/removed from the group * reduce debounce on autocompleter [ci skip]	8 years ago
Oliver Günther	ebdad784cd	[25415] Add ancestor groups always when inserting extra rows (#5587) ... The hierarchy render pass uses ancestor groups to identify which rows belong to a certain hierarchy group for simple selector-based hiding/expanding of nested groups. For extra added rows, these groups were only added when the ancestor was not yet added to the list, causing them to not respond to collapsing the ancestor group. [ci skip]	8 years ago
Oliver Günther	bf9373120b	[25416] Refresh query on removed query_props with ID set ... When you're navigating to a query and override a filter, then move back to the query, the URL is changed, however the query is not being refreshed. This is due to the checksum being required to be non-null, even though it can possibly become null in the above case.	8 years ago
Oliver Günther	e20ef8fc71	[25411] Never render extra parents in timeline (#5584) ... Currently, hierarchy mode does NOT load extra parents that are not part of the results table (marked grey). As they are not loaded, the timeline doesn't have any information to draw them with. However, IF the workPackages state _had_ the value of the work package (e.g., because it's open in split view or it is part of a relation), it would still be rendered. This PR avoids rendering these rows at all times. [ci skip]	8 years ago
ulferts	d9aab230fd	Fix/empty filters on export (#5579) ... * place empty filter set in representation url This will allow the empty filter set to override the default filter (status - open) * remove now unused method * persist having no filter in the url params Otherwise, the default filter (status - open) will reappear on reload [ci skip]	8 years ago
Roman Roelofsen	d3606545f1	Improve drawing/positioning of milestones and relation lines (#5583) ... * Improve drawing/positioning of milestones and relation lines * Rebase on op/dev [ci skip]	8 years ago
Oliver Günther	14839a92a9	Remove forkjoin to avoid asynchronous pulling of rows and other states (#5582) ... [ci skip]	8 years ago
Oliver Günther	c676d97881	Avoid undefined cell work packages ... Extra work package rows may result to valid rows in the timeline, but their associated work package is not loaded (hierarchy mode!).	8 years ago
Oliver Günther	bfba259846	Ignore an empty cell element ... [ci skip]	8 years ago
ulferts	cf78b9fd5a	Fix/roadmaps wp list links (#5577) ... * robustness on missing sort criteria * use v3 names in url Not strictly necessary as the api can also handle the AR identifiers * adapt specs [ci skip]	8 years ago
Oliver Günther	1163875917	[25383] Refactor wp-timeline cell to be rendered top-down (#5573) ... * [25383] Refactor wp-timeline cell to be rendered top-down Avoids creating timeline cells as part of the table rendering process, but rather lets the container maintain the reference to them to instrument drawing and updating single rows. This removes the necessity for the `unsubscribeTimelineCells` hook and with that fixes https://community.openproject.com/projects/openproject/work_packages/25383/activity?query_id=896 * Extract cells rendering in separate class * Add missing takeUntil [ci skip]	8 years ago
Oliver Günther	32381134f4	Fix relations removal in split screen and add test (#5578) ... [ci skip]	8 years ago
Oliver Günther	c96c6eb72b	[25400][25357][25399] Remove title from wp-display-formattable (#5575) ... Removes the title from formattible attributes. Fixes https://community.openproject.com/projects/openproject/work_packages/25399 https://community.openproject.com/projects/openproject/work_packages/25357 https://community.openproject.com/projects/openproject/work_packages/25400 [ci skip]	8 years ago
Jens Ulferts	10b01d994e	apply `ellipsis class` to query menu items	8 years ago
Oliver Günther	190e37e9d9	[25401] Restore details icon ... [ci skip]	8 years ago
Oliver Günther	160d8876c7	Add switch state in query state handling to clarify access to states (#5571) ... [ci skip]	8 years ago
Wieland Lindenthal	53ecfc19c8	Fix/25382/false duplicate error message (#5569) ... * fix false duplicate error * do not change keys of default groups unless name changed * groups that have the same key after transforming to lower case should be treated as duplicates. [ci skip]	8 years ago
Roman Roelofsen	d378cbe0a7	Removed debug console.log statements	8 years ago
Oliver Günther	907b3d5a04	Bump reactivestates and typescript (#5570) ... [ci skip]	8 years ago
Oliver Günther	a9b206687e	Don't handle the state link when modifier present (#5567) ... [ci skip]	8 years ago
Oliver Günther	f324aaff63	[25369] Avoid console errors when quickly moving between queries (#5566) ... [ci skip]	8 years ago
Oliver Günther	892e39161f	[25370] Explicitly clear query_props for query menu items (#5563) ... [ci skip]	8 years ago
Oliver Günther	42179cee4c	Find element that contains the ui-route attribute ... [ci skip]	8 years ago
Oliver Günther	e46d816e35	Run state change in new digest ... [ci skip]	8 years ago
Oliver Günther	3968b0b308	[25362] Hide attachment delete button if no permissions to remove (#5556) ... [ci skip]	8 years ago
Wieland Lindenthal	a432d04440	Fix: after deleting an attribute updating the hidden fields was missing (#5552) ... * Fix: after deleting an attribute updating the hidden fields was missing * Fix within not being called * Fix tests after within [ci skip]	8 years ago
Oliver Günther	31840cd524	[25345] Pass ui-router state in [data-ui-route] (#5553) ... The query menu items are rendered by rails but should be processed by angular, so the solution was to find clicks on special links marked with a [data-ui-route] attribute and pass the link to $location. 1. This fails on installations with relative URL, since a base tag is set and everything passed to $location will be ASSUMED relative to that base. Passing `/myrelative/work_packages` will result in `/myrelative/myrelative/work_packages` if the base is `/myrelative`. 2. The process of parsing the URL is buggy and may not lead to the correct state. Instead, I suggest to be explicit in what state this element should route to. https://community.openproject.com/projects/openproject/work_packages/25345 [ci skip]	8 years ago
ulferts	ada82c8d55	Fix/query selection min length (#5555) ... * prevent query selection autocomplete from closing * code prettification [ci skip]	8 years ago
Oliver Günther	61a4481372	[25333] Workaround for height flexbug in Safari 9 (#5550) ... Safari doesn't properly set the height of a flex container, so we need to enforce the height in its child through position absolute. That however requires us to set an explicit width to the non-growing details-view split pane, so there is some selector duplication. [ci skip]	8 years ago
Oliver Günther	821f6afb1b	[25358] Re-add margins to paragraphs in html formattable ... [ci skip]	8 years ago
Oliver Günther	4504bc445b	[25338] Append autocompleter to within relations tab (#5548) ... This allows the result list to scroll the relations tab instead of appending to a fixed height body. https://community.openproject.com/projects/openproject/work_packages/25338 [ci skip]	8 years ago
Roman Roelofsen	1d5955a8f0	Fixes timeline relations bugs (#5546) ... * Fixes timeline relations bugs: - relation lines were not updated during drag and move of their work packages - relation lines with the X directions right to left were not drawn correctly * Filter relevant relations in both subscribers [ci skip]	8 years ago
Oliver Günther	7f9a249a47	[25344] Render parent clamps in their respective colors ... [ci skip]	8 years ago
Oliver Günther	50d2b9a027	[25335] Return perPage localStorage only when number > 0 ... https://community.openproject.com/projects/openproject/work_packages/25335/activity?query_id=896	8 years ago
Oliver Günther	6ebd1185ea	[25342] Display editing blocked notification in table (#5542) ... https://community.openproject.com/projects/openproject/work_packages/25342	8 years ago
Oliver Günther	d6391bfce7	[25325] Debounce refreshing based on WP subscriber (#5537) ... [ci skip]	8 years ago
Oliver Günther	3e16b86009	[25312] Refresh the complete table side on column changes (#5527) ... * [25312] Refresh the complete table side on column changes After the integration of the timeline into the table, it was too costly to refresh the table (and re-initialize the timeline) for everytime the column were changed, so only each row was refreshed. Since the timeline is now separate, we can refresh them invidividually when being careful that this results in now row changes (such as changes to the columns) * Don't fire the timeline unsubscribe subject when refreshing table only [ci skip]	8 years ago
Oliver Günther	be4b16ff78	[25306][25284] Allow sticky table headers only in newer chrome versions ... This PR: * Adds a browser version testing package 'bowser' * Refactors the previous browser checking (unsupported browsers) with it * Adds a `-supports-sticky-headers` class to HTML when chrome version >= 58 is detected	8 years ago
Oliver Günther	5d50acc50e	[25288] Re-add translations to default attribute groups (#5515) ... * [25288] Re-add translations to default attribute groups Uses symbols to mark internal attribute groups and translates them in the schema representer to the user's locale. * Extend form configuration front end for translated default groups * fixing specs * fix feature spec for attribute groups * Add symbol test to attribute groups [ci skip]	8 years ago